Host controller TD breaking mechanism

2012-12-06 Thread Nikunj Sanghani
Hi, Suppose one TD that has 5 TRBs and each has trb Length of 200 bytes except last Trb all have chain bit set to 1. Single TD contains 5 TRBs. -- | -| | |trnlen =200 chain=1| TRB=1 | | -

Re: [PATCH 1/2 v2] usb/core: consider link speed while looking at bMaxPower

2012-12-06 Thread Sebastian Andrzej Siewior
On 12/05/2012 09:42 PM, Alan Stern wrote: value based on config& usb_device's speed value. The sysfs interface& the device descriptor dump compute the value on their own. Why doesn't the sysfs function use usb_get_max_power? Am I missing something? I have no idea. Updated the function. A

[PATCH v5] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-06 Thread Bernd Krumboeck
changes since v4: * removed FSF address * renamed struct usb_8dev * removed unused variable free_slots * replaced some _to_cpu functions with pointer equivalent * fix return value for usb_8dev_set_mode * handle can errors with separate function * fix overrun error handling * rewrite error handling

Re: [PATCH 2/2] usb/core: update power budget for SuperSpeed

2012-12-06 Thread Sebastian Andrzej Siewior
On 12/05/2012 09:48 PM, Alan Stern wrote: On Wed, 5 Dec 2012, Sebastian Andrzej Siewior wrote: Sarah pointed out that the USB3.0 spec also updates the amount of power that may be consumed by the device and quoted 9.2.5.1: |"The amount of current draw for SuperSpeed devices are increased to 150

USB3 vs. Kinect

2012-12-06 Thread Florian Echtler
Hello everyone, I'm seeing some slightly weird behavior when connecting a Kinect (USB 2 device with internal hub) to my Dell Latitude E6430 (running stock Ubuntu kernel 3.2.0-34-generic). There are two different cases: - When I plug the Kinect into an USB2 port on the docking station, I get

Re: [PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-12-06 Thread Grant Likely
On Thu, 08 Nov 2012 14:02:13 +0530, Vivek Gautam wrote: > Adding DWC3 device tree node for Exynos5250 along with the > device address and clock support needed for the controller. > > Signed-off-by: Vivek Gautam > --- > .../devicetree/bindings/usb/exynos-usb.txt | 14 +++ > ar

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-06 Thread Grant Likely
On Thu, 08 Nov 2012 12:24:24 +0530, Vivek Gautam wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > .../devicetree/bindings/usb/exynos-usb.txt | 25 > +++

Re: [PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-12-06 Thread Vivek Gautam
Hi Grant, On Thu, Dec 6, 2012 at 3:45 PM, Grant Likely wrote: > On Thu, 08 Nov 2012 14:02:13 +0530, Vivek Gautam > wrote: >> Adding DWC3 device tree node for Exynos5250 along with the >> device address and clock support needed for the controller. >> >> Signed-off-by: Vivek Gautam >> --- >> .

Re: [PATCH v2 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-06 Thread Vivek Gautam
On Thu, Dec 6, 2012 at 3:46 PM, Grant Likely wrote: > On Thu, 08 Nov 2012 12:24:24 +0530, Vivek Gautam > wrote: >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam >> Acked-by: Jingoo Han >> --- >> .../d

RE: [PATCH] usb: musb: Enable DMA Mode1 for device mode RX in ux500 platform

2012-12-06 Thread Supriya s KARANTH
Hi Felipe, > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, November 30, 2012 7:51 PM > > Hi, > > On Fri, Nov 30, 2012 at 12:02:25PM +0530, Supriya Karanth wrote: > > From: supriya karanth > > > > Handles: > > 1) Known transfer length > > a) Non multiple of packet size > >

[Suggestion] drivers/usb/core: for u16, use stack allocation instead of kmalloc

2012-12-06 Thread Chen Gang
Hello Greg Kroah-Hartman: in drivers/usb/core/message.c: at line 943, status is kmalloc ( sizeof u16 ) at line 952, assign the value of status to data at line 953, free status. it is better to let "u16 status" instead of "u16 *status = kmalloc...". thanks. gchen. 940 int usb_get_st

Re: [Suggestion] drivers/usb/core: for u16, use stack allocation instead of kmalloc

2012-12-06 Thread Peter Stuge
Chen Gang wrote: > it is better to let "u16 status" instead of "u16 *status = kmalloc...". .. > 940 int usb_get_status(struct usb_device *dev, int type, int target, void > *data) > 941 { > 942 int ret; > 943 u16 *status = kmalloc(sizeof(*status), GFP_KERNEL); > 944 > 945

Re: [Suggestion] drivers/usb/core: for u16, use stack allocation instead of kmalloc

2012-12-06 Thread Chen Gang
于 2012年12月06日 19:01, Peter Stuge 写道: > Chen Gang wrote: >> it is better to let "u16 status" instead of "u16 *status = kmalloc...". > . >> 940 int usb_get_status(struct usb_device *dev, int type, int target, void >> *data) >> 941 { >> 942 int ret; >> 943 u16 *status = kmalloc(

Re: [Suggestion] drivers/usb/core: for u16, use stack allocation instead of kmalloc

2012-12-06 Thread Oliver Neukum
On Thursday 06 December 2012 18:51:25 Chen Gang wrote: > Hello Greg Kroah-Hartman: > > in drivers/usb/core/message.c: > at line 943, status is kmalloc ( sizeof u16 ) > at line 952, assign the value of status to data > at line 953, free status. > > it is better to let "u16 status" instead

Re: [Suggestion] drivers/usb/core: for u16, use stack allocation instead of kmalloc

2012-12-06 Thread Chen Gang
于 2012年12月06日 19:32, Oliver Neukum 写道: > On Thursday 06 December 2012 18:51:25 Chen Gang wrote: >> Hello Greg Kroah-Hartman: >> >> in drivers/usb/core/message.c: >> at line 943, status is kmalloc ( sizeof u16 ) >> at line 952, assign the value of status to data >> at line 953, free status. >>

[Suggestion] drivers/usb/core: dev-config and dev->rawdescriptors, when processing failure.

2012-12-06 Thread Chen Gang
Hello Oliver Neukum: in drivers/usb/core/config.c, for function usb_get_configuration: if processing failed at line 694, we will goto err2 (line 755..759) in this condition, we do not free dev-config and dev->rawdescriptors. after checking another relative source code, it seems not an iss

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

2012-12-06 Thread Rafael J. Wysocki
On Thursday, December 06, 2012 03:17:14 PM Huang Ying wrote: > On Wed, 2012-12-05 at 16:33 -0800, Sarah Sharp wrote: > > On Wed, Nov 28, 2012 at 02:54:06PM -0800, Sarah Sharp wrote: > > > On Mon, Nov 26, 2012 at 10:48:03PM +0100, Bjørn Mork wrote: > > > > Sarah Sharp writes: > > > > > > > > > It

Re: [PATCH 2/2] usb/core: consider link speed while looking at bMaxPower

2012-12-06 Thread Sergei Shtylyov
Hello. On 05-12-2012 22:56, Sebastian Andrzej Siewior wrote: going through the tree I saw most people set it to something around 200 (if at all). There are a few omap/musb boards setting it to 500. The interresting part is davinci of course. So there is comment that says |"irlml6401 switches ov

Re: [RFC PATCH 1/5] Device Power: introduce power controller

2012-12-06 Thread Ming Lei
On Thu, Dec 6, 2012 at 11:46 AM, Jassi Brar wrote: >> The patch can make usb port deal with the 'power controller' only, and make >> it >> avoid to deal with regulators/clocks/... directly. >> > I am curious too, except for clocks and voltage supplies (regulators), > what other external resources

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-12-06 Thread Jassi Brar
On Wed, Dec 5, 2012 at 7:39 PM, Roger Quadros wrote: > Hi Jassi, > > On 12/01/2012 09:49 AM, Jassi Brar wrote: >> On Tue, Nov 27, 2012 at 10:32 PM, Greg KH wrote: >>> On Tue, Nov 27, 2012 at 11:30:11AM -0500, Alan Stern wrote: We should have a more generic solution in a more central loc

Re: [RFC PATCH 1/5] Device Power: introduce power controller

2012-12-06 Thread Jassi Brar
On 6 December 2012 18:48, Ming Lei wrote: > On Thu, Dec 6, 2012 at 11:46 AM, Jassi Brar > wrote: >>> The patch can make usb port deal with the 'power controller' only, and make >>> it >>> avoid to deal with regulators/clocks/... directly. >>> >> I am curious too, except for clocks and voltage s

Re: [RFC PATCH 4/5] arm: omap2: support port power on lan95xx devices

2012-12-06 Thread Alan Stern
On Thu, 6 Dec 2012, Andy Green wrote: > > Right. The question is should it be done in this somewhat roundabout > > way (you've got two separate assets for setting up this one thing), or > > should the USB port code be responsible for explicitly checking if > > there are any applicable assets when

Re: Correlating SOF with host system time

2012-12-06 Thread Alan Stern
On Thu, 6 Dec 2012, Stefan Tauner wrote: > On Wed, 5 Dec 2012 10:35:31 -0500 (EST) > Alan Stern wrote: > > Your theory omits an important point: The host system generally doesn't > > care exactly when frames start. Forcing it to keep track of these > > events adds overhead. > > Yes, it does,

Re: [PATCH 08/10] usb: add usb port auto power off mechanism

2012-12-06 Thread Alan Stern
On Thu, 6 Dec 2012, Lan Tianyu wrote: > Hi Alan: > Doing port_dev->power_on = true in usb_hub_set_port_power() just after > set PORT_POWER feature will cause device to be disconnected. If user set > PM Qos NO_POWER_OFF flag after the device was power off, the port would > be power on and do

Re: [Suggestion] drivers/usb/core: dev-config and dev->rawdescriptors, when processing failure.

2012-12-06 Thread Alan Stern
On Thu, 6 Dec 2012, Chen Gang wrote: > Hello Oliver Neukum: > > in drivers/usb/core/config.c, for function usb_get_configuration: > > if processing failed at line 694, we will goto err2 (line 755..759) > in this condition, we do not free dev-config and dev->rawdescriptors. This isn't neces

Re: USB3 vs. Kinect

2012-12-06 Thread Greg KH
On Thu, Dec 06, 2012 at 11:09:09AM +0100, Florian Echtler wrote: > Hello everyone, > > I'm seeing some slightly weird behavior when connecting a Kinect > (USB 2 device with internal hub) to my Dell Latitude E6430 (running > stock Ubuntu kernel 3.2.0-34-generic). There are two different > cases: W

Re: Max Service Opportunity Packet Count value

2012-12-06 Thread Greg KH
On Thu, Dec 06, 2012 at 06:31:04AM +, Nikunj Sanghani wrote: > Hi, > > As per the XHC Spec, Max Service Opportunity Packet Count (MSOPC) value for an > endpoint is set by the number of packets defined by the Endpoint Context Max > Burst Size field times the Mult field. > > But Max Burst Size

Re: Host controller TD breaking mechanism

2012-12-06 Thread Greg KH
On Thu, Dec 06, 2012 at 08:49:08AM +, Nikunj Sanghani wrote: > Hi, > > Suppose one TD that has 5 TRBs and each has trb Length of 200 bytes > except last Trb all have chain bit set to 1. > Single TD contains 5 TRBs. > > -- > | -

Re: problem with Roseweil eusb3 enclosure

2012-12-06 Thread Sebastian Andrzej Siewior
On Wed, Nov 28, 2012 at 10:27:58AM -0800, Sarah Sharp wrote: > Well, shoot. I'm sorry, John, but I've run out of ideas about how to > fix this device. Without a bus analyzer, it would be difficult to > figure out why the device works under Windows but not under Linux. John, do you have a link to

Re: problem with Roseweil eusb3 enclosure

2012-12-06 Thread Sarah Sharp
On Thu, Dec 06, 2012 at 06:18:19PM +0100, Sebastian Andrzej Siewior wrote: > On Wed, Nov 28, 2012 at 10:27:58AM -0800, Sarah Sharp wrote: > > Well, shoot. I'm sorry, John, but I've run out of ideas about how to > > fix this device. Without a bus analyzer, it would be difficult to > > figure out w

Random MAC address from smsc75xx: How to permanently set?

2012-12-06 Thread Cunningham, Robert
I'm trying to bring up an OMAP4 system based on Variscite's OM44 module running Linaro's Ubuntu Precise in a headless configuration.  The system contains two SMSC LAN7500 USB-GigE chips (not dongles), both of which are fully functional. The GigE chips don't have EEPROMS, so no permanent MAC addr

Re: Random MAC address from smsc75xx: How to permanently set?

2012-12-06 Thread Dan Williams
On Thu, 2012-12-06 at 18:35 +, Cunningham, Robert wrote: > I'm trying to bring up an OMAP4 system based on Variscite's OM44 module > running Linaro's Ubuntu Precise in a headless configuration. The system > contains two SMSC LAN7500 USB-GigE chips (not dongles), both of which are > fully fu

Re: Random MAC address from smsc75xx: How to permanently set?

2012-12-06 Thread Dan Williams
On Thu, 2012-12-06 at 12:44 -0600, Dan Williams wrote: > On Thu, 2012-12-06 at 18:35 +, Cunningham, Robert wrote: > > I'm trying to bring up an OMAP4 system based on Variscite's OM44 module > > running Linaro's Ubuntu Precise in a headless configuration. The system > > contains two SMSC LAN7

Re: problem with Roseweil eusb3 enclosure

2012-12-06 Thread covici
Hi. Goodness, I never knew you would actually buy one of those to test, but thanks much for your perseverence. The link is http://www.newegg.com/Product/Product.aspx?Item=N82E16817182211 Sebastian Andrzej Siewior wrote: > On Wed, Nov 28, 2012 at 10:27:58AM -0800, Sarah Sharp wrote: > > Well, s

Re: [PATCH v5] usb_8dev: Add support for USB2CAN interface from 8 devices

2012-12-06 Thread Bernd Krumboeck
Hi! Am 2012-12-06 17:44, schrieb Shawn Fisher: +static int usb_8dev_send_cmd(struct usb_8dev_priv *priv, +struct usb_8dev_cmd_msg *out, +struct usb_8dev_cmd_msg *in) +{ + int err; + int num_bytes_read;

Re: Random MAC address from smsc75xx: How to permanently set?

2012-12-06 Thread Bjørn Mork
Dan Williams writes: > On Thu, 2012-12-06 at 18:35 +, Cunningham, Robert wrote: > >> I'm trying to bring up an OMAP4 system based on Variscite's OM44 >> module running Linaro's Ubuntu Precise in a headless configuration. >> The system contains two SMSC LAN7500 USB-GigE chips (not dongles), >>

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

2012-12-06 Thread Sarah Sharp
On Thu, Dec 06, 2012 at 01:43:32AM +0100, Rafael J. Wysocki wrote: > On Wednesday, December 05, 2012 04:33:44 PM Sarah Sharp wrote: > > Wakeup from D3 works fine on the 3.5.0 kernel, but fails on 3.6.2. I > > haven't fully bisected yet. > > > > In debugging, I found that if you only enable runtim

Re: [Suggestion] drivers/usb/core: dev-config and dev->rawdescriptors, when processing failure.

2012-12-06 Thread Chen Gang
于 2012年12月06日 23:50, Alan Stern 写道: > On Thu, 6 Dec 2012, Chen Gang wrote: >> in drivers/usb/core/config.c, for function usb_get_configuration: >> >> if processing failed at line 694, we will goto err2 (line 755..759) >> in this condition, we do not free dev-config and dev->rawdescriptors. >

Re: Random MAC address from smsc75xx: How to permanently set?

2012-12-06 Thread Jassi Brar
On Fri, Dec 7, 2012 at 12:21 AM, Dan Williams wrote: > On Thu, 2012-12-06 at 12:44 -0600, Dan Williams wrote: >> On Thu, 2012-12-06 at 18:35 +, Cunningham, Robert wrote: >> > I'm trying to bring up an OMAP4 system based on Variscite's OM44 module >> > running Linaro's Ubuntu Precise in a head