[RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Andrzej Pietrasiewicz
In some parts of the kernel (e.g. planned configfs integration into usb gadget) there is a need to programmatically create config groups (directories) but it would be preferable to disallow creating them by the user. This is more or less what default_groups used to be for. But e.g. in the mass stor

[RFC][PATCH] fs: configfs: allow other kernel parts to programmatically create config groups

2012-11-26 Thread Andrzej Pietrasiewicz
Signed-off-by: Andrzej Pietrasiewicz Signed-off-by: Kyungmin Park --- fs/configfs/dir.c|5 +++-- include/linux/configfs.h |2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c index 7414ae2..42608dc 100644 --- a/fs/configfs/di

Re: [PATCH 16/16] ARM: OMAP: omap4panda: Power down the USB PHY and ETH when not in use

2012-11-26 Thread Felipe Balbi
Hi, On Fri, Nov 23, 2012 at 11:27:34AM -0500, Alan Stern wrote: > On Fri, 23 Nov 2012, Felipe Balbi wrote: > > > > And maybe the same sort of scheme could be used for clocks, although I > > > don't know how to do it in a generic way that will work on all > > > platforms. > > > > perhaps making

[PATCH v3 1/7] Revert "USB: chipidea: add vbus detect for udc"

2012-11-26 Thread Peter Chen
vbus register is at otgsc, and vbus detect does not belong to device function. Revert this patch, and will move vbus detect function to drivers/usb/chipidea/udc.c This reverts commit 8c4fc031954b4eb72daf13d3c907a985a3eee208. Signed-off-by: Peter Chen --- Changes for v3: Add Signed-off-by: Peter

[PATCH v3 2/7] usb: chipidea: add otg file

2012-11-26 Thread Peter Chen
Implement struct usb_otg, In that way, calling otg_set_peripheral will not be failed at udc.c. Signed-off-by: Peter Chen --- drivers/usb/chipidea/Makefile |2 +- drivers/usb/chipidea/ci.h |2 + drivers/usb/chipidea/otg.c| 60 + drivers/us

[PATCH v3 0/7] Add fully tested id switch and vbus connect detect support for Chipidea

2012-11-26 Thread Peter Chen
Changes for v3 mainly for 1/7, 3/7, 4/7, 7/7, see individual patch commit for detail. This patchset adds fully tested otg id switch function and vbus connect/disconnect detection for chipidea driver. The mainly design of id/vbus handling follows msm otg driver. I hope the msm usb maintainer can ha

[PATCH v3 5/7] usb: chipidea: udc: add pullup/pulldown dp at hw_device_state

2012-11-26 Thread Peter Chen
- During the connect/disconnect host, we need to pullup and pulldown dp - Make sure the dp is not pullup until the vbus is on when flag CI13XXX_PULLUP_ON_VBUS is set - Using hw_device_state when set run/stop bit Signed-off-by: Peter Chen --- drivers/usb/chipidea/udc.c | 10 -- 1 files

[PATCH v3 4/7] usb: chipidea: consolidate ci_role_driver's API for both roles

2012-11-26 Thread Peter Chen
- Create init/destroy API for probe and remove - start/stop API are only used otg id switch process - Create the gadget at ci_hdrc_probe if the gadget is supported at that port, the main purpose for this is to avoid gadget module load fail at init.rc Signed-off-by: Peter Chen --- Changes for v3:

[PATCH v3 6/7] usb: chipidea: udc: retire the flag CI13_PULLUP_ON_VBUS

2012-11-26 Thread Peter Chen
(change CI13XXX to CI13 to avoid junk email check) Now, we have handled vbus session in core driver when the vbus interrupt occurs, so our pullup operations are all according to vbus. Of cource, the software can still call .pullup when device connects to host if it wants to connect/disconnect with

[PATCH v3 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-26 Thread Peter Chen
The main design flow is the same with msm otg driver, that is the id and vbus interrupt are handled at core driver, others are handled by individual drivers. - At former design, when switch usb role from device->host, it will call udc_stop, it will remove the gadget driver, so when switch role fro

[PATCH v3 7/7] usb: chipidea: imx: add internal vbus regulator control

2012-11-26 Thread Peter Chen
- For host, the vbus should always be on. - For otg, the vbus is off defaultly, the vbus needs to be turned on/off when usb role switches. Signed-off-by: Peter Chen --- Changes for v3: - Add return value check for regulator_enable/regulator_disable - typo error drivers/usb/chipidea/ci.h

Re: [PATCH 2/9] usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer

2012-11-26 Thread Peter Chen
On Wed, Nov 14, 2012 at 05:19:03PM +0100, Michael Grzeschik wrote: > This patch adds support for a second and third clock to the chipidea driver. > On > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks > ("ahb", > "ipg" and "per") must be enabled in order to access the USB

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Sun, 25 Nov 2012 23:01:27 +0100, Clemens Ladisch wrote: > > Jonathan Nieder wrote: > > Some USB MIDI keyboards fail to operate after a USB autosuspend. > > Make that *all* USB MIDI devices with input ports. > > This is not a bug in the device, but one of the many bugs introduced > with the au

cdc-acm and remote wakeup

2012-11-26 Thread Daniele Palmas
Hello, I'm using the modem Telit HE910 with cdc-acm driver. I've found that after a suspend and resume of the operating system (e.g. pm-suspend), the modem does not answer anymore. Collecting logs with an usb sniffer, it seems that, unlike the Windows driver, the host does not send the packet SE

Re: [PATCH 4/9] usb: chipidea: ci13xxx-imx: add "dr_mode" property to device tree bindings

2012-11-26 Thread Peter Chen
On Fri, Nov 16, 2012 at 01:53:09PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Marc Kleine-Budde > > > > Its necessary to limit a hostonly soc to its single role, since > > debugging has shown that reading on the "CAP_DCCPARAMS" register inside > > a host-only port,

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-26 Thread Peter Chen
On Wed, Nov 14, 2012 at 05:19:06PM +0100, Michael Grzeschik wrote: > This patch makes it possible to set the connection of the usbphy to the > soc. It is derived from the oftree bindings for the ethernetphy and adds > similar helperfunctions. > > Signed-off-by: Michael Grzeschik > Signed-off-by:

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-26 Thread Bjørn Mork
Linus Walleij writes: > /* Check if device responds to control message 1 or if there is an error > */ > cmd = buf[16]; > ret = libusb_control_transfer (devh, > LIBUSB_ENDPOINT_IN | LIBUSB_RECIPIENT_DEVICE | > LIBUSB_REQUEST_TYPE_VENDOR, >

Re: [PATCH 2/9] usb: chipidea: ci13xxx_imx: add 2nd and 3rd clock to support imx5x and newer

2012-11-26 Thread Sascha Hauer
On Mon, Nov 26, 2012 at 05:29:31PM +0800, Peter Chen wrote: > On Wed, Nov 14, 2012 at 05:19:03PM +0100, Michael Grzeschik wrote: > > This patch adds support for a second and third clock to the chipidea > > driver. On > > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks > >

Re: cdc-acm and remote wakeup

2012-11-26 Thread Oliver Neukum
On Monday 26 November 2012 10:42:48 Daniele Palmas wrote: > Hello, > > I'm using the modem Telit HE910 with cdc-acm driver. > > I've found that after a suspend and resume of the operating system > (e.g. pm-suspend), the modem does not answer anymore. > > Collecting logs with an usb sniffer, it s

Re: Problem with OHCI on OMAP4430

2012-11-26 Thread Mohan V
Alan, On Tue, Oct 30, 2012 at 9:34 PM, Alan Stern wrote: > On Tue, 30 Oct 2012, Mohan V wrote: > >> >> >> Device not getting detected when >> >> >> connected--- >> >> >> >> >> >> / # [ 135.621002] usbhs_wakeup: Enabling clocks >> >> >> [ 135.6257

Re: cdc-acm and remote wakeup

2012-11-26 Thread Daniele Palmas
Hello Oliver, 2012/11/26 Oliver Neukum : > On Monday 26 November 2012 10:42:48 Daniele Palmas wrote: >> Hello, >> >> I'm using the modem Telit HE910 with cdc-acm driver. >> >> I've found that after a suspend and resume of the operating system >> (e.g. pm-suspend), the modem does not answer anymore

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Clemens Ladisch
Takashi Iwai wrote:> At Sun, 25 Nov 2012 23:01:27 +0100, > Clemens Ladisch wrote: >> >> Jonathan Nieder wrote: >>> Some USB MIDI keyboards fail to operate after a USB autosuspend. >> >> Make that *all* USB MIDI devices with input ports. >> >> This is not a bug in the device, but one of the many bug

[RFC PATCH 0/5] Device Paths introduced and applied to generic hub and panda

2012-11-26 Thread Andy Green
NB this is against usb-next at 3.7-rc6 The following series introduces "wildcard device paths" as discussed recently; in particular the wildcard idea is from Alan Stern. First the API is introduced for generating, comparing and registering the wildcard device paths. I put them in drivers/base fo

[RFC PATCH 1/5] drivers : introduce device_path api

2012-11-26 Thread Andy Green
This adds a small optional API into drivers/base which deals with generating, matching and registration of wildcard device paths. >From a struct device * you can generate a string like /platform/usbhs_omap/ehci-omap.0/usb1/1-1 which enapsulates the path of the device's connection to the board.

[RFC PATCH 2/5] usb: omap ehci: remove all regulator control from ehci omap

2012-11-26 Thread Andy Green
This series migrates it to the hub driver as suggested by Felipe Balbi. Signed-off-by: Andy Green --- drivers/usb/host/ehci-omap.c | 33 - 1 file changed, 33 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 44e7d0f..22

[RFC PATCH 3/5] usb: hub: add device_path regulator control to generic hub

2012-11-26 Thread Andy Green
This adds the config option to associate a regulator with each hub, when the hub on a specific, interesting device path appears, then the regular is powered while the logical hub exists. Signed-off-by: Andy Green --- drivers/usb/core/Kconfig | 10 ++ drivers/usb/core/hub.c | 26 +++

[RFC PATCH 4/5] omap4: panda: add smsc95xx regulator and reset dependent on root hub

2012-11-26 Thread Andy Green
This adds regulators which are controlled by the OMAP4 PandaBoard (ES)'s EHCI logical root hub existing. Without power control, the ULPI PHY + SMSC9614 on the Panda eats 700-900mW all the time, which is around the same as the idle power of the SoC and rest of the board. This allows us to start of

[RFC PATCH 5/5] config omap2plus add ehci bits

2012-11-26 Thread Andy Green
omap2plus seems to have rotted a bit, this is the delta that appears if we enable modular build for ehci-hcd and smsc95xx. Signed-off-by: Andy Green --- arch/arm/configs/omap2plus_defconfig | 42 ++ 1 file changed, 17 insertions(+), 25 deletions(-) diff --git a

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 13:35:31 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote:> At Sun, 25 Nov 2012 23:01:27 +0100, > > Clemens Ladisch wrote: > >> > >> Jonathan Nieder wrote: > >>> Some USB MIDI keyboards fail to operate after a USB autosuspend. > >> > >> Make that *all* USB MIDI devices with

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Michal Nazarewicz
On Mon, Nov 26 2012, Andrzej Pietrasiewicz wrote: > In some parts of the kernel (e.g. planned configfs integration into usb > gadget) there is a need to programmatically create config groups > (directories) but it would be preferable to disallow creating them by > the user. This is more or less wh

Re: [PATCH] Patch for clearing PRC bit in PORTSC register at the time of XHCI driver insertion

2012-11-26 Thread Bhavik Kothari
Hi Greg & Sarah, Would please tell us, what should be approach now? If possible, Sarah, would you please give us the Patch to clear all bits in xhci_reset()? Thanks, Bhavik Kothari > On Mon, Nov 19, 2012 at 6:59 PM, Bhavik Kothari > > wrote: > > H

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Clemens Ladisch
Takashi Iwai wrote: > Clemens Ladisch wrote: >> Takashi Iwai wrote: >>> Clemens Ladisch wrote: I'm working on a fix that adds proper power management for input ports, but this requires the driver to be reorganized a little ... >>> >>> Doesn't a simple patch like below work? >> >>> +static

Re: [PATCH 4/5] smsc95xx: refactor entering suspend modes

2012-11-26 Thread Bjørn Mork
[adding linux-usb to CC as this is very USB specific] Steve Glendinning writes: > + smsc95xx_set_feature(dev, USB_DEVICE_REMOTE_WAKEUP); That does look a bit strange to me. This is a USB interface driver. The USB device is handled by the generic "usb" USB device driver, which will DTRT for

Re: cdc-acm and remote wakeup

2012-11-26 Thread Oliver Neukum
On Monday 26 November 2012 13:29:09 Daniele Palmas wrote: > Ok. Do you have any hint for adding the code in the proper place? First we need to define a new quirk. > >> According to the USB 2.0 specs it seems to me that this feature should > >> be always requested when suspending a device, so pr

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Oliver Neukum
On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: > > If it has to be running, the easiest fix would be the patch like > > below. This will turn off the autopm essentially, but better than > > breakage. > > > > @@ -2074,6 +2077,8 @@ static void snd_usbmidi_input_start_ep(struct > > snd_

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Takashi Iwai
At Mon, 26 Nov 2012 14:43:13 +0100, Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Clemens Ladisch wrote: > >> Takashi Iwai wrote: > >>> Clemens Ladisch wrote: > I'm working on a fix that adds proper power management for input ports, > but this requires the driver to be reorganized a

Re: [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2012-11-26 Thread Greg KH
On Sun, Nov 25, 2012 at 11:43:14PM -0500, Chao Xie wrote: > From: Chao Xie > > This patches converts the driver into the new style start/stop > interface. As a result the driver no longer uses the static > global the_conroller variable. > > Signed-off-by: Chao Xie How come your signed-off-by a

Re: [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 06:39:36AM -0800, Greg KH wrote: > On Sun, Nov 25, 2012 at 11:43:14PM -0500, Chao Xie wrote: > > From: Chao Xie > > > > This patches converts the driver into the new style start/stop > > interface. As a result the driver no longer uses the static > > global the_conrol

Re: [PATCH 06/16] mfd: omap-usb-host: cleanup clock management code

2012-11-26 Thread Roger Quadros
Felipe, On 11/21/2012 03:39 PM, Felipe Balbi wrote: > Hi, > > On Thu, Nov 15, 2012 at 04:34:04PM +0200, Roger Quadros wrote: >> All ports have similarly named port clocks so we can >> bunch them into a port data structure and use for loop >> to enable/disable the clocks. >> >> Signed-off-by: Roge

Re: Any followups concerning: cannot submit urb 0, error -22: internal error followed by USB hung tasks

2012-11-26 Thread Oliver Neukum
On Friday 23 November 2012 11:42:02 Alan Stern wrote: > On Fri, 23 Nov 2012, Oliver Neukum wrote: > > > Hi Alan, > > > > did you ever recieve any feedback concerning the patch you wrote > > the patch in the message mentioned above for? I am getting reports > > from customers that it fixes issues

Re: [PATCH v3 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-26 Thread Michael Grzeschik
On Sun, Nov 25, 2012 at 05:18:35PM +0800, Peter Chen wrote: > On Fri, Nov 23, 2012 at 05:20:51PM +0100, Michael Grzeschik wrote: > > > usbphy: used to transfer data > > > (like your per) > > > > The "per" clk is a different clk than the usbphy. We have an usbphy clk > > aswell on the mx5x. As disc

Re: USB audio device

2012-11-26 Thread Alan Stern
On Sat, 24 Nov 2012, Jim Passmore wrote: > On Sat, Nov 24, 2012 at 6:08 PM, Oliver Neukum wrote: > >> NVIDIA Corporation MCP61 USB Controller, rev a3 > > > > Known problematic controller: > > http://www.mail-archive.com/linux-usb@vger.kernel.org/msg07227.html > > Well, that's a heck of a thread.

Re: d3cold breaks my usb 3.0 port (Lenovo X220)

2012-11-26 Thread Alan Stern
On Sun, 25 Nov 2012, Andrew Lutomirski wrote: > Here's lots of lots with debugging and notes. Turning off runtime > suspend isn't helping any more. This stick still works fine on a > non-USB3 port. > > Notes from me start with ***. ... > [ 44.856520] xhci_hcd :0e:00.0: set port remote w

Re: cdc-acm and remote wakeup

2012-11-26 Thread Daniele Palmas
2012/11/26 Oliver Neukum : > On Monday 26 November 2012 13:29:09 Daniele Palmas wrote: > >> Ok. Do you have any hint for adding the code in the proper place? > > First we need to define a new quirk. > >> >> According to the USB 2.0 specs it seems to me that this feature should >> >> be always reque

Re: cdc-acm and remote wakeup

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Daniele Palmas wrote: > Maybe I have to explain better my scenario: > > Modem is registered to the network. Host suspended, I want my device > to wake up the host when it receives, for example, a call or an sms. What if the modem isn't registered to the network? For example

Re: USB 2.0: No giveback comes for one submitted URB

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, naveen yadav wrote: > Dear Alan, > > Thanks for your reply , > > We check on 3.2.34 and 3.6.7 on X86 host machine. and result is same > without connecting Bluetooth device. > I am attaching log Yes, very good. But you still have to do what I mentioned in my earlier email:

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Oliver Neukum wrote: > On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: > > > > If it has to be running, the easiest fix would be the patch like > > > below. This will turn off the autopm essentially, but better than > > > breakage. > > > > > > @@ -2074,6 +2077,8 @

Re: cdc-acm and remote wakeup

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Oliver Neukum wrote: > > I understand that probably there are problems in the firmware of the > > modem (because it should not brick), but I'm trying to find a > > workaround to have things working. > > I am attaching a patch to introduce a new quirk type. You need to add > y

Re: Any followups concerning: cannot submit urb 0, error -22: internal error followed by USB hung tasks

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Oliver Neukum wrote: > On Friday 23 November 2012 11:42:02 Alan Stern wrote: > > On Fri, 23 Nov 2012, Oliver Neukum wrote: > > > > > Hi Alan, > > > > > > did you ever recieve any feedback concerning the patch you wrote > > > the patch in the message mentioned above for? I am

Re: [RFC PATCH 4/5] omap4: panda: add smsc95xx regulator and reset dependent on root hub

2012-11-26 Thread Roger Quadros
Hi Andy, On 11/26/2012 02:45 PM, Andy Green wrote: > This adds regulators which are controlled by the OMAP4 PandaBoard (ES)'s > EHCI logical root hub existing. > > Without power control, the ULPI PHY + SMSC9614 on the Panda eats 700-900mW > all the time, which is around the same as the idle power

configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/22/2012 09:59 PM, Michal Nazarewicz wrote: echo MassStorage> /cfg/usb-function-gadget/G1/C1/F1/name Why not mkdir /cfg/usb-function-gadget/G1/C1/F1/MassStorage ? Let me add what I have in my head + what Michał said in other mail: Lets assume we start at /sys/kernel/config/ga

Re: Mouse and keyboard freeze Ivy-bridge

2012-11-26 Thread Alan Stern
On Fri, 23 Nov 2012, Chris Holland wrote: > On Fri, Nov 23, 2012 at 11:03 AM, Alan Stern > wrote: > > On Thu, 22 Nov 2012, Chris Holland wrote: > > > >> https://bugzilla.kernel.org/show_bug.cgi?id=50821 > >> > >> > >> Summary: Mouse and keyboard freeze Ivy-bridge > >> I have been having the prob

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/26/2012 09:35 AM, Andrzej Pietrasiewicz wrote: In some parts of the kernel (e.g. planned configfs integration into usb gadget) there is a need to programmatically create config groups (directories) but it would be preferable to disallow creating them by the user. This is more or less what d

Re: cdc-acm and remote wakeup

2012-11-26 Thread Daniele Palmas
Hello Alan, 2012/11/26 Alan Stern : > On Mon, 26 Nov 2012, Daniele Palmas wrote: > >> Maybe I have to explain better my scenario: >> >> Modem is registered to the network. Host suspended, I want my device >> to wake up the host when it receives, for example, a call or an sms. > > What if the modem

Re: [PATCH v3 6/7] usb: chipidea: usbmisc: add mx53 support

2012-11-26 Thread Grant Likely
On Sun, 25 Nov 2012 16:09:31 +0800, Peter Chen wrote: > On Fri, Nov 23, 2012 at 11:02:13AM +0100, Marc Kleine-Budde wrote: > > On 11/23/2012 07:53 AM, Peter Chen wrote: > > > On Wed, Nov 21, 2012 at 03:06:32PM +0100, Michael Grzeschik wrote: > > >> This adds mx53 as the next user of the usbmisc dr

Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/23/2012 12:52 PM, Andrzej Pietrasiewicz wrote: The general idea is that: echo "some_name"> /cfg/usb-function-gadget/G1/C1/F1/name echo "some_name"> /cfg/usb-function-gadget/G1/C2/F1/name creates two separate instances of F1 in C1 and C2. Did you mean the same instance of F1 used both in

Re: USB issue with kernel 3.6

2012-11-26 Thread Alan Stern
On Thu, 22 Nov 2012, Piergiorgio Sartor wrote: > OK, I got a log with working and then non working system, > so there should be a transition, The trace attached to Kernel Bugzilla #50381 didn't give any details. All it showed was that at one point the computer stopped getting data from the driv

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Michal Nazarewicz
> On 11/26/2012 09:35 AM, Andrzej Pietrasiewicz wrote: >> In some parts of the kernel (e.g. planned configfs integration into usb >> gadget) there is a need to programmatically create config groups >> (directories) but it would be preferable to disallow creating them by >> the user. This is more or

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: > Step two is a folder where we setup individual configuration of a function. > > /functions/ttyS0 > /functions/ttyS1 > /functions/storage > > each one of the function folder has the file called "name". So for the > folder ttyS0 the file name

Re: cdc-acm and remote wakeup

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Daniele Palmas wrote: > > What if the modem isn't registered to the network? For example, if the > > cdc-acm driver is unloaded. Does it need remote wakeup to be enabled > > then? > > > > That is a good question: in my specific scenario it is not useful to > have the remote

Re: cdc-acm and remote wakeup

2012-11-26 Thread Daniele Palmas
2012/11/26 Alan Stern : > On Mon, 26 Nov 2012, Daniele Palmas wrote: > >> > What if the modem isn't registered to the network? For example, if the >> > cdc-acm driver is unloaded. Does it need remote wakeup to be enabled >> > then? >> > >> >> That is a good question: in my specific scenario it is

[PATCH] USB: OHCI: workaround for hardware bug: retired TDs not added to the Done Queue

2012-11-26 Thread Alan Stern
This patch (as1636) is a partial workaround for a hardware bug affecting OHCI controllers by NVIDIA at least, maybe others too. When the controller retires a Transfer Descriptor, it is supposed to add the TD onto the Done Queue. But sometimes this doesn't happen, with the result that ohci-hcd nev

Re: cdc-acm and remote wakeup

2012-11-26 Thread Oliver Neukum
On Monday 26 November 2012 12:06:21 Alan Stern wrote: > Still, this is an important consideration. It means that remote wakeup > doesn't need to be enabled when the driver isn't present. Which means > that the cdc-acm driver is indeed the right place to fix this problem > -- although the way you

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/26/2012 05:57 PM, Alan Stern wrote: On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: Step two is a folder where we setup individual configuration of a function. /functions/ttyS0 /functions/ttyS1 /functions/storage each one of the function folder has the file called "name". So for t

Re: [RFC 2/8] USB: Ignore xHCI Reset Device status.

2012-11-26 Thread Sarah Sharp
On Fri, Nov 23, 2012 at 12:40:12PM -0500, Alan Stern wrote: > On Wed, 21 Nov 2012, Sarah Sharp wrote: > > > A device may need to be reset several times during enumeration, and this > > causes a disconnect between the USB core's device state and the xHC's > > device state. > > > > For example, usb

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Michal Nazarewicz
On Mon, Nov 26 2012, Sebastian Andrzej Siewior wrote: > Wouldn't say that. It may adds complexity on another level. The target > subsystem has the same problem with adding luns and there seems nothing > wrong with having lun3 and 4 and leaving 0 and 1 unsued. That's not what Wikipedia claims thoug

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Michal Nazarewicz
> On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: >> Step two is a folder where we setup individual configuration of a function. >> >> /functions/ttyS0 >> /functions/ttyS1 >> /functions/storage >> >> each one of the function folder has the file called "name". So for the >> folder ttyS0 the

Re: [RFC][PATCH] fs: configfs: programmatically create config groups

2012-11-26 Thread Sebastian Andrzej Siewior
On 11/26/2012 05:56 PM, Michal Nazarewicz wrote: On 11/26/2012 09:35 AM, Andrzej Pietrasiewicz wrote: In some parts of the kernel (e.g. planned configfs integration into usb gadget) there is a need to programmatically create config groups (directories) but it would be preferable to disallow crea

Re: [RFC 3/8] xHCI: Clear all USB 2.0 change bits on port disable.

2012-11-26 Thread Sarah Sharp
On Fri, Nov 23, 2012 at 12:55:29PM -0500, Alan Stern wrote: > On Wed, 21 Nov 2012, Sarah Sharp wrote: > > > The USB core disables the USB 2.0 ports in several different error > > cases. It expects that all USB hubs will act like external hubs, and > > always return an interrupt event if a port ch

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2012-11-26 Thread Sergei Shtylyov
Hello. On 11/12/2012 09:01 PM, Sergei Shtylyov wrote: > This patch fixes the following: > WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference from > the function dma_controller_create() to the function > .init.text:cppi_controller_start() > The function __devinit dma_contro

Re: [PATCH] musb_core: print new line in the driver banner again

2012-11-26 Thread Sergei Shtylyov
On 11/14/2012 06:49 PM, Sergei Shtylyov wrote: > Commit 5c8a86e10a7c164f44537fabdc169fd8b4e7a440 (usb: musb: drop unneeded > musb_debug trickery) erroneously removed '\n' from the driver's banner. > Concatenate all the banner substrings while adding it back... > Signed-off-by: Sergei Shtylyov >

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: > On 11/26/2012 05:57 PM, Alan Stern wrote: > > On Mon, 26 Nov 2012, Sebastian Andrzej Siewior wrote: > > > >> Step two is a folder where we setup individual configuration of a function. > >> > >> /functions/ttyS0 > >> /functions/ttyS1 > >> /fu

Re: [RFC 2/8] USB: Ignore xHCI Reset Device status.

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sarah Sharp wrote: > > > This will cause > > > the port reset to fail until the device is logically disconnected. > > > > > > Fix this by ignoring the return value of the HCD reset_device callback. > > > > Does this really fix anything? Since the device can't be reset afte

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Michal Nazarewicz
On Mon, Nov 26 2012, Alan Stern wrote: > In your example, what files would appear under under > /functions/storage? I gather that the "storage" part is just a > placeholder name with no real meaning. The meaning is conveyed > when the user writes "mass_storage" to /functions/storage/name. > > Whe

Re: [RFC 3/8] xHCI: Clear all USB 2.0 change bits on port disable.

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sarah Sharp wrote: > > Is port-disabling the only place where this problem occurs? > > Probably not. > > > A more defensive approach would be to copy what ohci-hcd does. When a > > port-change interrupt occurs, the driver switches over to polling for > > root-hub status cha

Re: cdc-acm and remote wakeup

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Oliver Neukum wrote: > On Monday 26 November 2012 12:06:21 Alan Stern wrote: > > Still, this is an important consideration. It means that remote wakeup > > doesn't need to be enabled when the driver isn't present. Which means > > that the cdc-acm driver is indeed the right p

Re: [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 04:34:31PM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Nov 26, 2012 at 06:39:36AM -0800, Greg KH wrote: > > On Sun, Nov 25, 2012 at 11:43:14PM -0500, Chao Xie wrote: > > > From: Chao Xie > > > > > > This patches converts the driver into the new style start/stop > > > int

Re: configfs hierarchy (WAS: Re: [RFCv4 PATCH 02/13] usb: gadget: Add USB Functions Gadget)

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Michal Nazarewicz wrote: > On Mon, Nov 26 2012, Alan Stern wrote: > > In your example, what files would appear under under > > /functions/storage? I gather that the "storage" part is just a > > placeholder name with no real meaning. The meaning is conveyed > > when the user

Re: [PATCH 06/27] usb: host: ehci-mv: fix clk APIs

2012-11-26 Thread Alan Stern
On Sun, 25 Nov 2012, Chao Xie wrote: > From: Chao Xie > > the clock common driver changes, and arch-mmp will make use of > the common clock driver instead of its own. > So for enable clock. > first prepare the clock > then enable the clock. > > for disable clock > first disable the clock > then

Re: [RFC 0/8] USB core reset changes

2012-11-26 Thread Sarah Sharp
On Fri, Nov 23, 2012 at 01:20:15PM -0500, Alan Stern wrote: > On Wed, 21 Nov 2012, Sarah Sharp wrote: > > > Hi Alan, > > > > Can you take a look over this patchset to improve reset support under > > xHCI roothubs? > > > > There's a lot of changes here, but I tried to break it up into easily > >

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Andy Green wrote: > This adds a small optional API into drivers/base which deals with generating, > matching and registration of wildcard device paths. > > >From a struct device * you can generate a string like > > /platform/usbhs_omap/ehci-omap.0/usb1/1-1 > > which enapsu

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 12:45:34PM +, Andy Green wrote: > +struct device_path list; > +DEFINE_MUTEX(lock); Those are some very descriptive global variables you just created :( -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ke

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 12:45:34PM +, Andy Green wrote: > This adds a small optional API into drivers/base which deals with generating, > matching and registration of wildcard device paths. > > >From a struct device * you can generate a string like > > /platform/usbhs_omap/ehci-omap.0/usb1/1

Re: [RFC PATCH 3/5] usb: hub: add device_path regulator control to generic hub

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 12:45:45PM +, Andy Green wrote: > This adds the config option to associate a regulator with each hub, > when the hub on a specific, interesting device path appears, then > the regular is powered while the logical hub exists. > > Signed-off-by: Andy Green > --- > drive

Re: USB issue with kernel 3.6

2012-11-26 Thread Piergiorgio Sartor
On Mon, Nov 26, 2012 at 11:51:39AM -0500, Alan Stern wrote: > On Thu, 22 Nov 2012, Piergiorgio Sartor wrote: > > > OK, I got a log with working and then non working system, > > so there should be a transition, > > The trace attached to Kernel Bugzilla #50381 didn't give any details. > All it sh

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 11:22:06AM -0800, Greg KH wrote: > On Mon, Nov 26, 2012 at 12:45:34PM +, Andy Green wrote: > > This adds a small optional API into drivers/base which deals with > > generating, > > matching and registration of wildcard device paths. > > > > >From a struct device * you

Re: [PATCH 06/16] mfd: omap-usb-host: cleanup clock management code

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 05:14:45PM +0200, Roger Quadros wrote: > Felipe, > > On 11/21/2012 03:39 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Nov 15, 2012 at 04:34:04PM +0200, Roger Quadros wrote: > >> All ports have similarly named port clocks so we can > >> bunch them into a port data s

Re: [alsa-devel] [PATCH] usb: add USB_QUIRK_RESET_RESUME for M-Audio 49

2012-11-26 Thread Clemens Ladisch
Alan Stern wrote: > On Mon, 26 Nov 2012, Oliver Neukum wrote: >> On Monday 26 November 2012 14:43:13 Clemens Ladisch wrote: >>> usb_autopm_get_interface() cannot be called from the USB probe callback. >> >> You can use usb_autopm_get_interface_no_resume() >> During probe() the device is known to no

Re: [PATCH 01/27] usb: gadget: mv_udc: use udc_start and udc_stop functions

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 10:42:32AM -0800, Greg KH wrote: > On Mon, Nov 26, 2012 at 04:34:31PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Mon, Nov 26, 2012 at 06:39:36AM -0800, Greg KH wrote: > > > On Sun, Nov 25, 2012 at 11:43:14PM -0500, Chao Xie wrote: > > > > From: Chao Xie > > > > >

Re: [PATCH] lsusb: Fix USB 3.0 link state reporting.

2012-11-26 Thread Sarah Sharp
Greg, ping? On Thu, Nov 08, 2012 at 01:57:04PM -0800, Sarah Sharp wrote: > The math in the link status reporting is wrong. The link state is in > bits 8:5 of the hub port status word, which is split across a char > array. Currently, if the link state is 0xb (Loopback mode), the status > char arr

Re: [PATCH] cppi_dma: mark cppi_controller_create() and cppi_pool_init() as '__devinit'

2012-11-26 Thread Felipe Balbi
Hi, On Mon, Nov 26, 2012 at 10:14:30PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/12/2012 09:01 PM, Sergei Shtylyov wrote: > > > This patch fixes the following: > > > WARNING: vmlinux.o(.devinit.text+0x24ac): Section mismatch in reference > > from the function dma_controller_create() to

Re: [PATCH] lsusb: Fix USB 3.0 link state reporting.

2012-11-26 Thread Greg KH
On Mon, Nov 26, 2012 at 12:13:34PM -0800, Sarah Sharp wrote: > Greg, ping? Sorry, I've been swamped with kernel stuff. This patch is in my usbutils patch queue, along with a few other submitted patches, I hope to get to them later this week. Don't worry, it's not lost :) thanks, greg k-h -- To

Re: USB issue with kernel 3.6

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Piergiorgio Sartor wrote: > Hi Alan, > > thanks for the patch. > > I'll try to apply it and report the results, > including the USB EHCI register files. > > Unfortunately, I cannot provide a "deadline" > (so to speak), I'm quite busy at the moment. Don't worry about it; I'

[PATCH] uwb: fix uwb_dev_unlock() missed at an error path in uwb_rc_cmd_async()

2012-11-26 Thread Alexey Khoroshilov
There is the only path in uwb_rc_cmd_async() where rc->uwb_dev is left unlocked. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/uwb/reset.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/uwb/reset.c b/drivers/uwb/rese

Re: [RFC PATCH 1/5] drivers : introduce device_path api

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Greg KH wrote: > Ah, here's the root of your problem, right? You need a way for your > hardware to tell the kernel that you have a regulator attached to a > specific device? Using the device path and hard-coding it into the > kernel is not the proper way to solve this, sorry

Re: [RFC 2/8] USB: Ignore xHCI Reset Device status.

2012-11-26 Thread Sarah Sharp
On Mon, Nov 26, 2012 at 01:29:33PM -0500, Alan Stern wrote: > On Mon, 26 Nov 2012, Sarah Sharp wrote: > > > > > This will cause > > > > the port reset to fail until the device is logically disconnected. > > > > > > > > Fix this by ignoring the return value of the HCD reset_device callback. > > >

Re: Mouse and keyboard freeze Ivy-bridge

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Chris Holland wrote: > > Can you supply similar logging information for the case where the > > mouse/keyboard is plugged into a USB-2 motherboard port? Please > > include the contents of /sys/kernel/debug/usb/devices. > > > > Alan Stern > > > > Here is what I think is the la

Re: [RFC 2/8] USB: Ignore xHCI Reset Device status.

2012-11-26 Thread Alan Stern
On Mon, 26 Nov 2012, Sarah Sharp wrote: > On Mon, Nov 26, 2012 at 01:29:33PM -0500, Alan Stern wrote: > > On Mon, 26 Nov 2012, Sarah Sharp wrote: > > > > > > > This will cause > > > > > the port reset to fail until the device is logically disconnected. > > > > > > > > > > Fix this by ignoring t

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

2012-11-26 Thread Bjørn Mork
Sarah Sharp writes: > It looks like both Ulrich and Andrew have the same issue. I also have a > Lenovo x220, and I confirmed that when I turn on PCI runtime suspend, > the NEC host controller does not report port status changes when a new > USB device is plugged in. > > I'm running 3.6.7, and I'

Re: [RFC 2/8] USB: Ignore xHCI Reset Device status.

2012-11-26 Thread Sarah Sharp
On Mon, Nov 26, 2012 at 04:44:59PM -0500, Alan Stern wrote: > On Mon, 26 Nov 2012, Sarah Sharp wrote: > > > On Mon, Nov 26, 2012 at 01:29:33PM -0500, Alan Stern wrote: > > > On Mon, 26 Nov 2012, Sarah Sharp wrote: > > > > > > > > > This will cause > > > > > > the port reset to fail until the dev

  1   2   >