[PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Xiaotian Feng
If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Li Yang Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Cc: linuxppc-...@lists.ozlabs.org --- drivers/usb/gadget/f

Re: [PATCH v3 2/6] PM / Runtime: introduce pm_runtime_set[get]_memalloc_noio()

2012-10-31 Thread Oliver Neukum
On Wednesday 31 October 2012 11:05:33 Ming Lei wrote: > On Wed, Oct 31, 2012 at 10:08 AM, Ming Lei wrote: > >> I am afraid it is, because a disk may just have been probed as the > >> deviceis being reset. > > > > Yes, it is probable, and sounds like similar with 'root_wait' problem, see > > prepa

RE: Linux USB gadget mass storage

2012-10-31 Thread victor
Hi, In usb gadget file_storage.c, check_command(), the part "Check that only command bytes listed in the mask are non-zero" cannot handle the SCSI_INQUIRY command of 12 01 80 00 FF 00 The code will return EINVAL. Is this a bug? Thanks, victor -Original Message- From: victor [mailto:v

[PATCH] USB: serial: remove driver version information

2012-10-31 Thread Johan Hovold
Remove all MODULE_VERSION macros and driver-version information (except for garmin_gps which uses it in a status reply). It is the kernel version that matters and not some private version scheme which rarely even gets updated. Signed-off-by: Johan Hovold --- drivers/usb/serial/aircable.c

SIOCSIFFLAGS: No space left on device; error for 3G usb network dongle on linux 2.6.38

2012-10-31 Thread Ganesh Kumar
Hi all, *** Sorry if this is not the right forum to post this issue, as i searched for any linux usb users mailing list, dint get one, the one on sourceforge seems obsolete, so tried posting here. *** I'm working on Sierra wireless 3g usb dongle on Linux 2.6.38 on my embedded board, I'm facing an

Re: SIOCSIFFLAGS: No space left on device; error for 3G usb network dongle on linux 2.6.38

2012-10-31 Thread Oliver Neukum
On Wednesday 31 October 2012 16:49:36 Ganesh Kumar wrote: > Hi all, > > *** Sorry if this is not the right forum to post this issue, as i > searched for any linux usb users mailing list, dint get one, the one > on sourceforge seems obsolete, so tried posting here. *** > > I'm working on Sierra wi

Re: SIOCSIFFLAGS: No space left on device; error for 3G usb network dongle on linux 2.6.38

2012-10-31 Thread Ganesh Kumar
>>board <--> dlink hub <---> 3g usb dongle >> I connect the 3g usb dongle to the Dlink USB Hub and i issue the AT >> commands through the busybox microcom, after I get OK for the >> connection, if I try to >> run dhclinet on wwan0 or if I do a ifconfig wwan0 up i see the below >> error message:

Re: [PATCH v2 2/2] USB: DWC3: EXYNOS: Remove platform data for dwc3-exynos

2012-10-31 Thread Vivek Gautam
Hi all, On Tue, Oct 16, 2012 at 2:15 PM, Vivek Gautam wrote: > We are removing plat data which was used till now to init and > exit phy. We no longer need this since dwc3-core takes care of > initializing and shutting-down the phy using usb_phy_init() > and usb_phy_shutdown(). > > Signed-off-by:

[PATCH 08/11] ARM: OMAP: USB: Change the TLL clock names

2012-10-31 Thread Keshava Munegowda
The tll ports clock names are renamed as channel clocks. This is change is just adhere to TRM words Signed-off-by: Keshava Munegowda --- drivers/mfd/omap-usb-tll.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/oma

[PATCH 01/11] ARM: OMAP4: USB: Host: Add USB2 Host Device Tree Node

2012-10-31 Thread Keshava Munegowda
The device tree node details of usb2 host and tll components are included for OMAP4 SOC Signed-off-by: Keshava Munegowda --- .../devicetree/bindings/usb/omap-usb-host.txt | 24 .../devicetree/bindings/usb/omap-usb-tll.txt | 21 + arch/arm/boot/

[PATCH 04/11] ARM: OMAP3: USB: Host: Beagle-XM board specific device tree node

2012-10-31 Thread Keshava Munegowda
OMAP3 Beagle-XM board specific data for usb2 host device tree node is included. In Beagle XM board , the port 2 of usb host is connected to a hub with ethernet interface. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3-beagle-xm.dts | 32 1 file ch

[PATCH 02/11] ARM: OMAP4: USB: Host: Panda board specific device tree node

2012-10-31 Thread Keshava Munegowda
OMAP4 panda board specific device tree node is included. In OMAP4 panda board, the port 1 is used in ULPI PHY mode. The port 1 is connected to a on board hub with ethernet interface. TODO: The clock bindings are not yet avilable for OMAP4. hence , USB hub specific clocks are exported as dev

[PATCH 00/11] ARM: OMAP: USB: Host: Device tree Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host driver of OMAP3/OMAP4 are device tree complaiant with this patch series. The device tree data of UHH, EHCI, OHCI and TLL are included. The drivers are updated to extract and use the register set and interrupt numbers delivered by these device tree structures. Keshava Munegowda (11):

[PATCH 09/11] ARM: OMAP: USB: Remove the device name for TLL channel clocks for OMAP3

2012-10-31 Thread Keshava Munegowda
Since TLL channels clocks are dummy(virtual) nodes for OMAP3. The device names for these clocks are set to NULL. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/clock3xxx_data.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/clock3xxx_da

[PATCH 03/11] ARM: OMAP3: USB: Add USB2 Host Device Tree Node

2012-10-31 Thread Keshava Munegowda
The device tree node details of usb2 host and tll components are included for OMAP3 Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 69

[PATCH 06/11] ARM: OMAP: USB: Host: USB TLL Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB TLL device node is extracted and used in the probe of the driver to initialize the driver data. This TLL driver exports an API to usbhs driver to perform the port configuration. The usb2 hs driver invoke the same API in its driver probe to initialize the ports. Signed-off-by: Keshava Muneg

[PATCH 11/11] ARM: OMAP3: USB: Add pin mux configuration for beagle-xm board

2012-10-31 Thread Keshava Munegowda
The port2 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb2) port 2 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3-beagle-xm.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/oma

[PATCH 10/11] ARM: OMAP4: USB: Add pin mux configuration for panda board

2012-10-31 Thread Keshava Munegowda
The port1 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb1) port 1 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap4-panda.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/omap4-panda.d

[PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host device node is extracted and used in the probe of the driver to initialize the usb ports and controller. The platform specific initialization is also performed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-host.c |2 - drivers/mfd/omap-usb-host.c

[PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Keshava Munegowda
The usbhs core driver data is used by the ehci driver, because the ehci driver is child of usbhs core. The unused ehci, ohci and tll specific structures are removed. platform device creation of usbhs and tll using hwmod is removed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-hos

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 24, 2012 at 08:47:04PM +0200, Michal Nazarewicz wrote: > > On Wed, Oct 24, 2012 at 07:30:42PM +0200, Michal Nazarewicz wrote: > >> At first it looks strange as FSG does not use composite, but yeah: > > On Wed, Oct 24 2012, Sebastian Andrzej Siewior wrote: > > Yeah. However, it sho

Re: [PATCH v5 1/4] Revert "usb: otg: mxs-phy: Fix mx23 operation"

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 03:13:09PM +0800, Peter Chen wrote: > The real reason causes mx23 fail are: > > - Calling mxs_phy_hw_init(mxs_phy) again at connection > - Error connect/disconnect nodity at hub.c > > The coming patch will fix above two problems, Mike Thompson > tested his hardware wo

Re: [PATCH v5 2/4] usb: mxs-phy: re-init phy during the connection is useless

2012-10-31 Thread Felipe Balbi
On Mon, Oct 22, 2012 at 03:13:10PM +0800, Peter Chen wrote: > As phy is working, re-init phy may cause unexpected results > > Signed-off-by: Peter Chen Acked-by: Felipe Balbi > --- > drivers/usb/otg/mxs-phy.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drive

Re: [PATCH v5 1/4] Revert "usb: otg: mxs-phy: Fix mx23 operation"

2012-10-31 Thread Fabio Estevam
On Mon, Oct 22, 2012 at 5:13 AM, Peter Chen wrote: > The real reason causes mx23 fail are: > > - Calling mxs_phy_hw_init(mxs_phy) again at connection > - Error connect/disconnect nodity at hub.c > > The coming patch will fix above two problems, Mike Thompson So shouldn't this patch be the last on

Re: [PATCH] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 12:30:59PM -0700, Greg KH wrote: > On Fri, Oct 26, 2012 at 11:43:19PM +0900, Masanari Iida wrote: > > Correct spelling typo in debug message within drivers/usb. > > > > Signed-off-by: Masanari Iida > > This no longer applies, please redo it against the latest linux-n

Re: [PATCH 1/4 v5] usb: phy: add R-Car USB phy driver

2012-10-31 Thread Felipe Balbi
On Mon, Oct 29, 2012 at 12:44:16AM -0700, Kuninori Morimoto wrote: > This patch adds Renesas R-Car USB phy driver. > It supports R8A7779 chip at this point. > > R-Car has some USB controllers, but has only one phy-initializer. > So, this driver is counting users. > > Signed-off-by: Kuninori Morim

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Michal Nazarewicz
On Wed, Oct 31 2012, Felipe Balbi wrote: > nevertheless, I should be receiving a patch right about now removing > that file. Alan, care to send a patch for that ? I have some other stuff to remove as well, so I can take care of it, so Alan can spend his time on something more important. -- Best

Re: [PATCH REPOST] usb: host: tegra remove include of

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 11:01:08AM -0600, Stephen Warren wrote: > On 10/24/2012 01:29 PM, Stephen Warren wrote: > > Almost nothing from this file is used, and the file will hopefully be > > deleted soon. Copy the tiny portions that are used directly into > > ehci-tegra.c. I believe that Venu B

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 01:55:03PM +0100, Michal Nazarewicz wrote: > On Wed, Oct 31 2012, Felipe Balbi wrote: > > nevertheless, I should be receiving a patch right about now removing > > that file. Alan, care to send a patch for that ? > > I have some other stuff to remove as well, so I can

Re: [PATCH 05/16] usb/gadget: add some error recovery in afunc_bind()

2012-10-31 Thread Felipe Balbi
On Wed, Oct 24, 2012 at 02:20:02PM +0200, Sebastian Andrzej Siewior wrote: > On 10/24/2012 12:25 PM, Sergei Shtylyov wrote: > >Hello. > > Hi, > > >On 23-10-2012 0:14, Sebastian Andrzej Siewior wrote: > > > >>In case something goes wrong here, don't leak memory / endpoints. > > > >>Cc: jassisinghb

Re: [PATCH 11/16] usb/gadget: fix error path in uvc_function_bind()

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 22, 2012 at 10:15:05PM +0200, Sebastian Andrzej Siewior wrote: > The "video->minor = -1" assigment is done in V4L2 by > video_register_device() so it is removed here. > Now. uvc_function_bind() calls in error case uvc_function_unbind() for > cleanup. The problem is that uvc_functio

Re: dummy_hcd: try to add qh

2012-10-31 Thread Felipe Balbi
Hi, On Sat, Oct 27, 2012 at 12:53:49AM +0200, Sebastian Andrzej Siewior wrote: > I tried to add the qh structure. It is likely that patch #1 isn't 100% > checkpatch clear. If we agree on #3 then I go and clean it up. I wonder what I should do with this series... -- balbi signature.asc Descrip

Re: [PATCH] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 12:43:02PM +0100, Sebastian Andrzej Siewior wrote: > This replaced the handcrafted id handling by the PLATFORM_DEVID_AUTO > value which should do the same thing. > This patch probably also fixes ux500 because I did not find the "musbid" > variable to remove. And we clos

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: > If tasklet_disable() is called before related tasklet handled, > tasklet_kill will never be finished. tasklet_kill is enough. how did you test this ? Why changing FSL driver instead of switching over to chipidea which is supposed to

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Felipe Balbi
hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: > The use of variable length arrays in structs (VLAIS) in the Linux Kernel code > precludes the use of compilers which don't implement VLAIS (for instance the > Clang compiler). This patch instead calculates offsets into the kmallo

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-31 Thread Felipe Balbi
hi, On Mon, Oct 22, 2012 at 06:51:39AM +0200, Virupax SADASHIVPETIMATH wrote: > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Monday, October 15, 2012 5:49 PM > > To: Virupax SADASHIVPETIMATH > > Cc: ba...@ti.com; st...@rowland.harvard.edu; linux-usb@vger.kern

Re: [PATCH] usb:musb: Dequeue urbs on device unplug

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 10, 2012 at 10:06:03AM +0530, Virupax Sadashivpetimath wrote: > Flush queued urbs on receiving device disconnect > interrupt. This is required for successful disconnect > and successive enumeration of the device. > > In a failure case khubd hangs on usb-storage thread > for comple

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
On Sun, Oct 28, 2012 at 06:48:29PM +0100, Sebastian Andrzej Siewior wrote: > On Sun, Oct 28, 2012 at 06:30:02PM +0100, Dmytro Milinevskyy wrote: > > I was trying to keep 2 tabs but checkpatch didn't accept long line > > that's why I killed extra tab. > > Then move them to the code section instead

Re: [PATCH] usb: gadget: ncm: correct endianess conversion

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:44:27AM +0100, Dmytro Milinevskyy wrote: > Convert USB descriptor's fields to CPU byte order before using locally in USB > NCM gadget driver. > Tested on MIPS32 big-endian device. > > Signed-off-by: Dmytro Milinevskyy > --- > drivers/usb/gadget/f_ncm.c | 12 +

Re: [PATCH 00/11] ARM: OMAP: USB: Host: Device tree Adaptation

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 05:46:38PM +0530, Keshava Munegowda wrote: > The USB2 Host driver of OMAP3/OMAP4 are device tree complaiant with > this patch series. > The device tree data of UHH, EHCI, OHCI and TLL are included. > The drivers are updated to extract and use the register set and > inte

Re: dummy_hcd: try to add qh

2012-10-31 Thread Sebastian Andrzej Siewior
On 10/31/2012 02:15 PM, Felipe Balbi wrote: Hi, Hi, On Sat, Oct 27, 2012 at 12:53:49AM +0200, Sebastian Andrzej Siewior wrote: I tried to add the qh structure. It is likely that patch #1 isn't 100% checkpatch clear. If we agree on #3 then I go and clean it up. I wonder what I should do with

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 16, 2012 at 02:15:56PM +0530, Vivek Gautam wrote: > This patch adds support to parse probe data for > dwc3-exynos driver using device tree. > > Signed-off-by: Vivek Gautam does not apply to my dwc3 branch. Care to respin ? -- balbi signature.asc Description: Digital signature

Re: dummy_hcd: try to add qh

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 02:44:22PM +0100, Sebastian Andrzej Siewior wrote: > On 10/31/2012 02:15 PM, Felipe Balbi wrote: > >Hi, > Hi, > > >On Sat, Oct 27, 2012 at 12:53:49AM +0200, Sebastian Andrzej Siewior wrote: > >>I tried to add the qh structure. It is likely that patch #1 isn't 100% > >>

Re: [PATCH] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Sebastian Andrzej Siewior
On 10/31/2012 02:24 PM, Felipe Balbi wrote: unfortunately doesn't apply to my musb branch. Care to respin this patch ? Let me wait a bit until your tree makes it to k.o and then I rebase on top of it. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body

Re: [PATCH] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Felipe Balbi
On Wed, Oct 31, 2012 at 02:45:55PM +0100, Sebastian Andrzej Siewior wrote: > On 10/31/2012 02:24 PM, Felipe Balbi wrote: > >unfortunately doesn't apply to my musb branch. Care to respin this > >patch ? > > Let me wait a bit until your tree makes it to k.o and then I rebase on > top of it. cool, t

Re: [PATCH v7 2/5] usb: s3c-hsotg: Adding phy driver support

2012-10-31 Thread Felipe Balbi
Hi, On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote: > @@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct > platform_device *pdev) > int ret; > int i; > > - plat = pdev->dev.platform_data; > - if (!plat) { > - dev_err(&pdev->dev, "

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-10-31 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > This patchset is based on the work by Praveen Paneri for > samsung-usbphy driver: > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 > > Changes from v2: > - Using "EXYNOS5_PHY_" as common prefix along with exact n

Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

2012-10-31 Thread Rajaram R
Hi On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun wrote: > commit 65b3d52d02a558fbfe08e43688e15390c5ab3067 > (usb: musb: add musb_ida for multi instance support) > used musbid in ux500_remove() but nerver declared it. The above message doesnot match with your fix. You say ux500_remove is using m

Re: [GIT PULL] USB fixes for v3.7-rc4

2012-10-31 Thread Rajaram R
Hi Felipie/Greg On Tue, Oct 30, 2012 at 6:17 PM, Felipe Balbi wrote: > Hi Greg, > > Judging by how things are going, this is likely to be my last pull request > for v3.7-rc cycle, unless someone finds a big regression which we really must > fix during v3.7-rc. > > It's rather small; just a revert

[PATCH 0/2] usb: musb: dsps: fixes for -rc

2012-10-31 Thread Afzal Mohammed
Hi Balbi, This series contains a couple of fixes for musb dsps wrapper. First one restores capability to support at least one instance of musb. Without it, even a single instance can't be supported as change which is reverted by it was made along with multi phy changes and nop transciever dt supp

[PATCH 1/2] Revert "usb: musb: dsps: remove explicit NOP device creation"

2012-10-31 Thread Afzal Mohammed
This reverts commit d8c3ef256f88b7c6ecd673d03073b5645be9c5e4. Above mentioned change was made along with multi usb phy change and adding DT support for nop transceiver. But other two changes did not make it to mainline. This in effect makes dsps musb wrapper unusable even for single instance. Hen

[PATCH 2/2] usb: musb: dsps: document dt bindings properly

2012-10-31 Thread Afzal Mohammed
DT bindings normally use '-' (hyphens) instead of '_' (underscore), driver has it the proper way, but binding documentation does not reflect it, fix it. Signed-off-by: Afzal Mohammed --- Documentation/devicetree/bindings/usb/am33xx-usb.txt | 8 1 file changed, 4 insertions(+), 4 deletio

[RESEND PATCH 10/11] ARM: OMAP4: USB: Add pin mux configuration for panda board

2012-10-31 Thread Keshava Munegowda
The port1 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb1) port 1 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap4-panda.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/omap4-panda.d

[RESEND PATCH 08/11] ARM: OMAP: USB: Change the TLL clock names

2012-10-31 Thread Keshava Munegowda
The tll ports clock names are renamed as channel clocks. This is change is just adhere to TRM words Signed-off-by: Keshava Munegowda --- drivers/mfd/omap-usb-tll.c | 46 ++-- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/drivers/mfd/oma

[RESEND PATCH 01/11] ARM: OMAP4: USB: Host: Add USB2 Host Device Tree Node

2012-10-31 Thread Keshava Munegowda
The device tree node details of usb2 host and tll components are included for OMAP4 SOC Signed-off-by: Keshava Munegowda --- .../devicetree/bindings/usb/omap-usb-host.txt | 24 .../devicetree/bindings/usb/omap-usb-tll.txt | 21 + arch/arm/boot/

[RESEND PATCH 02/11] ARM: OMAP4: USB: Host: Panda board specific device tree node

2012-10-31 Thread Keshava Munegowda
OMAP4 panda board specific device tree node is included. In OMAP4 panda board, the port 1 is used in ULPI PHY mode. The port 1 is connected to a on board hub with ethernet interface. TODO: The clock bindings are not yet avilable for OMAP4. hence , USB hub specific clocks are exported as dev

[RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Keshava Munegowda
The usbhs core driver data is used by the ehci driver, because the ehci driver is child of usbhs core. The unused ehci, ohci and tll specific structures are removed. platform device creation of usbhs and tll using hwmod is removed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-hos

[RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host device node is extracted and used in the probe of the driver to initialize the usb ports and controller. The platform specific initialization is also performed. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/usb-host.c |2 - drivers/mfd/omap-usb-host.c

[RESEND PATCH 06/11] ARM: OMAP: USB: Host: USB TLL Device tree node Adaptation

2012-10-31 Thread Keshava Munegowda
The USB TLL device node is extracted and used in the probe of the driver to initialize the driver data. This TLL driver exports an API to usbhs driver to perform the port configuration. The usb2 hs driver invoke the same API in its driver probe to initialize the ports. Signed-off-by: Keshava Muneg

[RESEND PATCH 03/11] ARM: OMAP3: USB: Add USB2 Host Device Tree Node

2012-10-31 Thread Keshava Munegowda
The device tree node details of usb2 host and tll components are included for OMAP3 Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3.dtsi | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi index 69

[RESEND PATCH 00/11] ARM: OMAP: USB: Host: Device tree Adaptation

2012-10-31 Thread Keshava Munegowda
The USB2 Host driver of OMAP3/OMAP4 are device tree complaiant with this patch series. The device tree data of UHH, EHCI, OHCI and TLL are included. The drivers are updated to extract and use the register set and interrupt numbers delivered by these device tree structures. Keshava Munegowda (11):

[RESEND PATCH 09/11] ARM: OMAP: USB: Remove the device name for TLL channel clocks for OMAP3

2012-10-31 Thread Keshava Munegowda
Since TLL channels clocks are dummy(virtual) nodes for OMAP3. The device names for these clocks are set to NULL. Signed-off-by: Keshava Munegowda --- arch/arm/mach-omap2/clock3xxx_data.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-omap2/clock3xxx_da

[RESEND PATCH 11/11] ARM: OMAP3: USB: Add pin mux configuration for beagle-xm board

2012-10-31 Thread Keshava Munegowda
The port2 of omap4 panda board is used in ULPI PHY mode. The pin mux of usbhs (usbb2) port 2 is configured accordingly. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3-beagle-xm.dts | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/oma

[RESEND PATCH 04/11] ARM: OMAP3: USB: Host: Beagle-XM board specific device tree node

2012-10-31 Thread Keshava Munegowda
OMAP3 Beagle-XM board specific data for usb2 host device tree node is included. In Beagle XM board , the port 2 of usb host is connected to a hub with ethernet interface. Signed-off-by: Keshava Munegowda --- arch/arm/boot/dts/omap3-beagle-xm.dts | 32 1 file ch

Re: [PATCH 1/3] usb: otg: nop: add dt support

2012-10-31 Thread Afzal Mohammed
Hi Balbi, On Thursday 27 September 2012 11:15 AM, Afzal Mohammed wrote: This series is made over over Balbi's usb "master" branch. It applies cleanly over "musb" branch too. Please ignore this series, a new series has been posted, "usb: musb: dsps: fixes for -rc". Regards Afzal -- To unsubs

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-31 Thread Vivek Gautam
Hi Felipe, On Wed, Oct 31, 2012 at 7:08 PM, Felipe Balbi wrote: > Hi, > On Tue, Oct 16, 2012 at 02:15:56PM +0530, Vivek Gautam wrote: >> This patch adds support to parse probe data for >> dwc3-exynos driver using device tree. >> >> Signed-off-by: Vivek Gautam > > does not apply to my dwc3 branch

Re: [GIT PULL] USB fixes for v3.7-rc4

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 07:50:11PM +0530, Rajaram R wrote: > Hi Felipie/Greg > > On Tue, Oct 30, 2012 at 6:17 PM, Felipe Balbi wrote: > > Hi Greg, > > > > Judging by how things are going, this is likely to be my last pull request > > for v3.7-rc cycle, unless someone finds a big regression w

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 04:07:23PM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: > > This patchset is based on the work by Praveen Paneri for > > samsung-usbphy driver: > > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 > >

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Li Yang
On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi wrote: > On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: >> If tasklet_disable() is called before related tasklet handled, >> tasklet_kill will never be finished. tasklet_kill is enough. > > how did you test this ? Why changing FSL drive

Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 07:45:53PM +0530, Rajaram R wrote: > On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun wrote: > > commit 65b3d52d02a558fbfe08e43688e15390c5ab3067 > > (usb: musb: add musb_ida for multi instance support) > > used musbid in ux500_remove() but nerver declared it. > > The abo

Re: [PATCH 2/3] usb: gadget: fsl_qe_udc: do not use tasklet_disable before tasklet_kill

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 10:35:37PM +0800, Li Yang wrote: > On Wed, Oct 31, 2012 at 9:26 PM, Felipe Balbi wrote: > > On Wed, Oct 31, 2012 at 04:06:00PM +0800, Xiaotian Feng wrote: > >> If tasklet_disable() is called before related tasklet handled, > >> tasklet_kill will never be finished. task

Re: [PATCH v7 2/5] usb: s3c-hsotg: Adding phy driver support

2012-10-31 Thread Lukasz Majewski
Hi Felipe, > Hi, > > On Tue, Oct 30, 2012 at 10:27:34AM +0530, Praveen Paneri wrote: > > @@ -3501,20 +3511,27 @@ static int __devinit s3c_hsotg_probe(struct > > platform_device *pdev) int ret; > > int i; > > > > - plat = pdev->dev.platform_data; > > - if (!plat) { > > - dev_er

[PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Masanari Iida
Correct spelling typo in debug messages within drivers/usb. Signed-off-by: Masanari Iida Acked-by: Felipe Balbi --- drivers/usb/gadget/fsl_udc_core.c | 2 +- drivers/usb/gadget/tcm_usb_gadget.c | 2 +- drivers/usb/musb/musb_dsps.c| 2 +- drivers/usb/renesas_usbhs/fifo.c| 2 +- 4 f

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > On Wed, Oct 31 2012, Felipe Balbi wrote: > > nevertheless, I should be receiving a patch right about now removing > > that file. Alan, care to send a patch for that ? > > I have some other stuff to remove as well, so I can take care of it, so > Ala

Re: [PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Felipe Balbi
Hi, On Thu, Nov 01, 2012 at 12:03:51AM +0900, Masanari Iida wrote: > Correct spelling typo in debug messages within drivers/usb. > > Signed-off-by: Masanari Iida > Acked-by: Felipe Balbi Greg, since now this only touches the stuff I handle, I can apply this myself. whatever works best for you

[PATCH v2] usb/musb: remove hand-crafted id handling

2012-10-31 Thread Sebastian Andrzej Siewior
This replaced the handcrafted id handling by the PLATFORM_DEVID_AUTO value which should do the same thing. This patch probably also fixes ux500 because I did not find the "musbid" variable to remove. And we close a tiny-unlikely race window becuase the old code gave the id back before device was de

Re: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Felipe Balbi
Hi, On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: > On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > > > On Wed, Oct 31 2012, Felipe Balbi wrote: > > > nevertheless, I should be receiving a patch right about now removing > > > that file. Alan, care to send a patch for that ? > > >

Re: [PATCH v3 2/6] PM / Runtime: introduce pm_runtime_set[get]_memalloc_noio()

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Ming Lei wrote: > The below idea may help the problem which 'memalloc_noio' flag isn't set > during > usb_reset_device(). > > - for usb mass storage device, call pm_runtime_set_memalloc_noio(true) > inside usb_stor_probe2() and uas_probe(), and call > pm_runtime_set_mema

Re: [PATCH] usb: musb: ux500: fix 'musbid' undeclared error in ux500_remove()

2012-10-31 Thread Rajaram R
On Wed, Oct 31, 2012 at 8:00 PM, Felipe Balbi wrote: > Hi, > > On Wed, Oct 31, 2012 at 07:45:53PM +0530, Rajaram R wrote: >> On Tue, Oct 23, 2012 at 11:42 AM, Wei Yongjun wrote: >> > commit 65b3d52d02a558fbfe08e43688e15390c5ab3067 >> > (usb: musb: add musb_ida for multi instance support) >> > use

Re: During xHC Initialization (device is not connected), when HC-RESET is asserted, software is not expecting WRC or PRC bit set

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Bhavik Kothari wrote: > Hi Alan, > > Thanks for your inputs. > > As per your given instruction, we have modified a code and below is a patch, > > > --- a/linux-3.6.1/drivers/usb/core/hub.c2012-10-07 21:11:28.0 > +0530 > +++ b/linux-3.6.1/drivers/usb/core/hub.c

RE: Linux USB gadget mass storage

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, victor wrote: > Hi, > > In file_storage.c, send_status(), if (transport_is_bbb()), I add the line > bh->inreq->buf = bh -> buf, > > and in get_next_command(), if (transport_is_bbb()), I add the line > bh->outreq->context = bh, to make the bh address to be the same. > > Is t

Re: [PATCH V2 2/3] Remove VLAIS usage from gadget code

2012-10-31 Thread Behan Webster
On 12-10-31 09:28 AM, Felipe Balbi wrote: hi, On Tue, Oct 30, 2012 at 05:18:56PM -0400, Behan Webster wrote: The use of variable length arrays in structs (VLAIS) in the Linux Kernel code precludes the use of compilers which don't implement VLAIS (for instance the Clang compiler). This patch ins

RE: Linux USB gadget mass storage

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, victor wrote: > Hi, > > In usb gadget file_storage.c, check_command(), the part "Check that only > command bytes listed in the mask are non-zero" cannot handle the > SCSI_INQUIRY command of 12 01 80 00 FF 00 > > The code will return EINVAL. > > Is this a bug? No. Alan S

Re: [PATCH v3 2/6] PM / Runtime: introduce pm_runtime_set[get]_memalloc_noio()

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Alan Stern wrote: > On Wed, 31 Oct 2012, Ming Lei wrote: > > > The below idea may help the problem which 'memalloc_noio' flag isn't set > > during > > usb_reset_device(). > > > > - for usb mass storage device, call pm_runtime_set_memalloc_noio(true) > > inside usb_stor_pr

Re: [RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Alan Stern
On Wed, 31 Oct 2012, Keshava Munegowda wrote: > The usbhs core driver data is used by the ehci driver, because > the ehci driver is child of usbhs core. The unused ehci, ohci > and tll specific structures are removed. > platform device creation of usbhs and tll using hwmod is > removed. > > Signe

Re: [RESEND PATCH 07/11] ARM: OMAP: USB: Host: Ehci driver uses the usbhs port data

2012-10-31 Thread Keshava Munegowda
On Wednesday 31 October 2012 09:13 PM, Alan Stern wrote: On Wed, 31 Oct 2012, Keshava Munegowda wrote: The usbhs core driver data is used by the ehci driver, because the ehci driver is child of usbhs core. The unused ehci, ohci and tll specific structures are removed. platform device creation o

Re: [PATCH/Ver2] [trivial] usb: Fix typo in drivers/usb

2012-10-31 Thread Greg KH
On Wed, Oct 31, 2012 at 05:06:54PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Nov 01, 2012 at 12:03:51AM +0900, Masanari Iida wrote: > > Correct spelling typo in debug messages within drivers/usb. > > > > Signed-off-by: Masanari Iida > > Acked-by: Felipe Balbi > > Greg, since now this only t

Re: [PATCH REPOST] usb: host: tegra remove include of

2012-10-31 Thread Stephen Warren
On 10/31/2012 06:51 AM, Felipe Balbi wrote: > Hi, > > On Mon, Oct 29, 2012 at 11:01:08AM -0600, Stephen Warren wrote: >> On 10/24/2012 01:29 PM, Stephen Warren wrote: >>> Almost nothing from this file is used, and the file will >>> hopefully be deleted soon. Copy the tiny portions that are used >>

Re: [PATCH V2 0/3] Removing the use of VLAIS from USB Gadget and netfilter

2012-10-31 Thread David Miller
I'm not pulling this crap into my tree to deal with limitations of a non-gcc compiler. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] USB: remove iteration limit in hub_tt_work()

2012-10-31 Thread Alan Stern
This patch (as1621) removes the limit on the number of loops allowed in hub_tt_work(). The value is arbitrary, and it's silly to have a limit in the first place -- anything beyond the limit would not get handled. Besides, it's most unlikely that we'll ever need to clear more than a couple of TT b

[PATCH] USB: EHCI: remove unused Link Power Management code

2012-10-31 Thread Alan Stern
This patch (as1622) removes the USB-2.1 Link Power Management code from the ehci-hcd driver. This code was never integrated with usbcore, it is full of bugs, and it was not getting used by anybody. However, the debugging code for dumping the LPM-related fields in the EHCI registers is left in pla

Re: Endpoint is not halted

2012-10-31 Thread Sarah Sharp
On Wed, Oct 31, 2012 at 07:33:17PM +0530, Bhavik Kothari wrote: > Hi Sarah, > > Thanks Sarah, for your TD-size patch. > > We have tried with your given driver. > At first time, USB device gets successfully mounted, however after removing > USB device, once again if we insert the USB device, it do

[PATCH] USB: EHCI: remove ehci_port_power() routine

2012-10-31 Thread Alan Stern
This patch (as1623) removes the ehci_port_power() routine and all the places that call it. There's no reason for ehci-hcd to change the port power settings; the hub driver takes care of all that stuff. There is one exception: When the controller is resumed from hibernation or following a loss of

Re: [RESEND PATCH 05/11] ARM: OMAP: USB: Host: usb host Device tree node Adaptation

2012-10-31 Thread Tony Lindgren
* Keshava Munegowda [121031 07:29]: > The USB2 Host device node is extracted and used in the probe > of the driver to initialize the usb ports and controller. The > platform specific initialization is also performed. > > Signed-off-by: Keshava Munegowda > --- > arch/arm/mach-omap2/usb-host.c

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, October 31, 2012 8:07 AM > On Wed, Oct 31, 2012 at 11:07:44AM -0400, Alan Stern wrote: > > On Wed, 31 Oct 2012, Michal Nazarewicz wrote: > > > > > On Wed, Oct 31 2012, Fe

[PATCH] USB: iuu_phoenix: fix backported patches

2012-10-31 Thread Johan Hovold
Fix two memory leaks involving dbgbuf that were introduced in port-probe error paths when backporting the following port-data fixes from v3.7 (which doesn't have dbgbuf): 0978c94 USB: iuu_phoenix: fix sysfs-attribute creation 5363655 USB: iuu_phoenix: fix port-data memory leak Reported-by: Fenggu

[PATCH] USB: mos7840: fix port-data memory leak

2012-10-31 Thread Johan Hovold
commit 80c00750f0c9867a65b30a17880939b6bc660a77 upstream. Fix port-data memory leak by moving port data allocation and deallocation to port_probe and port_remove. Since commit 0998d0631001288 (device-core: Ensure drvdata = NULL when no driver is bound) the port private data is no longer freed at

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-10-31 Thread Alan Stern
On Fri, 26 Oct 2012, Sarah Sharp wrote: > On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote: > > The USB core isn't dropping the endpoints before it calls > > xhci_check_bandwidth. I remember running into this bug a while back, > > and I even started on a fix, but then couldn't reproduc

RE: [PATCH] usb/gadget: let file storage gadget select libcomposite

2012-10-31 Thread Michal Nazarewicz
On Wed, Oct 31 2012, Paul Zimmerman wrote: > Regarding that, would you guys accept a patch that adds the "buflen" > module parameter to the mass-storage gadget? Without increasing the > buffer length above 16K, it's impossible to approach the max throughput > allowed by SuperSpeed hosts. I have no

[PATCH 0/6] Some USB gadget cleanups

2012-10-31 Thread Michal Nazarewicz
From: Michal Nazarewicz This patchset remove the following: - the File-backed Storage Gadget (g_file_storage), and - is_dualspeed file and line referenced in sysfs. Once g_file_storage is removed, it also does some cleanup inside of the storage_common.c file. Based on top of felipe/master (4274

  1   2   >