Re: xhci Portsc register issue

2012-10-26 Thread Gerd Hoffmann
Hi, > But I'm not sure, since I've never attempted to memory map PCI registers > from userspace. I was under the impression that you just can't do that. You can mmap /sys/bus/pci/devices(${device}/resource0. Just hacked up a tool which dumps the capability registers this way: http://www.kra

Re: [PATCH v2 00/11] usbnet: usb_control_msg cleanup

2012-10-26 Thread David Miller
From: Ming Lei Date: Thu, 25 Oct 2012 13:46:53 +0800 > This patch set introduces 3 helpers for handling usb read, write > and write_async command, and replaces the low level's implemention > with the generic ones. > > This patchset is a cleanup and about 300 lines code is saved. > > Also, the p

Re: [PATCH] net: usb: Fix memory leak on Tx data path

2012-10-26 Thread Oliver Neukum
On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote: > Driver anchors the tx urbs and defers the urb submission if > a transmit request comes when the interface is suspended. > Anchoring urb increments the urb reference count. These > deferred urbs are later accessed by calling usb_get_from_anc

Re: [PATCH] net: usb: Fix memory leak on Tx data path

2012-10-26 Thread David Miller
From: Oliver Neukum Date: Fri, 26 Oct 2012 09:39:16 +0200 > On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote: >> Driver anchors the tx urbs and defers the urb submission if >> a transmit request comes when the interface is suspended. >> Anchoring urb increments the urb reference count. The

Re: [PATCH] qmi_wwan/cdc_ether: move Novatel 551 and E362 to qmi_wwan

2012-10-26 Thread David Miller
From: Dan Williams Date: Wed, 24 Oct 2012 17:10:34 -0500 > These devices provide QMI and ethernet functionality via a standard CDC > ethernet descriptor. But when driven by cdc_ether, the QMI > functionality is unavailable because only cdc_ether can claim the USB > interface. Thus blacklist the

[PATCH net-next] net: cdc_ncm: error path lock fix

2012-10-26 Thread Bjørn Mork
Fixes the sparse warning drivers/net/usb/cdc_ncm.c:836:9: warning: context imbalance in 'cdc_ncm_txpath_bh' - different lock contexts for basic block Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ncm.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/cdc_ncm.c b/dr

[PATCH net-next] net: sierra: shut up sparse restricted type warnings

2012-10-26 Thread Bjørn Mork
Removes the warnings drivers/net/usb/sierra_net.c:343:45: warning: incorrect type in assignment (different base types) drivers/net/usb/sierra_net.c:343:45:expected unsigned short [unsigned] [short] [usertype] drivers/net/usb/sierra_net.c:343:45:got restricted __be16 [usertype] and

[PATCH net-next] net: cdc_ncm: big endian fix

2012-10-26 Thread Bjørn Mork
Probably doesn't matter much since the value is used as a boolean anyway, but it removes the sparse warning: drivers/net/usb/cdc_ncm.c:1090:32: warning: incorrect type in assignment (different base types) drivers/net/usb/cdc_ncm.c:1090:32:expected unsigned short [unsigned] [usertype] conne

Re: [PATCH v2 2/2] USB: doc: Binding document for ehci-platform driver

2012-10-26 Thread Sebastian Andrzej Siewior
On Thu, Oct 25, 2012 at 10:36:14AM -0400, Alan Stern wrote: > What happens if the drivers get probed in the wrong order? That is, if > ehci-platform gets probed before ehci-spear (or whatever)? The "wrong" driver may get loaded. Right now, you should have them all in one driver. For instance the

[PATCH v2 net-next] net: sierra: shut up sparse restricted type warnings

2012-10-26 Thread Bjørn Mork
Removes the warnings drivers/net/usb/sierra_net.c:343:45: warning: incorrect type in assignment (different base types) drivers/net/usb/sierra_net.c:343:45:expected unsigned short [unsigned] [short] [usertype] drivers/net/usb/sierra_net.c:343:45:got restricted __be16 [usertype] and

Re: Large files/folders copying ends with I/O error in mass storage

2012-10-26 Thread megha dey
Hi, After applying this patch,we see that vfs_write is taking around 20 seconds.After this,from the bus traces we see that there are 2 consecutive CBW's and the corresponding CSW's are also out of order.How does f_mass_storage.c handle such a situation? On Mon, Oct 22, 2012 at 8:11 PM, Alan Stern

Re: [PATCH v3 1/3] usb: dwc3: Add the suspend/resume functionality

2012-10-26 Thread Felipe Balbi
Hi, On Fri, Oct 26, 2012 at 10:34:22AM +0530, Vikas Sajjan wrote: > Hi Felipe, > > On 18 October 2012 22:59, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 18, 2012 at 12:44:50PM -0400, Alan Stern wrote: > >> On Thu, 18 Oct 2012, Sarah Sharp wrote: > >> > >> > For system suspend while the DW3 h

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-26 Thread Felipe Balbi
Hi, On Thu, Oct 25, 2012 at 11:37:33AM +0530, Vivek Gautam wrote: > Hi, > > On Tue, Oct 16, 2012 at 3:38 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Oct 16, 2012 at 03:36:43PM +0530, kishon wrote: > >> Hi, > >> > >> On Tuesday 16 October 2012 03:23 PM, Felipe Balbi wrote: > >> >On Tue, Oct 1

Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests for a disabled USB endpoint on Freescale hardware

2012-10-26 Thread Felipe Balbi
Hi, On Thu, Oct 25, 2012 at 02:36:24AM +0200, Laurent Pinchart wrote: > Hi Felipe, > > On Monday 22 October 2012 13:56:01 Felipe Balbi wrote: > > On Mon, Oct 22, 2012 at 12:47:21PM +0200, Laurent Pinchart wrote: > > > On Monday 22 October 2012 03:33:19 Li Yang-R58472 wrote: > > > > On Saturday, O

Re: [PATCH] hid: put the case in the right switch statement

2012-10-26 Thread Benjamin Tissoires
Adding Jiri to the recipient list of the patch, otherwise, the thread may fall in the depth of his mailbox :) Cheers, Benjamin On Thu, Oct 25, 2012 at 7:08 PM, Benjamin Tissoires wrote: > Hi Alan, > > Yes, I saw that too. > > Acked-by: Benjamin Tissoires > > On Thu, Oct 25, 2012 at 4:35 PM, Ala

Re: [PATCH] hid: put the case in the right switch statement

2012-10-26 Thread Jiri Kosina
On Fri, 26 Oct 2012, Benjamin Tissoires wrote: > Adding Jiri to the recipient list of the patch, otherwise, the thread > may fall in the depth of his mailbox :) > > Cheers, > Benjamin > > On Thu, Oct 25, 2012 at 7:08 PM, Benjamin Tissoires > wrote: > > Hi Alan, > > > > Yes, I saw that too. > >

Re: problem with Roseweil eusb3 enclosure

2012-10-26 Thread covici
Sarah Sharp wrote: > On Thu, Oct 25, 2012 at 06:06:53PM -0400, cov...@ccs.covici.com wrote: > > Sarah Sharp wrote: > > > On Thu, Oct 25, 2012 at 12:53:52PM -0400, cov...@ccs.covici.com wrote: > > > > Sarah Sharp wrote: > > > > > On Wed, Oct 24, 2012 at 12:52:18PM -0400, cov...@ccs.covici.com wr

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-26 Thread Benoit Cousson
Hi Felipe, On 10/26/2012 10:13 AM, Felipe Balbi wrote: > Hi, > > On Thu, Oct 25, 2012 at 11:37:33AM +0530, Vivek Gautam wrote: >> Hi, >> >> On Tue, Oct 16, 2012 at 3:38 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Tue, Oct 16, 2012 at 03:36:43PM +0530, kishon wrote: Hi, On Tuesday 1

re: USB: usb-wwan: fix multiple memory leaks in error paths

2012-10-26 Thread Dan Carpenter
Hello Johan Hovold, The patch b8f0e82044c9: "USB: usb-wwan: fix multiple memory leaks in error paths" from Oct 25, 2012, leads to the following warning: drivers/usb/serial/usb_wwan.c:505 usb_wwan_port_probe() error: port->bulk_out_endpointAddress is never equal to -1 (wron

Re: [PATCH v2 1/2] USB: dwc3-exynos: Add support for device tree

2012-10-26 Thread Felipe Balbi
On Fri, Oct 26, 2012 at 01:44:38PM +0200, Benoit Cousson wrote: > Hi Felipe, > > On 10/26/2012 10:13 AM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 25, 2012 at 11:37:33AM +0530, Vivek Gautam wrote: > >> Hi, > >> > >> On Tue, Oct 16, 2012 at 3:38 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>>

Re: (BUG) qmi-wwan bug

2012-10-26 Thread Shawn J. Goff
On 10/26/2012 02:16 AM, Bjørn Mork wrote: "Shawn J. Goff" writes: After the failure happens, I can see from USB traces (and this is with an external USB sniffer) ARP requests going out and nothing coming in - so it seems like it's not a case of dropping URBs. Does the modem respond to other

[PATCH] [trivial] usb: Fix typo in drivers/usb

2012-10-26 Thread Masanari Iida
Correct spelling typo in debug message within drivers/usb. Signed-off-by: Masanari Iida --- drivers/usb/gadget/fsl_udc_core.c | 2 +- drivers/usb/gadget/tcm_usb_gadget.c | 2 +- drivers/usb/host/Kconfig| 4 ++-- drivers/usb/musb/musb_dsps.c| 2 +- drivers/usb/renesas_usbhs/

Re: During xHC Initialization (device is not connected), when HC-RESET is asserted, software is not expecting WRC or PRC bit set

2012-10-26 Thread Alan Stern
Always use Reply-To-All so that your messages get sent to the mailing list as well as to me. Also, please avoid top-posting. On Fri, 26 Oct 2012, Ankit wrote: > Hi Alan, > > Sorry, earlier code was not proper. > > Below is a code (mark as Bold), which we have put in hub_activate(), Sorry, I

Re: [PATCH v2 2/2] USB: doc: Binding document for ehci-platform driver

2012-10-26 Thread Alan Stern
On Fri, 26 Oct 2012, Sebastian Andrzej Siewior wrote: > On Thu, Oct 25, 2012 at 10:36:14AM -0400, Alan Stern wrote: > > What happens if the drivers get probed in the wrong order? That is, if > > ehci-platform gets probed before ehci-spear (or whatever)? > > The "wrong" driver may get loaded. T

Re: Large files/folders copying ends with I/O error in mass storage

2012-10-26 Thread Alan Stern
Please don't top-post. On Fri, 26 Oct 2012, megha dey wrote: > Hi, > After applying this patch,we see that vfs_write is taking around 20 > seconds.After this,from the bus traces we see that there are 2 > consecutive CBW's and the corresponding CSW's are also out of > order.How does f_mass_storage

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Roger Quadros
Hi Kishon & Benoit, On 09/24/2012 12:06 PM, Rabin Vincent wrote: > 2012/9/24 ABRAHAM, KISHON VIJAY : >> On Sat, Sep 22, 2012 at 3:03 AM, Rabin Vincent wrote: >>> USB doesn't work on pandaboard on linux-next, and bisection shows this >>> patch. Unfortunately, I can't provide a dmesg log because U

Re: Problem with OHCI on OMAP4430

2012-10-26 Thread Alan Stern
On Fri, 26 Oct 2012, Mohan V wrote: > >> When the USB bus is in suspend, a device connected to OHCI port does > >> not get detected, whereas the device connected to EHCI port is getting > >> detected. > > > > Can you provide a dmesg log showing the OHCI problem with > > CONFIG_USB_DEBUG enabled?

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Benoit Cousson
Hi Roger, On 10/26/2012 05:16 PM, Roger Quadros wrote: > Hi Kishon & Benoit, > > On 09/24/2012 12:06 PM, Rabin Vincent wrote: >> 2012/9/24 ABRAHAM, KISHON VIJAY : >>> On Sat, Sep 22, 2012 at 3:03 AM, Rabin Vincent wrote: USB doesn't work on pandaboard on linux-next, and bisection shows this

Re: USB isochronous frame lost

2012-10-26 Thread Alan Stern
On Fri, 26 Oct 2012, Stefan May wrote: > it seems that data are interpreted differently. While the host is > getting tons of -71 errors, data is passed to vmware correctly. That's a strange way of describing it. When the -71 errors occur there _is_ no data -- the device didn't send anything.

Re: [PATCH usb-next 2/3] USB: option: replace vendor probe rule with match flags

2012-10-26 Thread Oliver Neukum
On Thursday 25 October 2012 23:42:30 Bjørn Mork wrote: > Oliver Neukum writes: > > > On Thursday 25 October 2012 21:58:37 Bjørn Mork wrote: > >> No need for a vendor specific probe exception just to > >> match on the interface class. > > > > No need for a private macro. It already exists. > > > >

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Tony Lindgren
* Benoit Cousson [121026 08:23]: > Hi Roger, > > On 10/26/2012 05:16 PM, Roger Quadros wrote: > > Hi Kishon & Benoit, > > > > On 09/24/2012 12:06 PM, Rabin Vincent wrote: > >> 2012/9/24 ABRAHAM, KISHON VIJAY : > >>> On Sat, Sep 22, 2012 at 3:03 AM, Rabin Vincent wrote: > USB doesn't work o

Re: USB isochronous frame lost

2012-10-26 Thread Stefan May
I saw different bmVideoStandards with lsusb. It is the only parameter with a different value on both sides. Meanwhile, I found a way to make the camera work. I need to use the load option nodrop=1 in the host, but not in the guest. I have no idea why UVC sees incomplete frames only on host side.

Re: Unreliable USB3 with NEC uPD720200 and Delock Cardreader

2012-10-26 Thread Ulrich Eckhardt
Am 25.10.2012 22:11, schrieb Rafael J. Wysocki: On Thursday, October 25, 2012 07:15:58 PM Ulrich Eckhardt wrote: I have done first a cat to the control file which returns already on: uli:/ # cat /sys/devices/pci\:00/\:00\:04.0/power/control on Writing again on to the file does not chan

[PATCH] USB: usb_wwan: fix bulk-urb allocation

2012-10-26 Thread Johan Hovold
Make sure we do not allocate urbs if we do not have a bulk endpoint. Legacy code used incorrect assumption to test for bulk endpoints. Reported-by: Dan Carpenter Cc: stable Signed-off-by: Johan Hovold --- Thanks for catching this Dan. The driver has been using the incorrect assumption that th

Re: USB isochronous frame lost

2012-10-26 Thread Alan Stern
On Fri, 26 Oct 2012, Stefan May wrote: > I saw different bmVideoStandards with lsusb. It is the only parameter > with a different value on both sides. Meanwhile, I found a way to make > the camera work. I need to use the load option nodrop=1 in the host, but > not in the guest. > I have no idea

Re: xhci Portsc register issue

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 10:32:05AM +0530, shashank chaturvedi wrote: > >Why would you want to do that? For link power management? What is the > >xHCI kernel driver not providing you such that you have to write a > >userspace program? > > I want to do this for link power managment.But i am able t

[GIT PATCH] USB fixes for 3.7-rc3

2012-10-26 Thread Greg KH
The following changes since commit 6f0c0580b70c89094b3422ba81118c7b959c7556: Linux 3.7-rc2 (2012-10-20 12:11:32 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.7-rc3 for you to fetch changes up to 1d63f24697b1259921f08a

Re: [PATCH usb-next 2/3] USB: option: replace vendor probe rule with match flags

2012-10-26 Thread Bjørn Mork
Oliver Neukum writes: > On Thursday 25 October 2012 23:42:30 Bjørn Mork wrote: >> Oliver Neukum writes: >> >> > No need for a private macro. It already exists. >> > >> > /** >> > * USB_DEVICE_AND_INTERFACE_INFO - describe a specific usb device with a >> > class of usb interfaces >> >> Yes, bu

Re: problem with Roseweil eusb3 enclosure

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 06:35:57AM -0400, cov...@ccs.covici.com wrote: > Sarah Sharp wrote: > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > Well, with that kernel, it didn't repeat the messages indefinitely, so I > could save them and I also have the messages fr

Re: Endpoint is not halted

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 10:45:56AM +0530, Chintan Mehta wrote: > Hi Sarah, > > Thanks for the patch, I will try this out and let you know the results. > > One thing I am curios about, will this same patch apply to windows > driver/Compliance Verification Suite as well? > > If this also applies t

Re: Endpoint is not halted

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 02:50:20PM +0800, Shimmer Huang wrote: > Sarah, > > We've found the TD_size issue when developing a new XHCI host controller also: > 1. need fix xhci_td_remainder() and xhci_v1_0_td_remainder() What needed to be fixed in xhci_td_remainder()? > 2. we need to use DIV_ROUND

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Paul Walmsley
On Fri, 26 Oct 2012, Benoit Cousson wrote: > On 10/26/2012 05:16 PM, Roger Quadros wrote: > > > I still can't get musb to work on 3.7-rc2. Apparently it is still > > missing the patches from Benoit's for_3.7/dts_part2. > > > > Maybe I just need to wait for it to be merged? > > They are now in a

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Benoit Cousson
Hi Paul, On 10/26/2012 07:54 PM, Paul Walmsley wrote: > On Fri, 26 Oct 2012, Benoit Cousson wrote: > >> On 10/26/2012 05:16 PM, Roger Quadros wrote: >> >>> I still can't get musb to work on 3.7-rc2. Apparently it is still >>> missing the patches from Benoit's for_3.7/dts_part2. >>> >>> Maybe I ju

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Benoit Cousson
On 10/26/2012 07:57 PM, Benoit Cousson wrote: > Hi Paul, > > On 10/26/2012 07:54 PM, Paul Walmsley wrote: >> On Fri, 26 Oct 2012, Benoit Cousson wrote: >> >>> On 10/26/2012 05:16 PM, Roger Quadros wrote: >>> I still can't get musb to work on 3.7-rc2. Apparently it is still missing the pa

Re: Hibernation with LPM, was: Re: xhci: LPM issues using Western Digital harddrive

2012-10-26 Thread Alan Stern
On Tue, 16 Oct 2012, Sarah Sharp wrote: > > > > In addition to this, I see that ehci-hcd includes some basic support > > > > for LPM but it doesn't implement the set_usb2_hw_lpm HCD method. It's > > > > a sort of do-it-yourself approach (and it includes a bunch of bugs). > > > > > > Yeah, I thin

Re: [PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-10-26 Thread Tony Lindgren
* Benoit Cousson [121026 11:11]: > On 10/26/2012 07:57 PM, Benoit Cousson wrote: > > Hi Paul, > > > > On 10/26/2012 07:54 PM, Paul Walmsley wrote: > >> On Fri, 26 Oct 2012, Benoit Cousson wrote: > >> > >>> On 10/26/2012 05:16 PM, Roger Quadros wrote: > >>> > I still can't get musb to work on

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-10-26 Thread Sarah Sharp
On Wed, Oct 24, 2012 at 08:26:21PM +0200, Matthias Schniedermeyer wrote: > I tried 3.7-rc2 (exactly, i think) > > This isn't the same computer, but the same('oldconfig'ed) > configuration. This computer has a NEC-chip for xhci. > > uname -a: > Linux exp 3.7.0-rc2 #1 SMP Wed Oct 24 19:45:48 CEST

Re: problem with Roseweil eusb3 enclosure

2012-10-26 Thread covici
Sarah Sharp wrote: > On Fri, Oct 26, 2012 at 06:35:57AM -0400, cov...@ccs.covici.com wrote: > > Sarah Sharp wrote: > > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > > Well, with that kernel, it didn't repeat the messages indefinitely, so I > > could save the

Re: problem with Roseweil eusb3 enclosure

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 04:06:01PM -0400, cov...@ccs.covici.com wrote: > Sarah Sharp wrote: > > > On Fri, Oct 26, 2012 at 06:35:57AM -0400, cov...@ccs.covici.com wrote: > > > Sarah Sharp wrote: > > > > git clone > > > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > > >

Re: problem with Roseweil eusb3 enclosure

2012-10-26 Thread covici
Sarah Sharp wrote: > On Fri, Oct 26, 2012 at 04:06:01PM -0400, cov...@ccs.covici.com wrote: > > Sarah Sharp wrote: > > > > > On Fri, Oct 26, 2012 at 06:35:57AM -0400, cov...@ccs.covici.com wrote: > > > > Sarah Sharp wrote: > > > > > git clone > > > > > git://git.kernel.org/pub/scm/linux/kerne

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 10:36:06PM +0200, Matthias Schniedermeyer wrote: > On 26.10.2012 12:27, Sarah Sharp wrote: > > On Wed, Oct 24, 2012 at 08:26:21PM +0200, Matthias Schniedermeyer wrote: > > > I tried 3.7-rc2 (exactly, i think) > > > > > > This isn't the same computer, but the same('oldconfig

kmemleak report on isp1763 and sierra MC8705

2012-10-26 Thread Richard Retanubun
Hi Guys, I am debugging a reported kmemleak involving a sierra wireless MC8705 connected through isp1763 on powerpc linux-3.0.22 We are still isolating the exact trigger, but this is a pretty good one so far send "at!reset" to the modem control tty, wait until it finishes rebooting then try to

RE: Hibernation with LPM, was: Re: xhci: LPM issues using Western Digital harddrive

2012-10-26 Thread Pan, Jacob jun
> -Original Message- > From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Friday, October 26, 2012 11:52 AM > To: Sarah Sharp > Cc: USB list; Du, Alek; Pan, Jacob jun > Subject: Re: Hibernation with LPM, was: Re: xhci: LPM issues using Western > Digital harddrive > > On Tue, 16

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-10-26 Thread Sarah Sharp
On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote: > The USB core isn't dropping the endpoints before it calls > xhci_check_bandwidth. I remember running into this bug a while back, > and I even started on a fix, but then couldn't reproduce the problem. > I found the branch with the old

dummy_hcd: try to add qh

2012-10-26 Thread Sebastian Andrzej Siewior
I tried to add the qh structure. It is likely that patch #1 isn't 100% checkpatch clear. If we agree on #3 then I go and clean it up. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

[RFC 1/3] usb/dummy_hcd: move code that handles an URB into a separate function

2012-10-26 Thread Sebastian Andrzej Siewior
The code here is moved out of the list for each into a separate function. There should be no functional change. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/dummy_hcd.c | 314 +--- 1 file changed, 162 insertions(+), 152 deletions(-) diff -

[RFC 3/3] usb/dummy_hcd: assign endpoint on enqeue on host side

2012-10-26 Thread Sebastian Andrzej Siewior
dummy_urb_enqueue() now assigns the endpoint to the qh structure. If the UDC disables the endpoint (on the device side) the endpoint information is removed from the qh as well. I think real HW would timeout on transfer (and return -EPROTO) so we do here the same except that we might do this early a

[RFC 2/3] usb/dummy_hcd: introduce per-ep qh data structure

2012-10-26 Thread Sebastian Andrzej Siewior
Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/dummy_hcd.c | 115 ++-- 1 file changed, 88 insertions(+), 27 deletions(-) diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c index ea702c6..2c27566 100644 --- a/drivers/

Re: kmemleak report on isp1763 and sierra MC8705

2012-10-26 Thread Greg KH
On Fri, Oct 26, 2012 at 05:57:23PM -0400, Richard Retanubun wrote: > Hi Guys, > > I am debugging a reported kmemleak involving a sierra wireless MC8705 > connected > through isp1763 on powerpc linux-3.0.22 Does this also happen on 3.6.3? thanks, greg k-h -- To unsubscribe from this list: send

Re: dummy_hcd: try to add qh

2012-10-26 Thread Alan Stern
On Sat, 27 Oct 2012, Sebastian Andrzej Siewior wrote: > I tried to add the qh structure. It is likely that patch #1 isn't 100% > checkpatch clear. If we agree on #3 then I go and clean it up. Sorry, I've forgotten the context for this change. (We discussed something and I suggested the right sol

Re: HDD spins up to slow for USB and/or Mass-Storage Driver

2012-10-26 Thread Alan Stern
On Fri, 26 Oct 2012, Sarah Sharp wrote: > On Fri, Oct 26, 2012 at 03:01:32PM -0700, Sarah Sharp wrote: > > The USB core isn't dropping the endpoints before it calls > > xhci_check_bandwidth. I remember running into this bug a while back, > > and I even started on a fix, but then couldn't reproduc