Re: [PATCH 1/6] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-10-01 Thread Felipe Balbi
Hi, On Fri, Sep 28, 2012 at 07:01:04PM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Fri, Sep 28, 2012 at 6:27 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Sep 28, 2012 at 06:23:10PM +0530, Kishon Vijay Abraham I wrote: > >> Used of_platform_populate() to populate dwc3 core platform_device

[PATCH] usb: otg: Resolving a config conflict between omap4030_usb/omap6030 and usb_musb_omap2plus

2012-10-01 Thread jrm . kurtz
From: Jerome Kurtz When I try to compile with TWL6030_USB=y, TWL4030_USB=y and USB_MUSB_OMAP2PLUS=m, I get the following error: drivers/built-in.o: In function `twl4030_usb_irq': /home/xxx/kernel/linux/drivers/usb/otg/twl4030-usb.c:518: undefined reference to `omap_musb_mailbox' drivers/built-in

Re: [PATCH] usb: otg: Resolving a config conflict between omap4030_usb/omap6030 and usb_musb_omap2plus

2012-10-01 Thread Peter Meerwald
Hello, > From: Jerome Kurtz > > When I try to compile with TWL6030_USB=y, TWL4030_USB=y and > USB_MUSB_OMAP2PLUS=m, I get the following error: there is an earlier patch here: https://patchwork.kernel.org/patch/1370291/ and an alternative fix here: https://patchwork.kernel.org/patch/1409671/

[PATCH v2 3/7] usb: dwc3-omap: use runtime API's to enable clocks

2012-10-01 Thread Kishon Vijay Abraham I
Before accessing any register, runtime API's should be invoked to enable the clocks. runtime API's are added here to prevent abort during register access. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/driv

[PATCH v2 2/7] usb: dwc3-omap: use of_platform API to create dwc3 core pdev

2012-10-01 Thread Kishon Vijay Abraham I
Used of_platform_populate() to populate dwc3 core platform_device from device tree data. Since now the allocation of unique device id is handled be of_*, removed the call to dwc3_get_device_id. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 52

[PATCH v2 5/7] usb: dwc3-omap: Add an API to write to dwc mailbox

2012-10-01 Thread Kishon Vijay Abraham I
Add an API in the omap glue layer to write to the mailbox register which can be used by comparator driver(twl). To pass the detection of the attached device (signified by VBUS, ID) to the dwc3 core, dwc3 core has to write to the mailbox regiter. Signed-off-by: Kishon Vijay Abraham I --- drivers/

[PATCH v2 7/7] usb: dwc3: core: add dt support for dwc3 core

2012-10-01 Thread Kishon Vijay Abraham I
Added dwc3 support for dwc3 core and update the documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/dwc3.txt | 23 +++ drivers/usb/dwc3/core.c| 14 -- 2 fil

[PATCH v2 6/7] usb: dwc3-omap: Minor fixes to get dt working

2012-10-01 Thread Kishon Vijay Abraham I
Includes few minor fixes in dwc3-omap like populating the compatible string in a correct way, extracting the utmi-mode property properly and changing the index of get_irq since irq of core is removed from hwmod entry. Also updated the documentation with dwc3-omap device tree binding information. S

[PATCH v2 0/7] usb: dwc3-omap: add dt support

2012-10-01 Thread Kishon Vijay Abraham I
This patch series adds dt support to dwc3 core and fixes few minor stuff in dwc3-omap glue to get dwc3 working. While at that it also uses *of_platform* to create the child device (dwc3-core) and fixes to use runtime API's to enable clock and write to SYSCONFIG register. Changes from v1: * made d

[PATCH v2 4/7] usb: dwc3-omap: Remove explicit writes to SYSCONFIG register

2012-10-01 Thread Kishon Vijay Abraham I
The runtime API's takes care of setting the SYSCONFIG register with appropriate values. Hence explicit writes to SYSCONFIG register is removed. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/

[PATCH v2 1/7] usb: dwc3-omap: use device_for_each_child to handle child removal

2012-10-01 Thread Kishon Vijay Abraham I
Used device_for_each_child() to handle child device (dwc3 core) removal during devexit of dwc3 omap. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/u

[PATCH 0/4] USB: Define and implement URB_ISO_ASAP

2012-10-01 Thread Alan Stern
Greg: The following series of patches documents a precise meaning for the URB_ISO_ASAP flag and implements the new definition in the ehci-hcd, uhci-hcd, and ohci-hcd drivers. Until now there has not been any clear-cut description of what the flag means, and different host controller drivers have

[PATCH 1/4] USB: update documentation for URB_ISO_ASAP

2012-10-01 Thread Alan Stern
This patch (as1611) updates the USB documentation and kerneldoc to give a more precise meaning for the URB_ISO_ASAP flag and to explain more of the details of scheduling for isochronous URBs. Signed-off-by: Alan Stern --- Documentation/usb/error-codes.txt |5 ++--- drivers/usb/core/urb.c

[PATCH 2/4] EHCI: implement new semantics for URB_ISO_ASAP

2012-10-01 Thread Alan Stern
This patch (as1612) updates the isochronous scheduling and processing in ehci-hcd to match the new semantics for URB_ISO_ASAP. It also adds a missing "unlikely" in sitd_complete() to match the corresponding statement in itd_complete(), and it increments urb->error_count in a couple of places that

[PATCH 3/4] UHCI: implement new semantics for URB_ISO_ASAP

2012-10-01 Thread Alan Stern
This patch (as1613) updates the isochronous scheduling in uhci-hcd to match the new semantics for URB_ISO_ASAP. The amount of code alteration is smaller than it looks because of a change in the indentation level. Signed-off-by: Alan Stern --- drivers/usb/host/uhci-q.c | 73 +

[PATCH 4/4] OHCI: implement new semantics for URB_ISO_ASAP

2012-10-01 Thread Alan Stern
This patch (as1614) updates the isochronous scheduling in ohci-hcd to match the new semantics for URB_ISO_ASAP. Testing revealed a hardware bug in the way my OHCI controller handles expired isochronous TDs; consequently the patch tries hard to avoid creating them (unlike the ehci-hcd and uhci-hcd

Re: Fresco USB 3.0 Issue

2012-10-01 Thread Sarah Sharp
What problem did you have? All you sent me was the lspci output. Sarah Sharp On Fri, Sep 28, 2012 at 02:01:17AM +0330, Ali Shahbazi wrote: > 00:00.0 0600: 8086:d132 (rev 11) > Subsystem: 1043:1c77 > Control: I/O- Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- > Stepping- SER

Re: xhci: LPM issues using Western Digital harddrive

2012-10-01 Thread Sarah Sharp
On Fri, Sep 28, 2012 at 10:08:07PM -0400, Alan Stern wrote: > On Fri, 28 Sep 2012, Sarah Sharp wrote: > > > > This shows that the problem began when the device was sent a command it > > > didn't recognize: 0xA1, which is a 12-byte ATA pass-through, in this > > > case for an IDENTIFY DEVICE command

[PATCH] usb hub: send clear_tt_buffer_complete events when canceling TT clear work

2012-10-01 Thread Octavian Purdila
There is a race condition in the USB hub code with regard to handling TT clear requests that can get the HCD driver in a deadlock. Usually when an TT clear request is scheduled it will be executed immediately: <7>[6.077583] usb 2-1.3: unlink qh1-0e01/f4d4db00 start 0 [1/2 us] <3>[6.078041]

PROBLEM: USB2 oopses with stable kernels

2012-10-01 Thread Tuomas Jorma Juhani Räsänen
An userspace program reading continuously an USB2 HID mouse's Interrupt IN endpoint causes stable kernels to oops. We have encountered this in several stable kernels, the oldest tested being 2.6.32 and the latest 3.5.4. We found this bug originally from systems with SMARTBoards (http://smarttech.c

Re: xhci: LPM issues using Western Digital harddrive

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Sarah Sharp wrote: > > > Maybe the link > > > becomes unstable when LPM is enabled, and that causes transfer issues on > > > the beginning of some transfers? > > > > Maybe so. It's odd that the problem seems to affect only control > > transfers. All the bulk transfers in t

Re: [PATCH] usb hub: send clear_tt_buffer_complete events when canceling TT clear work

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Octavian Purdila wrote: > There is a race condition in the USB hub code with regard to handling > TT clear requests that can get the HCD driver in a deadlock. Usually > when an TT clear request is scheduled it will be executed immediately: > However, if a suspend operation is

Re: PROBLEM: USB2 oopses with stable kernels

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Tuomas Jorma Juhani [iso-8859-1] R�s�nen wrote: > An userspace program reading continuously an USB2 HID mouse's Interrupt > IN endpoint causes stable kernels to oops. We have encountered this in > several stable kernels, the oldest tested being 2.6.32 and the latest > 3.5.4. >

Re: [PATCH] usb hub: send clear_tt_buffer_complete events when canceling TT clear work

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Alan Stern wrote: > On Mon, 1 Oct 2012, Octavian Purdila wrote: > > > There is a race condition in the USB hub code with regard to handling > > TT clear requests that can get the HCD driver in a deadlock. Usually > > when an TT clear request is scheduled it will be executed im

Re: [PATCH v2 6/7] usb: dwc3-omap: Minor fixes to get dt working

2012-10-01 Thread Sergei Shtylyov
Hello. On 01-10-2012 12:25, Kishon Vijay Abraham I wrote: Includes few minor fixes in dwc3-omap like populating the compatible string in a correct way, extracting the utmi-mode property properly and changing the index of get_irq since irq of core is removed from hwmod entry. Also updated the do

Re: [PATCH 4/4] OHCI: implement new semantics for URB_ISO_ASAP

2012-10-01 Thread Sergei Shtylyov
Hello. On 01-10-2012 16:32, Alan Stern wrote: This patch (as1614) updates the isochronous scheduling in ohci-hcd to match the new semantics for URB_ISO_ASAP. Testing revealed a hardware bug in the way my OHCI controller handles expired isochronous TDs; consequently the patch tries hard to avoi

Re: [PATCH] usb hub: send clear_tt_buffer_complete events when canceling TT clear work

2012-10-01 Thread Octavian Purdila
Hi Alan, On Mon, Oct 1, 2012 at 8:48 PM, Alan Stern wrote: > > On Mon, 1 Oct 2012, Alan Stern wrote: > > > On Mon, 1 Oct 2012, Octavian Purdila wrote: > > > > > There is a race condition in the USB hub code with regard to handling > > > TT clear requests that can get the HCD driver in a deadlock.

[GIT PATCH] USB patches for 3.7-rc1

2012-10-01 Thread Greg KH
The following changes since commit 5698bd757d55b1bb87edd1a9744ab09c142abfc2: Linux 3.6-rc6 (2012-09-16 14:58:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.6 for you to fetch changes up to 70c048a238c780c226eb4b115e

Re: [PATCH 4/4] OHCI: implement new semantics for URB_ISO_ASAP

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Sergei Shtylyov wrote: > > + if (unlikely(tick_before(frame, next))) { > > + > > + /* USB_ISO_ASAP: Round up to the first available slot */ > > + if (urb->transfer_flags& URB_ISO_ASAP) > > + frame += (next

[PATCH v2] usb hub: send clear_tt_buffer_complete events when canceling TT clear work

2012-10-01 Thread Octavian Purdila
There is a race condition in the USB hub code with regard to handling TT clear requests that can get the HCD driver in a deadlock. Usually when an TT clear request is scheduled it will be executed immediately: <7>[6.077583] usb 2-1.3: unlink qh1-0e01/f4d4db00 start 0 [1/2 us] <3>[6.078041]

Re: xhci: LPM issues using Western Digital harddrive

2012-10-01 Thread Sarah Sharp
On Mon, Oct 01, 2012 at 01:32:08PM -0400, Alan Stern wrote: > On Mon, 1 Oct 2012, Sarah Sharp wrote: > > Second, I'm wondering if LPM is interacting with system suspend and > > resume in a bad way. I noticed in my log with the USB 3.0 hub and hard > > drive that LPM was disabled for the hub before

Re: [PATCH v2] usb hub: send clear_tt_buffer_complete events when canceling TT clear work

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Octavian Purdila wrote: > There is a race condition in the USB hub code with regard to handling > TT clear requests that can get the HCD driver in a deadlock. Usually > when an TT clear request is scheduled it will be executed immediately: ... > This patch changes hub_quiesce

Re: xhci: LPM issues using Western Digital harddrive

2012-10-01 Thread Alan Stern
On Mon, 1 Oct 2012, Sarah Sharp wrote: > > I don't remember the details. Doesn't usb_unlocked_disable_lpm() force > > the device back into U0? You call that routine before suspending the > > port. > > It sends the control transfer to bring the port from U1/U2 into U0 and > disables any furthe

Re: xhci: LPM issues using Western Digital harddrive

2012-10-01 Thread Sarah Sharp
On Mon, Oct 01, 2012 at 03:53:03PM -0400, Alan Stern wrote: > On Mon, 1 Oct 2012, Sarah Sharp wrote: > > > > I don't remember the details. Doesn't usb_unlocked_disable_lpm() force > > > the device back into U0? You call that routine before suspending the > > > port. > > > > It sends the contr

[RFC 1/2] Convert ehci-hcd to a library

2012-10-01 Thread Alan Stern
Felipe: We've been talking about this for a long time. Here at last is an initial attempt at splitting ehci-hcd up into a library module and multiple platform driver modules. The first patch is just preparation. It moves a few items between .c and .h files, adds a generic ehci_hc_driver struct

[RFC 2/2] Convert ehci-pci to a separate module

2012-10-01 Thread Alan Stern
Felipe: This makes ehci-pci a separate module that depends on ehci-hcd. It's very straightforward; the only awkward thing is the way the driver entries have to be overridden by hand. I couldn't think of any better way of doing it. This is the penalty we pay for not using an object-oriented prog

Re: [PATCH 1/1] Adds support for Lenovo 10/100 USB dongle.

2012-10-01 Thread David Miller
From: Quinlan Pfiffer Date: Fri, 28 Sep 2012 22:58:44 -0700 > This dongle ships with the X1 Carbon, and has an AX88772B > usb to ethernet chip in it. > > Signed-off-by: Quinlan Pfiffer Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to

[PATCH 00/12] usbnet: usb_control_msg cleanup

2012-10-01 Thread Ming Lei
Hi, This patch set introduces 3 helpers for handling usb read, write and write_async command, and replaces the low level's implemention with the generic ones. Firstly, it is a cleanup and about 300 lines code can be saved. Secondly, the patch fixes DMA on the buffer which is embedded inside one

[PATCH 01/12] usbnet: introduce usbnet 3 command helpers

2012-10-01 Thread Ming Lei
This patch introduces the below 3 usb command helpers: usbnet_read_cmd / usbnet_write_cmd / usbnet_write_cmd_async so that each low level driver doesn't need to implement them by itself, and the dma buffer allocation for usb transfer and runtime PM things can be handled just in one place.

[PATCH 02/12] usbnet: asix: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/asix_common.c | 117 + 1 file changed, 13 insertions(+), 104 deletions(-) diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c index 774d9ce..50d1673 100644 --- a/drivers/net/usb/asix_comm

[PATCH 03/12] usbnet: cdc-ncm: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/cdc_ncm.c | 73 ++--- 1 file changed, 23 insertions(+), 50 deletions(-) diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 4cd582a..429a2ad 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/dr

[PATCH 04/12] usbnet: dm9601: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/dm9601.c | 107 +++--- 1 file changed, 15 insertions(+), 92 deletions(-) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index e0433ce..3f554c1 100644 --- a/drivers/net/usb/dm9601.c +++ b/drive

[PATCH 05/12] usbnet: int51x1: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/int51x1.c | 52 +++-- 1 file changed, 3 insertions(+), 49 deletions(-) diff --git a/drivers/net/usb/int51x1.c b/drivers/net/usb/int51x1.c index 8de6417..ace9e74 100644 --- a/drivers/net/usb/int51x1.c +++ b/dri

[PATCH 06/12] usbnet: mcs7830: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/mcs7830.c | 85 - 1 file changed, 6 insertions(+), 79 deletions(-) diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c index 03c2d8d..db46a68 100644 --- a/drivers/net/usb/mcs7830.c +++ b/dri

[PATCH 07/12] usbnet: net1080: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/net1080.c | 110 + 1 file changed, 30 insertions(+), 80 deletions(-) diff --git a/drivers/net/usb/net1080.c b/drivers/net/usb/net1080.c index c062a3e..93e0716 100644 --- a/drivers/net/usb/net1080.c +++ b/dr

[PATCH 08/12] usbnet: plusb: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/plusb.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/net/usb/plusb.c b/drivers/net/usb/plusb.c index 4584b9a..0fcc8e6 100644 --- a/drivers/net/usb/plusb.c +++ b/drivers/net/usb/plusb.c @@ -71,13 +71,10 @@ s

[PATCH 09/12] usbnet: sierra_net: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/sierra_net.c | 45 -- 1 file changed, 17 insertions(+), 28 deletions(-) diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index c27d277..eb5c7a8 100644 --- a/drivers/net/usb/sierra_net.c

[PATCH 10/12] usbnet: smsc75xx: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/smsc75xx.c | 39 ++- 1 file changed, 14 insertions(+), 25 deletions(-) diff --git a/drivers/net/usb/smsc75xx.c b/drivers/net/usb/smsc75xx.c index b77ae76..1baa53a 100644 --- a/drivers/net/usb/smsc75xx.c +++ b/driv

[PATCH 11/12] usbnet: smsc95xx: apply introduced usb command APIs

2012-10-01 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/net/usb/smsc95xx.c | 115 +++- 1 file changed, 27 insertions(+), 88 deletions(-) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index 7479a57..1730f75 100644 --- a/drivers/net/usb/smsc95xx.c +++ b

[PATCH 12/12] usbnet: make device out of suspend before calling usbnet_read/write_cmd

2012-10-01 Thread Ming Lei
This patche gets the runtime PM reference count before calling usb_control_msg, and puts it after completion of the usb_control_msg, so that the usb control message can always be sent to one active device. Signed-off-by: Ming Lei --- drivers/net/usb/usbnet.c |4 1 file changed, 4 insert