Re: [PATCH] USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq

2012-09-27 Thread Nicolas Ferre
On 09/25/2012 03:40 PM, Greg KH : > On Tue, Sep 25, 2012 at 11:48:43AM +0200, Nicolas Ferre wrote: >> On 09/24/2012 07:34 PM, Greg KH : >>> On Mon, Sep 24, 2012 at 09:44:31AM +0200, Nicolas Ferre wrote: > This patches fixed the issue by adding the gpio valid check. > > Signed-off-by: Jo

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
On Wed, Sep 26, 2012 at 8:16 PM, Adrian Sandu wrote: > 2012-09-26T20:13:09.700606+03:00 d3xt3r01 kernel: [ 2466.455403] usb > 3-1.1: reset SuperSpeed USB device number 14 using xhci_hcd > 2012-09-26T20:13:09.713629+03:00 d3xt3r01 kernel: [ 2466.468373] > xhci_hcd :04:00.0: xHCI xhci_drop_endpo

[PATCH v2 0/2] usb: phy: add usb3 phy driver

2012-09-27 Thread Kishon Vijay Abraham I
Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. Currently writing to control module register is taken care in this driver which will be removed once the control module driver is in place. Changes from v1: * Added missing clk_put() * Remove the p

[PATCH v2 2/2] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-27 Thread Kishon Vijay Abraham I
"usb_otg_ss_refclk960m" is needed for usb2 phy present in omap5. For omap4, the clk_get of this clock will fail since it does not have this clock. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/omap-usb2.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) di

[PATCH v2 1/2] usb: phy: add a new driver for usb3 phy

2012-09-27 Thread Kishon Vijay Abraham I
Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes device tree support for usb3 phy driver and the documentation with device tree binding information is updated. Currently writing to control module register is taken care in this

Re: [PATCH v2 1/2] usb: phy: add a new driver for usb3 phy

2012-09-27 Thread Russell King - ARM Linux
On Thu, Sep 27, 2012 at 07:34:07PM +0530, Kishon Vijay Abraham I wrote: > +static int omap5_usb_phy_power(struct omap_usb *phy, bool on) > +{ > + u32 val; > + unsigned long rate; > + struct clk *sys_clk; > + > + sys_clk = clk_get(NULL, "sys_clkin"); > + if (IS_ERR(sys_clk)) { >

Re: proposal for switching off stuff for external ports

2012-09-27 Thread Alan Stern
On Wed, 26 Sep 2012, Sarah Sharp wrote: > > Oliver was pointing out that if none of the attached devices are FS/LS > > then the companion controller and all its ports could be powered off. > > The EHCI driver knows when a new FS/LS device gets attached, so it > > could arrange for the companio

Re: [PATCH v2 2/2] USB: set hub's default autosuspend delay as 0

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Ming Lei wrote: > This patch sets hub device's default autosuspend delay as 0 to > speedup bus suspend, see comments in code for details. > > Cc: Alan Stern > Signed-off-by: Ming Lei Acked-by: Alan Stern > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread Rob Herring
On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: >> On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: >>> All phy related programming like enabling/disabling the clocks, powering >>> on/off the phy is taken care of by this driv

Re: [PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Ming Lei wrote: > From: Ming Lei > > The hub status endpoint has a long 'bInterval', which is 255ms > for FS/LS device and 256ms for HS device according to USB 2.0 spec, > so the device connection change may be reported later more than 255ms > via status pipe. > > The conne

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Alan Stern
Please trim unnecessary junk from your emails. There's no reason to send all the stuff at the end of those messages to everybody on the mailing list. On Thu, 27 Sep 2012, Adrian Sandu wrote: > Anything else I can help with ? :| I'm stuck .. dunno what to test > more or what else helpfull info

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
>> Anything else I can help with ? :| I'm stuck .. dunno what to test >> more or what else helpfull info I could give ya' guys .. > > You could run a test with a 3.3 kernel, as Sarah asked earlier. Other > than that, I can't think of anything. Maybe Sarah will come up with a > patch for you to tr

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Adrian Sandu wrote: > >> Anything else I can help with ? :| I'm stuck .. dunno what to test > >> more or what else helpfull info I could give ya' guys .. > > > > You could run a test with a 3.3 kernel, as Sarah asked earlier. Other > > than that, I can't think of anything. M

Re: [PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Ming Lei
On Thu, Sep 27, 2012 at 10:31 PM, Alan Stern wrote: > On Thu, 27 Sep 2012, Ming Lei wrote: > >> From: Ming Lei >> >> The hub status endpoint has a long 'bInterval', which is 255ms >> for FS/LS device and 256ms for HS device according to USB 2.0 spec, >> so the device connection change may be repo

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
>> I tried with a 3.3.8 , same thing happened. I don't understand why my >> gentoo (asrock) fails and fedora(laptop) didn't ! :| >> Why ? What causes it to shutdown ? It can copy to/from drives ( in the >> hub or directly in the root hub ) .. but what makes it fail sometimes >> :| > > If we knew th

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Sep 27, 2012 at 7:54 PM, Rob Herring wrote: > On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: >>> On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the c

Re: [PATCH v2 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Ming Lei wrote: > >> + pm_wakeup_event(&hdev->dev, 2000); > >> + return -EBUSY; > >> + } > >> + } > > > > The !PMSG_IS_AUTO case should not return -EBUSY, because > > usb_suspend_both() will ignore the return valu

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Adrian Sandu wrote: > >> I tried with a 3.3.8 , same thing happened. I don't understand why my > >> gentoo (asrock) fails and fedora(laptop) didn't ! :| > >> Why ? What causes it to shutdown ? It can copy to/from drives ( in the > >> hub or directly in the root hub ) .. but wh

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Adrian Sandu wrote: > I tried with a 3.3.8 , same thing happened. I don't understand why my > gentoo (asrock) fails and fedora(laptop) didn't ! :| Come to think of it, you could try running the same kernel on both computers to see what happens. For example, boot both of the

[PATCH v3 0/2] USB: USB: two changes on hub autosuspend

2012-09-27 Thread Ming Lei
There are two patches on usb hub autosuspend. Change log: V3: - don't stop suspend for !PMSG_IS_AUTO() case(1/2) - remove one unnecessary check on device_may_wakeup()(1/2) V2: - check on udev->do_remote_wakeup(1/2) - handle wakeup source for system sleep(1/2)

[PATCH v3 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Ming Lei
The hub status endpoint has a long 'bInterval', which is 255ms for FS/LS device and 256ms for HS device according to USB 2.0 spec, so the device connection change may be reported later more than 255ms via status pipe. The connection change in hub may have been happened already on the downstream po

[PATCH v3 2/2] USB: set hub's default autosuspend delay as 0

2012-09-27 Thread Ming Lei
This patch sets hub device's default autosuspend delay as 0 to speedup bus suspend, see comments in code for details. Acked-by: Alan Stern Signed-off-by: Ming Lei --- drivers/usb/core/hub.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/usb/co

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Peter Stuge
Adrian Sandu wrote: > I tried with a 3.3.8 , same thing happened. I don't understand why my > gentoo (asrock) fails and fedora(laptop) didn't ! :| Try what Alan suggested, start the Gentoo userland with the Fedora kernel. Do you have some crazy USE flags for your toolchain? If the Fedora kernel

Re: [PATCH] USB: ohci-at91: fix null pointer in ohci_hcd_at91_overcurrent_irq

2012-09-27 Thread Greg KH
On Thu, Sep 27, 2012 at 11:01:01AM +0200, Nicolas Ferre wrote: > On 09/25/2012 03:40 PM, Greg KH : > > On Tue, Sep 25, 2012 at 11:48:43AM +0200, Nicolas Ferre wrote: > >> On 09/24/2012 07:34 PM, Greg KH : > >>> On Mon, Sep 24, 2012 at 09:44:31AM +0200, Nicolas Ferre wrote: > > This patches fixe

[GIT PATCH] USB fixes for 3.6-rc7

2012-09-27 Thread Greg KH
The following changes since commit 5698bd757d55b1bb87edd1a9744ab09c142abfc2: Linux 3.6-rc6 (2012-09-16 14:58:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.6-rc7 for you to fetch changes up to 0d00dc2611abbe6ad244d5

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
> Adrian Sandu wrote: >> I tried with a 3.3.8 , same thing happened. I don't understand why my >> gentoo (asrock) fails and fedora(laptop) didn't ! :| > > Try what Alan suggested, start the Gentoo userland with the Fedora > kernel. I tried booting a Fedora-17-x86_64-Live-Desktop.iso .. same thing

Re: [PATCH usb:usb-next] USB: ezusb: make some vars/funcs static

2012-09-27 Thread Greg Kroah-Hartman
On Thu, Sep 27, 2012 at 02:24:13PM +0800, Fengguang Wu wrote: > Signed-off-by: Fengguang Wu > --- > drivers/usb/misc/ezusb.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next > head: 70c0

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
>> Adrian Sandu wrote: >>> I tried with a 3.3.8 , same thing happened. I don't understand why my >>> gentoo (asrock) fails and fedora(laptop) didn't ! :| Tried to use the live cd on my laptop, can't reproduce it in any way on my computer .. Using the same live cd I can reproduce the problem on the

Re: [PATCH 1/2] usb/xhci: release xhci->lock during turning on/off usb port's acpi power resource

2012-09-27 Thread Sarah Sharp
Hi Tianyu, These patches look fine to me. Since Greg reverted the sysfs interface patch, no one can trigger this deadlock yet, right? It's still important to fix it before the new interface goes in, but not really urgent. It's too close to the merge window to queue things right now, so I'll sen

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Adrian Sandu wrote: > >> Adrian Sandu wrote: > >>> I tried with a 3.3.8 , same thing happened. I don't understand why my > >>> gentoo (asrock) fails and fedora(laptop) didn't ! :| > > Tried to use the live cd on my laptop, can't reproduce it in any way > on my computer .. > U

Re: [PATCH v3 1/2] USB: check port changes before hub runtime suspend for some bug device

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Ming Lei wrote: > The hub status endpoint has a long 'bInterval', which is 255ms > for FS/LS device and 256ms for HS device according to USB 2.0 spec, > so the device connection change may be reported later more than 255ms > via status pipe. > > The connection change in hub m

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
> Since you are using the same live CD on both computers, this has to be > caused by a difference in the hardware. What do "lspci -vvv" and > "lspci -vvv -n" show on the two computers? http://d3xt3r01.tk/~dexter/usbmon/asrock_lspci http://d3xt3r01.tk/~dexter/usbmon/vaio_lspci -- To unsubscribe fr

Re: cannot submit urb 0, error -22: internal error followed by USB hung tasks

2012-09-27 Thread Lassi Väätämöinen
Alan Stern wrote: > On Tue, 18 Sep 2012, Gian-Carlo Pascutto wrote: > >> I'm connecting a Logitech H530 USB Audio headset and a Logitech C910 >> webcam to an Asrock K10N78M Pro with an NVIDIA Corporation MCP78S >> [GeForce 8200] chipset & ECHI controller. >> >> After being in a video conference

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Sarah Sharp
On Thu, Sep 27, 2012 at 10:02:22PM +0300, Adrian Sandu wrote: > > Since you are using the same live CD on both computers, this has to be > > caused by a difference in the hardware. What do "lspci -vvv" and > > "lspci -vvv -n" show on the two computers? > > http://d3xt3r01.tk/~dexter/usbmon/asrock

Re: xhci: LPM issues using Western Digital harddrive

2012-09-27 Thread Sarah Sharp
On Wed, Sep 26, 2012 at 02:03:06PM -0400, Don Zickus wrote: > Hi Sarah, > > As discussed privately, here is the debug output of what happens when I > plug in the hard drive into my panther point system. > > kernel based off of greg's usb-next (0220a3f01a) with CONFIG_USB_DEBUG and > CONFIG_USB_XH

Re: [PATCH 10/29] PCI, USB: remove find_bridge in acpi_bus_type

2012-09-27 Thread Yinghai Lu
On Tue, Sep 25, 2012 at 9:57 AM, Yinghai Lu wrote: > On Tue, Sep 25, 2012 at 1:35 AM, Lan Tianyu wrote: >> 2012/9/25 Yinghai Lu : >>> The struct member is not used anymore, remove it. >>> >>> Signed-off-by: Yinghai Lu >>> Cc: Greg Kroah-Hartman >>> Cc: linux-usb@vger.kernel.org >>> --- >>> dri

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
> They're the same chipset. There's minor differences in the PCI > capabilities, but not much else. It could be something electrically > wrong with the AsRock system, I suppose. That's possible if you see > the errors popping up erratically. > > Any chance you can exchange the AsRock system? No

Re: xhci: LPM issues using Western Digital harddrive

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Sarah Sharp wrote: > On Wed, Sep 26, 2012 at 02:03:06PM -0400, Don Zickus wrote: > > Hi Sarah, > > > > As discussed privately, here is the debug output of what happens when I > > plug in the hard drive into my panther point system. > > > > kernel based off of greg's usb-next

Re: cannot submit urb 0, error -22: internal error followed by USB hung tasks

2012-09-27 Thread Alan Stern
On Thu, 27 Sep 2012, Lassi Väätämöinen wrote: > If it is of any use, I have had similar kind of issue with M-Audio MobilePre > (Mk II) USB audio interface. First the sound gets very noticeable static > noise and soon after the playback just stops. After unplugging the device it > does not get r

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread Cousson, Benoit
On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Theodore Kilgore
Adrian, I think that the suggestion about checking the power supply, the cabling, the grounding screws, and anything of like nature that has been omitted from this list is a very good idea. If successful it would eliminate the problem for you, as well as resolving the mystery. Unresolved myst

Re: cannot submit urb 0, error -22: internal error followed by USB hung tasks

2012-09-27 Thread Lassi Väätämöinen
On Sep 28, 2012, at 00:18 , Alan Stern wrote: > The usbmon trace does not show any errors at all. The file doesn't > contain any occurrences of "-22", for instance. Ok. How can I tell when this error is visible in the logs? Status field is -22? > > To be most helpful, you should provide both

Re: [PATCH 10/29] PCI, USB: remove find_bridge in acpi_bus_type

2012-09-27 Thread Lan Tianyu
2012/9/28 Yinghai Lu : > On Tue, Sep 25, 2012 at 9:57 AM, Yinghai Lu wrote: >> On Tue, Sep 25, 2012 at 1:35 AM, Lan Tianyu wrote: >>> 2012/9/25 Yinghai Lu : The struct member is not used anymore, remove it. Signed-off-by: Yinghai Lu Cc: Greg Kroah-Hartman Cc: linux-usb@

Re: [usb-storage] Re: usb3 fails to write when using usb3 hub in usb3 port

2012-09-27 Thread Adrian Sandu
> > Adrian, > > I think that the suggestion about checking the power supply, the cabling, > the grounding screws, and anything of like nature that has been omitted > from this list is a very good idea. If successful it would eliminate > the problem for you, as well as resolving the mystery. Unresol