Re: usb-serial.c:1415 code aligned with following code on line 1416

2012-09-19 Thread Greg Kroah-Hartman
On Wed, Sep 19, 2012 at 08:57:00AM +0800, Fengguang Wu wrote: > Hi Greg, > > FYI, coccinelle warns about > > drivers/usb/serial/usb-serial.c:1415:3-51: code aligned with following code > on line 1416 > > vim +1415 drivers/usb/serial/usb-serial.c > > 1412/* we only set the res

Re: [PATCH v3] USB: mxs-phy: add basic otg support

2012-09-19 Thread Marc Kleine-Budde
On 09/19/2012 03:11 AM, Richard Zhao wrote: > On Mon, Sep 17, 2012 at 01:06:21PM +0300, Alexander Shishkin wrote: >> Richard Zhao writes: >> >>> Signed-off-by: Richard Zhao >>> Acked-by: Felipe Balbi >> >> Felipe said, >> >>> if you add a commit log you can add my: >>> >>> Acked-by: Felipe Balb

Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote: > On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote: > > Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, > > are not correctly accessed on Tegra3 platform. > > > > Signed-off-by: Jim Lin > > --- > > Changes in v2: > > - Modify a

RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
>-Original Message- >From: Greg KH [mailto:gre...@linuxfoundation.org] >Sent: Wednesday, September 19, 2012 2:29 PM >To: Jim Lin >Cc: swar...@wwwdotorg.org; linux-usb@vger.kernel.org; >linux-ker...@vger.kernel.org >Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definitio

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Jiri Slaby
On 09/19/2012 04:36 AM, Kevin Daughtridge wrote: > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -775,12 +775,14 @@ int hid_open_report(struct hid_device *d > return -ENODEV; > size = device->dev_rsize; > > +start = kmemdup(start, size, GFP_KERNEL); > +if

Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Greg KH
On Wed, Sep 19, 2012 at 03:53:42PM +0800, Jim Lin wrote: > On Wed, 2012-09-19 at 14:29 +0800, Greg KH wrote: > > On Wed, Sep 19, 2012 at 11:48:50AM +0800, Jim Lin wrote: > > > Fix the issue that EHCI registers, hostpc[0] and usbmode_ex, > > > are not correctly accessed on Tegra3 platform. > > > >

RE: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definition

2012-09-19 Thread Jim Lin
>-Original Message- >From: Greg KH [mailto:gre...@linuxfoundation.org] >Sent: Wednesday, September 19, 2012 4:04 PM >To: Jim Lin >Cc: swar...@wwwdotorg.org; linux-usb@vger.kernel.org; >linux-ker...@vger.kernel.org >Subject: Re: [PATCH v2 1/1] USB: EHCI: Tegra: Fix wrong register definitio

Re: [RFC PATCH v1 1/3] usbnet: introduce usbnet_link_change API

2012-09-19 Thread Oliver Neukum
On Tuesday 18 September 2012 22:23:19 Ming Lei wrote: > This patch introduces the API of usbnet_link_change, so that > usbnet can trace the link change, which may help to implement > the later runtime PM triggered by usb ethernet link change. > > Signed-off-by: Ming Lei Acked-by: Oliver Neukum

Re: [RFC PATCH v1 2/3] usbnet: apply usbnet_link_change

2012-09-19 Thread Oliver Neukum
On Tuesday 18 September 2012 22:23:20 Ming Lei wrote: > This patch applies the introduce usbnet_link_change API. > > Signed-off-by: Ming Lei Acked-by: Oliver Neukum Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a m

[PATCH] fsl/usb: Add support for USB controller version 2.4

2012-09-19 Thread Ramneek Mehresh
Add support for USB controller version 2.4 Signed-off-by: Ramneek Mehresh --- Applies on git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git (branch usb-next) drivers/usb/host/fsl-mph-dr-of.c |2 ++ include/linux/fsl_devices.h |1 + 2 files changed, 3 insertions(+), 0 dele

Re: [PATCH] fsl/usb: Add support for USB controller version 2.4

2012-09-19 Thread Greg KH
On Wed, Sep 19, 2012 at 02:18:45PM +0530, Ramneek Mehresh wrote: > Add support for USB controller version 2.4 > > Signed-off-by: Ramneek Mehresh > --- > Applies on git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > (branch usb-next) > > drivers/usb/host/fsl-mph-dr-of.c |2 ++ >

[PATCH v3 3/3] ARM: dts: omap: Add usb_otg and glue data

2012-09-19 Thread Kishon Vijay Abraham I
Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. The dt data specifies among others the interface type (ULPI or UTMI), mode which is mostly OTG, power that specifies the amount of power this can supply when in host mode. Ac

[PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2012-09-19 Thread Kishon Vijay Abraham I
This patch series adds dt data to get MUSB working in omap4 and omap3 Changes from v2: * Changes the subject of all the patches to include "ARM: dts:" * Added reg property and interrupt property for "usb_otg_hs". Previously these were obtained from ti,hwmods property. * Rebased on git://git.ke

[PATCH v3 2/3] ARM: dts: Add twl4030-usb data

2012-09-19 Thread Kishon Vijay Abraham I
Add twl4030-usb data node in twl4030 device tree file. twl4030-usb is the phy driver for MUSB used in omap3 chipsets. The dt data is comprised of two interrupts, one for ID and one for VBUS and three phandles to regulator. Acked-by: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I --- arch/ar

[PATCH v3 1/3] ARM: dts: Add twl6030-usb data

2012-09-19 Thread Kishon Vijay Abraham I
Add twl6030-usb data node in twl6030 device tree file. twl6030-usb is the comparator driver for USB that detects VBUS and ID events. The dt data is comprised of two interrupts, one for ID and one for VBUS and a phandle to the regulator. Acked-by: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I

RE: [PATCH] fsl/usb: Add support for USB controller version 2.4

2012-09-19 Thread Mehresh Ramneek-B31383
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Wednesday, September 19, 2012 2:27 PM > To: Mehresh Ramneek-B31383 > Cc: linux-usb@vger.kernel.org > Subject: Re: [PATCH] fsl/usb: Add support for USB controller version 2.4 > > On Wed, Sep 19, 2012 at 02:18:45PM +0530,

[PATCH] Documentation: dt: bindings: Add missing information to omap-usb.txt

2012-09-19 Thread Kishon Vijay Abraham I
*reg* property and *interrupt* property for "usb_otg_hs" were previously obtained from ti,hwmods property. But these are now explicitly added to the dt node. So updated the documentation with these information. Signed-off-by: Kishon Vijay Abraham I --- *[PATCH v3 3/3] ARM: dts: omap: Add usb_otg

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-19 Thread Andrzej Pietrasiewicz
On Tuesday, September 18, 2012 6:10 PM Alan Stern wrote: > > > > > $ mkdir /cfg/usb-function-gadget/ufg/config1/function1/\ > > > f_mass_storage > > Speaking of no purpose, what is the reason > for .../function1/f_mass_storage ? Is there anything besides name and > f_mass_storage under functi

Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation

2012-09-19 Thread Samuel Ortiz
Hi Keshava, On Mon, Jul 16, 2012 at 07:01:06PM +0530, Keshava Munegowda wrote: > The TLL (Transceiver Less Link) is an separate IP block, independent of > the host controller. Basically this TLL operates like USB PHY which allows > the user to connect two USB transceiver interfaces together direct

[PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Kishon Vijay Abraham I
From: Moiz Sonasath For the gadget pullup functionality to work in SS mode it requires a particular sequence of toggling the run-stop bit. Here is the required sequence: - Set DCTL[31] - Clear DCTL[31] - Clear OMAP5430_CONTROL_CORE__PHY_POWER_USB[14] - Clear DCTL[8:5] = 0x00 - Set DCTL[8:5] = 0x

[PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-19 Thread Kishon Vijay Abraham I
"usb_otg_ss_refclk960m" is needed by usb2 phy present in omap5. For omap4, the clk_get of this clock will fail since it does not have this clock. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/usb-phy.txt |3 +++ drivers/usb/phy/omap-usb2.c

[PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-09-19 Thread Kishon Vijay Abraham I
Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes device tree support for usb3 phy driver and the documentation with device tree binding information is updated. Currently writing to control module register is taken care in this

[PATCH 0/4] usb: phy: add usb3 phy driver

2012-09-19 Thread Kishon Vijay Abraham I
Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. Currently writing to control module register is taken care in this driver which will be removed once the control module driver is in place. Also included the patch from Moiz to fix gadget pullup in

[PATCH 3/4] usb: phy: omap-usb3: Decrease the number of transitions to recovery

2012-09-19 Thread Kishon Vijay Abraham I
Power-cycling the PHY (partially) decreases the number of transitions to "Recovery" state. Hence changed the power up sequence to a partial power-up before a full power-up of the PHY. Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Moiz Sonasath --- drivers/usb/phy/omap-usb3.c | 43

[PATCH v2] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

2012-09-19 Thread navin patidar
From: navin In response to "usbip detach -p [port_number]" user command,vhci_shutdown_connection() gets executed which kills tcp_tx,tcp_rx kernel threads but doesn't set thread pointers to NULL. so, at the time of vhci_hcd removal vhci_shutdown_connection() again tries to kill kernel threads w

[PATCH v2] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-19 Thread navin patidar
From: navin stub_shutdown_connection() should set kernel thread pointers to NULL after killing them. so that at the time of usbip_host removal stub_shutdown_connection() doesn't try to kill kernel threads which are already killed. [ 1504.312158] BUG: unable to handle kernel NULL pointer derefe

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Sergei Shtylyov
Hello. On 19-09-2012 6:36, Kevin Daughtridge wrote: The dev_rdesc member of the hid_device structure is meant to store the original report descriptor received from the device, but it is currently passed to any report_fixup method before it is copied to the rdesc member. This patch moves the kme

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Jiri Kosina
On Tue, 18 Sep 2012, Kevin Daughtridge wrote: > The dev_rdesc member of the hid_device structure is meant to store the > original > report descriptor received from the device, but it is currently passed to any > report_fixup method before it is copied to the rdesc member. This patch moves > the km

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
Hi, On Wed, Sep 19, 2012 at 05:00:27PM +0530, Kishon Vijay Abraham I wrote: > From: Moiz Sonasath > > For the gadget pullup functionality to work in > SS mode it requires a particular sequence of > toggling the run-stop bit. Here is the required > sequence: > > - Set DCTL[31] > - Clear DCTL[31]

Re: [PATCH v2] staging: usbip: vhci_hcd: Fixed oops during removal of vhci_hcd

2012-09-19 Thread Dan Carpenter
Acked-by: Dan Carpenter regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] usb: phy: omap-usb3: Decrease the number of transitions to recovery

2012-09-19 Thread Felipe Balbi
On Wed, Sep 19, 2012 at 05:00:28PM +0530, Kishon Vijay Abraham I wrote: > Power-cycling the PHY (partially) decreases the number of transitions to > "Recovery" state. Hence changed the power up sequence to a partial > power-up before a full power-up of the PHY. > > Signed-off-by: Kishon Vijay Abra

Re: [PATCH v2] staging: usbip: stub_dev: Fixed oops during removal of usbip_host

2012-09-19 Thread Dan Carpenter
Acked-by: Dan Carpenter regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-19 Thread Felipe Balbi
On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: > "usb_otg_ss_refclk960m" is needed by usb2 phy present in omap5. For > omap4, the clk_get of this clock will fail since it does not have this > clock. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetr

Re: [PATCH v2 RESEND] USB: chipidea: convert to use devm_request_irq

2012-09-19 Thread Felipe Balbi
On Wed, Sep 19, 2012 at 09:32:49AM +0800, Richard Zhao wrote: > On Wed, Sep 19, 2012 at 03:30:41AM +0200, Marek Vasut wrote: > > Dear Richard Zhao, > > > > You know, commit message would be nice to have. > Yes, but for this one, the title shows obviously what it changed, > doesn't it? Alex has th

Re: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-19 Thread Felipe Balbi
On Tue, Sep 18, 2012 at 04:53:13PM +0200, Andrzej Pietrasiewicz wrote: > Hello Sebastian, > > On September 17, 2012 6:23 PM Sebastian Andrzej Siewior wrote: > > > > > > > Not looking at code. Can you give a few bash lines which setup the > > gadget? Please make it work with mass storage (which

[PATCH 3/5] uas: remove aborted field, replace with status bit.

2012-09-19 Thread Gerd Hoffmann
--- drivers/usb/storage/uas.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 1d326c5..42976ec 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -64,13 +64,13 @@ enum { D

[PATCH 1/5] uas: keep track of command urbs

2012-09-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index 638cd64..ab66365 100644 --- a/drivers/usb/storage/uas.c +++ b/drivers/usb/storage/uas.c @@ -41

[PATCH 2/5] uas: fix task management

2012-09-19 Thread Gerd Hoffmann
Allocate one tag for task management functions and use it properly. Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index ab66365..1d326c5 100644 --- a/d

[PATCH 0/5] uas: a bunch of bugfixes.

2012-09-19 Thread Gerd Hoffmann
Hi, Bugfix series for uas. First fixing a bunch of little issues in the scsi error handling. Then I finally figured the reason we end up in the scsi error handles in the first place is data corruption due to lack of locking. /me wonders why I didn't notice earlier, seems my kernel coding skil

[PATCH 5/5] uas: add locking

2012-09-19 Thread Gerd Hoffmann
Add spinlock to protect uas data structures. Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 45 + 1 files changed, 41 insertions(+), 4 deletions(-) diff --git a/drivers/usb/storage/uas.c b/drivers/usb/storage/uas.c index df1d72e..cb5c9

[PATCH 4/5] uas: fix abort

2012-09-19 Thread Gerd Hoffmann
Properly report aborted commands. Also don't access cmdinfo after kicking task management, it may not be valid any more once it returns. Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/usb/stora

Re: [PATCH 5/5] uas: add locking

2012-09-19 Thread Oliver Neukum
On Wednesday 19 September 2012 14:40:12 Gerd Hoffmann wrote: > @@ -101,7 +103,10 @@ static void uas_do_work(struct work_struct *work) > struct scsi_pointer *scp = (void *)cmdinfo; > struct scsi_cmnd *cmnd = container_of(scp, >

Re: BEEMO(OPTION) alias PANTECH P4200 LTE-Modem

2012-09-19 Thread Thomas Schäfer
I collected some additional information about this device. The windows-view: http://www.cis.uni-muenchen.de/~thomas/pantech-p4200-usb.png and the usbsnoop-logfile: http://www.cis.uni-muenchen.de/~thomas/pantech-p4200-usbsnoop.log.bz2 Has anybody suggestions, what could I do next? Regards, Thoma

RE: [PATCH 2/3] usb: gadget: Add USB functions gadget

2012-09-19 Thread Alan Stern
On Wed, 19 Sep 2012, Andrzej Pietrasiewicz wrote: > I am wondering, if it is possible to use the same function more than > once in a given configuration? That is, if it is possible to have > > /cfg/usb-function-gadget/ufg/config1/function1/f_mass_storage > > and > > /cfg/usb-function-gadget/ufg

[PATCH] sierra_ms: don't keep unused variable

2012-09-19 Thread Alan Cox
From: Alan Cox We need to call scsi_get_host_dev(sh) but we never use the return nor do we have any reason to check it. Signed-off-by: Alan Cox --- drivers/usb/storage/sierra_ms.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/storage/sierra_ms.c b/driver

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-09-19 Thread Marc Kleine-Budde
On 09/19/2012 01:30 PM, Kishon Vijay Abraham I wrote: > Added a driver for usb3 phy that handles the interaction between usb phy > device and dwc3 controller. > > This also includes device tree support for usb3 phy driver and > the documentation with device tree binding information is updated. >

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-19 Thread Marc Kleine-Budde
On 09/19/2012 01:56 PM, Felipe Balbi wrote: > On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: >> "usb_otg_ss_refclk960m" is needed by usb2 phy present in omap5. For >> omap4, the clk_get of this clock will fail since it does not have this >> clock. >> >> Signed-off-by: Kisho

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-19 Thread Felipe Balbi
On Wed, Sep 19, 2012 at 04:45:01PM +0200, Marc Kleine-Budde wrote: > On 09/19/2012 01:56 PM, Felipe Balbi wrote: > > On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: > >> "usb_otg_ss_refclk960m" is needed by usb2 phy present in omap5. For > >> omap4, the clk_get of this clock

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-19 Thread Marc Kleine-Budde
On 09/19/2012 04:42 PM, Felipe Balbi wrote: > On Wed, Sep 19, 2012 at 04:45:01PM +0200, Marc Kleine-Budde wrote: >> On 09/19/2012 01:56 PM, Felipe Balbi wrote: >>> On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: "usb_otg_ss_refclk960m" is needed by usb2 phy present in o

Re: [RFC] Documentation update for Isochronous URB handling

2012-09-19 Thread Laurent Pinchart
On Friday 14 September 2012 09:52:47 Alan Stern wrote: > On Fri, 14 Sep 2012, Pratyush Anand wrote: > > > Pratyush, since you have been busily working on related issues for the > > > dwc3, you might be interested in this too. > > > > Thanks for including me in CC. Whatever knowledge I have for the

[PATCH] usb: otg: Resolving a config conflict between omap4030_usb/omap6030 and usb_musb_omap2plus

2012-09-19 Thread jrm . kurtz
From: Jerome Kurtz When I try to compile with TWL6030_USB=y, TWL4030_USB=y and USB_MUSB_OMAP2PLUS=m, I get the following error: drivers/built-in.o: In function `twl4030_usb_irq': /home/xxx/kernel/linux/drivers/usb/otg/twl4030-usb.c:518: undefined reference to `omap_musb_mailbox' drivers/built-in

[PATCH v2 5/5] uas: add locking

2012-09-19 Thread Gerd Hoffmann
Add spinlock to protect uas data structures. [ v2: s/GFP_NOIO/GFP_ATOMIC/, better don't sleep when holding a spinlock ] Signed-off-by: Gerd Hoffmann --- drivers/usb/storage/uas.c | 51 ++-- 1 files changed, 44 insertions(+), 7 deletions(-) diff --git a

Re: AW: USB problem on beagleboard clone

2012-09-19 Thread Paul Walmsley
On Wed, 19 Sep 2012, Maximilian Schwerin wrote: > They're BeagleBoard XM clones. We're still trying to find out what the > real problem is. The problem persists across three separate layouts > using the same USB device and application. We're currently trying to see > if this is related to MUSB

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
Hi, On Wed, Sep 19, 2012 at 10:02:48AM -0500, Sonasath, Moiz wrote: > Felipe, > > On Wed, Sep 19, 2012 at 6:53 AM, Felipe Balbi wrote: > > > Hi, > > > > On Wed, Sep 19, 2012 at 05:00:27PM +0530, Kishon Vijay Abraham I wrote: > > > From: Moiz Sonasath > > > > > > For the gadget pullup functiona

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Kevin Daughtridge
On 09/19/12 01:05 N.U., Jiri Slaby wrote: AFAICS this is incorrect. Some drivers return pointers to their own static structure from their .report_fixup. Hence there are two problems: * leak, because kmemdup'ped start is never freed * invalid free -- kfree(device->rdesc) will try to free a static

Re: USB: EHCI: Many "Waited too long for the async..."

2012-09-19 Thread Alan Stern
On Tue, 18 Sep 2012, Thomas Voegtle wrote: > On Tue, 18 Sep 2012, Alan Stern wrote: > > On Tue, 18 Sep 2012, Thomas Voegtle wrote: > > > >> Hello, > >> > >> With 3.6.0-rc6 I see a lot of these lines: > >> [ 216.240493] ehci_hcd :00:10.4: Waited too long for the async > >> schedule status, giv

[PATCH] USB: remove dbg() usage in USB networking drivers

2012-09-19 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman The dbg() USB macro is so old, it predates me. The USB networking drivers are the last hold-out using this macro, and we want to get rid of it, so replace the usage of it with the proper netdev_dbg() or dev_dbg() (depending on the context) calls. Signed-off-by: Greg Kro

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
On Wed, Sep 19, 2012 at 11:50:53AM -0500, Sonasath, Moiz wrote: > Felipe, > > On Wed, Sep 19, 2012 at 11:04 AM, Felipe Balbi wrote: > > > Hi, > > > > On Wed, Sep 19, 2012 at 10:02:48AM -0500, Sonasath, Moiz wrote: > > > Felipe, > > > > > > On Wed, Sep 19, 2012 at 6:53 AM, Felipe Balbi wrote: >

Re: [PATCH 2/4] usb: dwc3: Fix gadget pullup in SS mode

2012-09-19 Thread Felipe Balbi
Hi again, On Wed, Sep 19, 2012 at 08:24:44PM +0300, Felipe Balbi wrote: > > > at minimum this should've come with a proper revision check anyway. > > > > > > > Actually most of it is under a rev check :) > > fair enough. one extra comment here. That revision check is not related to the silicon

Re: XHCI: URB not cancelled during disconnect of a MSC device

2012-09-19 Thread Sarah Sharp
Ajay, which host controller are you seeing the disconnect lags on? Can you send me the output of `sudo lspci -vvv -n`? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH] USB: remove dbg() usage in USB networking drivers

2012-09-19 Thread Joe Perches
On Wed, 2012-09-19 at 18:13 +0100, Greg Kroah-Hartman wrote: > The dbg() USB macro is so old, it predates me. The USB networking drivers are > the last hold-out using this macro, and we want to get rid of it, so replace > the usage of it with the proper netdev_dbg() or dev_dbg() (depending on the

Re: [RFC] How to handle delays in isochronous transfers?

2012-09-19 Thread Laurent Pinchart
Hi Alan, On Thursday 13 September 2012 12:08:35 Alan Stern wrote: > On Thu, 13 Sep 2012, Laurent Pinchart wrote: > > Hi Alan, > > > > Sorry for the late answer, I've been travelling with no internet > > connection. > > No problem; thanks for joining the discussion. > > > For video ISO IN problem

Re: USB: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc

2012-09-19 Thread Rene Buergel
> I get the following build errors with > this patch applied: > > ERROR: "ezusb_fx1_ihex_firmware_download" > [drivers/usb/serial/whiteheat.ko] undefined! > ERROR: "ezusb_fx1_ihex_firmware_download" > [drivers/usb/serial/keyspan_pda.ko] undefined! > ERROR: "ezusb_fx1_set_reset" [drivers/usb/serial

Re: USB: EHCI: Many "Waited too long for the async..."

2012-09-19 Thread Thomas Voegtle
On Wed, 19 Sep 2012, Alan Stern wrote: ... What's wrong with my setup? Maybe my .config might be a little bit strange, I use this machine mainly for testing (and streaming DVB-C) Probably nothing is wrong with your setup; most likely the problem is in your EHCI hardware. What does "lspci -v"

Re: BEEMO(OPTION) alias PANTECH P4200 LTE-Modem

2012-09-19 Thread Bjørn Mork
Thomas Schäfer writes: > I collected some additional information about this device. > > The windows-view: > http://www.cis.uni-muenchen.de/~thomas/pantech-p4200-usb.png > > and the usbsnoop-logfile: > http://www.cis.uni-muenchen.de/~thomas/pantech-p4200-usbsnoop.log.bz2 > > Has anybody suggestion

Re: [PATCH v2] HID: leave dev_rdesc unmodified and use it for comparisons

2012-09-19 Thread Henrik Rydberg
Hi Kevin, Thanks for looking to this. > Hmm. I hadn't noticed that the other drivers are returning a static > structure. In that case, it seems that report_fixup itself is broken > from a memory perspective, in that it returns pointers to > inconsistent storage types depending on the driver. The

Re: cannot submit urb 0, error -22: internal error followed by USB hung tasks

2012-09-19 Thread Alan Stern
On Tue, 18 Sep 2012, Gian-Carlo Pascutto wrote: > I'm connecting a Logitech H530 USB Audio headset and a Logitech C910 > webcam to an Asrock K10N78M Pro with an NVIDIA Corporation MCP78S > [GeForce 8200] chipset & ECHI controller. > > After being in a video conference for a while with Vidyo or Sk

Re: BEEMO(OPTION) alias PANTECH P4200 LTE-Modem

2012-09-19 Thread Bjørn Mork
Thomas Schäfer writes: > I collected some additional information about this device. > > The windows-view: > http://www.cis.uni-muenchen.de/~thomas/pantech-p4200-usb.png BTW, do you happen to have a Windows *.inf file for that device? It does use the same class/subclass/protocol as one of the cur

Re: BEEMO(OPTION) alias PANTECH P4200 LTE-Modem

2012-09-19 Thread Thomas Schäfer
Am Mittwoch, 19. September 2012 um 20:45:26 schrieb Bjørn Mork: > > Has anybody suggestions, what could I do next? > > I am wondering exactly how qmi_wwan does "not work"... I should test more than three times. More checking, use more test-kernels, check if modemmanger is disturbing, or other

Re: [PATCH] USB: remove dbg() usage in USB networking drivers

2012-09-19 Thread Greg Kroah-Hartman
On Wed, Sep 19, 2012 at 10:53:32AM -0700, Joe Perches wrote: > On Wed, 2012-09-19 at 18:13 +0100, Greg Kroah-Hartman wrote: > > The dbg() USB macro is so old, it predates me. The USB networking drivers > > are > > the last hold-out using this macro, and we want to get rid of it, so replace > > th

Re: [RFC] How to handle delays in isochronous transfers?

2012-09-19 Thread Alan Stern
On Wed, 19 Sep 2012, Laurent Pinchart wrote: > To be honest I thought the ASAP flag did what it now does with your patch :-) > The uvcvideo driver doesn't care much about when URBs will be transferred, I > just set the frame number to 0 and set the ASAP flag. > > If the number of lost packets i

[PATCH v2] USB: remove dbg() usage in USB networking drivers

2012-09-19 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman The dbg() USB macro is so old, it predates me. The USB networking drivers are the last hold-out using this macro, and we want to get rid of it, so replace the usage of it with the proper netdev_dbg() or dev_dbg() (depending on the context) calls. Some places we end up u

Re: [PATCH 0/4] Add PHY nofity for some i.mx SoCs

2012-09-19 Thread Mike Thompson
Tested on OLinuXino-Micro imx233 based hardware with patches applied against 'linux-next' branch. Tested-by: Mike Thompson Mike Thompson On Thu, Sep 13, 2012 at 8:18 PM, Peter Chen wrote: > At some i.mx SoCs, when controller works at host mode, the PHY > register needs to be changed at device

[PATCH] USB: qcaux: add Pantech vendor class match

2012-09-19 Thread Bjørn Mork
The three Pantech devices UML190 (106c:3716), UML290 (106c:3718) and P4200 (106c:3721) all use the same subclasses to identify vendor specific functions. Replace the existing device specific entries with generic vendor matching, adding support for the P4200. Cc: Cc: Thomas Schäfer Cc: Dan Willi

[PATCH] USB: option: blacklist QMI interface on ZTE MF683

2012-09-19 Thread Bjørn Mork
Interface #5 on ZTE MF683 is a QMI/wwan interface. Cc: Cc: Shawn J. Goff Signed-off-by: Bjørn Mork --- drivers/usb/serial/option.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 5ce88d1..5f30800 100644 --

[PATCH] net: qmi_wwan: adding Huawei E367, ZTE MF683 and Pantech P4200

2012-09-19 Thread Bjørn Mork
One of the modes of Huawei E367 has this QMI/wwan interface: I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=07 Driver=(none) E: Ad=83(I) Atr=03(Int.) MxPS= 64 Ivl=2ms E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=4ms Huawei use subclass and protoco

Re: USB: ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc

2012-09-19 Thread Greg KH
On Wed, Sep 19, 2012 at 08:23:07PM +0200, Rene Buergel wrote: > > I get the following build errors with > > this patch applied: > > > > ERROR: "ezusb_fx1_ihex_firmware_download" > > [drivers/usb/serial/whiteheat.ko] undefined! > > ERROR: "ezusb_fx1_ihex_firmware_download" > > [drivers/usb/serial/k

Re: [PATCH 7/8] usb/gadget: fix error path in uvc_function_bind()

2012-09-19 Thread Laurent Pinchart
Hi Sebastian, Thanks for the patch. On Sunday 16 September 2012 21:58:42 Sebastian Andrzej Siewior wrote: > The "video->minor = -1" assigment is done in V4L2 by > video_register_device() so it is removed here. > Now. uvc_function_bind() calls in error case uvc_function_unbind() for > cleanup. The

Re: [PATCH V4 1/5] ARM: OMAP: Add the USB TLL clocks device name

2012-09-19 Thread Paul Walmsley
On Mon, 16 Jul 2012, Keshava Munegowda wrote: > The platform device name "usbhs_tll" is added for the functional, > interface and channel clocks of the TLL module. > > Signed-off-by: Keshava Munegowda > Reviewed-by: Partha Basak Thanks, queued this patch for 3.7. - Paul -- To unsubscribe from

Re: [PATCH V4 5/5] ARM: OMAP: Remove older device name of the USB TLL clocks

2012-09-19 Thread Paul Walmsley
Hi On Mon, 16 Jul 2012, Keshava Munegowda wrote: > The usbhs device name of the functional, interface and > channel clocks of the TLL module is removed. > > Signed-off-by: Keshava Munegowda > Reviewed-by: Partha Basak Please re-send this one separately once patches 2-4 of this series have be

Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation

2012-09-19 Thread Paul Walmsley
Hi Samuel, I've queued patch 1 of this series for 3.7, which should go upstream via the OMAP -> arm-soc path. Also asked Keshava to re-send patch 5 to me once patches 2-4 have been merged. It's up to you how to handle patches 2-4. The series is a good step forward for us in terms of cleanup

[PATCH] USB: EHCI: remove useless test

2012-09-19 Thread Alan Stern
This patch (as1605) removes a useless test from the EHCI debugfs code. There's no point checking whether p.qh is non-NULL; we already know it is and in any case it gets dereferenced aerlier in the function. The useless test was identified by smatch. Signed-off-by: Alan Stern Reported-by: Fenggu

[PATCH] USB: EHCI: convert warning messages to debug-level

2012-09-19 Thread Alan Stern
This patch (as1606) converts two warning messages in the ehci-hcd driver to debug messages, and adds a little extra information to each. The log messages occur when an EHCI controller takes too long (more than 20 ms) to turn its async or periodic schedule on or off. If this happens at all, it's l

[PATCH 03/29] ARM: OMAP1: Make plat/mux.h omap1 only

2012-09-19 Thread Tony Lindgren
We are moving omap2+ to use the device tree based pinctrl-single.c and will be removing the old mux framework. This will remove the omap1 specific parts from plat-omap. Cc: Felipe Balbi Cc: Grant Likely Cc: Alan Stern Cc: Greg Kroah-Hartman Cc: Richard Purdie Cc: Florian Tobias Schandinat Cc

[Patch v4] ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc

2012-09-19 Thread Rene Buergel
This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and adapts Makefiles and Kconfigs switching from bool to tristate for CONFIG_USB_EZUSB Signed-off-by: René Bürgel --- diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig index 1bfcd02..1c63b54 100644 --- a/drivers/usb/m

RE: [PATCH 0/4] Add PHY nofity for some i.mx SoCs

2012-09-19 Thread Chen Peter-B29397
> -Original Message- > From: Mike Thompson [mailto:mpthomp...@gmail.com] > Sent: Thursday, September 20, 2012 3:58 AM > To: Chen Peter-B29397 > Cc: st...@rowland.harvard.edu; ba...@ti.com; > alexander.shish...@linux.intel.com; Zhao Richard-B20223; snijsure@grid- > net.com; Estevam Fabio-R

RE: [PATCH v2 0/2] Some tiny changes for split phy from otg

2012-09-19 Thread Chen Peter-B29397
> Below are two patches to split some phy related things from > otg. > > Changes for v2: > - Use git mv / git format -M to create patch for rename otg.c to phy.c > Hi Felipe, how about these two patches? > Peter Chen (2): > usb: phy: rename enum usb_otg_state to usb_state > usb: phy: rena

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2012-09-19 Thread Benoit Cousson
Hi Kishon, On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: > This patch series adds dt data to get MUSB working in omap4 and omap3 > > Changes from v2: > * Changes the subject of all the patches to include "ARM: dts:" > * Added reg property and interrupt property for "usb_otg_hs". Previousl

[PATCH v4] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-09-19 Thread Olivier Sobrie
This driver provides support for several Kvaser CAN/USB devices. Such kind of devices supports up to three CAN network interfaces. It has been tested with a Kvaser USB Leaf Light (one network interface) connected to a pch_can interface. The firmware version of the Kvaser device was 2.5.205. List

RE: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-19 Thread Venu Byravarasu
Hi Greg & Felipe, Can any of you please review and merge this change? Thanks, Venu > -Original Message- > From: Stephen Warren [mailto:swar...@wwwdotorg.org] > Sent: Thursday, September 13, 2012 10:49 PM > To: Venu Byravarasu > Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;

[PATCH] USB: fix missed resume for auto-suspend failed interface

2012-09-19 Thread Ming Lei
If one usb interface driver returns failure from its suspend(auto) callback inside usb_suspend_both, its resume() callback should be called to recover its working state. Unfortunately, usbcore missed it, so fix the bug by decreasing the iterator variable to cover the current failed interface. Cc:

[PATCH v2 00/34] i.MX multi-platform support

2012-09-19 Thread Shawn Guo
Here is the second post, which should have addressed the comments that reviewers put on v1. It's available on branch below. git://git.linaro.org/people/shawnguo/linux-2.6.git imx/multi-platform-v2 And it's based on the following branches. calxeda/multi-plat arm-soc/multiplatform/platform-

[PATCH v2 16/34] usb: ehci-mxc: remove unneeded mach/hardware.h inclusion

2012-09-19 Thread Shawn Guo
The inclusion of mach/hardware.h is not used by the driver at all. Remove it. Signed-off-by: Shawn Guo Acked-by: Sascha Hauer Acked-by: Arnd Bergmann Acked-by: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org --- drivers/usb/host/ehci-mxc.c |1 - 1 file changed, 1 deletion(-) diff --git