NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc.
In order to support USB PHY drivers on these SoCs, existing
PHY driver is split into SoC agnostic common USB PHY driver
and Tegra20-specific USB phy driver. This will facilitate
easy addition and deletion of phy drivers for Tegra SoCs.
S
Hi Sarah
On Thu, Sep 13, 2012 at 2:37 AM, Sarah Sharp
wrote:
> On Wed, Sep 12, 2012 at 03:36:39PM +0530, Ajay Gupta wrote:
>> Hi,
>>
>> I am using v3.5 kernel and running a test where I disconnect a SS MSC
>> device while a big file is being written to it. I am also watching the
>> lsusb output i
On 13/09/12 09:57, Christoph Jung wrote:
Am 13.09.2012 10:49, schrieb Alan Jenkins:
On 13/09/12 08:25, Christoph Jung wrote:
Hello,
I am from the company "Code Mercenaries GmbH" from Germany. We have
some USB HID devices wich work with Linux.
Since kernel version 2.6 our default products will
Hi,
On Thu, Sep 13, 2012 at 12:32 PM, Venu Byravarasu
wrote:
> NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc.
> In order to support USB PHY drivers on these SoCs, existing
> PHY driver is split into SoC agnostic common USB PHY driver
> and Tegra20-specific USB phy driver. This will
Thanks Kishon, for your comments.
Plz see my answers inline.
> -Original Message-
> From: ABRAHAM, KISHON VIJAY [mailto:kis...@ti.com]
> Sent: Thursday, September 13, 2012 3:25 PM
> To: Venu Byravarasu
> Cc: st...@rowland.harvard.edu; gre...@linuxfoundation.org;
> ba...@ti.com; Stephen War
Hi Alan,
Sorry for the late answer, I've been travelling with no internet connection.
On Tuesday 04 September 2012 10:23:41 Alan Stern wrote:
> On Tue, 4 Sep 2012, Peter Chen wrote:
> > > In such a situation, the delay is much bigger than the device's buffer,
> > > so just sending more samples af
*udc* allocated in usb_add_gadget_udc() is not freed in error
path. Fixed the same.
Signed-off-by: Kishon Vijay Abraham I
---
drivers/usb/gadget/udc-core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c
index bae243c..12186d8
Pratyush Anand (2):
usb/dwc3: Fix scatter gather implementation
usb/dwc3: req->queued must be forced to false in cleanup
drivers/usb/dwc3/core.h |2 +-
drivers/usb/dwc3/gadget.c | 291 ++---
2 files changed, 171 insertions(+), 122 deletions(-)
I am not sure, why I found it during SG debugging. But, I noticed that
even when req_queued list was empty, there were some request in
request_list having queued flag true. If I run test second time, it
first removes all request from request_list and hence busy_slot was
wrongly incremented.
Signed
To work with scatter gather properly, fixes have been done in number of
functions. I will explain requirement of each fixes one by one.
idwc3_gadget_giveback: We need to skip link TRB if it was one of the
intermediate TRB of SG.
dwc3_prepare_one_trb: We need to move req_queued only for the first
Signed-off-by: Søren Holm
Cc: sta...@vger.kernel.org
---
drivers/net/usb/asix.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index 3ae80ec..12f372e 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -1604,6 +1604,10 @@
The functions pm_runtime_get_sync and clk_enable
return a signed value. So the variable used to
store should be signed otherwise a negative value may be
wrongly interpreted.
While at it also remove the initialisation of ret to zero.
Signed-off-by: Shubhrajyoti D
---
untested
drivers/usb/phy/om
The function omap_usb2_set_comparator may return -ENODEV.
Use a signed variable to store and check so that the value
is not wrongly interpreted as a large positive number.
While at it lets use the err variable to do the same.
Signed-off-by: Shubhrajyoti D
---
untested
drivers/usb/otg/twl6030-us
Currently upon the read errors twl6030_readb returns a negative number.
The return value may be wrongly interpreted as the read value. Call
twl_i2c_read_u8 directly and in case of errors return thus preventing a
possible spurious detection.
Signed-off-by: Shubhrajyoti D
---
untested.
drivers/us
On Tue, 11 Sep 2012, Clemens Ladisch wrote:
> > The test patch should be ready for posting soon. Would you like to try
> > it out?
>
> Yes (if I find time).
Here it is. This is actually five separate patches combined into one.
It implements the new documented behavior in ehci-hcd and adds
d
On Wed, 12 Sep 2012, Sarah Sharp wrote:
> I don't think unbinding the xHCI driver will switch the ports back to
> EHCI, unless xhci_shutdown is called when the driver is unbound, and
> Michal has the recent bug fix commit
> e95829f474f0db3a4d940cae1423783edd966027 "xhci: Switch PPT ports to EHCI
>
On Thu, 13 Sep 2012, Ajay Gupta wrote:
> Hi Sarah
>
> On Thu, Sep 13, 2012 at 2:37 AM, Sarah Sharp
> wrote:
> > On Wed, Sep 12, 2012 at 03:36:39PM +0530, Ajay Gupta wrote:
> >> Hi,
> >>
> >> I am using v3.5 kernel and running a test where I disconnect a SS MSC
> >> device while a big file is bei
Hi,
On Thu, Sep 13, 2012 at 7:44 PM, Shubhrajyoti D wrote:
> The function omap_usb2_set_comparator may return -ENODEV.
> Use a signed variable to store and check so that the value
> is not wrongly interpreted as a large positive number.
> While at it lets use the err variable to do the same.
>
>
I tried to come up with a simple way to create gadget on the fly. But I
failed so far. Instead I try to provide a copy of each descriptor
(similiar to what the network gadget are doing) and maybe make simple
later on.
This is an example based on g_zero what I intend to do with all gadgets.
(does no
HS and SS descriptors are staticaly created. They are updated during the
bind process with the endpoint address, string id or interface numbers.
After that, the descriptor chain is linked to struct usb_function which
is used by composite in order to serve the GET_DESCRIPTOR requests,
number of avai
The descriptor are updated at bind-time. Provide a copy of each
descriptor so they two functions of the same kind without chaning the
same descriptor. At bind time we know the capabilit of the UDC and they
don't change so a copy of HS descriptors is not passed if the UDC does
not support HS speed.
On Thu, 13 Sep 2012, Laurent Pinchart wrote:
> Hi Alan,
>
> Sorry for the late answer, I've been travelling with no internet connection.
No problem; thanks for joining the discussion.
> For video ISO IN problems can be split in two categories.
>
> Small delays (< one video frame) should alread
On 09/12/2012 07:24 PM, Michal Nowak wrote:
> From https://bugzilla.kernel.org/show_bug.cgi?id=47421:
>
> I have problems with Samsung SCX-3205 scanner on Toshiba Satellite L855.
> When is scanner connected to the notebook (via USB) I can see it via
> `scanimage -L` on first attempt but on any oth
Alan Stern wrote:
> If instead I do "echo 2 3000 >test" then the next URB is submitted 3
> frames too late. Since the URB contains only 3 packets, all of its
> slots have already expired. The submission fails and the audio stops
> playing, although the ogg123 program continues running and the syn
The 5+4 magic for HS tries to aim 32ms which is also what is intended
with 1 << 5 for FS. This little macro should make this easier to
understand.
Signed-off-by: Sebastian Andrzej Siewior
---
drivers/usb/gadget/f_acm.c|7 +++
drivers/usb/gadget/f_ecm.c|8
drivers/usb
On 09/13/2012 01:02 AM, Venu Byravarasu wrote:
> NVIDIA produces several Tegra SoCs viz Tegra20, Tegra30 etc.
> In order to support USB PHY drivers on these SoCs, existing
> PHY driver is split into SoC agnostic common USB PHY driver
> and Tegra20-specific USB phy driver. This will facilitate
> eas
The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d:
Linux 3.6-rc4 (2012-09-01 10:39:58 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.6-rc6
for you to fetch changes up to 38bb2ca69d5b6db712688a
On Tue, Sep 11, 2012 at 11:34:56AM -0400, Alan Stern wrote:
> > Deregistering the bus first to prevent future readers from accessing the
> > device
> > before cleaning up the hcd, seemed like an appropriate way to go. I'll
> > leave
> > it to the experts to validate that or provide a better solu
Add check for return value of tty_port_tty_get,
since it can return NULL after port hangup that may happen anytime.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov
---
drivers/usb/serial/omninet.c |8 +---
1 file changed, 5 insertions(+),
Hello,
this is V2 of a patches-series for controllers using the ezusb-functions.
ezusb: remove dependency to usb_serial interface
euzsb: add support for Cypress FX2LP
ezusb: add functions for firmware download
ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
--
René Bürgel
SOHA
This patch removes the dependency on the usb_serial interface and names
some magic constants
Signed-off-by: René Bürgel
--
diff --git a/drivers/usb/serial/ezusb.c b/drivers/usb/serial/ezusb.c
index 800e8eb..3048b52d 100644
--- a/drivers/usb/serial/ezusb.c
+++ b/drivers/usb/serial/ezusb.c
@@ -9,2
This patch removes the dependency on the usb_serial interface and names
some magic constants
Signed-off-by: René Bürgel
--
diff --git a/drivers/usb/serial/ezusb.c b/drivers/usb/serial/ezusb.c
index 800e8eb..3048b52d 100644
--- a/drivers/usb/serial/ezusb.c
+++ b/drivers/usb/serial/ezusb.c
@@ -9,2
Hello,
this is V2 of a patches-series for controllers using the ezusb-functions.
ezusb: remove dependency to usb_serial interface
euzsb: add support for Cypress FX2LP
ezusb: add functions for firmware download
ezusb: move ezusb.c from drivers/usb/serial to drivers/usb/misc
--
René Bürgel
SOHARD
From: Bjørn Mork
Date: Thu, 13 Sep 2012 08:44:35 +0200
> This fixes a hang on suspend due to calling wdm_suspend on
> the unregistered data interface. The hang should have been
> a NULL pointer reference had it not been for a logic error
> in the cdc_wdm code.
>
> commit 230718bd net: qmi_wwan
This patch removes the dependency on the usb_serial interface and names
some magic constants
Signed-off-by: René Bürgel
--
diff --git a/drivers/usb/serial/ezusb.c b/drivers/usb/serial/ezusb.c
index 800e8eb..3048b52d 100644
--- a/drivers/usb/serial/ezusb.c
+++ b/drivers/usb/serial/ezusb.c
@@ -9,2
This Patch adds support for the newer Cypress FX2LP. It also adapts
three drivers currently using ezusb to the interface change. (whiteheat
and keyspan[_pda])
Signed-off-by: René Bürgel
--
diff --git a/drivers/usb/serial/ezusb.c b/drivers/usb/serial/ezusb.c
index 3048b52d..351988d 100644
--- a/
This patch adds new functions to upload firmware to the controller. The
drivers currently using ezusb are adapted to use these new functions.
This also fixes a bug occuring during firmware loading in the
whiteheat-driver:
The driver iterates over an ihex-formatted firmware using ++ on a "const
This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and
adapts Makefiles and Kconfigs
Signed-off-by: René Bürgel
--
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 1bfcd02..1c63b54 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -244,3 +2
please ignore this thread, i'm still new to this mailing list stuff :/
I'll do my best to avoid such noise in the future
- Ursprüngliche Mail -
> Hello,
>
> this is V2 of a patches-series for controllers using the
> ezusb-functions.
>
> ezusb: remove dependency to usb_serial interface
>
On Thu, 13 Sep 2012, Don Zickus wrote:
> Hi Alan,
>
> I adapted your patch to our 2.6.32 tree and the customer tested it without
> success. The output panic is attached below. I will work on getting a
> machine with the latest kernel to reproduce this problem so I don't waste
> your time chasin
On Thu, Sep 13, 2012 at 04:31:34PM -0400, Alan Stern wrote:
> On Thu, 13 Sep 2012, Don Zickus wrote:
>
> > Hi Alan,
> >
> > I adapted your patch to our 2.6.32 tree and the customer tested it without
> > success. The output panic is attached below. I will work on getting a
> > machine with the l
On Thu, 13 Sep 2012, Clemens Ladisch wrote:
> Alan Stern wrote:
> > If instead I do "echo 2 3000 >test" then the next URB is submitted 3
> > frames too late. Since the URB contains only 3 packets, all of its
> > slots have already expired. The submission fails and the audio stops
> > playing, al
On Sat, Aug 25, 2012 at 12:31:46PM +0300, Sami Farin wrote:
> On Sat, Aug 25, 2012 at 15:10:13 +0800, Andiry Xu wrote:
> ...
> > >
> > > 3.6.0-rc2-g6dab7ede has some funny printk's , but it panics on network use
> > > so I am back to 3.5.0-rc7-g84a1caf:
> > >
> > > <5>[5.163846] scsi 10:0:0:0:
On Thu, 13 Sep 2012, Sarah Sharp wrote:
> > I plugged rdf8 reader into usb3 port, mounted it (vfat),
> > cat garbage > out.bin , at the end ls showed a bit over 25200 byte file,
> > then empty dir listing (df showed input/output error). When mounted
> > with rdf8 reader plugged into usb2 port
The following changes since commit c2d57aec81f3d479642523fd4d3537006168c240:
USB: core: remove unused dbg() call in message.c (2012-09-13 11:23:03 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git
for-usb-next-2012-09-13
for you to
From: Elric Fu
The patch is used to cancel command when the command isn't
acknowledged and a timeout occurs.
This patch should be backported to kernels as old as 3.0, that contain
the commit 7ed603ecf8b68ab81f4c83097d3063d43ec73bb8 "xhci: Add an
assertion to check for virt_dev=0 bug." That commi
From: Elric Fu
Adding cmd_ring_state for command ring. It helps to verify
the current command ring state for controlling the command
ring operations.
This patch should be backported to kernels as old as 3.0. The commit
7ed603ecf8b68ab81f4c83097d3063d43ec73bb8 "xhci: Add an assertion to
check fo
From: Elric Fu
According to xHCI spec section 4.6.1.1 and section 4.6.1.2,
after aborting a command on the command ring, xHC will
generate a command completion event with its completion
code set to Command Ring Stopped at least. If a command is
currently executing at the time of aborting a comman
From: Elric Fu
Software have to abort command ring and cancel command
when a command is failed or hang. Otherwise, the command
ring will hang up and can't handle the others. An example
of a command that may hang is the Address Device Command,
because waiting for a SET_ADDRESS request to be acknow
From: Felipe Balbi
drivers/usb/host/xhci.c:1826:14: warning: symbol 'xhci_get_block_size' was not
declared. Should it be static?
drivers/usb/host/xhci.c:1844:14: warning: symbol 'xhci_get_largest_overhead'
was not declared. Should it be static?
drivers/usb/host/xhci-ring.c:2304:36: warning: con
From: Peter Senna Tschudin
removes unnecessary semicolon
Found by Coccinelle: http://coccinelle.lip6.fr/
Signed-off-by: Peter Senna Tschudin
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-ring.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/
From: Sebastian Andrzej Siewior
The comment is a quote of Alan Stern and reflects the data structure
better than the the initial comment.
Signed-off-by: Sebastian Andrzej Siewior
Signed-off-by: Sarah Sharp
---
drivers/usb/host/xhci-hub.c |2 +-
1 files changed, 1 insertions(+), 1 deletion
Hi,
it seems I can hit an infinite loop in the following function. The way
to trigger it is a stressing night of suspend/resume cycles repeated all
the time while some hiddev is being accessed.
void usbhid_init_reports(struct hid_device *hid)
{
struct hid_report *report;
struct
On Thu, Sep 13, 2012 at 04:01:43PM -0700, Sarah Sharp wrote:
> The following changes since commit c2d57aec81f3d479642523fd4d3537006168c240:
>
> USB: core: remove unused dbg() call in message.c (2012-09-13 11:23:03 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pu
Hi Richard,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: 799ee9243d892ad959c8e5f4549593ece59f1c80
commit: 8c4fc031954b4eb72daf13d3c907a985a3eee208 [141/145] USB: chipidea: add
vbus detect for udc
All smatch w
Hi Richard,
FYI, there are new smatch warnings show up in
commit 3807e26d69b9ad3864fe03224ebebc9610d5802e
Author: Alek Du
AuthorDate: Tue Jul 14 07:23:29 2009 +0800
drivers/usb/chipidea/../host/ehci-dbg.c:656 fill_periodic_buffer() warn:
variable dereferenced before check 'p.qh' (see line
On Fri, 14 Sep 2012, Fengguang Wu wrote:
> Hi Richard,
>
> FYI, there are new smatch warnings show up in
>
> commit 3807e26d69b9ad3864fe03224ebebc9610d5802e
> Author: Alek Du
> AuthorDate: Tue Jul 14 07:23:29 2009 +0800
>
> drivers/usb/chipidea/../host/ehci-dbg.c:656 fill_periodic_buffer()
This patch adds Renesas R-Car USB phy driver.
It supports R8A7779 chip at this point.
R-Car has some USB controllers, but has only one phy-initializer.
So, this driver is counting users.
Signed-off-by: Kuninori Morimoto
---
v4 -> v5
- removed LITTLE/BIG define
- use if (val == (ACT | PLL))
At some i.mx SoCs, when controller works at host mode, the PHY
register needs to be changed at device connect, disconnect, bus
suspend and resume due to the SoC limitations.
The phy notification should be added according to below rules:
1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during high sp
This let usb phy driver has the chance to change hw settings during
the controller suspend/resume procedure.
Besides, old parameter "port" is useless for phy notify, as one usb
phy is only for one usb port. New parameter "speed" stands for
the device's speed which is on the port.
Signed-off-by: P
These notify will be called during the bus suspend/resume procedure.
The mxs-phy needs to set/clear HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during the connect, disconnect,suspend and resume procedure.
The phy notification should be added according to below rules:
1. Only set HW_USBPHY_CTRL.ENHOSTDISCON
When there is a device at the port, it needs to notify PHY
driver bus's status during bus suspend/resume procedure
for some freescale i.mx SoC (i.mx23, i.mx28, i.mx6).
Signed-off-by: Peter Chen
---
drivers/usb/chipidea/host.c | 75 +-
1 files changed, 73
At commit 925aa46ba963a4da6d8ee6ab1d04a02ffa8db62b, Richard Zhao
adds the phy notification callback
when port change occurs. In fact, this phy notification should
be added according to below rules:
1. Only set HW_USBPHY_CTRL.ENHOSTDISCONDETECT
during high speed host mode.
2. Do not set HW_USBPHY_
Hi
>> >> I am using v3.5 kernel and running a test where I disconnect a SS MSC
>> >> device while a big file is being written to it. I am also watching the
>> >> lsusb output in parallel. Expectation is that SS MSC device should
>> >> immediately disappear from lsusb output but sometime I see that
On Thu, Sep 13, 2012 at 10:15:47PM +0200, Rene Buergel wrote:
> This Patch adds support for the newer Cypress FX2LP. It also adapts
> three drivers currently using ezusb to the interface change. (whiteheat
> and keyspan[_pda])
>
> Signed-off-by: René Bürgel
> --
Shouldn't this be 3 '-' charact
On Thu, Sep 13, 2012 at 10:19:11PM +0200, Rene Buergel wrote:
> This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and
> adapts Makefiles and Kconfigs
>
> Signed-off-by: René Bürgel
> --
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 1bfcd02..1c63b54 10064
On Wed, Sep 12, 2012 at 4:38 PM, Marc Kleine-Budde wrote:
> On 09/12/2012 12:45 PM, Praveen Paneri wrote:
>> This driver uses usb_phy interface to interact with s3c-hsotg. Supports
>> phy_init and phy_shutdown functions to enable/disable phy. Tested with
>> smdk6410 and smdkv310. More SoCs can be
There is a '&' vs '|' typo in the original code so the condition is
never true and we don't queue the work.
Signed-off-by: Dan Carpenter
---
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 2f45bba..5294f81 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipi
> Git should show this as a move, not as a "add a file and remove a
> file"
> type patch. Are you generating it properly?
Whats the proper way to do this? I did a git mv, git commit and than git diff
on that commit hash.
> Also, why move it? Are there other modules that need to use it?
>
> t
"ret" should be signed here for the error handling to work.
Signed-off-by: Dan Carpenter
diff --git a/drivers/usb/phy/omap-usb2.c b/drivers/usb/phy/omap-usb2.c
index 15ab3d6..d36c282 100644
--- a/drivers/usb/phy/omap-usb2.c
+++ b/drivers/usb/phy/omap-usb2.c
@@ -120,7 +120,7 @@ static int omap_us
> Also, why move it? Are there other modules that need to use it?
Fullquote from Aug, 24:
> > > > - Although i removed the dependency from ezusb to usb_serial,
> > > > ezusb.c still resides in drivers/usb/serial.
> > > > Can you give me a hint, where to put it instead?
> > > > I would like
On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote:
> There is a '&' vs '|' typo in the original code so the condition is
> never true and we don't queue the work.
>
> Signed-off-by: Dan Carpenter
> ---
>
> diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
> index 2
72 matches
Mail list logo
