Re: [PATCH v3 4/5] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-09-06 Thread Richard Zhao
On Wed, Sep 05, 2012 at 10:11:52AM +0200, Marc Kleine-Budde wrote: > If udc_start() fails the qh_pool dma-pool cannot be closed because > it's still in use. This patch factors out the dma_pool_free() loop > into destroy_eps() and calls it in the error path of udc_start(), > too. > > Cc: Richard Zh

RE: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Alexey ORISHKO
> -Original Message- > From: Oliver Neukum [mailto:oneu...@suse.de] > looking at cdc-ncm it seeems to me that cdc-ncm is forced to play very > dirty games because usbnet doesn't have a notion about aggregating > packets for a single transfer. Several issues need to be improved: Tx path:

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Bjørn Mork
Oliver Neukum writes: > looking at cdc-ncm it seeems to me that cdc-ncm is forced to play > very dirty games because usbnet doesn't have a notion about aggregating > packets for a single transfer. > > It seems to me that this can be fixed introducing a method for bundling, > which tells usbnet ho

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Bjørn Mork
Ming Lei writes: > On Thu, Sep 6, 2012 at 4:12 AM, Oliver Neukum wrote: >> Hi, >> >> looking at cdc-ncm it seeems to me that cdc-ncm is forced to play >> very dirty games because usbnet doesn't have a notion about aggregating >> packets for a single transfer. > > The Ethernet API we are using doe

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Oliver Neukum
On Thursday 06 September 2012 10:13:01 Alexey ORISHKO wrote: > > -Original Message- > > From: Oliver Neukum [mailto:oneu...@suse.de] > > > > looking at cdc-ncm it seeems to me that cdc-ncm is forced to play very > > dirty games because usbnet doesn't have a notion about aggregating > > pa

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Eric Dumazet
On Thu, 2012-09-06 at 10:50 +0200, Oliver Neukum wrote: > On Thursday 06 September 2012 10:13:01 Alexey ORISHKO wrote: > > Rx path: > > 4. IP packets are cloned to separate skb and length of actual data > set to eth packet size, while skb size is still the same as skb > containing full NTB frame.

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Eric Dumazet
On Thu, 2012-09-06 at 11:11 +0200, Eric Dumazet wrote: > Really skb_clone() use should be removed from cdc_ncm_rx_fixup() > > Unless you expect 10Gbit speed from this driver, skb_clone() is the > worst possible strategy. > > Allocating fresh skbs of the right size permits better memory use and >

Re: JMicron 20337 (152d:2338) and 3TB

2012-09-06 Thread Alon Bar-Lev
On Tue, Sep 4, 2012 at 5:32 PM, Alon Bar-Lev wrote: > Going to try out this one[1][2], but now I go to the store and test it > on site before buying. > > Alon > > [1] http://a.slickdeals.net/attachment.php?attachmentid=84784&d=... > [2] > http://www.zhuzhuchina.com/store/esata_to_usb_2_0_external_

[PATCH] usbip: avoid deadlock in vhci_device_unlink_cleanup()

2012-09-06 Thread Bernard Blackham
Almost all of usbip assumes that the_controller->lock is acquired before vdev->priv_lock. The exception is in vhci_device_unlink_cleanup(), where locks are acquired in the reverse order. This leads to occasional deadlocks. Fixing this is a bit fiddly, as the_controller->lock can't be held when cal

[PATCH] staging: usbip: vhci_hcd: fixed suspend-resume loop

2012-09-06 Thread navin patidar
USB autosuspend suspends vhci_hcd. In this process hcd_bus_suspend gets executed which puts vhci_hcd in suspend state and calls vhci_hub_status. vhci_hub_status function checks hub state and if it is in suspend state, usb_hcd_resume_root_hub gets executed which resumes hub and if hub is idle, aga

Re: [PATCH v7 1/7] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Aug 6, 2012 at 6:37 PM, Kishon Vijay Abraham I wrote: > All phy related programming like enabling/disabling the clocks, powering > on/off the phy is taken care of by this driver. It is also used for OTG > related functionality like srp. > > This also includes device tree support for u

Re: [PATCH v3 1/5] usb: chipidea: udc: fix setup of endpoint maxpacket size

2012-09-06 Thread Alexander Shishkin
Marc Kleine-Budde writes: > From: Michael Grzeschik > > This patch changes the setup of the endpoint maxpacket size. All non control > endpoints are initialized with an undefined ((unsigned short)~0) maxpacket > size. The maxpacket size of Endpoint 0 will be kept at CTRL_PAYLOAD_MAX. > > Some ga

Re: [PATCH v3 2/5] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-06 Thread Alexander Shishkin
Marc Kleine-Budde writes: > From: Michael Grzeschik > > Add function to physicaly enable or disable of pullup connection on the USB-D+ > line. The uvc gaget will fail, if this function is not implemented. > > Signed-off-by: Michael Grzeschik > Signed-off-by: Marc Kleine-Budde > Acked-by: Felip

Re: [PATCH v3 3/5] usb: chipidea: udc: fix error path in udc_start()

2012-09-06 Thread Alexander Shishkin
Marc Kleine-Budde writes: > This patch fixes the error path of udc_start(). Now NULL is used to > unset the peripheral with otg_set_peripheral(). > > Signed-off-by: Marc Kleine-Budde > Reviewed-by: Richard Zhao Acked-by: Alexander Shishkin > --- > drivers/usb/chipidea/udc.c |2 +- > 1 f

Re: [PATCH v3 2/5] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 02:26 PM, Alexander Shishkin wrote: > Marc Kleine-Budde writes: > >> From: Michael Grzeschik >> >> Add function to physicaly enable or disable of pullup connection on the >> USB-D+ >> line. The uvc gaget will fail, if this function is not implemented. >> >> Signed-off-by: Michael

Re: [PATCH v3 4/5] usb: chipidea: cleanup dma_pool if udc_start() fails

2012-09-06 Thread Alexander Shishkin
Marc Kleine-Budde writes: > If udc_start() fails the qh_pool dma-pool cannot be closed because > it's still in use. This patch factors out the dma_pool_free() loop > into destroy_eps() and calls it in the error path of udc_start(), > too. > > Cc: Richard Zhao > Signed-off-by: Marc Kleine-Budde

[PATCH 0/2] usb: chipidea: usbmisc: cleanups and prepare for multi soc support

2012-09-06 Thread Marc Kleine-Budde
Hello, these patches apply to Richard's usb-driver branch [1] and prepare the usbmisc driver for multi-soc support. Feel free to squash into your patches, or add to your tree. regards, Marc [1] https://github.com/riczhao/kernel-imx/tree/topics/usb-driver -- To unsubscribe from this list: send

[PATCH 1/2] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

2012-09-06 Thread Marc Kleine-Budde
While there fix a potential race condition, first set usbmisc, then call usbmisc_set_ops(). Signed-off-by: Marc Kleine-Budde --- drivers/usb/chipidea/usbmisc_imx6q.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx6q.c b/drivers/usb/ch

[PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-06 Thread Marc Kleine-Budde
Signed-off-by: Marc Kleine-Budde --- drivers/usb/chipidea/usbmisc_imx6q.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/usbmisc_imx6q.c b/drivers/usb/chipidea/usbmisc_imx6q.c index edc0edd7..5989a80 100644 --- a/drivers/usb/chipidea/usbmisc_

Re: [PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 02:37 PM, Marc Kleine-Budde wrote: > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx6q.c |9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/chipidea/usbmisc_imx6q.c > b/drivers/usb/chipidea/usbmisc_imx6q.c > i

Re: [PATCH v3 5/5] usb: chipidea: udc: don't stall endpoint if request list is empty in isr_tr_complete_low

2012-09-06 Thread Alexander Shishkin
Marc Kleine-Budde writes: > From: Michael Grzeschik > > When attaching an imx28 or imx53 in USB gadget mode to a Windows host and > starting a rndis connection we see this message every 4-10 seconds: > > g_ether gadget: high speed config #2: RNDIS > > Analysis shows that each time this messa

Re: [PATCH v3 5/5] usb: chipidea: udc: don't stall endpoint if request list is empty in isr_tr_complete_low

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 02:46 PM, Alexander Shishkin wrote: > Marc Kleine-Budde writes: > >> From: Michael Grzeschik >> >> When attaching an imx28 or imx53 in USB gadget mode to a Windows host and >> starting a rndis connection we see this message every 4-10 seconds: >> >> g_ether gadget: high speed c

Re: usbnet: fix oops in usbnet_start_xmit

2012-09-06 Thread Dan Carpenter
I sent this email a year ago when the patch was committed but I never received a response. regards, dan carpenter On Wed, Nov 09, 2011 at 10:34:59AM +0300, Dan Carpenter wrote: > Hello Konstantin Khlebnikov, > > This is a semi-automatic email about new static checker warnings. > > The patch 23b

[PATCH] usb: cdc-ncm: struct usb_cdc_ncm_ndp_input_size not initialized

2012-09-06 Thread Frank Hoffmann
Hello, we developing CDC/NCM firmware and found that the Linux CDC/NCM is not compliant to the USB CDC/NCM specification. The cause is a Bug in the cdc_ncm.c file. The structure usb_cdc_ncm_ndp_input_size is only allocated but not initialized. The CDC/NCM specification section "6.2.7 SetNtbInp

Re: [PATCH v3 2/5] usb: chipidea: udc: add pullup fuction, needed by the uvc gadget

2012-09-06 Thread Alexander Shishkin
Marc Kleine-Budde writes: > On 09/06/2012 02:26 PM, Alexander Shishkin wrote: >> Marc Kleine-Budde writes: >> >>> From: Michael Grzeschik >>> >>> Add function to physicaly enable or disable of pullup connection on the >>> USB-D+ >>> line. The uvc gaget will fail, if this function is not imple

Re: [PATCH v7 1/7] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread Arnd Bergmann
On Thursday 06 September 2012, ABRAHAM, KISHON VIJAY wrote: > > diff --git a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt > > b/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt > > index d2fe064..bb0c7f4 100644 > > --- a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt > > ++

Re: [GIT PULL] USB fixes for v3.6-rc4

2012-09-06 Thread Felipe Balbi
On Wed, Sep 05, 2012 at 04:49:37PM -0700, Greg KH wrote: > On Thu, Aug 23, 2012 at 12:03:58PM +0300, Felipe Balbi wrote: > > Hi Greg, > > > > Here's my (hopefully) last set of fixes for v3.6-rc cycle. Let me know if > > you > > want me to change anything and I'll do so ASAP. > > > > cheers > >

Re: chipidea driver

2012-09-06 Thread Alexander Shishkin
Greg KH writes: > On Fri, Aug 24, 2012 at 10:09:11AM +0800, Richard Zhao wrote: >> On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: >> > Hello, >> > >> > Michael and I have a bunch of updates and improvement for the chipidea >> > driver. They apply to Richard's tree: >> > >> >

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 05:01:46PM +0300, Pantelis Antoniou wrote: > Marking functions as __init or __devinit and calling them at other times > leads to predictable crashes (if you're lucky). > > Remove them for now. > > Signed-off-by: Pantelis Antoniou > --- > drivers/usb/musb/musb_core.c|

Re: Re: Re: 3.0 device attached to USB 3.0 hub port doesn't respond address device command after resume

2012-09-06 Thread Felipe Balbi
On Wed, Sep 05, 2012 at 02:23:30PM -0700, Sarah Sharp wrote: > On Tue, Aug 21, 2012 at 08:16:10PM +0800, Andiry Xu wrote: > > Just have one question - how do you add suspend/resume support for > > DWC USB 3 controller? Where can I find the source code? > > > > Is it reusing the suspend/resume code

Re: usbnet: fix oops in usbnet_start_xmit

2012-09-06 Thread Oliver Neukum
On Thursday 06 September 2012 05:52:30 Dan Carpenter wrote: > I sent this email a year ago when the patch was committed but I > never received a response. I probably should have checked then. > regards, > dan carpenter > > On Wed, Nov 09, 2011 at 10:34:59AM +0300, Dan Carpenter wrote: > > Hello

Re: chipidea driver

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 03:05 PM, Alexander Shishkin wrote: > Greg KH writes: > >> On Fri, Aug 24, 2012 at 10:09:11AM +0800, Richard Zhao wrote: >>> On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: Hello, Michael and I have a bunch of updates and improvement for the chipide

Re: [PATCH] usb: host: xhci: fix compilation error for non-PCI based stacks

2012-09-06 Thread Felipe Balbi
Hi, On Wed, Sep 05, 2012 at 12:31:50PM -0700, Sarah Sharp wrote: > On Wed, Sep 05, 2012 at 08:34:26AM +0300, Felipe Balbi wrote: > > From: Moiz Sonasath > > > > For non PCI-based stacks, this function call > > usb_disable_xhci_ports(to_pci_dev(hcd->self.controller)); > > made from xhci_shutdown

Re: [PATCH v7 1/7] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 01:03:02PM +, Arnd Bergmann wrote: > On Thursday 06 September 2012, ABRAHAM, KISHON VIJAY wrote: > > > diff --git a/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt > > > b/Documentation/devicetree/bindings/bus/omap-ocp2scp.txt > > > index d2fe064..bb0c7f4 100644

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Felipe Balbi
On Wed, Sep 05, 2012 at 02:10:39AM +, Chen Peter-B29397 wrote: > > > > > Because the fsl_udc_core driver shares one 'status_req' object for the > > complete ep0 control transfer, it is not possible to prime the final > > STATUS phase immediately after the IN transaction. E.g. ch9getstatus()

Re: [PATCH] usb: cdc-ncm: struct usb_cdc_ncm_ndp_input_size not initialized

2012-09-06 Thread Alexey Orishko
On Thu, Sep 6, 2012 at 2:35 PM, Frank Hoffmann wrote: > I'm not sure if it is also required to initialize the wNtbInMaxDatagrams > field because 0 (no limit) is a valid value. It is not required. The limit was removed in one of the patches earlier. /alexey -- To unsubscribe from this list: send

Re: chipidea driver

2012-09-06 Thread Greg KH
On Thu, Sep 06, 2012 at 03:15:10PM +0200, Marc Kleine-Budde wrote: > On 09/06/2012 03:05 PM, Alexander Shishkin wrote: > > Greg KH writes: > > > >> On Fri, Aug 24, 2012 at 10:09:11AM +0800, Richard Zhao wrote: > >>> On Thu, Aug 23, 2012 at 06:57:03PM +0200, Marc Kleine-Budde wrote: > Hello,

Re: [BUG] - USB3 bluetooth device not working properly?

2012-09-06 Thread Miroslav Sabljic
On 09/06/2012 12:02 AM, Sarah Sharp wrote: I'm actually wondering if you're hitting a bug that is fixed by a patch in my queue to send to Greg. Apparently, some BIOSes expect specific USB ports on the mobile Panther Point chipset to remain under the EHCI controller, even though they can be swit

Re: chipidea driver

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 04:02 PM, Greg KH wrote: >>> Indeed there's a pile of patches, I'm going through them right now, Marc >>> already has my acks. We should probably agree if I should collect them >>> all before sending to you or if guys can send them to you directly (as >>> soon as we agree on acks). >>

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Enrico Scholz
Felipe Balbi writes: >> > Because the fsl_udc_core driver shares one 'status_req' object for the >> > complete ep0 control transfer, it is not possible to prime the final >> > STATUS phase immediately after the IN transaction. E.g. ch9getstatus() >> > executed: >> > >> > | req = udc->status_req

Re: [PATCH] usb: gadget: fsl_udc_core: do not immediatly prime STATUS for IN xfer

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 04:27:12PM +0200, Enrico Scholz wrote: > Felipe Balbi writes: > > >> > Because the fsl_udc_core driver shares one 'status_req' object for the > >> > complete ep0 control transfer, it is not possible to prime the final > >> > STATUS phase immediately after the IN trans

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-06 Thread Enrico Scholz
Chen Peter-B29397 writes: > If the class driver has already mapped this address, the req->req.dma is not > DMA_ADDR_INVALID either, in this case, the dma_sync_single_for_cpu is > enough. ok; forget the patch then. Thanks Enrico -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Felipe Balbi
On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: > On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote: > >>> Since it's already a common function, we may give phandler > >>> property > >>> a common name too. So we will not need phandle argument. > >>>

Re: [PATCH 1/2] usb: otg: mxs-phy: Fix mx23 operation

2012-09-06 Thread Felipe Balbi
On Thu, Aug 30, 2012 at 08:04:04PM +0200, Marek Vasut wrote: > Dear Fabio Estevam, > > > Hi Marek, > > > > On Thu, Aug 30, 2012 at 12:20 PM, Marek Vasut wrote: > > >> +#define MXY_PHY_ENHOSTDISCONDETECT_DELAY 250 > > >> + > > > > > > Why 250 ? :) > > > > It is 250 ms. We found this one to

Re: [PATCH] usb: gadget: fsl_udc_core: remove mapped flag

2012-09-06 Thread Felipe Balbi
On Thu, Sep 06, 2012 at 04:32:28PM +0200, Enrico Scholz wrote: > Chen Peter-B29397 writes: > > > If the class driver has already mapped this address, the req->req.dma is not > > DMA_ADDR_INVALID either, in this case, the dma_sync_single_for_cpu is > > enough. > > ok; forget the patch then. fair

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Richard Zhao
On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: > On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: > > On 09/04/2012 07:51 PM, ABRAHAM, KISHON VIJAY wrote: > > >>> Since it's already a common function, we may give phandler > > >>> property > > >>

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Felipe Balbi
Hi, We should at least add Grant to the loop, I guess. On Thu, Sep 06, 2012 at 10:46:13PM +0800, Richard Zhao wrote: > On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: > > On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Budde wrote: > > > On 09/04/2012 07:51 PM, ABRAHAM, KISHON

[PATCH 0/3] omap: musb: Add device tree support

2012-09-06 Thread Kishon Vijay Abraham I
This patch series adds device tree support for MUSB. The glue layer is now made to write to mailbox register (present in control module) instead of calling phy layer to write to mailbox register. Writing to mailbox register notifies the core of events like device connect/disconnect. Previously th

[PATCH 2/3] usb: musb: omap: write directly to mailbox instead of using phy

2012-09-06 Thread Kishon Vijay Abraham I
The glue layer should directly write to mailbox register (present in control module) instead of calling phy layer to write to mailbox register. Writing to mailbox register notifies the core of events like device connect/disconnect. Currently writing to control module register is taken care in this

[PATCH 2/5] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-09-06 Thread Kishon Vijay Abraham I
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/Kconfig

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Pantelis Antoniou
Hi Felipe, A proper answer required some instrumentation printks(). So what I did is that I peppered each function marked with a removed __init or __devinit with a > printk(KERN_INFO "%s:%d (%s) %s\n", __FILE__, __LINE__, KBUILD_MODNAME, > __func__); > Both omap2430 & musb_hdrc are compiled

[PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread Kishon Vijay Abraham I
All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for usb2 phy driver and the documentation with device tree binding information is

[PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Kishon Vijay Abraham I
The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to control module, omap2430 will handle the register writes to

[PATCH 4/5] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-09-06 Thread Kishon Vijay Abraham I
Add device tree support for twl4030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 ++ drivers/usb/otg/twl4030-usb.c | 26 +++

[PATCH 0/5] usb: phy/otg: add dt support

2012-09-06 Thread Kishon Vijay Abraham I
This patch series adds device tree support for phy's (twl4030 and twl6030). A new omap-usb2 phy driver has been added (with only dt suppport) to perform phy configurations. Previously this configuration was performed by twl6030, using pdata function pointers. With the addition of omap-usb2 to per

[PATCH 3/5] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-09-06 Thread Kishon Vijay Abraham I
Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 21 +++ drivers/usb/otg/twl6030-usb.c | 39 +-

[PATCH 5/5] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-09-06 Thread Kishon Vijay Abraham I
All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap_phy_internal.c | 138 --- arch/arm/

[PATCH 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-06 Thread Kishon Vijay Abraham I
Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt | 33 drivers/usb/musb/omap2430.c| 54 +

Re: [PATCH 1/2] usb: otg: mxs-phy: Fix mx23 operation

2012-09-06 Thread Fabio Estevam
Hi Felipe, On Thu, Sep 6, 2012 at 11:30 AM, Felipe Balbi wrote: > I need a final version for this series or it won't make it into v3.7 I sent a v2 for this last week: http://www.spinics.net/lists/linux-usb/msg69955.html Thanks, Fabio Estevam -- To unsubscribe from this list: send the line "un

Re: [PATCH 1/2] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

2012-09-06 Thread Richard Zhao
Hi Marc, Thanks for your patch. It's good. Richard On Thu, Sep 06, 2012 at 02:37:58PM +0200, Marc Kleine-Budde wrote: > While there fix a potential race condition, first set usbmisc, then call > usbmisc_set_ops(). > > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx6q

Re: [PATCH 1/2] usb: chipidea: usbmisc: unset global varibale usbmisc on driver remove

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 05:11 PM, Richard Zhao wrote: > Hi Marc, > > Thanks for your patch. It's good. Please include or squash in your tree. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions| Phone: +49-231-2826-924 | Vertretung West/Dortmu

Re: [PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-06 Thread Richard Zhao
Hi Marc, usbmisc_imx6q.c is only for imx6x. And for a certain running kernel, there will be always one driver instance. Thanks Richard On Thu, Sep 06, 2012 at 02:37:59PM +0200, Marc Kleine-Budde wrote: > Signed-off-by: Marc Kleine-Budde > --- > drivers/usb/chipidea/usbmisc_imx6q.c |9 +

Re: [PATCH 2/2] usb: chipidea: usbmisc: prepare driver to handle more than one soc

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 05:15 PM, Richard Zhao wrote: > Hi Marc, > > usbmisc_imx6q.c is only for imx6x. And for a certain running kernel, > there will be always one driver instance. It's currently only for imx6q, but I've patches[1] in queue for mx53. And mx35 is about to be written. Marc [1] http://git.

Re: chipidea driver

2012-09-06 Thread Greg KH
On Thu, Sep 06, 2012 at 04:09:58PM +0200, Marc Kleine-Budde wrote: > On 09/06/2012 04:02 PM, Greg KH wrote: > >>> Indeed there's a pile of patches, I'm going through them right now, Marc > >>> already has my acks. We should probably agree if I should collect them > >>> all before sending to you or

Re: [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-06 Thread Marc Kleine-Budde
On 09/06/2012 04:46 PM, Felipe Balbi wrote: > Hi, > > We should at least add Grant to the loop, I guess. > > On Thu, Sep 06, 2012 at 10:46:13PM +0800, Richard Zhao wrote: >> On Thu, Sep 06, 2012 at 05:30:02PM +0300, Felipe Balbi wrote: >>> On Tue, Sep 04, 2012 at 09:32:06PM +0200, Marc Kleine-Bud

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Vaibhav Hiremath
On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > The mailbox register for usb otg in omap is present in control module. > On detection of any events VBUS or ID, this register should be written > to send the notification to musb core. > > Till we have a separate control module driver to write

Re: [GIT PULL] USB fixes for v3.6-rc4

2012-09-06 Thread Greg KH
On Thu, Sep 06, 2012 at 03:59:48PM +0300, Felipe Balbi wrote: > On Wed, Sep 05, 2012 at 04:49:37PM -0700, Greg KH wrote: > > On Thu, Aug 23, 2012 at 12:03:58PM +0300, Felipe Balbi wrote: > > > Hi Greg, > > > > > > Here's my (hopefully) last set of fixes for v3.6-rc cycle. Let me know if > > > you

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Ming Lei
On Thu, Sep 6, 2012 at 4:30 PM, Bjørn Mork wrote: > Ming Lei writes: >> On Thu, Sep 6, 2012 at 4:12 AM, Oliver Neukum wrote: >>> Hi, >>> >>> looking at cdc-ncm it seeems to me that cdc-ncm is forced to play >>> very dirty games because usbnet doesn't have a notion about aggregating >>> packets f

[PATCH 1/10] drivers/net/usb/sierra_net.c: removes unnecessary semicolon

2012-09-06 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/net/usb/sierra_net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -u -p a/drivers/net/usb/sierra_net.c b/drivers/net/usb/

Re: [PATCH RESEND] USB/host: Cleanup unneccessary irq disable code

2012-09-06 Thread gre...@linuxfoundation.org
On Thu, Sep 06, 2012 at 02:00:16AM +, Liu, Chuansheng wrote: > Because the IRQF_DISABLED as the flag is now a NOOP and has been > deprecated and in hardirq context the interrupt is disabled. > > so in usb/host code: > Removing the usage of flag IRQF_DISABLED; > Removing the calling local_irq s

When enabling usb autosuspend, new usb devices aren't recognized

2012-09-06 Thread Florian Merz
Hi, To enable usb autosuspend i use the following in a script after booting: for i in `find /sys/bus/usb/devices/*/power/control`; do echo auto > $i; done; for i in `find /sys/bus/usb/devices/*/power/autosuspend`; do echo 2 > $i; done; After this new usb devices aren't recognized anymore. Whether

[PATCH] USB: XHCI: xhci-ring: Remove unused dma address calculation in inc_enq and inc_deq function

2012-09-06 Thread Girish Verma
Resending patch with latest kernel code: In xhci-ring.c, function inc_enq and inc_deq calculate the dma address of trb but never used. Signed-off-by: Girish Verma --- drivers/usb/host/xhci-ring.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/xhci

[GIT PULL] USB fixes for v3.6-rc4

2012-09-06 Thread Felipe Balbi
Hi Greg, Here's my previous pull request now rebased on top of v3.6-rc4. Sorry for the inconvenience my "never rebase" methodology :-) Note that I'm rebased on top of v3.6-rc4, so you should probably merge that tag on your tree. After merging v3.6-rc4 on your tree, you can merge my tag and you s

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote: > Hi Felipe, > > A proper answer required some instrumentation printks(). > > So what I did is that I peppered each function marked with a removed > __init or __devinit with a > > > printk(KERN_INFO "%s:%d (%s) %s\n", __FIL

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: > > > On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > > The mailbox register for usb otg in omap is present in control module. > > On detection of any events VBUS or ID, this register should be written > > to send the not

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 08:13:03PM +0300, Felipe Balbi wrote: > Hi, > > On Thu, Sep 06, 2012 at 09:04:58PM +0530, Vaibhav Hiremath wrote: > > > > > > On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: > > > The mailbox register for usb otg in omap is present in control module. > > > On dete

Re: A question on EHCI unlink code

2012-09-06 Thread Alan Stern
On Thu, 6 Sep 2012, Pavan Kondeti wrote: > Hi > > I am debugging "EHCI host system error" (4.15.2.4) issue. The issue > happens during unlinking of URB from an interface driver. In our system > the device is always connected to the host. some interfaces are always > active (I/O can happen). Other

Re: When enabling usb autosuspend, new usb devices aren't recognized

2012-09-06 Thread Alan Stern
On Thu, 6 Sep 2012, Florian Merz wrote: > Hi, > > To enable usb autosuspend i use the following in a script after booting: > for i in `find /sys/bus/usb/devices/*/power/control`; do echo auto > $i; done; > for i in `find /sys/bus/usb/devices/*/power/autosuspend`; do echo 2 > $i; > done; > > Aft

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Pantelis Antoniou
Hi Felipe I see about __devinit. There's no crash because in those logs the __init modifiers are gone. Regards -- Pantelis On Sep 6, 2012, at 8:07 PM, Felipe Balbi wrote: > Hi, > > On Thu, Sep 06, 2012 at 05:58:27PM +0300, Pantelis Antoniou wrote: >> Hi Felipe, >> >> A proper answer require

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: > Hi Felipe > > I see about __devinit. > There's no crash because in those logs the __init modifiers are gone. it'd be cool to see the crash, though ;-) -- balbi signature.asc Description: Digital signature

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Pantelis Antoniou
On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote: > Hi, > > On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: >> Hi Felipe >> >> I see about __devinit. >> There's no crash because in those logs the __init modifiers are gone. > > it'd be cool to see the crash, though ;-) > > --

Re: create libcomposite, v3

2012-09-06 Thread Sebastian Andrzej Siewior
On Fri, Aug 31, 2012 at 01:39:21PM +0200, Andrzej Pietrasiewicz wrote: > We need a configurable composite gadget in the Tizen platform to > provide sdbd connectivity and mass storage function at the same time. Your argument is pointless because sdbd is not supported by ccg at this time. You could

Re: [PATCH] musb: Kill __init from function that are called at other times as well.

2012-09-06 Thread Felipe Balbi
Hi, On Thu, Sep 06, 2012 at 08:42:56PM +0300, Pantelis Antoniou wrote: > > On Sep 6, 2012, at 8:37 PM, Felipe Balbi wrote: > > > Hi, > > > > On Thu, Sep 06, 2012 at 08:36:39PM +0300, Pantelis Antoniou wrote: > >> Hi Felipe > >> > >> I see about __devinit. > >> There's no crash because in those

Re: changing usbnet's API to better deal with cdc-ncm

2012-09-06 Thread Oliver Neukum
On Friday 07 September 2012 00:09:13 Ming Lei wrote: > On Thu, Sep 6, 2012 at 4:30 PM, Bjørn Mork wrote: > > Ming Lei writes: > >> Looks the introduced .tx_bundle is not necessary since .tx_fixup is OK. > > > > The minidriver does not have any information about tx in progress. The > > Inside .

Re: create libcomposite, v3

2012-09-06 Thread Sebastian Andrzej Siewior
On Tue, Sep 04, 2012 at 03:05:51PM +0200, Marek Szyprowski wrote: > CCG (as well as Android gadget) provides functionality that was not provided > by any of the gadgets before. As You have noticed once, all existing gadget > had static configuration and the only possibility to change configuration

libcomposite, v4

2012-09-06 Thread Sebastian Andrzej Siewior
This is a rebase & respin of the complete two stage series on top of current linus/greg/felipe trees. Patch #1 is new, it adds a note about compatibility issues around ccg in staging. The first few patches still touch ccg because I had to change central gadget code and there was no other sane way.

[PATCH 02/29] usb/gadget: move bind callback into driver struct usb_composite_driver

2012-09-06 Thread Sebastian Andrzej Siewior
It was moved to be an argument in 07a18bd716ed5 ("usb gadget: don't save bind callback in struct usb_composite_driver"). The reason was to avoid the section missmatch. The warning was shown because ->bind is marked as __init becuase it is a one time init. The warning can be also suppresed by whitel

[PATCH 07/29] staging/ccg: include all sourced files

2012-09-06 Thread Sebastian Andrzej Siewior
This Android gadget includes a bunch of .c files. Fixing normal gadgets is not the real problem but this gadget is not always fixable since the problem here are fundumential / design. *I* wanted to get this removed but other people want to keep it even though there were reports that Android itself

[PATCH 03/29] usb/gadget: remove __devexit in f_uac2

2012-09-06 Thread Sebastian Andrzej Siewior
avoids the following section missmatch |WARNING: drivers/usb/gadget/g_audio.o(.init.text+0x2e7): Section |mismatch in reference from the function afunc_bind() to the function |.devexit.text:snd_uac2_remove() |The function __init afunc_bind() references |a function __devexit snd_uac2_remove(). |This

[PATCH 05/29] usb/gadget: move bind() callback back to struct usb_composite_driver

2012-09-06 Thread Sebastian Andrzej Siewior
This partly reverts 07a18bd7 ("usb gadget: don't save bind callback in struct usb_composite_driver") and fixes new drivers. The section missmatch problems was solved by whitelisting structs in question via __ref. Cc: de...@driverdev.osuosl.org Signed-off-by: Sebastian Andrzej Siewior --- drivers

[PATCH 06/29] usb/gadget: move bind() callback back to struct usb_gadget_driver

2012-09-06 Thread Sebastian Andrzej Siewior
This partly reverts 07a18bd7 ("usb gadget: don't save bind callback in struct usb_composite_driver") and fixes new drivers. The section missmatch problems was solved by whitelisting bind callback in modpost. Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/composite.c|3 ++

[PATCH 04/29] usb/gadget: push all usb_composite_driver structs into __refdata

2012-09-06 Thread Sebastian Andrzej Siewior
As it turns out, Sam's comment was better than I initially assumed. This patch pushes as struct usb_composite_driver data structures into __refdata section to avoid a section missmatch report from modpost because the ->bind() can be marked __init. The only downside is that modpost does not check be

[PATCH 08/29] usb/gadget: remove global variable composite in composite.c

2012-09-06 Thread Sebastian Andrzej Siewior
This patch removes the global variable composite in composite.c. The private data which was saved there is now passed via an additional argument to the bind() function in struct usb_gadget_driver. Only the "old-style" UDC drivers have to be touched here, new style are doing it right because this c

[PATCH 01/29] staging/ccg: Add a note about compatibility issues.

2012-09-06 Thread Sebastian Andrzej Siewior
The first item on the todo list is a new user interface. Put this information into Kconfig's help entry to people are not too confusing once an user API changes which does not happen in kernel otherwise. Cc: de...@driverdev.osuosl.org Signed-off-by: Sebastian Andrzej Siewior --- drivers/staging/

[PATCH 09/29] usb/pxa25x: make it compile with debug again

2012-09-06 Thread Sebastian Andrzej Siewior
|drivers/usb/gadget/pxa25x_udc.h: In function 'dump_state': |drivers/usb/gadget/pxa25x_udc.h:228:20: error: invalid type argument of '->' (have 'struct usb_ep') Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/pxa25x_udc.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [BUG] - USB3 bluetooth device not working properly?

2012-09-06 Thread Sarah Sharp
On Thu, Sep 06, 2012 at 04:09:29PM +0200, Miroslav Sabljic wrote: > On 09/06/2012 12:02 AM, Sarah Sharp wrote: > > >I'm actually wondering if you're hitting a bug that is fixed by a patch > >in my queue to send to Greg. Apparently, some BIOSes expect specific > >USB ports on the mobile Panther Po

[PATCH 13/29] usb/libcomposite: add epautoconf.c to libcomposite

2012-09-06 Thread Sebastian Andrzej Siewior
This patch adds epautoconf.c into libcomposite and updates all gadgets. Acked-by: Michal Nazarewicz Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/Makefile |2 +- drivers/usb/gadget/acm_ms.c |1 - drivers/usb/gadget/audio.c |2 +- drivers/us

[PATCH 11/29] usb/libcomposite: move config.c into libcomposite

2012-09-06 Thread Sebastian Andrzej Siewior
This patch moves config.c into libcomposite and updates all gadgets. Acked-by: Michal Nazarewicz Signed-off-by: Sebastian Andrzej Siewior --- drivers/usb/gadget/Makefile |2 +- drivers/usb/gadget/acm_ms.c |1 - drivers/usb/gadget/audio.c |1 - drivers/usb/ga

[PATCH 18/29] usb/gadget: make g_printer enumerate again

2012-09-06 Thread Sebastian Andrzej Siewior
This was broken in 2e87edf49 ("usb: gadget: make g_printer use composite"). The USB-strings were not setup properly and were not used. No function was added which results in an empty USB config. While fixing this, the interface number is now auto generated and not hard coded to 0. Signed-off-by: S

[PATCH 14/29] usb/gadget: move USB_BUFSIZ into global composite.h

2012-09-06 Thread Sebastian Andrzej Siewior
This patch moves USB_BUFSIZ into global header file as USB_COMP_EP0_BUFSIZ. There is currently only one user (f_sourcesink) besides composite which need it. Ideally f_sourcesink would have its own ep0 buffer. Lets keep it that way it was for now. Acked-by: Michal Nazarewicz Signed-off-by: Sebasti

  1   2   >