Re: [PATCHv3] usb: dwc3: use a burst size only ss-mode

2012-08-31 Thread Felipe Balbi
Hi, On Fri, Aug 31, 2012 at 01:42:23PM +0900, Chanho Park wrote: > When connection is established non-ss mode, a maxburst is set to 0. > Therefore, the value of burst size has wrong value. We must use the burst size > only in ss-mode. > > Signed-off-by: Chanho Park > Signed-off-by: Kyungmin Park

[PATCH] staging: remove ccg

2012-08-31 Thread Sebastian Andrzej Siewior
The Android folks are currently using their original gadget and not this. This gadget will be replaced by the configfs based interface. So remove it now. Signed-off-by: Sebastian Andrzej Siewior --- * Benoit Goby | 2012-08-30 15:43:18 [-0700]: >It's ok if it gets removed. Actually we're still us

RE: [PATCHv3] usb: dwc3: use a burst size only ss-mode

2012-08-31 Thread Chanho Park
> -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Friday, August 31, 2012 3:59 PM > To: Chanho Park > Cc: ba...@ti.com; gre...@linuxfoundation.org; linux-usb@vger.kernel.org; > Kyungmin Park > Subject: Re: [PATCHv3] usb: dwc3: use a burst size only ss-mode > > Hi, >

[PATCHv4] usb: dwc3: set up burst size only superspeed mode

2012-08-31 Thread Chanho Park
When connection is established non-ss mode, a maxburst is set to 0. Therefore, the value of burst size has wrong value. We must use the burst size only in superspeed mode. Signed-off-by: Chanho Park Signed-off-by: Kyungmin Park --- drivers/usb/dwc3/gadget.c | 10 -- 1 file changed, 8

RE: create libcomposite, v3

2012-08-31 Thread Andrzej Pietrasiewicz
On Wednesday, August 29, 2012 9:35 PM Sebastian Andrzej Siewior wrote: > > Okay. Dear ccg gadget submitter: Do you still need that code in staging > tree or is it okay if it gets removed? Dear Sebastian, Thank you for asking for my opinion. I would like to say that we need ccg in the tree. It

Re: [PATCH v2 0/5] usb: gadget: s3c2410_udc: Fixes and cleanup

2012-08-31 Thread Felipe Balbi
Hi, On Tue, Aug 28, 2012 at 07:41:49PM +0530, Sachin Kamat wrote: > Hi Felipe, > > Any comments on this series? yes, please give me more time :-) I was waiting to see if someone else would have any comments, as I don't have that HW :-) Also, was trying to wait for v3.6-rc4 before queueing patch

Re: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread Felipe Balbi
Hi, On Thu, Aug 30, 2012 at 03:39:40PM +0400, Sergei Shtylyov wrote: > Hello. > > On 30-08-2012 14:50, Ravi Babu wrote: > > >From: Ajay Kumar Gupta > > >Added device tree data for usbss on am33xx. There are two musb controllers > >on am33xx platform so have port0_mode and port1_mode additional

RE: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread B, Ravi
> On Thu, Aug 30, 2012 at 03:39:40PM +0400, Sergei Shtylyov wrote: > > Hello. > > > > On 30-08-2012 14:50, Ravi Babu wrote: > > > > >From: Ajay Kumar Gupta > > > > >Added device tree data for usbss on am33xx. There are two musb > > >controllers on am33xx platform so have port0_mode and > port

Re: create libcomposite, v3

2012-08-31 Thread Sebastian Andrzej Siewior
On 08/31/2012 11:29 AM, Andrzej Pietrasiewicz wrote: Thank you for asking for my opinion. I would like to say that we need ccg in the tree. It seems that the big change with converting to configfs will not happen within the next two kernel releases, and we still don't know the new framework will

Re: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Aug 30, 2012 at 4:20 PM, Ravi Babu wrote: > From: Ajay Kumar Gupta > > Added device tree data for usbss on am33xx. There are two musb controllers > on am33xx platform so have port0_mode and port1_mode additional data. > > Signed-off-by: Ajay Kumar Gupta > Signed-off-by: Ravi Babu >

Re: create libcomposite, v3

2012-08-31 Thread Felipe Balbi
On Fri, Aug 31, 2012 at 12:04:56PM +0200, Sebastian Andrzej Siewior wrote: > On 08/31/2012 11:29 AM, Andrzej Pietrasiewicz wrote: > >Thank you for asking for my opinion. I would like to say that we need ccg > >in the tree. > > > >It seems that the big change with converting to configfs will not hap

RE: [PATCH v8 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread B, Ravi
> On Thu, Aug 30, 2012 at 4:20 PM, Ravi Babu wrote: > > From: Ajay Kumar Gupta > > > > Added device tree data for usbss on am33xx. There are two musb > > controllers on am33xx platform so have port0_mode and > port1_mode additional data. > > > > Signed-off-by: Ajay Kumar Gupta > > Signed-off

[PATCH v9 11/13] usb: musb: dsps: get the PHY using phandle api

2012-08-31 Thread Ravi Babu
From: Santhapuri, Damodar AM33xx has two PHY of same type used by each musb controller so use phandle of phy nodes to get the phy pointer. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- .../devicetree/bindings/usb/am33xx-usb.txt |2

[PATCH v9 08/13] arm/dts: am33xx: Add dt data for usbss

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- arch/arm/boot/dts/am33xx.dts

[PATCH v9 02/13] usb: musb: dsps: enable phy control for am335x

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta Enabled the phy control logic for am335x also based on usbss revision register. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- arch/arm/plat-omap/include/plat/usb.h |1 + drivers/usb/musb/musb_dsps.c | 17

[PATCH v9 04/13] usb: musb: kill global and static for multi instance

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta Moved global variable "musb_debugfs_root" and static variable "old_state" to 'struct musb' to help support multi instance of musb controller as present on AM335x platform. Also removed the global variable "orig_dma_mask" and filled the dev->dma_mask with parent device's dm

[PATCH v9 10/13] usb: musb: dsps: remove explicit NOP device creation

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta As NOP device node is now added in am33xx tree so remove the call which creates the NOP platform_device. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- drivers/usb/musb/musb_dsps.c |3 +-- 1 files changed, 1 insertio

[PATCH v9 05/13] usb: musb: am335x: add support for dual instance

2012-08-31 Thread Ravi Babu
AM335x and TI81xx platform has dual musb controller so updating the musb_dspc.c to support the same. Changes: - Moved otg_workaround timer to glue structure - Moved static local variable last_timer to glue structure - PHY on/off related cleanups Signed-off-by: Ajay Kumar G

[PATCH v9 03/13] usb: musb: add musb_ida for multi instance support

2012-08-31 Thread Ravi Babu
Added musb_ida in musb_core.c to manage the multi core ids. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- drivers/usb/musb/am35x.c | 42 -- drivers/usb/musb/blackfin.c | 26 --

[PATCH v9 06/13] usb: otg: nop: add support for multiple tranceiver

2012-08-31 Thread Ravi Babu
From: Santhapuri, Damodar Currently we have one single nop transceiver support as same is defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. This need to be changed to support multiple otg controller each using nop transceiver on a platform such as am335x. Signed-off-by: Ajay Kumar

[PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread Ravi Babu
From: Santhapuri, Damodar AM335x uses NOP transceiver driver and need to enable builtin PHY by writing into usb_ctrl register available in system control module register space. This is being added at musb glue driver layer untill a separate system control module driver is available. Signed-off-b

[PATCH v9 00/13] usb: musb: adding multi instance support

2012-08-31 Thread Ravi Babu
This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to g

[PATCH v9 12/13] arm/dts: am33xx: add phy phandle to usbss

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta Added NOP PHY phandle to usbss device node as same will be used to get the phy from otg framework. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- arch/arm/boot/dts/am33xx.dtsi |2 ++ 1 files changed, 2 insertions(+),

[PATCH v9 09/13] arm/dts: am33xx: add dt data for usb nop phy

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta AM33xx has two musb controller and they have one NOP PHY each. Added the device tree data for NOP PHY. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- arch/arm/boot/dts/am33xx.dtsi |8 1 files changed, 8 inse

[PATCH v9 07/13] usb: musb: dsps: add dt support

2012-08-31 Thread Ravi Babu
From: Ajay Kumar Gupta Added device tree support for dsps musb glue driver and updated the Documentation with device tree binding information. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Santhapuri, Damodar Signed-off-by: Ravi Babu --- .../devicetree/bindings/usb/am33xx-usb.txt |

[PATCH v9 13/13] usb: otg: nop: add dt support

2012-08-31 Thread Ravi Babu
Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta Signed-off-by: Ravi Babu --- .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ drivers/usb/otg/nop-usb-xceiv.

RE: create libcomposite, v3

2012-08-31 Thread Andrzej Pietrasiewicz
On Friday, August 31, 2012 12:12 PM Felipe Balbi wrote: > Unless it can be proven that ccg has active users, we should get rid of it > for now before someone starts using it and we need to maintain the ABI for > the next 10 years. We need a configurable composite gadget in the Tizen platform to

Re: create libcomposite, v3

2012-08-31 Thread Felipe Balbi
Hi, On Fri, Aug 31, 2012 at 01:39:21PM +0200, Andrzej Pietrasiewicz wrote: > On Friday, August 31, 2012 12:12 PM Felipe Balbi wrote: > > > > > Unless it can be proven that ccg has active users, we should get rid of it > > for now before someone starts using it and we need to maintain the ABI fo

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread Felipe Balbi
Hi, On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote: > From: Santhapuri, Damodar > > AM335x uses NOP transceiver driver and need to enable builtin PHY > by writing into usb_ctrl register available in system control > module register space. This is being added at musb glue driver > laye

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi wrote: > Hi, > > On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote: >> From: Santhapuri, Damodar >> >> AM335x uses NOP transceiver driver and need to enable builtin PHY >> by writing into usb_ctrl register available in system control >> m

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread Felipe Balbi
On Fri, Aug 31, 2012 at 06:51:04PM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi wrote: > > Hi, > > > > On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote: > >> From: Santhapuri, Damodar > >> > >> AM335x uses NOP transceiver driver and need to

[PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Forest Bond
From: Forest Bond Certain eGalax devices expose an interface with class HID and protocol None. Some work with usbhid and some work with usbtouchscreen, but there is no easy way to differentiate. Sending an eGalax diagnostic packet seems to kick them all into using the right protocol for usbtouc

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 09:56:58AM -0400, Forest Bond wrote: > From: Forest Bond > > Certain eGalax devices expose an interface with class HID and protocol > None. Some work with usbhid and some work with usbtouchscreen, but > there is no easy way to differentiate. Sending an eGalax diagnostic

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread ABRAHAM, KISHON VIJAY
On Fri, Aug 31, 2012 at 6:49 PM, Felipe Balbi wrote: > On Fri, Aug 31, 2012 at 06:51:04PM +0530, ABRAHAM, KISHON VIJAY wrote: >> Hi, >> >> On Fri, Aug 31, 2012 at 5:53 PM, Felipe Balbi wrote: >> > Hi, >> > >> > On Fri, Aug 31, 2012 at 04:39:47PM +0530, Ravi Babu wrote: >> >> From: Santhapuri, Dam

Re: [PATCH v9 01/13] usb: musb: dsps: add phy control logic to glue

2012-08-31 Thread Tony Lindgren
* Ravi Babu [120831 04:10]: > --- a/arch/arm/plat-omap/include/plat/usb.h > +++ b/arch/arm/plat-omap/include/plat/usb.h > @@ -95,7 +95,6 @@ extern void am35x_musb_reset(void); > extern void am35x_musb_phy_power(u8 on); > extern void am35x_musb_clear_irq(void); > extern void am35x_set_mode(u8 mu

Re: [PATCHv3] usb: dwc3: use a burst size only ss-mode

2012-08-31 Thread Sergei Shtylyov
Hello. On 08/31/2012 08:42 AM, Chanho Park wrote: > When connection is established non-ss mode, ^ "in" missing > a maxburst is set to 0. > Therefore, the value of burst size has wrong value. We must use the burst size Value has value? > only in ss-mode. W

[RFC] How to handle delays in isochronous transfers?

2012-08-31 Thread Alan Stern
Clemens and Laurent (and anyone else who's interested): How should the lower USB layers handle delays in transferring isochronous data? I'm asking you because the most common usages of isochronous transfers are for audio and video. Here's an example to illustrate what I mean. Typically an audio

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Sergei Shtylyov
Hello. On 08/31/2012 05:56 PM, Forest Bond wrote: > From: Forest Bond > Certain eGalax devices expose an interface with class HID and protocol > None. Some work with usbhid and some work with usbtouchscreen, but > there is no easy way to differentiate. Sending an eGalax diagnostic > packet se

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 10:50:38PM +0400, Sergei Shtylyov wrote: > Hello. > > On 08/31/2012 05:56 PM, Forest Bond wrote: > > > From: Forest Bond > > > Certain eGalax devices expose an interface with class HID and protocol > > None. Some work with usbhid and some work with usbtouchscreen, but >

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Alan Stern
On Fri, 31 Aug 2012, Dmitry Torokhov wrote: > > > + /* Send a "check active" packet. The response will be read > > > + * later and ignored. */ > > > + ret = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > > > + 0, > > > +

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Forest Bond
Hi, On Fri, Aug 31, 2012 at 04:04:58PM -0400, Alan Stern wrote: > On Fri, 31 Aug 2012, Dmitry Torokhov wrote: > > > > > + /* Send a "check active" packet. The response will be > > > > read > > > > +* later and ignored. */ > > > > + ret = usb_control_ms

Re: [PATCH] net: qmi_wwan: new device: Foxconn/Novatel E396

2012-08-31 Thread David Miller
From: Bjørn Mork Date: Wed, 29 Aug 2012 09:03:34 +0200 > Aleksander Morgado writes: > >> Foxconn-branded Novatel E396, Gobi3k modem. >> >> Cc: Dan Williams >> Cc: Bjørn Mork >> Cc: Ben Chan >> Signed-off-by: Aleksander Morgado ... > If it matters to anyone: > > Acked-by: Bjørn Mork Appl

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Forest Bond
Hi, On Fri, Aug 31, 2012 at 04:04:58PM -0400, Alan Stern wrote: > On Fri, 31 Aug 2012, Dmitry Torokhov wrote: > > > > > + /* Send a "check active" packet. The response will be > > > > read > > > > +* later and ignored. */ > > > > + ret = usb_control_ms

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Dmitry Torokhov
On Fri, Aug 31, 2012 at 06:53:53PM -0400, Forest Bond wrote: > Hi, > > On Fri, Aug 31, 2012 at 04:04:58PM -0400, Alan Stern wrote: > > On Fri, 31 Aug 2012, Dmitry Torokhov wrote: > > > > > > > + /* Send a "check active" packet. The response will be > > > > > read > > > > > +

Re: [PATCH] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Forest Bond
Hi Dmitry, On Fri, Aug 31, 2012 at 04:10:47PM -0700, Dmitry Torokhov wrote: > On Fri, Aug 31, 2012 at 06:53:53PM -0400, Forest Bond wrote: > > Hi, > > > > On Fri, Aug 31, 2012 at 04:04:58PM -0400, Alan Stern wrote: > > > On Fri, 31 Aug 2012, Dmitry Torokhov wrote: > > > > > > > > > + /

[PATCH resend] Input: usbtouchscreen - initialize eGalax devices

2012-08-31 Thread Forest Bond
From: Forest Bond Certain eGalax devices expose an interface with class HID and protocol None. Some work with usbhid and some work with usbtouchscreen, but there is no easy way to differentiate. Sending an eGalax diagnostic packet seems to kick them all into using the right protocol for usbtouc

Re: JMicron 20337 (152d:2338) and 3TB

2012-08-31 Thread Norman Diamond
Robert Hancock wrote: On 05/08/2012 06:12 PM, Norman Diamond wrote: On Wed, 2012/5/9, Alan Stern wrote: On Tue, 8 May 2012, Norman Diamond wrote: Alan Stern wrote: On Tue, 8 May 2012, Norman Diamond wrote: Sometimes I guess a USB-to-[S]ATA bridge might obey ATA passthru of an ATA Identify c