Re: [RFC ebeam PATCH v2 3/3] input: misc: New USB eBeam input driver.

2012-08-13 Thread Jiri Kosina
On Fri, 3 Aug 2012, Yann Cantin wrote: > >> +#include > > > > As this driver is not a HID bus driver, why do you need this include? > > Cinder, removed > > >> +#define DRIVER_VERSION"v0.7" > > > > I don't think we need to be tracking driver versions for newly submitted > > drivers, git i

[BUG Report] BUG: unable to handle kernel NULL pointer dereference at

2012-08-13 Thread Liu Bo
Hi all, I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. When I unplug my mobile usb card, I hit this: [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at (null) [ 247.017378] IP: [] stop_read_write_urbs+0x3f/0x90 [usb_wwan] [ 247.017484] PGD 0

[PATCH 1/1] usb: hcd: mark controller's suspend routine as async

2012-08-13 Thread Peter Chen
Host controller's suspend should be executed later than root hub's, or the hang may occur when root hub try to visit some registers but host controller's suspend close the related clocks. Mark controller's suspend as async can make sure it is executed later than root hub's as host controller is the

Re: [BUG Report] BUG: unable to handle kernel NULL pointer dereference at

2012-08-13 Thread Bjørn Mork
Liu Bo writes: > I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. > > When I unplug my mobile usb card, I hit this: > > [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at > (null) > [ 247.017378] IP: [] stop_read_write_urbs+0x3f/0x90 > [usb_wwan

USB host isochronous transfer broken

2012-08-13 Thread Ruben Jenster
Hi, I need some help debugging a USB transfer problem on my raspberry pi. I know this is not a mainstream kernel issue but I would be glad if someone here can help me understand and debug the problem. The problem is that the DVB Transport stream recorded from a usb DVB stick (cinergy htc stick)

Re: [BUG Report] BUG: unable to handle kernel NULL pointer dereference at

2012-08-13 Thread Liu Bo
On 08/13/2012 06:01 PM, Bjørn Mork wrote: > Liu Bo writes: > >> I'm using mainline upstream 3.6.0-rc1 compiled based on Fedora-16. >> >> When I unplug my mobile usb card, I hit this: >> >> [ 247.017258] BUG: unable to handle kernel NULL pointer dereference at >> (null) >> [ 247.01737

Re: [PATCH net 0/3] qmi_wwan: simplify device matching and add a few new devices

2012-08-13 Thread Bjørn Mork
Bjørn Mork writes: > The home cooked whitelisting code can be removed now that > the USB core supports interface number matching. > > The second patch adds a few new devices. > > The third patch improves device list readability by using > existing macros where possible. > > I hope this can go in

[PATCH RFC] usb: musb: convert the request_irq of NIrq to devm_*

2012-08-13 Thread Shubhrajyoti D
Convert the request_irq to devm_request_irq. Also fixes the case where the in the function musb_init_controller free_irq(called from musb_free) is called before it is allocated. Signed-off-by: Shubhrajyoti D --- drivers/usb/musb/musb_core.c |4 ++-- 1 files changed, 2 insertions(+), 2 deleti

Re: [PATCH 1/1] usb: hcd: mark controller's suspend routine as async

2012-08-13 Thread Alan Stern
On Mon, 13 Aug 2012, Peter Chen wrote: > Host controller's suspend should be executed later than root hub's, > or the hang may occur when root hub try to visit some registers > but host controller's suspend close the related clocks. Have you ever seen this happen? It should not be possible, beca

[PATCH v3] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-08-13 Thread Olivier Sobrie
This driver provides support for several Kvaser CAN/USB devices. Such kind of devices supports up to three CAN network interfaces. It has been tested with a Kvaser USB Leaf Light (one network interface) connected to a pch_can interface. The firmware version of the Kvaser device was 2.5.205. List

Re: DesignWare USB OTG dwc_otg issues with high-speed hubs

2012-08-13 Thread Felipe Balbi
On Sat, Aug 11, 2012 at 12:13:58AM +0400, Paul Fertser wrote: > Hi Felipe, > > On Fri, Aug 10, 2012 at 10:39:52PM +0300, Felipe Balbi wrote: > > On Fri, Aug 10, 2012 at 10:35:20PM +0400, Paul Fertser wrote: > > > I'm using an RT3052F device (DIR-620 SOHO wifi router) with current > > > OpenWrt tru

question concerning finish_port_resume()

2012-08-13 Thread Oliver Neukum
Hi, in finish_port_resume() usb_get_status() is always done and the result evaluated even in the case of reset_resume. Is this efficient? If a device has been reset, remote wakeup must be disabled. Regards Oliver -- To unsubscribe from this list: send the line "unsubscrib

mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Sean Cross
We're trying to get USB host mode working on a Freescale i.MX233. I'm using a chumby hacker board, but there are several people trying on an OlinuXino board as well. We're running into a problem where every time the root hub is detected, it's disconnected. This results in kernel messages such as

Re: Infinite looping in omap2430.c USB driver

2012-08-13 Thread Felipe Balbi
Hi, On Mon, Aug 13, 2012 at 12:34:53PM +1000, NeilBrown wrote: > On Thu, 9 Aug 2012 14:15:51 +0300 Felipe Balbi wrote: > > > > hehe, that's nasty. Please send a patch converting to a try count and a > > udelay_range(), or something. > > > > how's this? > > Thanks, > NeilBrown > > > From: N

Re: USB host isochronous transfer broken

2012-08-13 Thread Greg KH
On Mon, Aug 13, 2012 at 12:01:52PM +0200, Ruben Jenster wrote: > Hi, > > I need some help debugging a USB transfer problem on my raspberry pi. > I know this is not a mainstream kernel issue but I would be glad if someone > here can > help me understand and debug the problem. > > The problem is t

Prolem of setting DeviceRemovable according ACPI information

2012-08-13 Thread Lan, Tianyu
Hi all: I am trying to implement patch of setting DeviceRemovable according ACPI information. The DeviceRemovable is set in hcd driver *_hub_descriptor(e.g ehci_hub_descriptor()). But these functions just have struct usb_hcd or hcd specific struct(e.g struct xhci_hcd) and struct

Re: question concerning finish_port_resume()

2012-08-13 Thread Alan Stern
On Mon, 13 Aug 2012, Oliver Neukum wrote: > Hi, > > in finish_port_resume() usb_get_status() is always done and the result > evaluated even in the case of reset_resume. Is this efficient? If a device > has been reset, remote wakeup must be disabled. Checking the remote wakeup setting is not the

Re: Prolem of setting DeviceRemovable according ACPI information

2012-08-13 Thread Alan Stern
On Mon, 13 Aug 2012, Lan, Tianyu wrote: > Hi all: > I am trying to implement patch of setting DeviceRemovable > according ACPI information. > The DeviceRemovable is set in hcd driver *_hub_descriptor(e.g > ehci_hub_descriptor()). But these > functions just have struct usb_hcd or hc

Re: usbserial issue

2012-08-13 Thread Guilherme Bedin
Hi, I discovered the problem. I am using Openwrt and I was missing the module usb-serial-option. Using it everything works fine. The device modules and parameters are loaded and ttyUSB* are created. Thanks for all the help, Guilherme On Fri, Jul 20, 2012 at 3:47 AM, Bjørn Mork wrote: > Guil

[patch] xhci: Fix a logical vs bitwise AND bug

2012-08-13 Thread Dan Carpenter
The intent was to test whether the flag was set. Signed-off-by: Dan Carpenter diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index c59d5b5..617b0a7 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c @@ -659,7 +659,7 @@ void xhci_shutdown(struct usb_hcd *hcd) {

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Fabio Estevam
On 8/13/12, Sean Cross wrote: > We're trying to get USB host mode working on a Freescale i.MX233. I'm > using > a chumby hacker board, but there are several people trying on an OlinuXino > board as well. We're running into a problem where every time the root hub > is detected, it's disconnected.

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Felipe Balbi
Hi, On Mon, Aug 13, 2012 at 03:04:56PM -0300, Fabio Estevam wrote: > On 8/13/12, Sean Cross wrote: > > We're trying to get USB host mode working on a Freescale i.MX233. I'm > > using > > a chumby hacker board, but there are several people trying on an OlinuXino > > board as well. We're running

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Fabio Estevam
On 8/13/12, Felipe Balbi wrote: > Will there be another version for this or is this final ? Won't this > cause any regressions to other boards ? The proposed patch is not meant to be a final one. We still need to figure out the proper way to handle HOSTDISCONDETECT for all i.mx SoCs, including

Re: Infinite looping in omap2430.c USB driver

2012-08-13 Thread NeilBrown
On Mon, 13 Aug 2012 17:32:34 +0300 Felipe Balbi wrote: > Hi, > > On Mon, Aug 13, 2012 at 12:34:53PM +1000, NeilBrown wrote: > > On Thu, 9 Aug 2012 14:15:51 +0300 Felipe Balbi wrote: > > > > > > > hehe, that's nasty. Please send a patch converting to a try count and a > > > udelay_range(), or

RE: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Chen Peter-B29397
> On 8/13/12, Felipe Balbi wrote: > > > Will there be another version for this or is this final ? Won't this > > cause any regressions to other boards ? > > The proposed patch is not meant to be a final one. > > We still need to figure out the proper way to handle HOSTDISCONDETECT > for all i

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Marek Vasut
Dear Chen Peter-B29397, > > On 8/13/12, Felipe Balbi wrote: > > > Will there be another version for this or is this final ? Won't this > > > cause any regressions to other boards ? > > > > The proposed patch is not meant to be a final one. > > > > We still need to figure out the proper way to h

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Fabio Estevam
Peter, On 8/13/12, Chen Peter-B29397 wrote: > According to IC guys, the logic of handling HOSTDISCONDETECT is the same > between i.mx28 and i.mx23. As pointed out by Sean, on mx23 reference manual we have the following text describing HOSTDISCONDETECT: "Due to a on chip issue (Errata #2791), s

RE: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Chen Peter-B29397
Add IC guy Best regards, Peter Chen > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Tuesday, August 14, 2012 10:01 AM > To: Chen Peter-B29397 > Cc: ba...@ti.com; Sean Cross; linux-usb@vger.kernel.org; Estevam Fabio- > R49496; Zhao Richard-B20223; Shawn Guo;

RE: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Chen Peter-B29397
> > > According to IC guys, the logic of handling HOSTDISCONDETECT is the > same > > between i.mx28 and i.mx23. > > As pointed out by Sean, on mx23 reference manual we have the following > text describing HOSTDISCONDETECT: > > "Due to a on chip issue (Errata #2791), software must > pay attenti

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Richard Zhao
On Tue, Aug 14, 2012 at 10:40:21AM +0800, Chen Peter-B29397 wrote: > > > > > > According to IC guys, the logic of handling HOSTDISCONDETECT is the > > same > > > between i.mx28 and i.mx23. > > > > As pointed out by Sean, on mx23 reference manual we have the following > > text describing HOSTDIS

RE: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Chen Peter-B29397
> > > > > It is the same with i.mx28. > If they're same, imx23 should be ok. The mxs_phy driver pass test > on mx28. > > I think Richard's patch should not > > violate point 2. Richard, can you confirm it? > You mean I should not set the bit in mxs_phy_on_connect? > or mxs_phy_on_connect is calle

RE: [PATCH 1/1] usb: hcd: mark controller's suspend routine as async

2012-08-13 Thread Chen Peter-B29397
> > > Host controller's suspend should be executed later than root hub's, > > or the hang may occur when root hub try to visit some registers > > but host controller's suspend close the related clocks. > > Have you ever seen this happen? It should not be possible, because the > PM core is care

Re: mxs-phy on i.MX233 not enumerating

2012-08-13 Thread Richard Zhao
On Tue, Aug 14, 2012 at 11:11:53AM +0800, Chen Peter-B29397 wrote: > > > > > > > > It is the same with i.mx28. > > If they're same, imx23 should be ok. The mxs_phy driver pass test > > on mx28. > > > I think Richard's patch should not > > > violate point 2. Richard, can you confirm it? > > You me

Re: USB host isochronous transfer broken

2012-08-13 Thread Ruben Jenster
Hi Greg, thanks for your answer. On Aug 13, 2012, at 4:42 PM, Greg KH wrote: > > After reading the code for the USB host driver for this hardware, and > reading the hardware data sheet, I'm amazed that any USB devices work on > this platform :) You really did this? I think it would take me a f

[PATCH 3/5] drivers/usb/wusbcore/wa-hc.c: fix error return code

2012-08-13 Thread Julia Lawall
From: Julia Lawall Convert a 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret != 0\|ret

[PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code

2012-08-13 Thread Julia Lawall
From: Julia Lawall Convert a possibly 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret !

[PATCH 1/5] drivers/usb/gadget/s3c-hsotg.c: fix error return code

2012-08-13 Thread Julia Lawall
From: Julia Lawall Convert a 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret != 0\|ret

[PATCH 4/5] drivers/usb/host/ohci-platform.c: fix error return code

2012-08-13 Thread Julia Lawall
From: Julia Lawall Convert a possibly 0 error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e,e1,e2,e3,e4,x; @@ ( if (\(ret !