[PATCH v2] USB: ohci-pxa27x: add DT bindings

2012-07-30 Thread Daniel Mack
Add DT bindings to the ohci-pxa27x driver and some documentation. Successfully tested on a PXA3xx board. Signed-off-by: Daniel Mack --- Changes from v1: - renamed "mrvl" to "marvell" Greg, I think that would best go through your usb tree. Is that ok? Documentation/devicetree/bindings/usb/px

USB 3.0 ports drops when using usb3 external hard drive dock.

2012-07-30 Thread Johannes Ylönen
Problem is that, when I try to move files from usb3 hard drive dock to laptop, all usb ports drops (all external ports are usb3). How to reproduce bug: 1. When connecting hard drive dock everything is well, here is log: Jul 28 10:21:49 localhost kernel: [ 520.002851] usb 4-1: new SuperSpeed USB

Re: [PATCH v2] USB: ohci-pxa27x: add DT bindings

2012-07-30 Thread Daniel Mack
(Cc Greg) On 30.07.2012 09:29, Daniel Mack wrote: > Add DT bindings to the ohci-pxa27x driver and some documentation. > > Successfully tested on a PXA3xx board. > > Signed-off-by: Daniel Mack > --- > Changes from v1: > - renamed "mrvl" to "marvell" > > Greg, I think that would best go through

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 11:34:10 Lan Tianyu wrote: > The hub is always supposed to support reset and its persist is enabled. By default, not necessarily always. User space may disable it. > So hub doesn't need attribute avoid_reset_quirk. The patch is to take > attribute avoid_reset_quirk out of u

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 11:34:11 Lan Tianyu wrote: > --- a/drivers/usb/core/sysfs.c > +++ b/drivers/usb/core/sysfs.c > @@ -209,10 +209,13 @@ set_avoid_reset_quirk(struct device *dev, struct > device_attribute *attr, > if (sscanf(buf, "%d", &val) != 1 || val < 0 || val > 1) >

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Lan Tianyu
On 2012年07月30日 15:24, Oliver Neukum wrote: On Monday 30 July 2012 11:34:11 Lan Tianyu wrote: --- a/drivers/usb/core/sysfs.c +++ b/drivers/usb/core/sysfs.c @@ -209,10 +209,13 @@ set_avoid_reset_quirk(struct device *dev, struct device_attribute *attr, if (sscanf(buf, "%d",&val) != 1 || v

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread Bjørn Mork
Huang Ying writes: > Do you have time to test the following patch to fix the lspci issue? > > Subject: [BUGFIX] PCI/PM: Keep parent bridge active when read/write config reg Sure. But keep this going and I will file a request for modular build of the PCI subsystem :-) The patch works fine for

Re: [PATCH 1/3] usb: Rename temp variable "config" to "val" in the set_avoid_reset_quirk()

2012-07-30 Thread Bjørn Mork
Lan Tianyu writes: > - if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1) > + if (sscanf(buf, "%d", &val) != 1 || val < 0 || val > 1) > return -EINVAL; Not directly related to this patch, but a question I started wondering about recently: Is there some generi

Re: [PATCH] Add Etron XHCI quirk to avoid warning spam

2012-07-30 Thread Daniel J Blueman
On 28 July 2012 01:10, Sarah Sharp wrote: > On Fri, Jul 27, 2012 at 02:40:56PM +0800, Daniel J Blueman wrote: >> On 27 July 2012 14:14, Sarah Sharp wrote: >> > On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote: >> >> When various USB3 devices with Etron XHCI controllers, we see a b

[PATCH v6 06/11] arm/dts: Add twl6030-usb data

2012-07-30 Thread Kishon Vijay Abraham I
Add twl6030-usb data node in twl6030 device tree file Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4-panda.dts |4 arch/arm/boot/dts/omap4-sdp.dts |4 arch/arm/boot/dts/twl6030.dtsi|5 + 3 files changed, 13 insertions(+) diff --git a/arch/arm/b

[PATCH v6 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-07-30 Thread Kishon Vijay Abraham I
The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to control module, omap2430 will handle the register writes to

[PATCH v6 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-30 Thread Kishon Vijay Abraham I
All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap_phy_internal.c | 138 --- arch/arm/

[PATCH v6 00/11] omap: musb: Add device tree support

2012-07-30 Thread Kishon Vijay Abraham I
This patch series adds device tree support for MUSB and device tree support for all the related modules to get MUSB working in OMAP platform. A new omap-usb2 phy driver has been added (with only dt suppport) to perform phy configurations. Previously this configuration was performed by twl6030, usi

[PATCH v6 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-30 Thread Kishon Vijay Abraham I
Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 29c6243..15f1890 100644 --- a/arch/arm/boot/dts/

[PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Kishon Vijay Abraham I
All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for usb2 phy driver and the documentation with device tree binding information is

[PATCH v6 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-30 Thread Kishon Vijay Abraham I
Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt | 34 +++- drivers/usb/musb/omap2430.c| 54 +

[PATCH v6 08/11] arm/dts: Add twl4030-usb data

2012-07-30 Thread Kishon Vijay Abraham I
Add twl4030-usb data node in twl4030 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/twl4030.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi index 22f4d13..761a5a5 1006

[PATCH v6 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-30 Thread Kishon Vijay Abraham I
Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3-beagle.dts |6 ++ arch/arm/boot/dts/omap3-evm.dts|6 ++ arch/arm/boot/dts/omap3.dtsi

[PATCH v6 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-30 Thread Kishon Vijay Abraham I
Add device tree support for twl4030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 ++ drivers/usb/otg/twl4030-usb.c | 26 +++

[PATCH v6 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-07-30 Thread Kishon Vijay Abraham I
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Writing to control module which is now handled in omap2430.c should be

[PATCH v6 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-30 Thread Kishon Vijay Abraham I
Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 21 +++ drivers/usb/otg/twl6030-usb.c | 39 +-

Re: [PATCH 00/12] chipidea/imx: add otg support and some bug fix

2012-07-30 Thread Richard Zhao
On Thu, Jul 26, 2012 at 06:59:48PM +0800, Richard Zhao wrote: > On Thu, Jul 19, 2012 at 10:05:54AM +0800, Richard Zhao wrote: > > On Mon, Jul 16, 2012 at 05:40:57PM -0700, Greg KH wrote: > > > On Thu, Jul 12, 2012 at 03:01:40PM +0800, Richard Zhao wrote: > > > > The patch set is tested on imx6q_sab

Re: [PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-30 Thread Sascha Hauer
On Thu, Jul 26, 2012 at 06:35:14PM +0800, Richard Zhao wrote: > i.MX usb controllers shares non-core registers, which may include > SoC specific controls. We take it as a usbmisc device and usbmisc > driver set operations needed by ci13xxx_imx driver. > > For example, Sabrelite board has bad over-

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: > + writel(~PHY_PD, phy->control_dev); > + /* XXX: add proper documentation for this delay */ > + mdelay(200); Do you need this to be busy? -- To unsubscribe from this list: se

Re: [PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-30 Thread Richard Zhao
On Mon, Jul 30, 2012 at 11:32:44AM +0200, Sascha Hauer wrote: > On Thu, Jul 26, 2012 at 06:35:14PM +0800, Richard Zhao wrote: > > i.MX usb controllers shares non-core registers, which may include > > SoC specific controls. We take it as a usbmisc device and usbmisc > > driver set operations needed

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: > On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >> + writel(~PHY_PD, phy->control_dev); >> + /* XXX: add proper documentation for this delay */ >> + mdelay(200); >

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 15:58:25 Lan Tianyu wrote: > On 2012年07月30日 15:24, Oliver Neukum wrote: > > this is on second thought quite problematic. If user space has > > disabled the persist feature it must stay disabled, even if > > the quirk setting is removed. > Yeah. You are right. So how about re

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread Shubhrajyoti
On Monday 30 July 2012 03:16 PM, ABRAHAM, KISHON VIJAY wrote: > Hi, > > On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: >> On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >>> + writel(~PHY_PD, phy->control_dev); >>> + /* XXX: add proper d

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-30 Thread Ido Shayevitz
Hi Paul, On Thu, July 26, 2012 4:38 pm, Paul Zimmerman wrote: >> From: linux-usb-ow...@vger.kernel.org >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Ido Shayevitz >> Sent: Wednesday, July 25, 2012 5:46 AM >> >> This is first release of otg driver for the dwc3 Synopsys USB3 core. >> The

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-30 Thread Ido Shayevitz
Hi Anton, On Sun, July 29, 2012 7:10 pm, Anton Tikhomirov wrote: > Hi Ido, > > Some more comments. > >> -Original Message- >> From: Ido Shayevitz [mailto:i...@codeaurora.org] >> Sent: Sunday, July 29, 2012 9:55 PM >> To: Anton Tikhomirov >> Subject: RE: [RFC/PATCH v3] usb: dwc3: Introduce

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-30 Thread Anton Tikhomirov
Hi Ido, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Ido Shayevitz > Sent: Monday, July 30, 2012 7:53 PM > To: Anton Tikhomirov > Cc: 'Ido Shayevitz'; 'Felipe Balbi'; linux-usb@vger.kernel.org > Subject: RE: [RFC/PATC

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-30 Thread Ido Shayevitz
Hi Anton, On Mon, July 30, 2012 5:25 am, Anton Tikhomirov wrote: > Hi Ido, > >> > >> > You activate sm only if gadget and host are ready. At the same time, >> > in dwc3_otg_interrupt() you schedule work if interrupt happens. In >> > situation >> > when host is not set yet, but cable is plugged, we

Re: [PATCH] isp1362-hcd.c: usb message always saved in case of underrun

2012-07-30 Thread Claudio Scordino
Il 20/07/2012 17:15, Greg KH ha scritto: On Fri, Jul 20, 2012 at 12:26:10PM +0200, Claudio Scordino wrote: Il 20/07/2012 00:58, Greg KH ha scritto: On Wed, Jul 18, 2012 at 10:53:09AM +0200, Claudio Scordino wrote: Il 06/07/2012 19:41, Greg KH ha scritto: On Wed, Jun 27, 2012 at 06:01:39PM +02

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread huang ying
On Mon, Jul 30, 2012 at 4:08 PM, Bjørn Mork wrote: > Huang Ying writes: > >> Do you have time to test the following patch to fix the lspci issue? >> >> Subject: [BUGFIX] PCI/PM: Keep parent bridge active when read/write config >> reg > > > Sure. But keep this going and I will file a request for

Re: [PATCH] usb: serial: mos7840: Avoid kfree() on bad pointer

2012-07-30 Thread Sergei Shtylyov
Hello. On 07/24/2012 11:17 PM, Mark Ferrell wrote: > * mos7840_startup() blindly calls kfree() on memory that may have never been > allocated. Callling kfree() on NULL pointers is valid. > Signed-off-by: Mark Ferrell WBR, Sergei -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Lan Tianyu wrote: > The hub is always supposed to support reset and its persist is enabled. > So hub doesn't need attribute avoid_reset_quirk. The patch is to take > attribute avoid_reset_quirk out of usb device's attribute group and > add or remove it in the usb_create/remove

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Huang Ying wrote: > > Yup, that worked in the quick test I just did. > > > > lspci reading the device config will still not wake the bridge, but I > > assume that is intentional? But loading the device driver now wakes > > both the bridge and the device, so that works. > >

Re: [PATCH 1/3] usb: Rename temp variable "config" to "val" in the set_avoid_reset_quirk()

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Lan Tianyu wrote: > In USB, the word "config" already has a separate meaning. So it will > cause confusion if use "config" as variable's name for other purposes. > This patch is to convert the "config" to "val" > > Signed-off-by: Lan Tianyu Acked-by: Alan Stern -- To uns

Re: [PATCH 1/3] usb: Rename temp variable "config" to "val" in the set_avoid_reset_quirk()

2012-07-30 Thread Michal Nazarewicz
On Mon, 30 Jul 2012 10:33:27 +0200, Bjørn Mork wrote: Lan Tianyu writes: Not directly related to this patch, but a question I started wondering about recently: Is there some generic guideline wrt parsing boolean flags in sysfs? If not, shouldn't there be? I see a lot of different approaches

[PATCH]staging: usbip: Fix typos.

2012-07-30 Thread Justin P. Mattock
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: usbip drivers/staging/usbip/stub_rx.c |2 +- drivers/staging/usbip/vhci_hcd.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drive

Re: [RFC ebeam PATCH 3/3] input: misc: New USB eBeam input driver.

2012-07-30 Thread Yann Cantin
Hi, >> The code structure (device selector + functions indirection) also seems >> overkill >> to me for now, but permit to anticipate device's variations. If it appears >> that they >> all works in the same way, it'll be easy (and more comfortable to me) to >> step down, >> the opposite seems m

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Lan Tianyu wrote: > The attribute avoid_reset_quirk means the device should not be reset. > when it is set, persist_enabled also should be set to 0 to prevent > reset-resume when the device resumes. > > Current only in the usb_detect_quirks(), persist_enabled will > be set de

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Oliver Neukum wrote: > On Monday 30 July 2012 11:34:10 Lan Tianyu wrote: > > The hub is always supposed to support reset and its persist is enabled. > > By default, not necessarily always. User space may disable it. No -- necessarily always. Userspace cannot disable it. Th

Re: [PATCH 1/3] usb: Rename temp variable "config" to "val" in the set_avoid_reset_quirk()

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Bjørn Mork wrote: > Lan Tianyu writes: > > > - if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1) > > + if (sscanf(buf, "%d", &val) != 1 || val < 0 || val > 1) > > return -EINVAL; > > Not directly related to this patch, but a question I started

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Oliver Neukum wrote: > On Monday 30 July 2012 15:58:25 Lan Tianyu wrote: > > On 2012年07月30日 15:24, Oliver Neukum wrote: > > > > this is on second thought quite problematic. If user space has > > > disabled the persist feature it must stay disabled, even if > > > the quirk set

[PATCH 7/7] drivers/usb/host/ehci-xilinx-of.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

[PATCH 5/7] drivers/usb/host/ehci-tegra.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

[PATCH 1/7] drivers/usb/host/ehci-ppc-of.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

[PATCH 2/7] drivers/usb/host/ehci-s5p.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

[PATCH 3/7] drivers/usb/host/ehci-sead3.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

[PATCH 4/7] drivers/usb/host/ehci-sh.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

[PATCH 6/7] drivers/usb/host/ehci-vt8500.c: use devm_ functions

2012-07-30 Thread Julia Lawall
From: Julia Lawall The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Signed-off-by: Julia Lawall --- Not compiled

Re: [PATCH 1/9] drivers/usb/host/ehci-atmel.c: use devm_ functions

2012-07-30 Thread Alan Stern
On Sun, 29 Jul 2012, Julia Lawall wrote: > From: Julia Lawall > > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > func

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 10:39:50 Alan Stern wrote: > > this leads to behavior that is not easy to predict or understand. > > It would be cleaner to leave the flag alone and check for the quirk > > in addition for the flag when the check is done. > > I disagree. Leaving the flag set but then not im

[PATCH] USB: echi-dbgp: increase the controller wait time to come out of halt.

2012-07-30 Thread Colin Ian King
The default 10 microsecond delay for the controller to come out of halt in dbgp_ehci_startup is too short, so increase it to 1 millisecond. This is based on emperical testing on various USB debug ports on modern machines such as a Lenovo X220i and an Ivybridge development platform that needed to w

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Oliver Neukum wrote: > On Monday 30 July 2012 10:39:50 Alan Stern wrote: > > > this leads to behavior that is not easy to predict or understand. > > > It would be cleaner to leave the flag alone and check for the quirk > > > in addition for the flag when the check is done. > >

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 11:16:12 Alan Stern wrote: > As you say, coupling the two attributes is confusing and circumvents > the permissions. If the device needs a reset-resume, we'll go ahead > and try to do it. If the reset fails because the firmware gets erased, > at least there will be an error

Re: [PATCH 00/12] chipidea/imx: add otg support and some bug fix

2012-07-30 Thread Greg KH
On Mon, Jul 30, 2012 at 05:17:58PM +0800, Richard Zhao wrote: > On Thu, Jul 26, 2012 at 06:59:48PM +0800, Richard Zhao wrote: > > On Thu, Jul 19, 2012 at 10:05:54AM +0800, Richard Zhao wrote: > > > On Mon, Jul 16, 2012 at 05:40:57PM -0700, Greg KH wrote: > > > > On Thu, Jul 12, 2012 at 03:01:40PM +

[PATCH RESEND] [RFC] usb:gadget: Refcount for gadget pullup

2012-07-30 Thread Lukasz Majewski
This commit fixes the way gadget's pullup method (wrapped at usb_gadget_connect/disconnect) is called in the udc-core. The composite driver allows correct driver registration, even when it calls the usb_gadget_disconnect method (composite driver configuration is defered for user space - please lo

Re: [PATCH 1/3] usb: Rename temp variable "config" to "val" in the set_avoid_reset_quirk()

2012-07-30 Thread Greg KH
On Mon, Jul 30, 2012 at 10:33:27AM +0200, Bjørn Mork wrote: > Lan Tianyu writes: > > > - if (sscanf(buf, "%d", &config) != 1 || config < 0 || config > 1) > > + if (sscanf(buf, "%d", &val) != 1 || val < 0 || val > 1) > > return -EINVAL; > > Not directly related to this patch, but

Re: [PATCH]staging: usbip: Fix typos.

2012-07-30 Thread Sergei Shtylyov
Hello. On 07/30/2012 06:23 PM, Justin P. Mattock wrote: > From: "Justin P. Mattock" > Signed-off-by: Justin P. Mattock > --- > The below patch fixes typos found while reading through staging: usbip Unfortunately, it introduces some new instead. :-) > diff --git a/drivers/staging/usbip/v

Re: [PATCH 5/7] drivers/usb/host/ehci-tegra.c: use devm_ functions

2012-07-30 Thread Stephen Warren
On 07/30/2012 08:43 AM, Julia Lawall wrote: > From: Julia Lawall > > The various devm_ functions allocate memory that is released when a driver > detaches. This patch uses these functions for data that is allocated in > the probe function of a platform device and is only freed in the remove > fu

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread Bjørn Mork
huang ying writes: > On Mon, Jul 30, 2012 at 4:08 PM, Bjørn Mork wrote: >> Huang Ying writes: >> >>> Do you have time to test the following patch to fix the lspci issue? >>> >>> Subject: [BUGFIX] PCI/PM: Keep parent bridge active when read/write config >>> reg >> >> >> Sure. But keep this goi

Re: [PATCH v2] USB: ohci-pxa27x: add DT bindings

2012-07-30 Thread Greg KH
On Mon, Jul 30, 2012 at 09:29:12AM +0200, Daniel Mack wrote: > Add DT bindings to the ohci-pxa27x driver and some documentation. > > Successfully tested on a PXA3xx board. > > Signed-off-by: Daniel Mack > --- > Changes from v1: > - renamed "mrvl" to "marvell" > > Greg, I think that would best

Re: [PATCH v2] USB: ohci-pxa27x: add DT bindings

2012-07-30 Thread Daniel Mack
On 30.07.2012 19:05, Greg KH wrote: > On Mon, Jul 30, 2012 at 09:29:12AM +0200, Daniel Mack wrote: >> Add DT bindings to the ohci-pxa27x driver and some documentation. >> >> Successfully tested on a PXA3xx board. >> >> Signed-off-by: Daniel Mack >> --- >> Changes from v1: >> - renamed "mrvl" to "

Re: [PATCH 1/3] usb: musb: drop useless board_mode usage

2012-07-30 Thread Sergei Shtylyov
Hello. On 11/24/2011 09:59 PM, Sergei Shtylyov wrote: >> we are compiling the driver always with full OTG >> capabilities, so that board_mode trick becomes >> useless. >> Signed-off-by: Felipe Balbi >> --- >> I would like to get Acks from blackfin, da8xx and davinci guys, please. >After ha

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-30 Thread Paul Zimmerman
> From: Ido Shayevitz [mailto:i...@codeaurora.org] > Sent: Monday, July 30, 2012 3:15 AM > > On Thu, July 26, 2012 4:38 pm, Paul Zimmerman wrote: > >> From: linux-usb-ow...@vger.kernel.org > >> [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Ido Shayevitz > >> Sent: Wednesday, July 25, 2012

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Sarah Sharp
On Mon, Jul 30, 2012 at 09:28:36AM +0200, Oliver Neukum wrote: > On Monday 30 July 2012 11:34:10 Lan Tianyu wrote: > > The hub is always supposed to support reset and its persist is enabled. > > By default, not necessarily always. User space may disable it. > > > So hub doesn't need attribute avo

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 13:00:18 Sarah Sharp wrote: > So far, the discussion on the mailing list seems to boil down to: > > Issues > -- > > - We need to issue a reset resume for all suspended devices that have >been powered off. > > - We can't power off ports with connected devices tha

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Bjørn Mork
Sarah Sharp writes: > On Mon, Jul 30, 2012 at 09:28:36AM +0200, Oliver Neukum wrote: >> On Monday 30 July 2012 11:34:10 Lan Tianyu wrote: >> > The hub is always supposed to support reset and its persist is enabled. >> >> By default, not necessarily always. User space may disable it. >> >> > So h

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 22:35:37 Bjørn Mork wrote: > Sarah Sharp writes: > > On Mon, Jul 30, 2012 at 09:28:36AM +0200, Oliver Neukum wrote: > > - We need to issue a reset resume for all suspended devices that have > >been powered off. > > > > - We can't power off ports with connected devices

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Sarah Sharp wrote: > So far, the discussion on the mailing list seems to boil down to: > > Issues > -- > > - We need to issue a reset resume for all suspended devices that have >been powered off. > > - We can't power off ports with connected devices that require f

Re: usb scheduler

2012-07-30 Thread Alan Stern
On Mon, 30 Jul 2012, Alexey Filin wrote: > > Yes, something like it might work, I think. But you probably wouldn't > > want to use URBs for this; they have too much overhead. You'd need a > > more direct interface to the host controller driver. > > really, too much, about 7 us on my pc (Core2 D

Re: [PATCH] usb: host: xhci: Compliance Mode port recovery

2012-07-30 Thread 'Greg KH'
On Mon, Jul 30, 2012 at 03:22:52PM -0500, Alexis Cortes wrote: > Hi Greg, > > I'm sorry for my late response on this. First of all thanks for your reply > and your feedback :) > > We have been discussing with one of our major customers the possibility of > identifying the platforms with the fail

Re: usb scheduler

2012-07-30 Thread Alexey Filin
On Tue, Jul 31, 2012 at 1:08 AM, Alan Stern wrote: > On Mon, 30 Jul 2012, Alexey Filin wrote: > >> > Yes, something like it might work, I think. But you probably wouldn't >> > want to use URBs for this; they have too much overhead. You'd need a >> > more direct interface to the host controller d

Re: [PATCH v6 00/14] add imx usb driver based on Greg next tree

2012-07-30 Thread Fabio Estevam
On Mon, Jun 25, 2012 at 11:37 PM, Shawn Guo wrote: > On Mon, Jun 25, 2012 at 01:18:22PM -0300, Fabio Estevam wrote: >> Any suggestions as to how to make the driver work on mx23? >> > I won't be able to test it on my imx23-evk board, because the board > design is somehow odd on vbus supply, which p

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-30 Thread Sarah Sharp
Hi Denis, Can you send me the output of `sudo dmidecode`? I'd like to see if I can make a more general patch apply to the Intense-PC. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread Huang Ying
On Mon, 2012-07-30 at 18:57 +0200, Bjørn Mork wrote: > huang ying writes: > > > On Mon, Jul 30, 2012 at 4:08 PM, Bjørn Mork wrote: > >> Huang Ying writes: > >> > >>> Do you have time to test the following patch to fix the lspci issue? > >>> > >>> Subject: [BUGFIX] PCI/PM: Keep parent bridge act

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread Huang Ying
On Mon, 2012-07-30 at 10:19 -0400, Alan Stern wrote: > On Mon, 30 Jul 2012, Huang Ying wrote: > > > > Yup, that worked in the quick test I just did. > > > > > > lspci reading the device config will still not wake the bridge, but I > > > assume that is intentional? But loading the device driver

[PATCH V2 0/2] UVC webcam gadget related changes

2012-07-30 Thread Bhupesh Sharma
This patchset tries to handle all the review comments received on the following UVC gadget related patches: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework [PATCH 5/5] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) com

[PATCH V2 1/2] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2012-07-30 Thread Bhupesh Sharma
This patch reworks the videobuffer management logic present in the UVC webcam gadget and ports it to use the "more apt" videobuf2 framework for video buffer management. To support routing video data captured from a real V4L2 video capture device with a "zero copy" operation on videobuffers (as the

[PATCH V2 2/2] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) command

2012-07-30 Thread Bhupesh Sharma
This patch adds the support in UVC webcam gadget design for providing USB_GADGET_DELAYED_STATUS in response to a set_interface(alt setting 1) command issue by the Host. The current UVC webcam gadget design generates a STREAMON event corresponding to a set_interface(alt setting 1) command from the

RE: [PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-30 Thread Chen Peter-B29397
> > > > <&usbmisc 0> would then mean port 0 of the usbmisc device. > I didn't add the restriction that a usbmisc driver must have a usbmisc > device. I'm not sure whether all SoC and future SoC can be look as > a device. > > Peter, do you have any idea? > I have not followed this usbmisc design

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-30 Thread Huang Ying
On Mon, 2012-07-30 at 10:19 -0400, Alan Stern wrote: > On Mon, 30 Jul 2012, Huang Ying wrote: > > > > Yup, that worked in the quick test I just did. > > > > > > lspci reading the device config will still not wake the bridge, but I > > > assume that is intentional? But loading the device driver

Re: [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC.

2012-07-30 Thread Oliver Neukum
On Monday 30 July 2012 15:34:06 Sarah Sharp wrote: > Hi Denis, > > Can you send me the output of `sudo dmidecode`? I'd like to see if I > can make a more general patch apply to the Intense-PC. As this is for shutdown, why not all systems? Regards Oliver -- To unsubscrib

[PATCH] usb: host: ehci-platform: add pm_runtime_xx()

2012-07-30 Thread Kuninori Morimoto
this patch enable to use pm_runtime_xxx() on ehci-platform if .config has CONFIG_PM_RUNTIME, otherwise, these are ignored Signed-off-by: Kuninori Morimoto --- drivers/usb/host/ehci-platform.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-plat

[PATCH] usb: host: ohci-platform: add pm_runtime_xx()

2012-07-30 Thread Kuninori Morimoto
this patch enable to use pm_runtime_xxx() on ohci-platform if .config has CONFIG_PM_RUNTIME, otherwise, these are ignored Signed-off-by: Kuninori Morimoto --- drivers/usb/host/ohci-platform.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ohci-plat

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-30 Thread Matthew Hall
On Thu, Jul 26, 2012 at 11:36:44PM -0700, Matthew Hall wrote: > On Thu, Jul 26, 2012 at 11:27:47PM -0700, Sarah Sharp wrote: > > Man, I hope my code hasn't eaten your disk. Is there any chance you > > could replace the drive in the enclosure and create a new file system to > > test? > > This part

Re: [PATCH 3/3] usb: Change persist_enabled when attribute avoid_reset_quirk is modified

2012-07-30 Thread Lan Tianyu
On 2012年07月30日 23:16, Alan Stern wrote: On Mon, 30 Jul 2012, Oliver Neukum wrote: On Monday 30 July 2012 10:39:50 Alan Stern wrote: this leads to behavior that is not easy to predict or understand. It would be cleaner to leave the flag alone and check for the quirk in addition for the flag whe

Re: [PATCH 2/3] usb: Take attribute avoid_reset_quirk out of usb device's attribute group

2012-07-30 Thread Lan Tianyu
On 2012年07月31日 04:00, Sarah Sharp wrote: On Mon, Jul 30, 2012 at 09:28:36AM +0200, Oliver Neukum wrote: On Monday 30 July 2012 11:34:10 Lan Tianyu wrote: The hub is always supposed to support reset and its persist is enabled. By default, not necessarily always. User space may disable it. So