Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Felipe Balbi
Hi, On Wed, Jul 25, 2012 at 09:10:49PM +, Paul Zimmerman wrote: > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > Sent: Wednesday, July 25, 2012 2:03 PM > > > > On Wed, 25 Jul 2012, Paul Zimmerman wrote: > > > > > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > > > Sent:

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Felipe Balbi
Hi, On Wed, Jul 25, 2012 at 02:53:00PM +0200, Rajaram REGUPATHY wrote: > The short_not_ok field is used by class drivers to indicate udc whether short > packet is expected during a particular transfer. > In case of mass storage, during command and status phase this field is set as > false and se

Re: [PATCH] usb:musb: Fix for Full Speed issue

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 08:03:11AM +0200, Ajay M JAWADE wrote: > After sending the USB Bus reset, Host waits for High Speed Chirps. > If the soft-disconnect and soft-connect happens during this chirp time, > then Host doesn't detect this disconnect. > Host treats this as Full Speed Device as t

Re: [PATCH v5 03/11] usb: musb: am335x: add support for dual instance

2012-07-26 Thread Felipe Balbi
On Wed, Jul 25, 2012 at 05:37:21PM +0530, Ajay Kumar Gupta wrote: > AM335x and TI81xx platform has dual musb controller so updating the > musb_dspc.c to support the same. > > Changes: > - Moved otg_workaround timer to glue structure > - Moved static local variable last_timer to glue st

Re: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Felipe Balbi
Hi, On Wed, Jul 25, 2012 at 05:37:22PM +0530, Ajay Kumar Gupta wrote: > diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c > index 01203eb..eb6220f 100644 > --- a/drivers/usb/musb/am35x.c > +++ b/drivers/usb/musb/am35x.c > @@ -364,7 +364,7 @@ static int am35x_musb_init(struct musb *m

Re: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Felipe Balbi
Hi, On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb *musb) > struct dentry *root; > struct dentry *file; > int ret; > + charname[1

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 01:23:01AM +0200, Laurent Pinchart wrote: > Hi Bhupesh, > > On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote: > > On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote: > > > On Wednesday 25 July 2012 15:06:37 Bhupesh SHARMA wrote: > > > > > > [snip] > > >

RE: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Gupta, Ajay Kumar
Hi > On Wed, Jul 25, 2012 at 05:37:22PM +0530, Ajay Kumar Gupta wrote: > > diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c > > index 01203eb..eb6220f 100644 > > --- a/drivers/usb/musb/am35x.c > > +++ b/drivers/usb/musb/am35x.c > > @@ -364,7 +364,7 @@ static int am35x_musb_init(stru

RE: [PATCH v5 03/11] usb: musb: am335x: add support for dual instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 05:37:21PM +0530, Ajay Kumar Gupta wrote: > > AM335x and TI81xx platform has dual musb controller so updating the > > musb_dspc.c to support the same. > > > > Changes: > > - Moved otg_workaround timer to glue structure > > - Moved static local variable last_tim

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb *musb) > > struct dentry *root; > > struct dentry *file; > > int ret; > > + charnam

Re: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote: > > > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > > > data->set_phy_power(0); > > > > > > usb_put_phy(musb->xceiv); > > > - usb_nop_xceiv_unregister(); > > > + usb_nop_xceiv_unregister(musb->

Re: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Felipe Balbi
On Thu, Jul 26, 2012 at 08:25:32AM +, Gupta, Ajay Kumar wrote: > Hi, > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb *musb) > > > struct dentry *root; > > > struct dentry *file;

RE: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote: > > > > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > > > > data->set_phy_power(0); > > > > > > > > usb_put_phy(musb->xceiv); > > > > - usb_nop_xceiv_unregister(); > > > > +

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb > *musb) > > > > struct dentry *root; > > > > struct dentry *file; > > > > int ret; >

Re: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Felipe Balbi
On Thu, Jul 26, 2012 at 08:29:06AM +, Gupta, Ajay Kumar wrote: > Hi, > > On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote: > > > > > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > > > > > data->set_phy_power(0); > > > > > > > > > > usb_p

RE: [PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 26, 2012 at 08:29:06AM +, Gupta, Ajay Kumar wrote: > > Hi, > > > On Thu, Jul 26, 2012 at 08:22:35AM +, Gupta, Ajay Kumar wrote: > > > > > > @@ -408,7 +408,7 @@ static int am35x_musb_exit(struct musb *musb) > > > > > > data->set_phy_power(0); > > > > > > > > > >

[PATCH 7/26] USB:support the new interfaces of Huawei Data Card devices in option driver

2012-07-26 Thread Fangxiaozhi (Franko)
From: fangxiaozhi 1. This patch is based on the kernel of 3.5 2. In this patch, we add new micro for matching the series USB devices with vendor ID and interface information. 3. In this patch, we add new declarations into option.c to support the new interfaces of Huawei Data Card devices. And a

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Huang Ying
On Wed, 2012-07-25 at 15:58 +0200, Bjørn Mork wrote: > huang ying writes: > > > Hi, Bjorn, > > > > Thank you very much for your detailed information. > > > > On Wed, Jul 25, 2012 at 5:58 PM, Bjørn Mork wrote: > >> Huang Ying writes: > >>> On Wed, 2012-07-25 at 06:08 +0200, Bjørn Mork wrote: > >

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Laurent Pinchart
Hi Felipe, On Thursday 26 July 2012 10:45:56 Felipe Balbi wrote: > On Thu, Jul 26, 2012 at 01:23:01AM +0200, Laurent Pinchart wrote: > > On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote: > > > On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote: > > > > On Wednesday 25 July 2012 15:06

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 11:53:57AM +0200, Laurent Pinchart wrote: > > Until then, I don't think we have a solution for this problem which > > would work always and, in fact, I don't want to have such a solution > > otherwise we will have to maintain it for the forseeable future. > > I don't a

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Laurent Pinchart
On Thursday 26 July 2012 13:11:47 Felipe Balbi wrote: > On Thu, Jul 26, 2012 at 11:53:57AM +0200, Laurent Pinchart wrote: > > > Until then, I don't think we have a solution for this problem which > > > would work always and, in fact, I don't want to have such a solution > > > otherwise we will have

RE: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Bhupesh SHARMA
Hi, > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Thursday, July 26, 2012 3:50 PM > To: ba...@ti.com > Cc: Bhupesh SHARMA; linux-usb@vger.kernel.org > Subject: Re: [RFC] usb: gadget: Ensure correct functionality for > gadgets that wish to

[PATCH v3 0/3] imx: add usbmisc support

2012-07-26 Thread Richard Zhao
usbmisc driver handles the SoC specific non-core usb registers. Changes since last version: - build usbmisc drivers into ci13xxx-imx module if it's chosen. - interprete properties in common code - check wether usbmisc_ops is null - dts: enable usbmisc device by default - take clk changes as a

[PATCH v3 1/3] USB: chipidea: add imx usbmisc support

2012-07-26 Thread Richard Zhao
i.MX usb controllers shares non-core registers, which may include SoC specific controls. We take it as a usbmisc device and usbmisc driver set operations needed by ci13xxx_imx driver. For example, Sabrelite board has bad over-current design, we can usbmisc to disable over-current detect. Signed-o

[PATCH v3 2/3] ARM: dts: imx6q-sabrelite: add usbmisc device

2012-07-26 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/boot/dts/imx6q-sabrelite.dts |1 + arch/arm/boot/dts/imx6q.dtsi | 18 ++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts index d42

[PATCH v3 3/3] ARM: imx6q: clk_register_clkdev usbmisc clock

2012-07-26 Thread Richard Zhao
Signed-off-by: Richard Zhao --- arch/arm/mach-imx/clk-imx6q.c |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/clk-imx6q.c b/arch/arm/mach-imx/clk-imx6q.c index ea89520..660fcbb 100644 --- a/arch/arm/mach-imx/clk-imx6q.c +++ b/arch/arm/mach-imx/clk-imx6q.c @@ -405,6 +405,7

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Bjørn Mork
Huang Ying writes: > Do you have time to try the below patch? Sure. Looks OK wrt the USB problems, but may cause problems with the PCIe WiFi card. Unless those are related to other changes in -next. Anyway, for I applied your patch on top of next-20120724 for consistency (still without Rafael

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 06:28:36PM +0800, Bhupesh SHARMA wrote: > > I just doesn't work :-) Calling usb_gadget_disconnect() during bind > > doesn't > > prevent the device from being visible to the USB host. Bhupesh has > > analyzed > > the problem and submitted this RFC as a possible fix. how

Re: New input driver for eBeam device (ask for review)

2012-07-26 Thread Yann Cantin
Hi, Le 26/07/2012 00:35, Greg KH a écrit : >> /*** >> * sysfs part >> */ >> DEVICE_MINMAX_ATTR(min_x); >> DEVICE_MINMAX_ATTR(max_x); >> DEVICE_MINMAX_ATTR(min_y); >> DEVICE_MINMAX_ATTR(max_y); > > What are all of these

Re: [PATCH 00/12] chipidea/imx: add otg support and some bug fix

2012-07-26 Thread Richard Zhao
On Thu, Jul 19, 2012 at 10:05:54AM +0800, Richard Zhao wrote: > On Mon, Jul 16, 2012 at 05:40:57PM -0700, Greg KH wrote: > > On Thu, Jul 12, 2012 at 03:01:40PM +0800, Richard Zhao wrote: > > > The patch set is tested on imx6q_sabrelite board. > > > > > > The patch can also be found at > > > https:

RE: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Bhupesh SHARMA
Hi, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, July 26, 2012 4:13 PM > To: Bhupesh SHARMA > Cc: Laurent Pinchart; ba...@ti.com; linux-usb@vger.kernel.org > Subject: Re: [RFC] usb: gadget: Ensure correct functionality for > gadgets that wish to 'connec

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Bjørn Mork
Bjørn Mork writes: > > Jul 26 12:20:43 nemi kernel: [ 493.812266] iwlwifi :03:00.0: Refused to > change power state, currently in D3 > Jul 26 12:20:43 nemi kernel: [ 493.812331] iwlwifi :03:00.0: > pci_resource_len = 0x2000 > Jul 26 12:20:43 nemi kernel: [ 493.812335] iwlwifi 000

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 07:00:03PM +0800, Bhupesh SHARMA wrote: > > > Yes. Felipe, plz go through the problem description as mentioned in > > > the patch log message which can be seen here: > > > http://permalink.gmane.org/gmane.linux.usb.general/66585 > > > > sure, please see above patch. Th

RE: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Bhupesh SHARMA
Hi, > -Original Message- > From: Felipe Balbi [mailto:ba...@ti.com] > Sent: Thursday, July 26, 2012 4:38 PM > To: Bhupesh SHARMA > Cc: ba...@ti.com; Laurent Pinchart; linux-usb@vger.kernel.org > Subject: Re: [RFC] usb: gadget: Ensure correct functionality for > gadgets that wish to 'connec

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Felipe Balbi
Hi, On Thu, Jul 26, 2012 at 07:51:05PM +0800, Bhupesh SHARMA wrote: > > | @@ -808,9 +809,16 @@ static inline int usb_gadget_connect(struct > > usb_gadget *gadget) > > | */ > > | static inline int usb_gadget_disconnect(struct usb_gadget *gadget) > > { > > | + int ret; > > | + > > | if (!gadget

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Bjørn Mork
Bjørn Mork writes: > Capabilities: [c8] Power Management version 3 > Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA > PME(D0+,D1-,D2-,D3hot+,D3cold+) > Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- > > Capabilities: [a0] Power Management versi

Re: [PATCH 3/3] usb: gadget/uvc: Add fix for UVC compliance test suite's assertion 6.1.25 failure

2012-07-26 Thread Sergei Shtylyov
Hello. On 26-07-2012 9:12, Bhupesh Sharma wrote: As per the UVC compliance test suite's assertion 6.1.25, the `iFunction` field of the Interface Association Descriptor (IAD) should the match the ^^^ not needed `iInterface` field of

Re: [PATCH] usb:musb: Fix for Full Speed issue

2012-07-26 Thread Sergei Shtylyov
Hello. On 26-07-2012 10:03, Ajay M JAWADE wrote: After sending the USB Bus reset, Host waits for High Speed Chirps. If the soft-disconnect and soft-connect happens during this chirp time, then Host doesn't detect this disconnect. Why talk about soft-connect when we're already connected (as

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi, > > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb > > *musb) > > > > > struct dentry *root; > > > > > struct dentry *file; > > > > > int

Re: [PATCH] musb_gadget: use variables according to their names in rxstate()

2012-07-26 Thread Sergei Shtylyov
Hello. On 16-07-2012 23:25, Sergei Shtylyov wrote: In rxstate(), improper types are given to 'fifo_count' and 'len' variables, and these variables are not used in accordance to their names (up to the certain point), i.e. 'len' to hold the size of a packet in the RX FIFO, and 'fifo_count' to hol

RE: [PATCH 3/3] usb: gadget/uvc: Add fix for UVC compliance test suite's assertion 6.1.25 failure

2012-07-26 Thread Bhupesh SHARMA
Hi Sergei, Thanks for your review. > -Original Message- > From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] > Sent: Thursday, July 26, 2012 5:43 PM > To: Bhupesh SHARMA > Cc: linux-usb@vger.kernel.org; laurent.pinch...@ideasonboard.com; > ba...@ti.com > Subject: Re: [PATCH 3/3] usb: gad

Re: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Felipe Balbi
On Thu, Jul 26, 2012 at 12:46:43PM +, Gupta, Ajay Kumar wrote: > Hi, > > > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct musb > > > *musb) > > > > > > struct dentry *root; > > > > > >

RE: [PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-26 Thread Gupta, Ajay Kumar
Hi > On Thu, Jul 26, 2012 at 12:46:43PM +, Gupta, Ajay Kumar wrote: > > Hi, > > > > > > On Wed, Jul 25, 2012 at 05:42:06PM +0530, Ajay Kumar Gupta wrote: > > > > > > > @@ -240,20 +238,24 @@ int __devinit musb_init_debugfs(struct > > > > > > > musb > > > > *musb) > > > > > > > struct dentry

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Sarah Sharp
On Wed, Jul 25, 2012 at 10:24:26PM -0700, Matthew Hall wrote: > On Wed, Jul 25, 2012 at 10:46:37AM -0700, Sarah Sharp wrote: > I think I'm in the same state as Gary only different. ;) I am getting weird > behavior with the quirk patch. The device popped up for about half a minute, > then went hay

Re: add ZTE EV_DO to a proper driver

2012-07-26 Thread nirinA raseliarison
hi Greg, Le Thu, 26 Jul 2012 01:04:08 +0300, Greg KH a écrit: On Wed, Jul 25, 2012 at 12:51:34PM -0700, nirinA raseliarison wrote: hello there, i have an usb modem zte ev-do that i used with kernel from 2.6.29 up to 3.5. since 3.5, i got the following message: [77496.664090] usb 5-2:

usb scheduler

2012-07-26 Thread Alexey Filin
Hello, I work in a scientific organization (www.ihep.su, experiments in high energy physics). My colleagues developed a crate controller with buffer memory and a usb interface (read out module, rom) to read out crate electronics with cypress ez-usb sx2 (cy7c68001). I developed a (Linux) kernel dri

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Bjørn Mork wrote: > Huang Ying writes: > > > Do you have time to try the below patch? > > Sure. Looks OK wrt the USB problems, but may cause problems with the > PCIe WiFi card. Unless those are related to other changes in -next. > > Anyway, for I applied your patch on to

Re: [PATCH] mceusb: Add Twisted Melon USB IDs

2012-07-26 Thread Mark Lord
On 12-07-11 06:53 PM, Mark Lord wrote: > Add USB identifiers for MCE compatible I/R transceivers from Twisted Melon. > > Signed-off-by: Mark Lord > --- > Mauro, please queue this up for inclusion in linux-3.6. > Patch is also attached to bypass emailer mangling. > Thanks. > > --- linux-3.5-rc6/d

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Felipe Balbi wrote: > > > > > > > Maybe while bringing it back you can remove the checks for > > > > > > > SuperSpeed. > > > > > > > Is there any reason to keep them? > > > Okay, that's fine. But it doesn't answer my earlier question: Is there > > > really any need for the

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Felipe Balbi wrote: > Hi, > > On Wed, Jul 25, 2012 at 02:53:00PM +0200, Rajaram REGUPATHY wrote: > > The short_not_ok field is used by class drivers to indicate udc whether > > short packet is expected during a particular transfer. > > In case of mass storage, during command

Re: add ZTE EV_DO to a proper driver

2012-07-26 Thread Greg KH
On Thu, Jul 26, 2012 at 05:51:59PM +0300, nirinA raseliarison wrote: > hi Greg, > > Le Thu, 26 Jul 2012 01:04:08 +0300, Greg KH a > écrit: > > >On Wed, Jul 25, 2012 at 12:51:34PM -0700, nirinA raseliarison wrote: > >>hello there, > >>i have an usb modem zte ev-do that i used with kernel from > >

(Query): [PATCH v4 2/4] usb gadget: Configure endpoint according to gadget speed.

2012-07-26 Thread Rajaram R
Hi Felipe/Alan Any comments for the below query ? On Thu, Jul 12, 2012 at 4:53 PM, Rajaram R wrote: > Hi > > > On Thu, Nov 18, 2010 at 6:17 PM, Tatyana Brokhman > wrote: >> >> Add config_ep_by_speed() to configure the endpoint according to the gadget >> speed. Using this function will spare the

Re: usb scheduler

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Alexey Filin wrote: > Hello, > > I work in a scientific organization (www.ihep.su, experiments in high > energy physics). My colleagues developed a crate controller with > buffer memory and a usb interface (read out module, rom) to read out > crate electronics with cypress ez

Re: usb scheduler

2012-07-26 Thread Hans Petter Selasky
On Thursday 26 July 2012 17:47:11 Alan Stern wrote: > > * Is there a USB controller with scheduling in current microframe? > > They all do it. But they won't generate completion IRQs any faster > than 8 KHz. Hi, Maybe a bit off-topic: I've noticed that if you STALL a USB transfer, this rule

Re: usb scheduler

2012-07-26 Thread Hans Petter Selasky
On Thursday 26 July 2012 17:47:11 Alan Stern wrote: > To get maximum throughput you should submit multiple URBs originally, > and then submit a new URB whenever an URB completes. I recommand using > a pipeline depth of 10-20 ms. For bulk transfers at high speed, that > comes out to between 500 KB

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Bjørn Mork
Alan Stern writes: >> USB hotplugging seems to work fine with this. > > Don't be too sure. Have you tested to see if it still works after > doing "rmmod ehci-hcd"? > > So far you have tested the EHCI controllers, but have you tested the > UHCI controllers? Unloading ehci-hcd will force them t

Re: (Query): [PATCH v4 2/4] usb gadget: Configure endpoint according to gadget speed.

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Rajaram R wrote: > Hi Felipe/Alan > > Any comments for the below query ? > > On Thu, Jul 12, 2012 at 4:53 PM, Rajaram R > wrote: > > Hi > > > > > > On Thu, Nov 18, 2010 at 6:17 PM, Tatyana Brokhman > > wrote: > >> > >> Add config_ep_by_speed() to configure the endpoint ac

[RFC 2/2] usb: usb_wwan: port may be gone on device resume

2012-07-26 Thread Bjørn Mork
We cannot unconditionally access any usb-serial port specific data from the USB driver. The usb-serial port may already be gone when the USB device is resumed. This will happen when the driver is unloaded. Treat ports with no portdata as closed ports to avoid a NULL pointer dereference on resume

[RFC 0/2] Fixing usb_wwan NULL pointer dereferencing

2012-07-26 Thread Bjørn Mork
ly to the current linux-next (next-20120726). I did not know exactly how to handle the suspend/resume issues, so I took the absolute minimum approach to avoid Ooopsing if the device is suspended when the module is unloaded. This is split out in a separate patch. Should probably be polished a bit. An

[RFC 1/2] usb: usb_wwan: replace release and disconnect with a port_remove hook

2012-07-26 Thread Bjørn Mork
Doing port specific cleanup in the .port_remove hook is a lot simpler and safer than doing it in the USB driver .release or .disconnect methods. The removal of the port from the usb-serial bus will happen before the USB driver cleanup, so we must be careful about accessing port specific driver data

Re: usb scheduler

2012-07-26 Thread Alexey Filin
On Thu, Jul 26, 2012 at 7:47 PM, Alan Stern wrote: > On Thu, 26 Jul 2012, Alexey Filin wrote: > >> Hello, >> >> I work in a scientific organization (www.ihep.su, experiments in high >> energy physics). My colleagues developed a crate controller with >> buffer memory and a usb interface (read out m

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Paul Zimmerman
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, July 26, 2012 8:16 AM > > On Thu, 26 Jul 2012, Felipe Balbi wrote: > > > > > > > > > Maybe while bringing it back you can remove the checks for > > > > > > > > SuperSpeed. > > > > > > > > Is there any reason to keep them? >

Re: [RFC 0/2] Fixing usb_wwan NULL pointer dereferencing

2012-07-26 Thread Alan Stern
ething like this would do? It is based on usb-3.6-rc1, but will > also apply to the current linux-next (next-20120726). This seems more or less reasonable. In theory, stop_read_write_urbs() could be moved directly into usb_wwan_suspend() since it isn't used anywhere else now. >

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Paul Zimmerman wrote: > > That's very clear. So Rajaram, when you redo the patch you can simply > > leave out the checks for SuperSpeed. Set or clear the short_not_ok > > flag depending only on the size of the bulk transfer, regardless of the > > speed. > > I have a bit of

Re: usb scheduler

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Alexey Filin wrote: > transfer with 2kB per URB hits artificial limit in our read out module > (19 MB/s for 128 kB URB). I think difference in performance for > pipeline of concurrent URBs and one iterative URB with 128 kB buffer > will be negligible, 128 kB URB takes at least

Re: [RFC 0/2] Fixing usb_wwan NULL pointer dereferencing

2012-07-26 Thread Bjørn Mork
in the port_remove callback. >> >> Maybe something like this would do? It is based on usb-3.6-rc1, but will >> also apply to the current linux-next (next-20120726). > > This seems more or less reasonable. In theory, stop_read_write_urbs() > could be moved directly int

Re: add ZTE EV_DO to a proper driver

2012-07-26 Thread nirinA raseliarison
Le Thu, 26 Jul 2012 18:32:36 +0300, Greg KH a écrit: http://pastebin.com/UPCAj2Br Where did you get those original files from? That's what I am curious about, is there a link online that I can find this at? those files are also in the installation cdrom shipped with the device.

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Paul Zimmerman
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Thursday, July 26, 2012 12:32 PM > > On Thu, 26 Jul 2012, Paul Zimmerman wrote: > > > > That's very clear. So Rajaram, when you redo the patch you can simply > > > leave out the checks for SuperSpeed. Set or clear the short_not_ok >

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Sarah Sharp
On Thu, Jul 26, 2012 at 07:16:38AM -0700, Sarah Sharp wrote: > On Wed, Jul 25, 2012 at 10:24:26PM -0700, Matthew Hall wrote: > > On Wed, Jul 25, 2012 at 10:46:37AM -0700, Sarah Sharp wrote: > > I think I'm in the same state as Gary only different. ;) I am getting weird > > behavior with the quirk

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-26 Thread Alan Stern
On Thu, 26 Jul 2012, Paul Zimmerman wrote: > > Hmmm. I suppose an impartial approach would be to set short_not_ok > > only when the blocksize >= the maxpacket size. That should always work > > as a general rule, regardless of speed. > > Yes. And that might save us from having to rehash all this

Kernel OOPS in usb_submit_urb in drivers/usb/core/urb.c

2012-07-26 Thread Damjan
While playing with my custom made i2c-tiny-usb adapter I triggered this kernel OOPS in usb_submit_urb in the drivers/usb/core/urb.c file. From looking at the file, before line 329 it needs to check if &ep->desc is NULL, before it sends it to the usb_endpoint_type (inline) function. As seen i

Re: Kernel OOPS in usb_submit_urb in drivers/usb/core/urb.c

2012-07-26 Thread Greg KH
On Thu, Jul 26, 2012 at 11:25:44PM +0200, Damjan wrote: > While playing with my custom made i2c-tiny-usb adapter I triggered > this kernel OOPS in usb_submit_urb in the drivers/usb/core/urb.c > file. > > From looking at the file, before line 329 it needs to check if > &ep->desc is NULL, before it

Re: Kernel OOPS in usb_submit_urb in drivers/usb/core/urb.c

2012-07-26 Thread Damjan
On чет, 26 јул 2012 23:32:48 CEST, Greg KH wrote: On Thu, Jul 26, 2012 at 11:25:44PM +0200, Damjan wrote: While playing with my custom made i2c-tiny-usb adapter I triggered this kernel OOPS in usb_submit_urb in the drivers/usb/core/urb.c file. From looking at the file, before line 329 it needs

[PATCH V2 1/2] USB: musb: gadget: add missed pm_runtime ops to avoid oops

2012-07-26 Thread Zumeng Chen
musb_gadget has done pm_runtime_* operations in functions insmod-related, and it is necessary to add them in functions rmmod-related, otherwise the following Oops will be happend after rmmod. root@ti-omap3:~# rmmod g_ether Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab006 In

[PATCH 2/3] usb: serial: prevent suspend/resume from racing against probe/remove

2012-07-26 Thread Bjørn Mork
Some usb-serial drivers may access port data in their suspend/ resume functions. Such drivers must always verify the validity of the data as both suspend and resume can be called both before usb_serial_device_probe and after usb_serial_device_remove. But the port data may be invalidated during por

[PATCH 3/3] usb: usb_wwan: resume/suspend can be called after port is gone

2012-07-26 Thread Bjørn Mork
We cannot unconditionally access any usb-serial port specific data from the interface driver. Both supending and resuming may happen after the port has been removed and portdata is freed. Treat ports with no portdata as closed ports to avoid a NULL pointer dereference on resume. No need to kill

[PATCH 0/3] Fixing usb_wwan NULL pointer dereferencing

2012-07-26 Thread Bjørn Mork
OK, I take my chances on submitting this in the middle of the merge window. This should ideally have been in -rc1 to prevent the 100% reproducible Ooopses which are bound to hit people testing -rc1 with any of these 3 drivers... Changes from the RFC patchset: - new patch adding usb_autopm_get_in

[PATCH 1/3] usb: usb_wwan: replace release and disconnect with a port_remove hook

2012-07-26 Thread Bjørn Mork
Doing port specific cleanup in the .port_remove hook is a lot simpler and safer than doing it in the USB driver .release or .disconnect methods. The removal of the port from the usb-serial bus will happen before the USB driver cleanup, so we must be careful about accessing port specific driver data

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-26 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Ido Shayevitz > Sent: Wednesday, July 25, 2012 5:46 AM > > This is first release of otg driver for the dwc3 Synopsys USB3 core. > The otg driver implements the otg final state machine and control the >

RE: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Xu, Andiry
> -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Sarah Sharp > Sent: Friday, July 27, 2012 4:22 AM > To: Matthew Hall > Cc: linux-usb@vger.kernel.org; g...@rellim.com > Subject: Re: the dreaded "needs XHCI_TRUST_TX_LENGTH

[PATCH] Add Etron XHCI quirk to avoid warning spam

2012-07-26 Thread Daniel J Blueman
When various USB3 devices with Etron XHCI controllers, we see a bunch of warnings: xhci_hcd :02:00.0: WARN Successful completion on short TX: needs XHCI_TRUST_TX_LENGTH quirk? Acknowledge the issue by adding the quirk. Signed-off-by: Daniel J Blueman --- drivers/usb/host/xhci-pci.c | 11 +

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-26 Thread Huang Ying
On Thu, 2012-07-26 at 12:35 +0200, Bjørn Mork wrote: > Huang Ying writes: > > > Do you have time to try the below patch? > > Sure. Looks OK wrt the USB problems, but may cause problems with the > PCIe WiFi card. Unless those are related to other changes in -next. > > Anyway, for I applied you

RE: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-26 Thread Bhupesh SHARMA
Hi, > -Original Message- > From: Bhupesh SHARMA > Sent: Thursday, July 26, 2012 6:02 PM > To: 'ba...@ti.com' > Cc: Laurent Pinchart; linux-usb@vger.kernel.org > Subject: RE: [RFC] usb: gadget: Ensure correct functionality for > gadgets that wish to 'connect' only when directed by user-spac

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Matthew Hall
On Thu, Jul 26, 2012 at 01:22:15PM -0700, Sarah Sharp wrote: > Ok, I think I have the root cause of this message, and it's a nasty > little bug. Can you apply the attached patch (instead of the previous > debug patch) and test? I think your disk will work once it's applied, > but please double ch

Re: [PATCH] Add Etron XHCI quirk to avoid warning spam

2012-07-26 Thread Sarah Sharp
Hi Daniel, I already have a patch in my queue for this. However, it keys off the PCI_DEVICE_ID_ASROCK_P67 PCI device ID. Do you have another Etron device with a different device ID that needs this quirk? Sarah Sharp On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote: > When vario

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Sarah Sharp
On Fri, Jul 27, 2012 at 03:00:53AM +, Xu, Andiry wrote: > > -Original Message- > > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > > ow...@vger.kernel.org] On Behalf Of Sarah Sharp > > Sent: Friday, July 27, 2012 4:22 AM > > To: Matthew Hall > > Cc: linux-usb@vger.kernel.org;

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Matthew Hall
Argh! Forgot to remember to include the kern log again: http://www.mhcomputing.net/tmp/xhci-bug/dmesg-usb-3-port-memory-patch-plugin.txt.gz Regards, Matthew. On Thu, Jul 26, 2012 at 11:09:13PM -0700, Matthew Hall wrote: > On Thu, Jul 26, 2012 at 01:22:15PM -0700, Sarah Sharp wrote: > > Ok, I thi

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Sarah Sharp
On Thu, Jul 26, 2012 at 11:09:13PM -0700, Matthew Hall wrote: > On Thu, Jul 26, 2012 at 01:22:15PM -0700, Sarah Sharp wrote: > > Ok, I think I have the root cause of this message, and it's a nasty > > little bug. Can you apply the attached patch (instead of the previous > > debug patch) and test?

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-26 Thread Matthew Hall
On Thu, Jul 26, 2012 at 11:27:47PM -0700, Sarah Sharp wrote: > Yeah, I was kind of banging my head on the desk as well. I'm really not > sure why it wasn't causing a general protection fault, so it's possible > I could be wrong in my analysis of what the bug might do. ;-) > > I did test this lat

Re: [PATCH] Add Etron XHCI quirk to avoid warning spam

2012-07-26 Thread Daniel J Blueman
On 27 July 2012 14:14, Sarah Sharp wrote: > On Fri, Jul 27, 2012 at 12:03:44PM +0800, Daniel J Blueman wrote: >> When various USB3 devices with Etron XHCI controllers, we see a bunch of >> warnings: >> xhci_hcd :02:00.0: WARN Successful completion on short TX: needs >> XHCI_TRUST_TX_LENGTH qui