RE: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-25 Thread Bhupesh SHARMA
Hi, > -Original Message- > From: Bhupesh SHARMA > Sent: Wednesday, June 27, 2012 9:08 AM > To: ba...@ti.com; linux-usb@vger.kernel.org > Cc: gre...@linuxfoundation.org; laurent.pinch...@ideasonboard.com > Subject: [RFC] usb: gadget: Ensure correct functionality for gadgets > that wish to '

Re: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote: > Fixes endpoint starvation issue when more than one bulk QH is > multiplexed on the reserved bulk TX endpoint. > > This patch sets the NAK timeout interval for such QHs, and when > a timeout triggers the next QH will be schedu

Re: [PATCH v4 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 19, 2012 at 05:15:57PM +0530, Ajay Kumar Gupta wrote: > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 89d1871..3e09984 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -99,6 +99,7 @@ > #include > #include >

Re: [PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Felipe Balbi
Hi, On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote: > Moved global variable "musb_debugfs_root" and static variable > "old_state" to 'struct musb' to help support multi instance of > musb controller as present on AM335x platform. > > Also removed the global variable "orig_dma_ma

Re: [PATCH] omap: usb: host: remove deprecated flag 'es2_compatibility'

2012-07-25 Thread Felipe Balbi
Hi, On Tue, Jul 24, 2012 at 09:08:40PM +0300, Ruslan Bilovol wrote: > Currently this flag is not used anywhere and may be safely removed. > > Signed-off-by: Ruslan Bilovol looks good to me. Keshava ? > --- > arch/arm/mach-omap2/usb-host.c|1 - > arch/arm/plat-omap/include/plat/usb

the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-25 Thread Matthew Hall
Hello Sarah et. al, I am attempting to use an Inland brand USB 3.0 multi-purpose Memory Card reader, which I purchased from Micro Center, along with a Patriot EP Series SDXC UHS-1 64 GB memory card, which I purchased from Fry's. I am connecting these to my Debian unstable system running Linux 3

RE: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote: > > Fixes endpoint starvation issue when more than one bulk QH is > > multiplexed on the reserved bulk TX endpoint. > > > > This patch sets the NAK timeout interval for such QHs, and when > > a timeout triggers the next QH will

RE: [PATCH v4 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Thu, Jul 19, 2012 at 05:15:57PM +0530, Ajay Kumar Gupta wrote: > > diff --git a/drivers/usb/musb/musb_core.c > > b/drivers/usb/musb/musb_core.c index 89d1871..3e09984 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > @@ -99,6 +99,7 @@ > > #include >

RE: [PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > > On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote: > > Moved global variable "musb_debugfs_root" and static variable > > "old_state" to 'struct musb' to help support multi instance of musb > > controller as present on AM335x platform. > > > > Also removed the global variable

RE: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > > On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote: > > > Fixes endpoint starvation issue when more than one bulk QH is > > > multiplexed on the reserved bulk TX endpoint. > > > > > > This patch sets the NAK timeout interval for such QHs, and when > > > a timeout triggers the

Re: [PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Felipe Balbi
On Wed, Jul 25, 2012 at 10:34:49AM +, Gupta, Ajay Kumar wrote: > Hi, > > > > On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote: > > > Moved global variable "musb_debugfs_root" and static variable > > > "old_state" to 'struct musb' to help support multi instance of musb > > > con

Re: [PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-25 Thread Felipe Balbi
On Wed, Jul 25, 2012 at 10:38:59AM +, Gupta, Ajay Kumar wrote: > Hi, > > > On Thu, Jul 19, 2012 at 01:41:59PM +0530, Ajay Kumar Gupta wrote: > > > > Fixes endpoint starvation issue when more than one bulk QH is > > > > multiplexed on the reserved bulk TX endpoint. > > > > > > > > This patch set

RE: [PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 10:34:49AM +, Gupta, Ajay Kumar wrote: > > Hi, > > > > > > On Thu, Jul 19, 2012 at 05:15:58PM +0530, Ajay Kumar Gupta wrote: > > > > Moved global variable "musb_debugfs_root" and static variable > > > > "old_state" to 'struct musb' to help support multi instance of

RE: [RFC/PATCH v2] usb: dwc3: Introduce OTG driver for dwc3

2012-07-25 Thread Ido Shayevitz
Hi Anton, On Tue, July 17, 2012 9:27 pm, Anton Tikhomirov wrote: > Hi, > >> -Original Message- >> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- >> ow...@vger.kernel.org] On Behalf Of Ido Shayevitz >> Sent: Thursday, July 12, 2012 1:24 AM >> To: ba...@ti.com >> Cc: linux-usb@vge

[PATCH v5 09/11] usb: musb: dsps: remove explicit NOP device creation

2012-07-25 Thread Ajay Kumar Gupta
As NOP device node is now added in am33xx tree so remove the call which creates the NOP platform_device. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_dsps.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/mus

[PATCH v5 08/11] arm/dts: am33xx: add dt data for usb nop phy

2012-07-25 Thread Ajay Kumar Gupta
AM33xx has two musb controller and they have one NOP PHY each. Added the device tree data for NOP PHY. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/d

[PATCH v5 11/11] arm/dts: am33xx: add phy phandle to usbss

2012-07-25 Thread Ajay Kumar Gupta
Added NOP PHY phandle to usbss device node as same will be used to get the phy from otg framework. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.

[PATCH v5 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-25 Thread Ajay Kumar Gupta
Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/a

[PATCH 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Ajay Kumar Gupta
Moved global variable "musb_debugfs_root" and static variable "old_state" to 'struct musb' to help support multi instance of musb controller as present on AM335x platform. Also removed the global variable "orig_dma_mask" and filled the dev->dma_mask with parent device's dma_mask. Signed-off-by: A

[PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Ajay Kumar Gupta
Added 'id' field within 'struct musb' which can be used to determine the current instance of musb controller. Also defined musb_ida in musb_core.c to manage the core ids. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/am35x.c | 42 -- drivers/

[PATCH v5 00/11] usb: musb: adding multi instance support

2012-07-25 Thread Ajay Kumar Gupta
This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to g

[PATCH v5 10/11] usb: musb: dsps: get the PHY using phandle api

2012-07-25 Thread Ajay Kumar Gupta
AM33xx has two PHY of same type used by each musb controller so use phandle of phy nodes to get the phy pointer. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |2 ++ drivers/usb/musb/musb_dsps.c |4 +++- 2 files changed, 5 in

[PATCH v5 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-25 Thread Ajay Kumar Gupta
Currently we have one single nop transceiver support as same is defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. This need to be changed to support multiple otg controller each using nop transceiver on a platform such as am335x. Signed-off-by: Ajay Kumar Gupta --- arch/arm/mach-o

[PATCH v5 07/11] usb: otg: nop: add dt support

2012-07-25 Thread Ajay Kumar Gupta
Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ drivers/usb/otg/nop-usb-xceiv.c| 1

[PATCH v5 05/11] usb: musb: dsps: add dt support

2012-07-25 Thread Ajay Kumar Gupta
Added device tree support for dsps musb glue driver and updated the Documentation with device tree binding information. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt | 14 + drivers/usb/musb/musb_dsps.c | 60 +

[PATCH v5 03/11] usb: musb: am335x: add support for dual instance

2012-07-25 Thread Ajay Kumar Gupta
AM335x and TI81xx platform has dual musb controller so updating the musb_dspc.c to support the same. Changes: - Moved otg_workaround timer to glue structure - Moved static local variable last_timer to glue structure - PHY on/off related cleanups Signed-off-by: Ajay Kumar G

[PATCH v5 02/11] usb: musb: kill global and static for multi instance

2012-07-25 Thread Ajay Kumar Gupta
Moved global variable "musb_debugfs_root" and static variable "old_state" to 'struct musb' to help support multi instance of musb controller as present on AM335x platform. Also removed the global variable "orig_dma_mask" and filled the dev->dma_mask with parent device's dma_mask. Signed-off-by: A

RE: [PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and feature add

2012-07-25 Thread Neil Zhang
Hi Balbi, > -Original Message- > From: Neil Zhang > Sent: 2012年7月19日 22:48 > To: Neil Zhang; ba...@ti.com; gre...@linuxfoundation.org > Cc: Chao Xie; khoroshi...@ispras.ru; linux-usb@vger.kernel.org > Subject: RE: [PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and feature > add > > Hi Balbi,

Re: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Felipe Balbi
hi, On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 89d1871..f5eb8a7 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -1889,6 +1921,7 @@ musb_init_controller

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > diff --git a/drivers/usb/musb/musb_core.c > > b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644 > > --- a/drivers/usb/musb/musb_core.c > > +++ b/drivers/usb/musb/musb_core.c > > > > > @@ -1889,6 +1921,7 @@

Re: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Felipe Balbi
Hi. On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote: > Hi, > > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > > diff --git a/drivers/usb/musb/musb_core.c > > > b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644 > > > --- a/drivers/usb/musb/mu

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote: > > Hi, > > > > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > > > diff --git a/drivers/usb/musb/musb_core.c > > > > b/drivers/usb/musb/musb_core.c index 89d1871..f5eb8a7 100644 > > > > --- a/drivers

Re: [PATCH] omap: usb: host: remove deprecated flag 'es2_compatibility'

2012-07-25 Thread Munegowda, Keshava
On Wed, Jul 25, 2012 at 1:24 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jul 24, 2012 at 09:08:40PM +0300, Ruslan Bilovol wrote: >> Currently this flag is not used anywhere and may be safely removed. >> >> Signed-off-by: Ruslan Bilovol > > looks good to me. Keshava ? Ruslan please remove the

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Ming Lei
CC usb guys and list On Wed, Jul 25, 2012 at 1:53 AM, Linus Torvalds wrote: > > I really think the isight thing is a totally different thing entirely. > > And quite frankly, that's just a BUG in the USB implementation. If the > USB ID changes, it shouldn't be considered a "resume" thing at all, >

Re: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Felipe Balbi
On Wed, Jul 25, 2012 at 12:30:12PM +, Gupta, Ajay Kumar wrote: > Hi, > > On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote: > > > Hi, > > > > > > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > > > > diff --git a/drivers/usb/musb/musb_core.c > > > > > b

RE: [PATCH v5 01/11] usb: musb: add musb->id to identify core instance

2012-07-25 Thread Gupta, Ajay Kumar
Hi, > On Wed, Jul 25, 2012 at 12:30:12PM +, Gupta, Ajay Kumar wrote: > > Hi, > > > On Wed, Jul 25, 2012 at 12:19:32PM +, Gupta, Ajay Kumar wrote: > > > > Hi, > > > > > > > > > > On Wed, Jul 25, 2012 at 05:37:19PM +0530, Ajay Kumar Gupta wrote: > > > > > > diff --git a/drivers/usb/musb/musb_

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Oliver Neukum
On Wednesday 25 July 2012 20:35:28 Ming Lei wrote: > CC usb guys and list > > On Wed, Jul 25, 2012 at 1:53 AM, Linus Torvalds > wrote: > > > > I really think the isight thing is a totally different thing entirely. > > > > And quite frankly, that's just a BUG in the USB implementation. If the > >

[RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-25 Thread Ido Shayevitz
This is first release of otg driver for the dwc3 Synopsys USB3 core. The otg driver implements the otg final state machine and control the activation of the device controller or host controller. In this first implementation, only simple DRD mode is implemented, determine if A or B device according

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Ming Lei
On Wed, Jul 25, 2012 at 8:43 PM, Oliver Neukum wrote: > This is likely unwise. You'd better introduce a special flag for kernel > threads > that should be thawed only after user space will have been thawed. IMO, it is not necessary to introduce one extra flag for the purpose since - usermo

usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Rajaram REGUPATHY
The short_not_ok field is used by class drivers to indicate udc whether short packet is expected during a particular transfer. In case of mass storage, during command and status phase this field is set as false and set to true during data phase. musb driver uses this field to decide whether to pr

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Ming Lei
On Wed, Jul 25, 2012 at 8:50 PM, Ming Lei wrote: > - no harm to thaw all user space tasks before thawing all kernel threads > (there isn't any dependency about the thawing order) Sorry, I mean there isn't any constraint about the order, but the 'dependency' may be just what the patch is

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Michal Nazarewicz
On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY wrote: The short_not_ok field is used by class drivers to indicate udc whether short packet is expected during a particular transfer. In case of mass storage, during command and status phase this field is set as false and set to true durin

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-25 Thread Laurent Pinchart
Hi Bhupesh, On Wednesday 25 July 2012 15:06:37 Bhupesh SHARMA wrote: [snip] > It's been almost a month since this RFC was circulated. > As no comments have been received so far, http://www.spinics.net/lists/linux-usb/msg66755.html Mails get lost sometime. BTW, http://www.spinics.net/lists/lin

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread huang ying
Hi, Bjorn, Thank you very much for your detailed information. On Wed, Jul 25, 2012 at 5:58 PM, Bjørn Mork wrote: > Huang Ying writes: >> On Wed, 2012-07-25 at 06:08 +0200, Bjørn Mork wrote: >>> Enabling autosuspend for USB causes hotplug failure in the current >>> linux-next. Newly plugged devi

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Rajaram R
Hi On Wed, Jul 25, 2012 at 6:33 PM, Michal Nazarewicz wrote: > On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY > wrote: >> >> The short_not_ok field is used by class drivers to indicate udc whether >> short packet is expected during a particular transfer. >> In case of mass storage, during

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread Bjørn Mork
huang ying writes: > Hi, Bjorn, > > Thank you very much for your detailed information. > > On Wed, Jul 25, 2012 at 5:58 PM, Bjørn Mork wrote: >> Huang Ying writes: >>> On Wed, 2012-07-25 at 06:08 +0200, Bjørn Mork wrote: Enabling autosuspend for USB causes hotplug failure in the current >>

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Rajaram REGUPATHY wrote: > The short_not_ok field is used by class drivers to indicate udc whether short > packet is expected during a particular transfer. > In case of mass storage, during command and status phase this field is set as > false and set to true during data pha

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Rajaram R wrote: > Hi > > On Wed, Jul 25, 2012 at 6:33 PM, Michal Nazarewicz wrote: > > On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY > > wrote: > >> > >> The short_not_ok field is used by class drivers to indicate udc whether > >> short packet is expected during a

[PATCH] USB: ohci-pxa27x: add DT bindings

2012-07-25 Thread Daniel Mack
Add DT bindings to the ohci-pxa27x driver and some documentation. Successfully tested on a PXA3xx board. Signed-off-by: Daniel Mack --- Documentation/devicetree/bindings/usb/pxa-usb.txt | 31 ++ drivers/usb/host/ohci-pxa27x.c| 68 + 2 files ch

RE: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-25 Thread Bhupesh SHARMA
Hi Laurent, > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Wednesday, July 25, 2012 6:41 PM > To: Bhupesh SHARMA > Cc: ba...@ti.com; linux-usb@vger.kernel.org; gre...@linuxfoundation.org > Subject: Re: [RFC] usb: gadget: Ensure correct func

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Rajaram R
Hi Alan On Wed, Jul 25, 2012 at 9:07 PM, Alan Stern wrote: > On Wed, 25 Jul 2012, Rajaram R wrote: > >> Hi >> >> On Wed, Jul 25, 2012 at 6:33 PM, Michal Nazarewicz wrote: >> > On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY >> > wrote: >> >> >> >> The short_not_ok field is used by class d

Re: [PATCH] USB: ohci-pxa27x: add DT bindings

2012-07-25 Thread Arnd Bergmann
On Wednesday 25 July 2012, Daniel Mack wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/pxa-usb.txt > @@ -0,0 +1,31 @@ > +PXA USB controllers > + > +OHCI > + > +Required properties: > + - compatible: Should be "mrvl,pxa-ohci" for USB controllers > + used in host mode. > + > +

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Rajaram R wrote: > >> > There's one thing I don't get. The message talks about musb but the code > >> > checks for non Super Speed devices. So maybe the code is correct, maybe > >> > it's not, but the message does not really explain it (at least to me). > >> > > >> Please le

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Linus Torvalds
On Wed, Jul 25, 2012 at 5:35 AM, Ming Lei wrote: > > The below patch should fix the problem above. Actually, I think we could make this even simpler. There's nothing wrong with saying "user mode is enabled" *just* before we unthaw things, if we also simply guarantee that there is no sleeping loc

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Rajaram R
On Wed, Jul 25, 2012 at 10:51 PM, Alan Stern wrote: > On Wed, 25 Jul 2012, Rajaram R wrote: > >> >> > There's one thing I don't get. The message talks about musb but the >> >> > code >> >> > checks for non Super Speed devices. So maybe the code is correct, maybe >> >> > it's not, but the messag

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-25 Thread Sarah Sharp
On Wed, Jul 25, 2012 at 02:31:20AM -0700, Matthew Hall wrote: > Hello Sarah et. al, Hi Matthew! It helps if you Cc my email address in your mail. Otherwise it might get lost in a separate folder and ignored for a couple days. > I am attempting to use an Inland brand USB 3.0 multi-purpose Memory

[RFT] xhci: Rate-limit XHCI_TRUST_TX_LENGTH quirk warning.

2012-07-25 Thread Sarah Sharp
When we encounter an xHCI host that needs the XHCI_TRUST_TX_LENGTH quirk, the xHCI driver ends up spewing messages about the quirk into dmesg every time a short packet occurs. Change the xHCI driver to rate-limit such warnings. This patch should be backported to kernels as old as 2.6.36, that con

RE: [PATCH 5/5] usb: gadget/uvc: Add support for 'USB_GADGET_DELAYED_STATUS' response for a set_intf(alt-set 1) command

2012-07-25 Thread Bhupesh SHARMA
Hi Laurent, > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Saturday, July 07, 2012 6:37 PM > To: Bhupesh SHARMA > Cc: linux-usb@vger.kernel.org; ba...@ti.com; linux- > me...@vger.kernel.org; gre...@linuxfoundation.org > Subject: Re: [PATCH

RE: [PATCH 4/5] usb: gadget/uvc: Port UVC webcam gadget to use videobuf2 framework

2012-07-25 Thread Bhupesh SHARMA
Hi Laurent, Sorry for the delayed reply. I thought of performing some extensive tests before replying to your comments. > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Saturday, July 07, 2012 5:28 PM > To: Bhupesh SHARMA > Cc: linux-usb@vge

Re: controlling record light on camera

2012-07-25 Thread Adam Wozniak
I'm not getting much traction with this approach. I get: Turning light on now...[73405.001220] usb 1-1.2: usbfs: process 30710 (badusbled) did not claim interface 0 before use libusb_control_transfer() returned -1 I'm not familiar enough with libusb to know what this error means. --Adam On

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Paul Zimmerman
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Alan Stern > > On Wed, 25 Jul 2012, Rajaram R wrote: > > > >> > There's one thing I don't get. The message talks about musb but > > >> > the code checks for non Super Speed devices. So maybe the cod

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread Rafael J. Wysocki
On Wednesday, July 25, 2012, Bjørn Mork wrote: > huang ying writes: > > > Hi, Bjorn, > > > > Thank you very much for your detailed information. > > > > On Wed, Jul 25, 2012 at 5:58 PM, Bjørn Mork wrote: > >> Huang Ying writes: > >>> On Wed, 2012-07-25 at 06:08 +0200, Bjørn Mork wrote: > En

Re: controlling record light on camera

2012-07-25 Thread Adam Wozniak
Got now, thanks. On 07/25/2012 11:39 AM, Adam Wozniak wrote: I'm not getting much traction with this approach. I get: Turning light on now...[73405.001220] usb 1-1.2: usbfs: process 30710 (badusbled) did not claim interface 0 before use libusb_control_transfer() returned -1 I'm not familia

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Rafael J. Wysocki
On Wednesday, July 25, 2012, Linus Torvalds wrote: > On Wed, Jul 25, 2012 at 5:35 AM, Ming Lei wrote: > > > > The below patch should fix the problem above. > > Actually, I think we could make this even simpler. > > There's nothing wrong with saying "user mode is enabled" *just* before > we untha

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Rajaram R wrote: > On Wed, Jul 25, 2012 at 10:51 PM, Alan Stern > wrote: > > On Wed, 25 Jul 2012, Rajaram R wrote: > > > >> >> > There's one thing I don't get. The message talks about musb but the > >> >> > code > >> >> > checks for non Super Speed devices. So maybe the c

[PATCH] PCI / PM: Fix messages printed by acpi_pci_set_power_state()

2012-07-25 Thread Rafael J. Wysocki
If a PCI device is put into D3_cold by acpi_bus_set_power(), the message printed by acpi_pci_set_power_state() says that its power state has been changed to D4, which doesn't make sense. In turn, if the device is put into D3_hot, the message says just "D3" without specifying which variant of D3 it

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Paul Zimmerman wrote: > > > > I don't understand this either. What's wrong with setting > > > > short_not_ok while at SuperSpeed? It shouldn't force the use of a > > bounce buffer. > > > > > > > > > > I have just brought back some code removed by patch "usb: fix mass > > > s

add ZTE EV_DO to a proper driver

2012-07-25 Thread nirinA raseliarison
hello there, i have an usb modem zte ev-do that i used with kernel from 2.6.29 up to 3.5. since 3.5, i got the following message: [77496.664090] usb 5-2: udev 10, busnum 5, minor = 521 [77496.664097] usb 5-2: New USB device found, idVendor=19d2, idProduct= [77496.664102] usb 5-2: N

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread Rafael J. Wysocki
On Wednesday, July 25, 2012, Bjørn Mork wrote: > huang ying writes: > > > Hi, Bjorn, > > > > Thank you very much for your detailed information. > > > > On Wed, Jul 25, 2012 at 5:58 PM, Bjørn Mork wrote: > >> Huang Ying writes: > >>> On Wed, 2012-07-25 at 06:08 +0200, Bjørn Mork wrote: > En

Re: [PATCH] PCI / PM: Fix messages printed by acpi_pci_set_power_state()

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Rafael J. Wysocki wrote: > > If a PCI device is put into D3_cold by acpi_bus_set_power(), > the message printed by acpi_pci_set_power_state() says that its > power state has been changed to D4, which doesn't make sense. > In turn, if the device is put into D3_hot, the message

[PATCH] ueagle-atm: Declare MODULE_FIRMWARE usage

2012-07-25 Thread Tim Gardner
Cc: Matthieu CASTET Cc: Stanislaw Gruszka Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/usb/atm/ueagle-atm.c | 79 +++--- 1 file changed, 66 insertions(+), 13 deletions(-) diff --git a/drivers/usb/atm/ueagle-a

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Paul Zimmerman
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Wednesday, July 25, 2012 12:48 PM > To: Paul Zimmerman > Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org > Subject: RE: usb : mass storage : short_not_ok for non usb3 udc > > On Wed, 25 Jul 2012, Paul Zimmerman wrote: > > >

[PATCH][update] PCI / PM: Fix messages printed by acpi_pci_set_power_state()

2012-07-25 Thread Rafael J. Wysocki
On Wednesday, July 25, 2012, Alan Stern wrote: > On Wed, 25 Jul 2012, Rafael J. Wysocki wrote: > > > > > If a PCI device is put into D3_cold by acpi_bus_set_power(), > > the message printed by acpi_pci_set_power_state() says that its > > power state has been changed to D4, which doesn't make sens

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Alan Stern
On Wed, 25 Jul 2012, Paul Zimmerman wrote: > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > Sent: Wednesday, July 25, 2012 12:48 PM > > To: Paul Zimmerman > > Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org > > Subject: RE: usb : mass storage : short_not_ok for non usb3 udc

RE: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Paul Zimmerman
> From: Alan Stern [mailto:st...@rowland.harvard.edu] > Sent: Wednesday, July 25, 2012 2:03 PM > > On Wed, 25 Jul 2012, Paul Zimmerman wrote: > > > > From: Alan Stern [mailto:st...@rowland.harvard.edu] > > > Sent: Wednesday, July 25, 2012 12:48 PM > > > To: Paul Zimmerman > > > Cc: Rajaram R; Mic

Re: add ZTE EV_DO to a proper driver

2012-07-25 Thread Greg KH
On Wed, Jul 25, 2012 at 12:51:34PM -0700, nirinA raseliarison wrote: > hello there, > i have an usb modem zte ev-do that i used with kernel from 2.6.29 up to 3.5. > since 3.5, i got the following message: > > [77496.664090] usb 5-2: udev 10, busnum 5, minor = 521 > [77496.664097] usb 5-2:

Re: New input driver for eBeam device (ask for review)

2012-07-25 Thread Greg KH
On Sun, Jul 22, 2012 at 05:28:12PM +0200, Yann Cantin wrote: > /*** > * sysfs part > */ > > /* > * screen min/max and H matrix coefs > * _get return *current* value > * _set set new value > */ > #define DEVICE_MINMAX

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread Bjørn Mork
"Rafael J. Wysocki" writes: > This is not really necessary. The problem is the change of behavior I was > worried about some time ago. > > Namely, the device in question apparently doesn't support ACPI D3_hot, > so acpi_pm_device_sleep_state() returns D2 as the target state, where it > would ret

Re: Writing a driver for a not really HID compliant device

2012-07-25 Thread Greg KH
On Sun, Jul 22, 2012 at 07:35:58PM +0200, Marian Beermann wrote: > Hi, > > I have here a "Microsoft Sidewinder Strategic Commander". It's > basically a fancy joystick (two axis plus rotation and a dozen or so > buttons), but it's not HID compliant, i.e. I can only use it via > hidraw. > I already

Re: [RFC] usb: gadget: Ensure correct functionality for gadgets that wish to 'connect' only when directed by user-space

2012-07-25 Thread Laurent Pinchart
Hi Bhupesh, On Thursday 26 July 2012 00:12:46 Bhupesh SHARMA wrote: > On Wednesday, July 25, 2012 6:41 PM Laurent Pinchart wrote: > > On Wednesday 25 July 2012 15:06:37 Bhupesh SHARMA wrote: > > > > [snip] > > > > > It's been almost a month since this RFC was circulated. > > > As no comments hav

[GIT PATCH] USB merge for 3.6-rc1

2012-07-25 Thread Greg KH
The following changes since commit 84a1caf1453c3d44050bd22db958af4a7f99315c: Linux 3.5-rc7 (2012-07-14 15:40:28 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-3.6-rc1 for you to fetch changes up to e387ef5c47ddeaeaa3cbdc

Re: [RFC PATCH 00/13] firmware loader: introduce cache/uncache firmware

2012-07-25 Thread Ming Lei
On Thu, Jul 26, 2012 at 1:23 AM, Linus Torvalds wrote: > > So *if* the only problem wrt the USB hub code comes from this area, IMO, USB hub code may not be the only one because both device_add and device_del can just be run in process context, so any hotplug bus may have this kind of problem sin

RE: [RFC/PATCH v3] usb: dwc3: Introduce OTG driver for dwc3

2012-07-25 Thread Anton Tikhomirov
Hi Ido, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Ido Shayevitz > Sent: Wednesday, July 25, 2012 9:46 PM > To: ba...@ti.com; av.tikhomi...@samsung.com > Cc: linux-usb@vger.kernel.org; i...@codeaurora.org > Subject:

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread Huang Ying
Hi, Rafael, On Wed, 2012-07-25 at 22:02 +0200, Rafael J. Wysocki wrote: > On Wednesday, July 25, 2012, Bjørn Mork wrote: > > huang ying writes: > > > > > Hi, Bjorn, > > > > > > Thank you very much for your detailed information. > > > > > > On Wed, Jul 25, 2012 at 5:58 PM, Bjørn Mork wrote: > >

Re: bisected regression, v3.5 -> next-20120724: PCI PM causes USB hotplug failure

2012-07-25 Thread Huang Ying
On Thu, 2012-07-26 at 00:36 +0200, Bjørn Mork wrote: > "Rafael J. Wysocki" writes: > > > This is not really necessary. The problem is the change of behavior I was > > worried about some time ago. > > > > Namely, the device in question apparently doesn't support ACPI D3_hot, > > so acpi_pm_device

[PATCH 0/3] Fixes for UVC test suite (available in USBCV) failures

2012-07-25 Thread Bhupesh Sharma
This patchset addresses a few issues found out while enumerating/running USBCV's UVC test suite with the UVC webcam gadget. After these fixes, all the UVC related test assertions PASS (but one also need to handle the Processing Unit/Selector Unit and Camera Terminal Unit test cases in the applicat

[PATCH 1/3] usb: gadget/uvc: Fix 'Illegal endpoint address 0x80' issue for VC Endpoint

2012-07-25 Thread Bhupesh Sharma
In case of super-speed descriptors for a UVC device, the `bEndpointAddress` of the video control endpoint (interrupt endpoint), was not correctly assigned and hence it was initialized with a default value of 0x80. This caused the enumeration of a super-speed UVC device on a Windows7 host machine to

[PATCH 2/3] usb: gadget/uvc: Add fix for UVC compliance test suite assertion 6.3.90 failure

2012-07-25 Thread Bhupesh Sharma
As per UVC compliance test specification's assertion number 6.3.90 related to 'Standard VS Isochronous Video Data Endpoint Descriptor Assertions', the bits D3..2 of 'bmAttributes' field of Standard VS Isochronous Video Data Endpoint Descriptor should be 01 (binary) to indicate that the synchronizat

[PATCH 3/3] usb: gadget/uvc: Add fix for UVC compliance test suite's assertion 6.1.25 failure

2012-07-25 Thread Bhupesh Sharma
As per the UVC compliance test suite's assertion 6.1.25, the `iFunction` field of the Interface Association Descriptor (IAD) should the match the `iInterface` field of the standard Video Control (VC) Interface Descriptor for this Video Interface Collection (VIC). This mandatory case is captured in

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-25 Thread Matthew Hall
On Wed, Jul 25, 2012 at 10:46:37AM -0700, Sarah Sharp wrote: > Hi Matthew! It helps if you Cc my email address in your mail. > Otherwise it might get lost in a separate folder and ignored for a > couple days. I was attempting to follow the pattern you established with Gary when you redirected hi

Re: the dreaded "needs XHCI_TRUST_TX_LENGTH quirk" returns

2012-07-25 Thread Matthew Hall
Forgot to mention, I put a new log here with the latest behavior with the patch: http://www.mhcomputing.net/tmp/xhci-bug/dmesg-usb-3-port-quirk-patch-plugin.txt.gz Regards, Matthew. On Wed, Jul 25, 2012 at 10:24:26PM -0700, Matthew Hall wrote: > On Wed, Jul 25, 2012 at 10:46:37AM -0700, Sarah S

Re: usb : mass storage : short_not_ok for non usb3 udc

2012-07-25 Thread Rajaram R
On Thu, Jul 26, 2012 at 2:33 AM, Alan Stern wrote: > On Wed, 25 Jul 2012, Paul Zimmerman wrote: > >> > From: Alan Stern [mailto:st...@rowland.harvard.edu] >> > Sent: Wednesday, July 25, 2012 12:48 PM >> > To: Paul Zimmerman >> > Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org >> > Subj

[PATCH] usb:musb: Fix for Full Speed issue

2012-07-25 Thread Ajay M JAWADE
After sending the USB Bus reset, Host waits for High Speed Chirps. If the soft-disconnect and soft-connect happens during this chirp time, then Host doesn't detect this disconnect. Host treats this as Full Speed Device as there are no chirps. To avoid this Full Speed Enumeration, soft-disconnect an

[PATCH] usb:musb: Fix for Full Speed issue

2012-07-25 Thread Ajay M JAWADE
After sending the USB Bus reset, Host waits for High Speed Chirps. If the soft-disconnect and soft-connect happens during this chirp time, then Host doesn't detect this disconnect. Host treats this as Full Speed Device as there are no chirps. To avoid this Full Speed Enumeration, soft-disconnect an