usbip & etoken

2012-07-19 Thread Oleg
Hi, list. I have a problem with usbip and etoken. Matt Mooney didn't reply me. Greg Kroah-Hartman seems to be too busy. So, i doesn't know who can help me with my problem. May be anybody know what the cause of the problem? I have a usb etoken that doesn't want to work with usbip from 3.2.21

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Oliver Neukum
On Wednesday 18 July 2012 15:07:14 Sarah Sharp wrote: > On Wed, Jul 18, 2012 at 09:03:59PM +0200, Oliver Neukum wrote: > > No, now that I think about it an attribute for the drivers is necessary. > > Like drivers have "supports_autosuspend" they also should have > > "supports_power_off". In addi

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Lan Tianyu
On 2012年07月19日 14:37, Oliver Neukum wrote: On Wednesday 18 July 2012 15:07:14 Sarah Sharp wrote: On Wed, Jul 18, 2012 at 09:03:59PM +0200, Oliver Neukum wrote: No, now that I think about it an attribute for the drivers is necessary. Like drivers have "supports_autosuspend" they also should ha

[PATCH 2/4] usb: musb: host: don't program dma for zero byte tx

2012-07-19 Thread Ajay Kumar Gupta
This is to reduce the overhead of dma programming for zero byte transmit as same can be done using pio mode. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_host.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_host.c b/driver

[PATCH 1/4] usb: musb: gadget: fix kernel crash after rmmod

2012-07-19 Thread Ajay Kumar Gupta
musb->gadget_driver is not getting reset to NULL after the gadget driver is removed. Fixing the same by resetting the musb->gadget_driver to NULL when gadget driver is removed. Signed-off-by: Ajay Kumar Gupta --- This set of four patches are musb bugfix and created against linus's tree. driver

[PATCH 3/4] usb: musb: gadget: don't program dma for zero byte tx

2012-07-19 Thread Ajay Kumar Gupta
This is to reduce the overhead of dma programming for zero byte transmit as same can be done using pio mode. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_gadget.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/m

[PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Ajay Kumar Gupta
There is no need to call read_fifo for zero byte length. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_gadget_ep0.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_gadget_ep0.c b/drivers/usb/musb/musb_gadget_ep0.c index e40d764..d7

[PATCH] USB: musb: NAK timeout scheme on bulk TX endpoint

2012-07-19 Thread Ajay Kumar Gupta
Fixes endpoint starvation issue when more than one bulk QH is multiplexed on the reserved bulk TX endpoint. This patch sets the NAK timeout interval for such QHs, and when a timeout triggers the next QH will be scheduled. This scheme doesn't work for devices which are connected to a high to full

Re: [PATCH] usb: chipidea: ci13xxx-imx: remove global struct

2012-07-19 Thread Wolfram Sang
On Thu, Jul 19, 2012 at 01:31:07AM +0200, Michael Grzeschik wrote: > This patch removes the limitation of having only one > instance of the ci13xxx-imx. Each instance of the ci13xxx-imx > could have different flags to be configured with, so we also > move this settings to the devicetree properties.

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Lan Tianyu
On 2012年07月19日 14:37, Oliver Neukum wrote: On Wednesday 18 July 2012 15:07:14 Sarah Sharp wrote: On Wed, Jul 18, 2012 at 09:03:59PM +0200, Oliver Neukum wrote: No, now that I think about it an attribute for the drivers is necessary. Like drivers have "supports_autosuspend" they also should ha

Re: [PATCH v3 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 11:11 AM, Ajay Kumar Gupta wrote: > Currently we have one single nop transceiver support as same is > defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. > This need to be changed to support multiple otg controller each > using nop transceiver on a platfor

Re: [PATCH v3 07/11] usb: otg: nop: add dt support

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 11:11 AM, Ajay Kumar Gupta wrote: > Added device tree support for nop transceiver driver and updated the > Documentation with device tree binding information for am33xx platform. > > Signed-off-by: Ajay Kumar Gupta > --- > .../devicetree/bindings/usb/am33xx-usb.txt

RE: Problems with the Nikon D800 and USB3

2012-07-19 Thread Xu, Andiry
Sorry about that, but you need to enable CONFIG_USB_DEBUG too. Can you rebuild the kernel and send out the dmesg again? Thanks, Andiry -Original Message- From: Richard Adams [mailto:rich...@digicave.com] Sent: Wednesday, July 18, 2012 6:50 PM To: Xu, Andiry Cc: linux-usb@vger.kernel.org

RE: [PATCH v3 07/11] usb: otg: nop: add dt support

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > > Added device tree support for nop transceiver driver and updated the > > Documentation with device tree binding information for am33xx platform. > > > > Signed-off-by: Ajay Kumar Gupta > > --- > > .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ > > drivers/usb/otg/nop-usb-x

RE: [PATCH v3 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > > Currently we have one single nop transceiver support as same is > > defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. > > This need to be changed to support multiple otg controller each > > using nop transceiver on a platform such as am335x. > > > > Signed-off-by: Ajay Kumar

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Munegowda, Keshava
On Thu, Jul 12, 2012 at 12:11 PM, Munegowda, Keshava wrote: > On Wed, Jul 11, 2012 at 7:53 PM, Kevin Hilman wrote: >> "Munegowda, Keshava" writes: >> >>> On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, K

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Felipe Balbi
Hi, On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled > "Fix OMAP EHCI suspend/resume failure (i693)" is causing > the usb hub and device detection fails in beagle XM > causeing NFS not functional. This affects the core

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Oliver Neukum
On Thursday 19 July 2012 15:42:37 Lan Tianyu wrote: > On 2012年07月19日 14:37, Oliver Neukum wrote: > > But this leaves me with a question. Has anybody ever measured the additional > > power savings compared to a suspended state for devices? Or are you doing > > this only as a prelude to become able

[PATCH v4 0/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-19 Thread Laurent Pinchart
Hi, Here's the fourth version of the Logitech UVC devices RESET_RESUME quirk patches. Compared to v3, the usb_detect_interface_quirks() has been moved to usb_enumerate_device(). Laurent Pinchart (2): usb: Add quirk detection based on interface information usb: Add USB_QUIRK_RESET_RESUME for a

[PATCH v4 1/2] usb: Add quirk detection based on interface information

2012-07-19 Thread Laurent Pinchart
When a whole class of devices (possibly from a specific vendor, or across multiple vendors) require a quirk, explictly listing all devices in the class make the quirks table unnecessarily large. Fix this by allowing matching devices based on interface information. Signed-off-by: Laurent Pinchart

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Oliver Neukum
On Thursday 19 July 2012 16:21:38 Lan Tianyu wrote: > On 2012年07月19日 14:37, Oliver Neukum wrote: > > Unloading the driver is a user space issue. > > But you are right there is a missing case > hi all: > I have a question About device which needs a firmware when connected. > If the port

[PATCH v4 2/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-19 Thread Laurent Pinchart
Most Logitech UVC webcams (both early models that don't advertise UVC compatibility and newer UVC-advertised devices) require the RESET_RESUME quirk. Instead of listing each and every model, match the devices based on the UVC interface information. Signed-off-by: Laurent Pinchart --- drivers/usb

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Ming Lei
On Thu, Jul 19, 2012 at 5:33 PM, Oliver Neukum wrote: > On Thursday 19 July 2012 16:21:38 Lan Tianyu wrote: >> On 2012年07月19日 14:37, Oliver Neukum wrote: > >> > Unloading the driver is a user space issue. >> > But you are right there is a missing case >> hi all: >> I have a question About de

Re: [PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Sergei Shtylyov
Hello. On 19-07-2012 11:55, Ajay Kumar Gupta wrote: There is no need to call read_fifo for zero byte length. The same as there's no need to write, and not only here? Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_gadget_ep0.c |6 -- 1 files changed, 4 insertions(+)

RE: [PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > On 19-07-2012 11:55, Ajay Kumar Gupta wrote: > > > There is no need to call read_fifo for zero byte length. > > The same as there's no need to write, and not only here? Yes, it applies to write also but seems write is taken care for zero byte length. > > > Signed-off-by: Ajay Kumar

[PATCH v4 00/11] usb: musb: adding multi instance support

2012-07-19 Thread Ajay Kumar Gupta
This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle() to g

[PATCH v4 05/11] usb: musb: dsps: add dt support

2012-07-19 Thread Ajay Kumar Gupta
Added device tree support for dsps musb glue driver and updated the Documentation with device tree binding information. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt | 14 + drivers/usb/musb/musb_dsps.c | 60 +

[PATCH v4 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-19 Thread Ajay Kumar Gupta
Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/a

[PATCH v4 08/11] arm/dts: am33xx: add dt data for usb nop phy

2012-07-19 Thread Ajay Kumar Gupta
AM33xx has two musb controller and they have one NOP PHY each. Added the device tree data for NOP PHY. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/d

[PATCH v4 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-19 Thread Ajay Kumar Gupta
Currently we have one single nop transceiver support as same is defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. This need to be changed to support multiple otg controller each using nop transceiver on a platform such as am335x. Signed-off-by: Ajay Kumar Gupta --- arch/arm/mach-o

[PATCH v4 03/11] usb: musb: am335x: add support for dual instance

2012-07-19 Thread Ajay Kumar Gupta
AM335x and TI81xx platform has dual musb controller so updating the musb_dspc.c to support the same. Changes: - Moved otg_workaround timer to glue structure - Moved static local variable last_timer to glue structure - PHY on/off related cleanups Signed-off-by: Ajay Kumar G

[PATCH v4 09/11] usb: musb: dsps: remove explicit NOP device creation

2012-07-19 Thread Ajay Kumar Gupta
As NOP device node is now added in am33xx tree so remove the call which creates the NOP platform_device. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_dsps.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/mus

[PATCH v4 01/11] usb: musb: add musb->id to identify core instance

2012-07-19 Thread Ajay Kumar Gupta
Added 'id' field within 'struct musb' which can be used to determine the current instance of musb controller. Also defined musb_ida in musb_core.c to manage the core ids. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/am35x.c | 42 -- drivers/

[PATCH v4 11/11] arm/dts: am33xx: add phy phandle to usbss

2012-07-19 Thread Ajay Kumar Gupta
Added NOP PHY phandle to usbss device node as same will be used to get the phy from otg framework. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.

[PATCH v4 07/11] usb: otg: nop: add dt support

2012-07-19 Thread Ajay Kumar Gupta
Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ drivers/usb/otg/nop-usb-xceiv.c| 1

[PATCH v4 02/11] usb: musb: kill global and static for multi instance

2012-07-19 Thread Ajay Kumar Gupta
Moved global variable "musb_debugfs_root" and static variable "old_state" to 'struct musb' to help support multi instance of musb controller as present on AM335x platform. Also removed the global variable "orig_dma_mask" and filled the dev->dma_mask with parent device's dma_mask. Signed-off-by: A

[PATCH v4 10/11] usb: musb: dsps: get the PHY using phandle api

2012-07-19 Thread Ajay Kumar Gupta
AM33xx has two PHY of same type used by each musb controller so use phandle of phy nodes to get the phy pointer. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |2 ++ drivers/usb/musb/musb_dsps.c |4 +++- 2 files changed, 5 in

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Munegowda, Keshava
On Thu, Jul 19, 2012 at 3:50 PM, Felipe Balbi wrote: > Hi, > > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: >> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled >> "Fix OMAP EHCI suspend/resume failure (i693)" is causing >> the usb hub and device detection fails in

Re: [PATCH] usb: chipidea: ci13xxx-imx: remove global struct

2012-07-19 Thread Michael Grzeschik
Hi Wolfram, On Thu, Jul 19, 2012 at 10:28:56AM +0200, Wolfram Sang wrote: > On Thu, Jul 19, 2012 at 01:31:07AM +0200, Michael Grzeschik wrote: > > This patch removes the limitation of having only one > > instance of the ci13xxx-imx. Each instance of the ci13xxx-imx > > could have different flags t

RE: [PATCH v4 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/usb/omap-usb.txt | 34 - > drivers/usb/musb/omap2430.c| 55 > > 2 files changed, 88 insertions(+), 1 deletions(-) > > diff --git a/Documentation/devi

Re: [RFC PATCH for v3.5 0/2] usb: gadget: at91_udc: fix oops regression

2012-07-19 Thread Fabio Porcedda
On Wed, Jul 18, 2012 at 11:56 AM, Sebastian Andrzej Siewior wrote: > On Mon, Jul 16, 2012 at 02:50:29PM +0200, Fabio Porcedda wrote: >> PROBLEM: >> 1. >> usb: gadget: at91_udc: kernel oops regression when connecting the usb cable >> >> 2. >> Every time i connect the usb cable the kernel got a oops

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Lan Tianyu
Resend because sent to maillist failed. 2012/7/19 Oliver Neukum > > On Thursday 19 July 2012 16:21:38 Lan Tianyu wrote: > > On 2012年07月19日 14:37, Oliver Neukum wrote: > > > > Unloading the driver is a user space issue. > > > But you are right there is a missing case > > hi all: > > I have a

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Alan Stern
On Wed, 18 Jul 2012, Oliver Neukum wrote: > On Wednesday 18 July 2012 12:40:38 Alan Stern wrote: > > > Oliver, you seem to be arguing both sides of this discussion. You > > But there are more than two sides in this discussion. > > > point out the the power-off operation is too dangerous in ge

Re: [PATCH v4 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-19 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 19, 2012 at 6:51 PM, Gupta, Ajay Kumar wrote: > Hi, >> Signed-off-by: Kishon Vijay Abraham I >> --- >> Documentation/devicetree/bindings/usb/omap-usb.txt | 34 - >> drivers/usb/musb/omap2430.c| 55 >> >> 2 files change

Re: [PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Sergei Shtylyov
On 07/19/2012 03:22 PM, Gupta, Ajay Kumar wrote: >>> There is no need to call read_fifo for zero byte length. >> The same as there's no need to write, and not only here? > Yes, it applies to write also but seems write is taken care > for zero byte length. Frankly speaking, I don't see i

Re: some questions about usb_serial_probe

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, loody wrote: > > You didn't look at usb_serial_probe. At the end of that function there > I found what you mentioned. > for (i = 0; i < num_ports; ++i) { > > retval = device_add(&port->dev); > ... Yes, that's it. > > is a

RE: [PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and feature add

2012-07-19 Thread Neil Zhang
Hi Balbi, > -Original Message- > From: Neil Zhang [mailto:zhan...@marvell.com] > Sent: 2012年7月10日 10:07 > To: ba...@ti.com; gre...@linuxfoundation.org > Cc: Chao Xie; khoroshi...@ispras.ru; linux-usb@vger.kernel.org; Neil > Zhang > Subject: [PATCH 0/7 v2] usb: gadget: mv_udc: bug fix and f

Re: [PATCH v4 0/2] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, Laurent Pinchart wrote: > Hi, > > Here's the fourth version of the Logitech UVC devices RESET_RESUME quirk > patches. Compared to v3, the usb_detect_interface_quirks() has been moved to > usb_enumerate_device(). > > Laurent Pinchart (2): > usb: Add quirk detection based on

Re: USB enumeration post-resume NOT persistent yet "persist" --> swapped devices nodes --> root partition reference broken

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, Andreas Mohr wrote: > Hi, > > Yesterday I was surprised to see that with *another* external USB disk > happening to be connected before boot, > the system booted with root partition device sdb1 assigned rather than sda1. > Not thinking much, I then proceeded putting the syste

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, Felipe Balbi wrote: > Hi, > > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: > > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled > > "Fix OMAP EHCI suspend/resume failure (i693)" is causing > > the usb hub and device detection fails in beagle X

solar lala shared photos with you

2012-07-19 Thread solar lala
Dear sir We supply solar PV system (including solar panels , frame, cable ,inverter and controller , power distribution cabinet) with 1.6$/w FOB shenzhen. Email me or just call me directly if needed. Thank you! Best wishes lala Ecosol PV Tech Co

Re: Kernel tracing options with USB subsystem

2012-07-19 Thread Balakumar
Hello Alan, John, I had this question from the embedded perspective. printk on occasions seems to have some overhead which actually dilutes the issue occurrence frequency. So, just wanted to know if this was not included by choice. Many Thanks, ~Bala On 07/19/2012 12:12 AM, Alan Stern wrote:

[PATCH 1/2] usb/at91udc: don't overwrite driver data

2012-07-19 Thread Sebastian Andrzej Siewior
The driver was converted to the new start/stop interface in f3d8bf34c2 ("usb: gadget: at91_udc: convert to new style start/stop interface"). I overlooked that the driver is overwritting the private data which is used by the composite framework. The udc driver doesn't read it, it is only writen here

[PATCH 2/2] usb/at91udc: Don't check for ep->ep.desc

2012-07-19 Thread Sebastian Andrzej Siewior
We used earlier to check for ep->ep.desc to figure out if this ep is already enabled and if so, abort. Ido Shayevitz removed the usb_endpoint_descriptor from private udc structure 5a6506f00 ("usb: gadget: Update at91_udc to use usb_endpoint_descriptor inside the struct usb_ep") but did not fix up t

Re: [RFC PATCH for v3.5 0/2] usb: gadget: at91_udc: fix oops regression

2012-07-19 Thread Sebastian Andrzej Siewior
On Thu, Jul 19, 2012 at 03:50:54PM +0200, Fabio Porcedda wrote: > > I would prefer to fix the bug causing the oops instead of reverting patches. > > Me too, it's just that i don't have much time to work on that, and so > I'm not confident to be able to fix the kernel panic oops in time for > the v

Re: USB enumeration post-resume NOT persistent yet "persist" --> swapped devices nodes --> root partition reference broken

2012-07-19 Thread Andreas Mohr
Hi, On Thu, Jul 19, 2012 at 11:11:50AM -0400, Alan Stern wrote: > On Thu, 19 Jul 2012, Andreas Mohr wrote: > > > Hi, > > > > Yesterday I was surprised to see that with *another* external USB disk > > happening to be connected before boot, > > the system booted with root partition device sdb1 ass

Re: Kernel tracing options with USB subsystem

2012-07-19 Thread Greg KH
On Thu, Jul 19, 2012 at 10:00:12PM +0530, Balakumar wrote: > Hello Alan, John, > > I had this question from the embedded perspective. printk on > occasions seems to have some overhead which actually dilutes the > issue occurrence frequency. So, just wanted to know if this was not > included by cho

Re: USB enumeration post-resume NOT persistent yet "persist" --> swapped devices nodes --> root partition reference broken

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, Andreas Mohr wrote: > Hi, > > On Thu, Jul 19, 2012 at 11:11:50AM -0400, Alan Stern wrote: > > On Thu, 19 Jul 2012, Andreas Mohr wrote: > > > > > Hi, > > > > > > Yesterday I was surprised to see that with *another* external USB disk > > > happening to be connected before boo

usbserial issue

2012-07-19 Thread Guilherme Bedin
Hi, I am playing with some devices and seems to me that I stuck with a driver limitation. I connected usb-to-rs323/485 converter that uses ftdi_sio and usbserial modules and it works. After that I tried to use a 3g modem and it works passing vendor and product parameters to the usbserial module

[PATCH 0/6] USBHID: fix several suspend-related bugs

2012-07-19 Thread Alan Stern
Jiri: This patch series fixes several major and minor bugs in the usbhid driver related to suspend and resume, and especially autosuspend. I don't think any of the problems are terribly severe, although some of them prevent autosuspend from working properly, so I haven't marked the patches for -

[PATCH 1/6] USBHID: fix use-after-free bug

2012-07-19 Thread Alan Stern
This patch (as1592) fixes an obscure problem in the usbhid driver. Under some circumstances, a control or interrupt-OUT URB can be submitted twice. This will happen if the first submission fails; the queue pointers aren't updated, so the next time the queue is restarted the same URB will be submit

[PATCH 2/6] USBHID: fix autosuspend calls

2012-07-19 Thread Alan Stern
This patch (as1593) fixes some logic errors in the usbhid driver relating to runtime PM. The driver does not balance its calls to usb_autopm_get_interface_async() and usb_autopm_put_interface_async(). For example, when the control queue is restarted the driver does a _get. But the resume won't h

[PATCH 3/6] USBHID: inline some simple routines

2012-07-19 Thread Alan Stern
This patch (as1594) simplifies the usbhid driver by inlining a couple of routines. As a result of an earlier patch, irq_out_pump_restart() and ctrl_pump_restart() are each used in only one place. Since they don't really do what their names say, and since they each involve only about two lines of

[PATCH 4/6] USBHID: replace HID_REPORTED_IDLE with HID_SUSPENDED

2012-07-19 Thread Alan Stern
This patch (as1595) improves the usbhid driver by using the HID_SUSPENDED bitflag to indicate that the device is suspended rather than using HID_REPORTED_IDLE, which the patch removes. Since HID_SUSPENDED was not being used for anything, and since the name "HID_REPORTED_IDLE" doesn't convey much m

[PATCH 5/6] USBHID: check for suspend or reset before restarting

2012-07-19 Thread Alan Stern
This patch (as1596) improves the queue-restart logic in usbhid by checking to see if the device is suspended or a reset is about to occur. There's no point submitting an URB if either of those is true. Signed-off-by: Alan Stern CC: Oliver Neukum --- drivers/hid/usbhid/hid-core.c |6 -

[PATCH 6/6] USBHID: fix error paths in suspend

2012-07-19 Thread Alan Stern
This patch (as1597) fixes some of the error paths in usbhid's suspend routine. The driver was not careful to restart everything that might have been stopped, in cases where a suspend failed. For example, once the HID_SUSPENDED flag is set, an output report submission would not restart the corresp

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Oliver Neukum
On Thursday 19 July 2012 18:58:38 Ming Lei wrote: > On Thu, Jul 19, 2012 at 5:33 PM, Oliver Neukum wrote: > > Yes. That's how reset_resume() works. > > If reset_resume flag is set, usbcore will try to reset the device first > during resume, and no disconnect will be involved if reset completes >

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Oliver Neukum
On Thursday 19 July 2012 10:42:23 Alan Stern wrote: > > > > 1) remote wakeup is requested > > 2) user space has blocked it via the new sysfs attribute > > 3) USB_QUIRK_RESET_MORPHS is set > > The same is true for external ports if they are marked as > non-removable. For example, consider a comp

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Alan Stern
On Thu, 19 Jul 2012, Oliver Neukum wrote: > On Thursday 19 July 2012 18:58:38 Ming Lei wrote: > > On Thu, Jul 19, 2012 at 5:33 PM, Oliver Neukum wrote: > > > > Yes. That's how reset_resume() works. > > > > If reset_resume flag is set, usbcore will try to reset the device first > > during resume

Re: usbserial issue

2012-07-19 Thread Greg KH
On Thu, Jul 19, 2012 at 04:37:17PM -0300, Guilherme Bedin wrote: > Hi, > > I am playing with some devices and seems to me that I stuck with > a driver limitation. I connected usb-to-rs323/485 converter > that uses ftdi_sio and usbserial modules and it works. After that > I tried to use a 3g mod

Re: usbserial issue

2012-07-19 Thread Guilherme Bedin
Hi, Thanks for explanation on how things work. The problem is if I don't pass the vendor and prodId the 3g modem is detect as an USB mass storage. Even after using usb_modeswitch usb_modeswitch -default-vendor 0x19d2 -default-product 0×2000 -target-vendor 0x19d2 -target-product 0×0031 -message

Re: [RFC PATCH for v3.5 0/2] usb: gadget: at91_udc: fix oops regression

2012-07-19 Thread Greg Kroah-Hartman
On Thu, Jul 19, 2012 at 07:16:54PM +0200, Sebastian Andrzej Siewior wrote: > On Thu, Jul 19, 2012 at 03:50:54PM +0200, Fabio Porcedda wrote: > > > I would prefer to fix the bug causing the oops instead of reverting > > > patches. > > > > Me too, it's just that i don't have much time to work on th

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Greg KH
On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote: > Hi, > > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: > > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled > > "Fix OMAP EHCI suspend/resume failure (i693)" is causing > > the usb hub and device detecti

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-19 Thread Greg KH
On Thu, Jul 19, 2012 at 03:54:05PM -0700, Greg KH wrote: > On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote: > > > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled > > > "Fix OMAP EHCI suspend

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-19 Thread Greg KH
On Tue, Jul 17, 2012 at 08:34:39PM +0200, Marc Kleine-Budde wrote: > On 07/17/2012 07:47 PM, Greg KH wrote: > > On Mon, Jul 16, 2012 at 10:18:20PM +0200, Marc Kleine-Budde wrote: > >> Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", > >> the udc part of the chipidea driver need

Re: [PATCH] isp1362-hcd.c: usb message always saved in case of underrun

2012-07-19 Thread Greg KH
On Wed, Jul 18, 2012 at 10:53:09AM +0200, Claudio Scordino wrote: > Il 06/07/2012 19:41, Greg KH ha scritto: > >On Wed, Jun 27, 2012 at 06:01:39PM +0200, Claudio Scordino wrote: > >>Hi Olav, > >> > >>please find below a patch for the isp1362-hcd.c driver to always > >>save the message in case o

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Ming Lei
On Fri, Jul 20, 2012 at 3:37 AM, Oliver Neukum wrote: > > We cannot do this as the device state is specific to a driver. And the driver > must have an interface to be bound to. That is why we use reset_resume() > instead of resume(). resume() means that the device must be brought up > but has reta

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Peter Chen
> Oh. I recheck find these device will use ordinary resume rather than > reset_resume(). > I remeber you said userspace should set USB_QUIRK_RESET_MORPHS for those > kind devices. After reset, they will morph. So reset_resume doesn't > work for them. > Ordinary resume almost just calls usb_get_stat

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-19 Thread Lan Tianyu
On 2012年07月20日 09:18, Peter Chen wrote: Oh. I recheck find these device will use ordinary resume rather than reset_resume(). I remeber you said userspace should set USB_QUIRK_RESET_MORPHS for those kind devices. After reset, they will morph. So reset_resume doesn't work for them. Ordinary resume

RE: [PATCH 4/4] usb: musb: gadget: do read_fifo for non zero data only

2012-07-19 Thread Gupta, Ajay Kumar
Hi, > On 07/19/2012 03:22 PM, Gupta, Ajay Kumar wrote: > > >>> There is no need to call read_fifo for zero byte length. > > >> The same as there's no need to write, and not only here? > > > Yes, it applies to write also but seems write is taken care > > for zero byte length. > >Frankly

[PATCH v2 3/4] usb: musb: gadget: don't program dma for zero byte tx

2012-07-19 Thread Ajay Kumar Gupta
This is to reduce the overhead of dma programming for zero byte transmit as same can be done using pio mode. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_gadget.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/m

[PATCH v2 2/4] usb: musb: host: don't program dma for zero byte tx

2012-07-19 Thread Ajay Kumar Gupta
This is to reduce the overhead of dma programming for zero byte transmit as same can be done using pio mode. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_host.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/usb/musb/musb_host.c b/driver

[PATCH v2 1/4] usb: musb: gadget: fix kernel crash after rmmod

2012-07-19 Thread Ajay Kumar Gupta
musb->gadget_driver is not getting reset to NULL after the gadget driver is removed. Fixing the same by resetting the musb->gadget_driver to NULL when gadget driver is removed. Signed-off-by: Ajay Kumar Gupta --- Changes from v1: - Fixed Sergei's commend on [PATCH 4/4] drivers/usb/musb

[PATCH v2 4/4] usb: musb: check for zero byte in musb_read/write_fifo

2012-07-19 Thread Ajay Kumar Gupta
Added a check in musb_{read | write}_fifo for zero byte length. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_core.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index db3dff8..2901f38 100644

[PATCH v5 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-19 Thread Kishon Vijay Abraham I
All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap_phy_internal.c | 138 --- arch/arm/

[PATCH v5 06/11] arm/dts: Add twl6030-usb data

2012-07-19 Thread Kishon Vijay Abraham I
Add twl6030-usb data node in twl6030 device tree file Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4-panda.dts |4 arch/arm/boot/dts/omap4-sdp.dts |4 arch/arm/boot/dts/twl6030.dtsi|6 ++ 3 files changed, 14 insertions(+) diff --git a/arch/arm/

[PATCH v5 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-19 Thread Kishon Vijay Abraham I
Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 22 +++ drivers/usb/otg/twl6030-usb.c | 39 +-

[PATCH v5 00/11] omap: musb: Add device tree support

2012-07-19 Thread Kishon Vijay Abraham I
This patch series adds device tree support for MUSB and device tree support for all the related modules to get MUSB working in OMAP platform. A new omap-usb2 phy driver has been added (with only dt suppport) to perform phy configurations. Previously this configuration was performed by twl6030, usi

[PATCH v5 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-07-19 Thread Kishon Vijay Abraham I
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Writing to control module which is now handled in omap2430.c should be

[PATCH v5 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-19 Thread Kishon Vijay Abraham I
Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 29c6243..15f1890 100644 --- a/arch/arm/boot/dts/

[PATCH v5 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-19 Thread Kishon Vijay Abraham I
Add device tree support for twl4030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 ++ drivers/usb/otg/twl4030-usb.c | 26 +++

[PATCH v5 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-19 Thread Kishon Vijay Abraham I
All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for usb2 phy driver and the documentation with device tree binding information is

[PATCH v5 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-07-19 Thread Kishon Vijay Abraham I
The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to control module, omap2430 will handle the register writes to

[PATCH v5 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-19 Thread Kishon Vijay Abraham I
Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt | 34 +++- drivers/usb/musb/omap2430.c| 54 +

[PATCH v5 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-19 Thread Kishon Vijay Abraham I
Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3-beagle.dts |6 ++ arch/arm/boot/dts/omap3-evm.dts|6 ++ arch/arm/boot/dts/omap3.dtsi

[PATCH v5 08/11] arm/dts: Add twl4030-usb data

2012-07-19 Thread Kishon Vijay Abraham I
Add twl4030-usb data node in twl4030 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/twl4030.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi index 22f4d13..761a5a5 1006

Re: usbserial issue

2012-07-19 Thread Bjørn Mork
Guilherme Bedin writes: > Thanks for explanation on how things work. > The problem is if I don't pass the vendor and prodId the 3g modem is > detect as an USB mass storage. Even after using usb_modeswitch > > usb_modeswitch -default-vendor 0x19d2 -default-product 0×2000 > -target-vendor 0x19d2

[patch] USB: whci-hcd: fix NULL dereference on allocation failure

2012-07-19 Thread Dan Carpenter
If usb_create_hcd() fails here then we dereference "whc" inside the call to whc_clean_up() before it has been set. The compiler would have warned about this if we hadn't initialized all the pointers to NULL at the start of the function. I've cleaned that up as well. Signed-off-by: Dan Carpenter