Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

2012-07-17 Thread James Bottomley
On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote: > On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote: > > From: Namjae Jeon > > > > The numbers of USB HDDs(All USB HDD I checked) does not respond > > correctly to scsi mode sense command for retrieving the write cache > > page status. E

[PATCH v2 00/11] omap: musb: Add device tree support

2012-07-17 Thread Kishon Vijay Abraham I
This patch series adds device tree support for MUSB and device tree support for all the related modules to get MUSB working in OMAP platform. A new omap-usb2 phy driver has been added (with only dt suppport) to perform phy configurations. Previously this configuration was performed by twl6030, usi

[PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread Kishon Vijay Abraham I
Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index bda5df3..4d2dcc1 100644 --- a/a

[PATCH v2 06/11] arm/dts: Add twl6030-usb data

2012-07-17 Thread Kishon Vijay Abraham I
Add twl6030-usb data node in twl6030 device tree file Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4-panda.dts |4 arch/arm/boot/dts/omap4-sdp.dts |4 arch/arm/boot/dts/twl6030.dtsi|6 ++ 3 files changed, 14 insertions(+), 0 deletions(-) diff -

[PATCH v2 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-07-17 Thread Kishon Vijay Abraham I
The mailbox register for usb otg in omap is present in control module. On detection of any events VBUS or ID, this register should be written to send the notification to musb core. Till we have a separate control module driver to write to control module, omap2430 will handle the register writes to

[PATCH v2 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-07-17 Thread Kishon Vijay Abraham I
Add device tree support for twl6030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 22 +++ drivers/usb/otg/twl6030-usb.c | 39 +-

[PATCH v2 10/11] arm/dts: omap: Add usb_otg and glue data

2012-07-17 Thread Kishon Vijay Abraham I
Add usb otg data node in omap4/omap3 device tree file. Also update the node with board specific setting in omapx-.dts file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3-beagle.dts |6 ++ arch/arm/boot/dts/omap3-evm.dts|6 ++ arch/arm/boot/dts/omap3.dtsi

[PATCH v2 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-07-17 Thread Kishon Vijay Abraham I
All the unnessary functions in omap-phy-internal is removed. These functionality are now handled by omap-usb2 phy driver. Cc: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I Acked-by: Tony Lindgren --- arch/arm/mach-omap2/omap_phy_internal.c | 138 --- arch/arm/

[PATCH v2 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-07-17 Thread Kishon Vijay Abraham I
Add device tree support for twl4030 usb driver. Update the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/usb/twl-usb.txt| 19 ++ drivers/usb/otg/twl4030-usb.c | 26 +++

[PATCH v2 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-07-17 Thread Kishon Vijay Abraham I
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Writing to control module which is now handled in omap2430.c should be

[PATCH v2 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-17 Thread Kishon Vijay Abraham I
All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for usb2 phy driver and the documentation with device tree binding information is

[PATCH v2 09/11] drivers: usb: musb: Add device tree support for omap musb glue

2012-07-17 Thread Kishon Vijay Abraham I
Added device tree support for omap musb driver and updated the Documentation with device tree binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt | 34 - drivers/usb/musb/omap2430.c| 55

[PATCH v2 08/11] arm/dts: Add twl4030-usb data

2012-07-17 Thread Kishon Vijay Abraham I
Add twl4030-usb data node in twl4030 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/twl4030.dtsi | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/twl4030.dtsi b/arch/arm/boot/dts/twl4030.dtsi index 22f4

EHCI: Centralize controller initialization

2012-07-17 Thread Andrew Lunn
Hi Alan kisskb is showing up a warning in drivers/usb/host/ehci-orion.c which i think is from a change you made: drivers/usb/host/ehci-orion.c:109:2: warning: passing argument 1 of 'ehci_setup' from incompatible pointer type [enabled by default] diff --git a/drivers/usb/host/ehci-orion.c b/driv

[PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

2012-07-17 Thread Sachin Kamat
Adds header file protection macros. Signed-off-by: Sachin Kamat --- include/linux/platform_data/s3c-hsotg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/platform_data/s3c-hsotg.h b/include/linux/platform_data/s3c-hsotg.h index 97ec12c..ff5892d 10064

[PATCH v2 09/11] usb: musb: dsps: remove explicit NOP device creation

2012-07-17 Thread Ajay Kumar Gupta
As NOP device node is now added in am33xx tree so remove the call which creates the NOP platform_device. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musb_dsps.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/mus

[PATCH v2 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-17 Thread Ajay Kumar Gupta
Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/a

[PATCH v2 11/11] arm/dts: am33xx: add phy phandle to usbss

2012-07-17 Thread Ajay Kumar Gupta
Added NOP PHY phandle to usbss device node as same will be used to get the phy from otg framework. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.

[PATCH v2 08/11] arm/dts: am33xx: add dt data for usb nop phy

2012-07-17 Thread Ajay Kumar Gupta
AM33xx has two musb controller and they have one NOP PHY each. Added the device tree data for NOP PHY. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/d

[PATCH v2 10/11] usb: musb: dsps: get the PHY using phandle api

2012-07-17 Thread Ajay Kumar Gupta
AM33xx has two PHY of same type used by each musb controller so use phandle of phy nodes to get the phy pointer. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |2 ++ drivers/usb/musb/musb_dsps.c |4 +++- 2 files changed, 5 in

[PATCH v2 01/11] usb: musb: add musb->id to identify core instance

2012-07-17 Thread Ajay Kumar Gupta
Added 'id' field within 'struct musb' which can be used to determine the current instance of musb controller. Also defined musb_ida in musb_core.c to manage the core ids. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/am35x.c | 42 -- drivers/

[PATCH v2 03/11] usb: musb: am335x: add support for dual instance

2012-07-17 Thread Ajay Kumar Gupta
AM335x and TI81xx platform has dual musb controller so updating the musb_dspc.c to support the same. Changes: - Moved otg_workaround timer to glue structure - Moved static local variable last_timer to glue structure - PHY on/off related cleanups Signed-off-by: Ajay Kumar G

[PATCH v2 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-17 Thread Ajay Kumar Gupta
Currently we have one single nop transceiver support as same is defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. This need to be changed to support multiple otg controller each using nop transceiver on a platform such as am335x. Signed-off-by: Ajay Kumar Gupta --- arch/arm/mach-o

[PATCH v2 07/11] usb: otg: nop: add dt support

2012-07-17 Thread Ajay Kumar Gupta
Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ drivers/usb/otg/nop-usb-xceiv.c| 1

[PATCH v2 05/11] usb: musb: dsps: add dt support

2012-07-17 Thread Ajay Kumar Gupta
Added device tree support for dsps musb glue driver and updated the Documentation with device tree binding information. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt | 14 + drivers/usb/musb/musb_dsps.c | 62 +

[PATCH v2 02/11] usb: musb: kill global and static for multi instance

2012-07-17 Thread Ajay Kumar Gupta
Moved global variable "musb_debugfs_root" and static variable "old_state" to 'struct musb' to help support multi instance of musb controller as present on AM335x platform. Also removed the global variable "orig_dma_mask" and filled the dev->dma_mask with parent device's dma_mask. Signed-off-by: A

[PATCH v2 00/11] usb: musb: adding multi instance support

2012-07-17 Thread Ajay Kumar Gupta
Hi, This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API devm_usb_get_phy_by_phandle()

Re: [PATCH 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-07-17 Thread Arnd Bergmann
On Tuesday 17 July 2012, ABRAHAM, KISHON VIJAY wrote: > On Mon, Jul 16, 2012 at 7:43 PM, Kishon Vijay Abraham I wrote: > > Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of > > creating all the devices that is connected to OCP2SCP. In the case of OMAP4, > > USB2PHY is conne

Re: [PATCH] usb: chipidea: fix linking of udc if gadget is build as module

2012-07-17 Thread Felipe Balbi
Hi, On Mon, Jul 16, 2012 at 09:57:27PM +0200, Marc Kleine-Budde wrote: > Hello, > > On 07/16/2012 04:20 PM, Felipe Balbi wrote: > > This is not the real problem. The problem is that USB_CHIPIDEA depends > > on USB (which is the Host side USB). So if you make host built-in, you > > can

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-17 Thread Felipe Balbi
Hi, On Mon, Jul 16, 2012 at 10:18:20PM +0200, Marc Kleine-Budde wrote: > Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", > the udc part of the chipidea driver needs the generic usb gadget helper > functions. If the chipidea driver with udc support is built into the > kernel a

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-17 Thread Marc Kleine-Budde
On 07/17/2012 11:15 AM, Felipe Balbi wrote: > On Mon, Jul 16, 2012 at 10:18:20PM +0200, Marc Kleine-Budde wrote: >> Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", >> the udc part of the chipidea driver needs the generic usb gadget helper >> functions. If the chipidea driver w

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-17 Thread Felipe Balbi
Hi, On Tue, Jul 17, 2012 at 11:34:52AM +0200, Marc Kleine-Budde wrote: > On 07/17/2012 11:15 AM, Felipe Balbi wrote: > > On Mon, Jul 16, 2012 at 10:18:20PM +0200, Marc Kleine-Budde wrote: > >> Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", > >> the udc part of the chipidea d

[PATCH RESEND v4] USB: host: Add Device tree support for ohci-exynos & ehci-s5p

2012-07-17 Thread Vivek Gautam
Adding Greg KH, and Jingoo Han in the mail thread. Reworked third patch; other two got applied to 'usb-next' branch. Changes from v3: 1) Change the function name from s5p_ehci_setup_gpio() to s5p_setup_vbus_gpio(). 2) Make s5p_setup_vbus_gpio() function to return void instead of int. 3) Return vo

[PATCH RESEND v4] USB: ehci-s5p: Add vbus setup function to the s5p ehci glue layer

2012-07-17 Thread Vivek Gautam
This patch retrieves and configures the vbus control gpio via the device tree. The suspend/resume callbacks will be later modified for vbus control. Signed-off-by: Abhilash Kesavan Signed-off-by: Vivek Gautam --- drivers/usb/host/ehci-s5p.c | 21 + 1 files changed, 21 inse

Re: [PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

2012-07-17 Thread Felipe Balbi
On Tue, Jul 17, 2012 at 02:40:10PM +0530, Sachin Kamat wrote: > Adds header file protection macros. you need to comment if you actually ran into an issue. Is there any file which ends up with double inclusion of this header or are you just trying to be safe ? > Signed-off-by: Sachin Kamat > ---

Re: [PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

2012-07-17 Thread Sachin Kamat
On 17/07/2012, Felipe Balbi wrote: > On Tue, Jul 17, 2012 at 02:40:10PM +0530, Sachin Kamat wrote: >> Adds header file protection macros. > > you need to comment if you actually ran into an issue. Is there any file > which ends up with double inclusion of this header or are you just > trying to be

[PATCH Resend] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

2012-07-17 Thread Sachin Kamat
Adds header file protection macros to avoid multiple inclusion. Signed-off-by: Sachin Kamat --- include/linux/platform_data/s3c-hsotg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/platform_data/s3c-hsotg.h b/include/linux/platform_data/s3c-hsotg.h

Re: [PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

2012-07-17 Thread Felipe Balbi
On Tue, Jul 17, 2012 at 04:33:14PM +0530, Sachin Kamat wrote: > On 17/07/2012, Felipe Balbi wrote: > > On Tue, Jul 17, 2012 at 02:40:10PM +0530, Sachin Kamat wrote: > >> Adds header file protection macros. > > > > you need to comment if you actually ran into an issue. Is there any file > > which e

Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.

2012-07-17 Thread Sergei Shtylyov
Hello. On 16-07-2012 20:46, Denis Turischev wrote: Intense-PC is Compulab's mini-desktop with Intel Panther Point chipset. Unconditional ports switching provided by function usb_enable_xhci_ports() leads to surprising results, after shutdown system powered-on again after a few seconds. On Wi

Re: [PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 12:10, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/

Re: [PATCH 1/1] usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 13:10, Sachin Kamat wrote: Adds header file protection macros. Signed-off-by: Sachin Kamat --- include/linux/platform_data/s3c-hsotg.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/linux/platform_data/s3c-hsotg.h b/include/li

Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread Sergei Shtylyov
Hello. On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi

Re: [PATCH v2 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 13:13, Ajay Kumar Gupta wrote: Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 fil

Re: [PATCH v2 07/11] usb: otg: nop: add dt support

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 13:13, Ajay Kumar Gupta wrote: Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |3 ++

Re: [PATCH v2 08/11] arm/dts: am33xx: add dt data for usb nop phy

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 13:13, Ajay Kumar Gupta wrote: AM33xx has two musb controller and they have one NOP PHY each. Added the device tree data for NOP PHY. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-)

Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios

2012-07-17 Thread Dirk Behme
On 13.06.2012 14:34, Richard Zhao wrote: Sometimes, boards have gpios that don't own by any driver or owner by a generic driver that don't like hacks. Such gpios is normally output and need setup once on boot. So I introduce the config-on-boot gpios. Signed-off-by: Richard Zhao Cc: Shawn Guo C

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Lan Tianyu
On 2012/7/16 22:13, Alan Stern wrote: On Mon, 16 Jul 2012, Lan Tianyu wrote: Currently, "power/wakeup" sysfs file can't control remote wakeup in the runtime suspend. It only depends on "usb_interface->needs_remote_wakeup" to determine whether enable remote wakeup or not when runtime suspending.

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Oliver Neukum
On Tuesday 17 July 2012 21:35:00 Lan Tianyu wrote: > On 2012/7/16 22:13, Alan Stern wrote: > > On Mon, 16 Jul 2012, Lan Tianyu wrote: > > > >> Currently, "power/wakeup" sysfs file can't control remote wakeup in the > >> runtime > >> suspend. It only depends on "usb_interface->needs_remote_wakeup"

[PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Laurent Pinchart
Most Logitech UVC webcams (both early models that don't advertise UVC compatibility and newer UVC-advertised devices) require the RESET_RESUME quirk. Instead of listing each and every model, match the devices based on the UVC interface information. Signed-off-by: Laurent Pinchart --- drivers/usb

Re: EHCI: Centralize controller initialization

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Andrew Lunn wrote: > Hi Alan > > kisskb is showing up a warning in drivers/usb/host/ehci-orion.c > which i think is from a change you made: > > drivers/usb/host/ehci-orion.c:109:2: warning: passing argument 1 of > 'ehci_setup' from incompatible pointer type [enabled by defa

Re: [PATCH RESEND v4] USB: ehci-s5p: Add vbus setup function to the s5p ehci glue layer

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Vivek Gautam wrote: > This patch retrieves and configures the vbus control gpio via > the device tree. The suspend/resume callbacks will be later > modified for vbus control. > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vivek Gautam Acked-by: Alan Stern -- To uns

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Oliver Neukum wrote: > > Yeah. Lost some background introduction. I recently try to realize usb > > port power off mechanism for ports with device. So design, the port with > > device only can be power off when remote wakeup disable. Why is that? What happens if you power-o

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Lan Tianyu
On 2012/7/17 21:48, Oliver Neukum wrote: On Tuesday 17 July 2012 21:35:00 Lan Tianyu wrote: On 2012/7/16 22:13, Alan Stern wrote: On Mon, 16 Jul 2012, Lan Tianyu wrote: Currently, "power/wakeup" sysfs file can't control remote wakeup in the runtime suspend. It only depends on "usb_interface->

Re: [PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Laurent Pinchart wrote: > Most Logitech UVC webcams (both early models that don't advertise UVC > compatibility and newer UVC-advertised devices) require the RESET_RESUME > quirk. Instead of listing each and every model, match the devices based > on the UVC interface informati

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Oliver Neukum
On Tuesday 17 July 2012 22:28:32 Lan Tianyu wrote: > On 2012/7/17 21:48, Oliver Neukum wrote: > > But the driver will not work if you don't use remote wakeup when it needs > > it. > > Under those circumstances you better unbind the driver. > > > hi Oliver: > Thanks for reply. Why unbind dri

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Lan Tianyu
On 2012/7/17 22:26, Alan Stern wrote: On Tue, 17 Jul 2012, Oliver Neukum wrote: Yeah. Lost some background introduction. I recently try to realize usb port power off mechanism for ports with device. So design, the port with device only can be power off when remote wakeup disable. Why is that?

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Lan Tianyu wrote: > > But the driver will not work if you don't use remote wakeup when it needs > > it. > > Under those circumstances you better unbind the driver. > > > hi Oliver: > Thanks for reply. Why unbind driver? I am sorry I don't understand it. > Can you elabo

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Oliver Neukum
On Tuesday 17 July 2012 22:49:26 Lan Tianyu wrote: > On 2012/7/17 22:26, Alan Stern wrote: > > What sort of driver are you talking about? An HID driver? Serial > > driver? > I can find hid, bcm, serial, mouse, screen and some net device drivers > does such thing. set needs_remote_wakeup to 1 in

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Lan Tianyu wrote: > > Why is that? What happens if you power-off a port where the device has > > remove wakeup enabled? > > > I will not power off a port where the device has remote wakeup enabled. > Only when disabled, the port will power off. What about the case where the

Re: [PATCH RESEND 0/3] scsi: fix internal write cache issue on usb hdd.

2012-07-17 Thread Greg KH
On Tue, Jul 17, 2012 at 08:19:14AM +0100, James Bottomley wrote: > On Mon, 2012-07-16 at 16:48 -0700, Greg KH wrote: > > On Sat, Jul 07, 2012 at 11:04:45PM -0400, Namjae Jeon wrote: > > > From: Namjae Jeon > > > > > > The numbers of USB HDDs(All USB HDD I checked) does not respond > > > correctly

usb-next EHCI improvements success report

2012-07-17 Thread Daniel Drake
Hi Alan, I've been investigating a problem with UVC webcams on the XO-1 laptop (CS5536 EHCI). Running webcam apps, especially guvcview, was killing the entire USB bus more often than not ("failed EHCI handshake, HC died, giving up" or similar). Reproduced on 3.5-rc7 and throughout various old ker

Re: usb-next EHCI improvements success report

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Daniel Drake wrote: > Hi Alan, > > I've been investigating a problem with UVC webcams on the XO-1 laptop > (CS5536 EHCI). > > Running webcam apps, especially guvcview, was killing the entire USB > bus more often than not ("failed EHCI handshake, HC died, giving up" > or simi

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Sarah Sharp
On Tue, Jul 17, 2012 at 10:49:26PM +0800, Lan Tianyu wrote: > On 2012/7/17 22:26, Alan Stern wrote: > >On Tue, 17 Jul 2012, Oliver Neukum wrote: > > > >>>Yeah. Lost some background introduction. I recently try to realize usb > >>>port power off mechanism for ports with device. So design, the port w

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-17 Thread Greg KH
On Mon, Jul 16, 2012 at 10:18:20PM +0200, Marc Kleine-Budde wrote: > Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", > the udc part of the chipidea driver needs the generic usb gadget helper > functions. If the chipidea driver with udc support is built into the > kernel and us

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Sarah Sharp
Ok, let's step back a bit here. Tianyu, I think you're confused about what exactly USB device suspend is, and what remote wakeup is. I suggest you read Documentation/power-management.txt. I think Tianyu is concerned that the port power off mechanism will not be used very often because many USB d

Re: [PATCH v2] usb: chipidea: fix and improve dependencies if usb host or gadget support is built as module

2012-07-17 Thread Marc Kleine-Budde
On 07/17/2012 07:47 PM, Greg KH wrote: > On Mon, Jul 16, 2012 at 10:18:20PM +0200, Marc Kleine-Budde wrote: >> Since commit "5e0aa49 usb: chipidea: use generic map/unmap routines", >> the udc part of the chipidea driver needs the generic usb gadget helper >> functions. If the chipidea driver with u

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Sarah Sharp wrote: > On Tue, Jul 17, 2012 at 10:49:26PM +0800, Lan Tianyu wrote: > > On 2012/7/17 22:26, Alan Stern wrote: > > >On Tue, 17 Jul 2012, Oliver Neukum wrote: > > > > > >>>Yeah. Lost some background introduction. I recently try to realize usb > > >>>port power off m

Re: Problems with ASMedia ASM1042 SuperSpeed USB Host

2012-07-17 Thread Sarah Sharp
On Mon, Jul 16, 2012 at 10:56:05AM -0400, Alan Stern wrote: > On Mon, 16 Jul 2012, Ingo Rohloff wrote: > > > Hello, > > > > I have some problems with an ASM1042 SuperSpeed Host Controller. > > (IvyBridge + PantherPoint Motherboard). > > I also read some comments that this particular Host Controll

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Bjørn Mork
Alan Stern writes: > Last time I checked, the > kernel did not try to prevent users from unplugging their USB devices. > :-) That would be a nice feature for usb attached storage devices though :-) Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: Problems with ASMedia ASM1042 SuperSpeed USB Host

2012-07-17 Thread Alan Stern
On Tue, 17 Jul 2012, Sarah Sharp wrote: > > See > > > > http://marc.info/?l=linux-usb&m=134236551409964&w=2 > > > > Apparently the ASM1042 reports that a transfer completed normally even > > when it was short (or when it was cancelled). > > When an URB is canceled, the xHCI driver asks the

[PATCH net-next] net: qmi_wwan: make dynamic device IDs work

2012-07-17 Thread Bjørn Mork
The usbnet API use the device ID table to store a pointer to a minidriver. Setting a generic pointer for dynamic device IDs will in most cases make them work as expected. usbnet will otherwise treat the dynamic IDs as blacklisted. That is rarely useful. There is no standard class describing devic

Re: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Sarah Sharp
On Tue, Jul 17, 2012 at 03:00:08PM -0400, Alan Stern wrote: > On Tue, 17 Jul 2012, Sarah Sharp wrote: > > > On Tue, Jul 17, 2012 at 10:49:26PM +0800, Lan Tianyu wrote: > > > On 2012/7/17 22:26, Alan Stern wrote: > > > >On Tue, 17 Jul 2012, Oliver Neukum wrote: > > > > > > > >>>Yeah. Lost some back

[PATCH 0/8] USB port power off mechanism

2012-07-17 Thread Sarah Sharp
The following changes since commit 66177cc10295ffdfc613c06f59b07a577d91ee82: usb: s3c-hsotg: Add header file protection macros in s3c-hsotg.h (2012-07-17 10:54:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sarah/xhci.git for-usb-next-2012-0

[PATCH 1/8] usb: make usb port a real device

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu This patch turns each USB port on a hub into a new struct device. This new device has the USB hub interface device as its parent. The port devices are stored in a new structure (usb_port), and an array of usb_ports are dynamically allocated once we know how many ports the USB h

[PATCH 2/8] usb: move children to struct usb_port

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu The usb_device structure contains an array of usb_device "children". This array is only valid if the usb_device is a hub, so it makes no sense to store it there. Instead, store the usb_device child in its parent usb_port structure. Since usb_port is an internal USB core structu

[PATCH 3/8] usb/acpi: Bind ACPI node to USB port, not usb_device.

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu In the ACPI DSDT table, only usb root hub and usb ports are ACPI device nodes. Originally, we bound the usb port's ACPI node to the usb device attached to the port. However, we want to access those ACPI port methods when the port is empty, and there's no usb_device associated w

[PATCH 7/8] usb: Fail a get config when the port is powered off.

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu Alan Stern pointed out that a USB port could potentially get powered off when the attached USB device is in the middle of enumerating, due to race conditions: http://marc.info/?l=linux-usb&m=134130616707548&w=2 If that happens, we need to ensure the enumeration fails. I

[PATCH 6/8] usb/acpi: Use ACPI methods to power off ports.

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu Upcoming Intel systems will have an ACPI method to control whether a USB port can be completely powered off. The implication of powering off a USB port is that the device and host sees a physical disconnect, and subsequent port connections and remote wakeups will be lost. Add a

[PATCH 8/8] usb : Add sysfs files to control port power.

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu This patch adds two sysfs files for each usb hub port to allow userspace to control the port power policy. For an upcoming Intel xHCI roothub, this will translate into ACPI calls to completely power off or power on the port. As a reminder, when these ports are completely powere

[PATCH 5/8] xhci: Handle clear PORT_POWER feature.

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu This patch makes the xHCI roothub code handle the clear PORT_POWER feature request. Setting port power is already handled. Signed-off-by: Lan Tianyu Signed-off-by: Sarah Sharp --- drivers/usb/host/xhci-hub.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH 4/8] usb/acpi: Store info on device removability.

2012-07-17 Thread Sarah Sharp
From: Lan Tianyu In the upcoming USB port power off patches, we need to know whether a USB port can ever see a disconnect event. Often USB ports are internal to a system, and users can't disconnect USB devices from that port. Sometimes those ports will remain empty, because the OEM chose not to

Re: [PATCH RESEND v4] USB: ehci-s5p: Add vbus setup function to the s5p ehci glue layer

2012-07-17 Thread Jingoo Han
On Tuesday, July 17, 2012 8:03 PM, Vivek Gautam wrote: > > This patch retrieves and configures the vbus control gpio via > the device tree. The suspend/resume callbacks will be later > modified for vbus control. > > Signed-off-by: Abhilash Kesavan > Signed-off-by: Vivek Gautam Acked-by: Jingoo

Re: [PATCH] target: Allow for target_submit_cmd() returning errors

2012-07-17 Thread Nicholas A. Bellinger
On Tue, 2012-07-17 at 23:37 +, Nicholas A. Bellinger wrote: > From: Roland Dreier > > We want it to be possible for target_submit_cmd() to return errors up > to its fabric module callers. For now just update the prototype to > return an int, and update all callers to handle non-zero return v

Re: [PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Eric Ding
On 07/17/2012 10:47 PM, Alan Stern wrote: > On Tue, 17 Jul 2012, Laurent Pinchart wrote: >> Alan, what do you think about this approach ? I'm not sure whether we need to >> include the early UVC models that advertise a vendor-specific class in the >> list. > The general approach is okay. The deta

Re: [PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Laurent Pinchart
On Wednesday 18 July 2012 08:09:27 Eric Ding wrote: > On 07/17/2012 10:47 PM, Alan Stern wrote: > > On Tue, 17 Jul 2012, Laurent Pinchart wrote: > >> Alan, what do you think about this approach ? I'm not sure whether we > >> need to include the early UVC models that advertise a vendor-specific > >>

Re: [PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Laurent Pinchart
Hi Alan, On Tuesday 17 July 2012 10:47:39 Alan Stern wrote: > On Tue, 17 Jul 2012, Laurent Pinchart wrote: > > Most Logitech UVC webcams (both early models that don't advertise UVC > > compatibility and newer UVC-advertised devices) require the RESET_RESUME > > quirk. Instead of listing each and e

Re: [PATCH] usb: Add USB_QUIRK_RESET_RESUME for all Logitech UVC webcams

2012-07-17 Thread Eric Ding
On 07/18/2012 09:13 AM, Laurent Pinchart wrote: > On Wednesday 18 July 2012 08:09:27 Eric Ding wrote: >> On 07/17/2012 10:47 PM, Alan Stern wrote: >>> On Tue, 17 Jul 2012, Laurent Pinchart wrote: Alan, what do you think about this approach ? I'm not sure whether we need to include the ear

some questions about usb_serial_probe

2012-07-17 Thread loody
Dear all: in usb_serial_probe, we create tty_port based on max_endpoints. My questions are: 1. some callback functions, such serial_hangup, serial_carrier_raised, etc. will called by tty layer with different tty_ports. how tty layer know these tty_ports? I only found tty_port_init to initial these

RE: [RFC PATCH] USB: enable "power/wakeup" to control remote wakeup in the runtime suspend

2012-07-17 Thread Chen Peter-B29397
> 2. If an internal USB port is suspended with remote wakeup disabled, > power off the port. Add code to the USB core to ignore the device > disconnect in this special case, so the driver thinks the device is > still suspended. Issue a reset-resume when the driver wants to resume > the device.

RE: [RFC/PATCH v2] usb: dwc3: Introduce OTG driver for dwc3

2012-07-17 Thread Anton Tikhomirov
Hi, > -Original Message- > From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb- > ow...@vger.kernel.org] On Behalf Of Ido Shayevitz > Sent: Thursday, July 12, 2012 1:24 AM > To: ba...@ti.com > Cc: linux-usb@vger.kernel.org; i...@codeaurora.org > Subject: [RFC/PATCH v2] usb: dwc3: Intro

Re: some questions about usb_serial_probe

2012-07-17 Thread Greg KH
On Wed, Jul 18, 2012 at 11:22:49AM +0800, loody wrote: > Dear all: > in usb_serial_probe, we create tty_port based on max_endpoints. Or based on the number that the driver said to create. > My questions are: > 1. some callback functions, such serial_hangup, serial_carrier_raised, > etc. will call

Re: some questions about usb_serial_probe

2012-07-17 Thread loody
hi: 2012/7/18 Greg KH : > On Wed, Jul 18, 2012 at 11:22:49AM +0800, loody wrote: >> Dear all: >> in usb_serial_probe, we create tty_port based on max_endpoints. > > Or based on the number that the driver said to create. > >> My questions are: >> 1. some callback functions, such serial_hangup, seri

Re: [PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 17, 2012 at 5:57 PM, Sergei Shtylyov wrote: > Hello. > > > On 17-07-2012 12:10, Kishon Vijay Abraham I wrote: > >> Add omap-usb2 data node in omap4 device tree file. > > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/omap4.dtsi |5 + >> 1 files ch

Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Jul 17, 2012 at 6:06 PM, Sergei Shtylyov wrote: > Hello. > > > On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: > >> Add ocp2scp data node in omap4 device tree file. > > >> Signed-off-by: Kishon Vijay Abraham I >> --- >> arch/arm/boot/dts/omap4.dtsi |8 >> 1 files c

[PATCH v2 0/2] omap: add ocp2scp as a bus driver

2012-07-17 Thread Kishon Vijay Abraham I
This patch series is done as a preparatory step for adding phy drivers for dwc3 and musb. This series adds a new driver for ocp2scp (only dt) to which phy drivers are connected. Since currently there is no generic way to create a child device along with doing a pm_runtime_enable (the exact requir

[PATCH v2 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread Kishon Vijay Abraham I
Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi index 359c497..29c6243 100644 --- a/

[PATCH v2 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-07-17 Thread Kishon Vijay Abraham I
Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of creating all the devices that is connected to OCP2SCP. In the case of OMAP4, USB2PHY is connected to ocp2scp. This also includes device tree support for ocp2scp driver and the documentation with device tree binding informati

[PATCH v3 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-07-17 Thread Kishon Vijay Abraham I
All the PHY configuration other than VBUS, ID GND and OTG SRP are removed from twl6030. The phy configurations are taken care by the dedicated usb2 phy driver. So twl6030 is made as comparator driver for VBUS and ID detection. Writing to control module which is now handled in omap2430.c should be

[PATCH v3 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-17 Thread Kishon Vijay Abraham I
All phy related programming like enabling/disabling the clocks, powering on/off the phy is taken care of by this driver. It is also used for OTG related functionality like srp. This also includes device tree support for usb2 phy driver and the documentation with device tree binding information is

[PATCH v3 06/11] arm/dts: Add twl6030-usb data

2012-07-17 Thread Kishon Vijay Abraham I
Add twl6030-usb data node in twl6030 device tree file Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4-panda.dts |4 arch/arm/boot/dts/omap4-sdp.dts |4 arch/arm/boot/dts/twl6030.dtsi|6 ++ 3 files changed, 14 insertions(+), 0 deletions(-) diff -

  1   2   >