Re: usbtest usage

2008-02-22 Thread Francis Moreau
On Fri, Feb 22, 2008 at 8:52 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 20 February 2008, Francis Moreau wrote: > > Hello, > > > > I'm struggling with this module to test my udc. > > > > I loaded the zero driver like the following: > > > > $ modprobe g_zero pattern=1 >

Re: usbtest usage

2008-02-22 Thread David Brownell
On Friday 22 February 2008, Francis Moreau wrote: > >  > > >  > To start the tests, I use the testusb user tool with the wrapper script > > test.sh. > >  > In this script, the buflen for the host is set to 2048. > > > >  Which as you note is incompatible with "pattern=1". > > > >  If you want to u

Re: usbtest usage

2008-02-22 Thread Francis Moreau
On Fri, Feb 22, 2008 at 10:00 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Friday 22 February 2008, Francis Moreau wrote: > > > > > > > > To start the tests, I use the testusb user tool with the wrapper > script test.sh. > > > > In this script, the buflen for the host is set to 2048. >

definition fo transaction?

2008-02-22 Thread vichy
Dear all: When I read spec there is a term called transaction. Which one of the followings is the exact definition of transaction? 1. by packet; that means each package sent by host or device will be a transaction. 2. A in/out pair is a transaction. 3. any behavior before ACK toke. Appreciate your

Re: usb/serial/io_ti.c: inconsequent NULL checking

2008-02-22 Thread Alan Cox
> Either the test of port->tty here is unneeded: > > if (port->tty) >port->tty->low_latency = low_latency; > > ...or the lack of test of port->tty here is a mistake: > >edge_set_termios (port, port->tty->termios); Interesting - so coverity doesn't understand the BKL. It

[patch] Remove unneeded null tty check in drivers/usb/serial/io_ti.c

2008-02-22 Thread Ray Lee
The Coverity checker (and Adrian Bunk) spotted an inconsistent NULL check of port->tty (it's blindly dereferenced later without the check). Alan Cox confirmed the check can go. Signed-off-by: Ray Lee <[EMAIL PROTECTED]> cc: linux-usb@vger.kernel.org cc: Greg KH <[EMAIL PROTECTED]> cc: Adrian Bu

Re: [linux-usb-devel] [patch 2.6.23-rc1-git] OHCI handles more ZFMicro quirks

2008-02-22 Thread Mike Nuss
On Wed, Aug 1, 2007 at 3:24 PM, David Brownell <[EMAIL PROTECTED]> wrote: > From: Mike Nuss <[EMAIL PROTECTED]> > > The ZF Micro OHCI controller exhibits unexpected behavior that seems to be > related to high load. Under certain conditions, the controller will > complete a TD, remove it from th

Re: [PATCH 2.6.24.2] ehci: fix for as974 introduced bug

2008-02-22 Thread Alan Stern
On Thu, 21 Feb 2008, Misha Zhilin wrote: > Alan, > I've got a bit more time now, so let me give you more detailed > explanation of what's going on. > > First of all we are talking about large URBs. These are URBs that > transfers more than 20KB of data. In other words, they require more than > on

Re: [PATCH 2.6.24.2] ehci: fix for as974 introduced bug

2008-02-22 Thread Misha Zhilin
Alan, > > > > So, how it used to be up until 2.6.24: > > Short transfer was detected inside qh_completions. EREMOTEIO status was > > set to urb_status. By means of qtd_copy_status function and urb_status > > field, the EREMOTEIO status was carried through all of qtd belonging to > > the URB. As

Re: [PATCH 2.6.24.2] ehci: fix for as974 introduced bug

2008-02-22 Thread Alan Stern
On Fri, 22 Feb 2008, Misha Zhilin wrote: > That's exactly what I did in the patch I've sent you. In addition to > that, last_status carried -EREMOTEIO instead of 0. But I guess it's a > matter of preference. Important thing for the fix is to carry an error > status through all USB's qtds. > > Her

[2.6 patch] usb/serial/io_ti.c: remove unneeded NULL check

2008-02-22 Thread Adrian Bunk
On Fri, Feb 22, 2008 at 10:10:16AM +, Alan Cox wrote: > > Either the test of port->tty here is unneeded: > > > > if (port->tty) > >port->tty->low_latency = low_latency; > > > > ...or the lack of test of port->tty here is a mistake: > > > > edge_set_termios (port, port->

Re: [PATCH 2.6.24.2] ehci: fix for as974 introduced bug

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 02:42:46PM -0500, Alan Stern wrote: > On Fri, 22 Feb 2008, Misha Zhilin wrote: > > > That's exactly what I did in the patch I've sent you. In addition to > > that, last_status carried -EREMOTEIO instead of 0. But I guess it's a > > matter of preference. Important thing for

Re: [2.6 patch] usb/serial/io_ti.c: remove unneeded NULL check

2008-02-22 Thread Alan Cox
Already patched in my tree - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: USB Persist issue

2008-02-22 Thread Alan Stern
On Thu, 21 Feb 2008, Herton Ronaldo Krzesinski wrote: > I inserted some dev_printk/printk's, I paste here for reference. I went > further > trying to debug, so that's why there is more things, I'll explain: Your debugging helped. Here are the key lines: > [ 58.071856] hub 5-0:1.0: trying to

Re: [PATCH 2.6.24.2] ehci: fix for as974 introduced bug

2008-02-22 Thread Alan Stern
On Fri, 22 Feb 2008, Greg KH wrote: > I'm guessing this is a 2.6.25 and .24-stable thing? Yes. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] usb-storage: don't access beyond the end of the sg buffer

2008-02-22 Thread Alan Stern
This patch (as1038) fixes a bug in usb_stor_access_xfer_buf() and usb_stor_set_xfer_buf() (the bug was originally found by Boaz Harrosh): The routine must not attempt to write beyond the end of a scatter-gather list or beyond the number of bytes requested. Signed-off-by: Alan Stern <[EMAIL PROTECT

Re: OMAP34xx EHCI bulk OUT CRC16 complementing

2008-02-22 Thread David Brownell
On Tuesday 19 February 2008, Pandita, Vikram wrote: > USB EHCI/OHCI experts > > On omap-git v2.6.25-rc2, TI OMAP34xx EHCI controller, we are seeing a > strange behavior on a bulk OUT 512 byte transfer. > > We can see through the CATC that the 512 byte goes out successfully > but there are many T

Re: [PATCH] usb-storage: update earlier scatter-gather bug fix

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 05:00:06PM -0500, Alan Stern wrote: > This patch (as1037) makes a small update to the earlier as1035 patch. > The minimum-length computation shouldn't be done in > usb_stor_access_xfer_buf(), since that routine can be called multiple > times for a single transfer. It should

[PATCH] usb-storage: update earlier scatter-gather bug fix

2008-02-22 Thread Alan Stern
This patch (as1037) makes a small update to the earlier as1035 patch. The minimum-length computation shouldn't be done in usb_stor_access_xfer_buf(), since that routine can be called multiple times for a single transfer. It should be done in usb_stor_set_xfer_buf() instead, which gets called only

Re: [PATCH] usb-storage: update earlier scatter-gather bug fix

2008-02-22 Thread Alan Stern
On Fri, 22 Feb 2008, Greg KH wrote: > On Fri, Feb 22, 2008 at 05:00:06PM -0500, Alan Stern wrote: > > This patch (as1037) makes a small update to the earlier as1035 patch. > > The minimum-length computation shouldn't be done in > > usb_stor_access_xfer_buf(), since that routine can be called multi

Advice about USB-serial adapters

2008-02-22 Thread jscandal
Hi, This is my first post to this list, so I hope this is an apropriate place to ask my questions. As stated in the subject, I am looking for advice regarding USB to serial (RS-232) adapters on linux. We, at the robotics institute where I work, have a couple of new laptops lacking serial interfaces

Re: Advice about USB-serial adapters

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 10:22:03PM +0100, [EMAIL PROTECTED] wrote: > Hi, > This is my first post to this list, so I hope this is an apropriate place > to ask my questions. > As stated in the subject, I am looking for advice regarding USB to serial > (RS-232) adapters on linux. We, at the robotics i

Re: Question regarding usb-serial based driver.

2008-02-22 Thread Greg KH
On Wed, Feb 20, 2008 at 10:35:48AM -0800, Chetan Karia wrote: > Hello, > > I am kernel newbie and I have a question about usb serial driver. I > have a usb to serial driver which exposes 3 virtual serial ports > ttyUSB0, ttyUSB1 and ttyUSB2. The endpoint to virtual serial port > mapping is like th

[patch 2.6.25-rc2-git] pxa2xx_udc: fix misuse of clock enable/disable calls

2008-02-22 Thread David Brownell
From: Dmitry Baryshkov <[EMAIL PROTECTED]> Fix pxa2xx_udc to balance calls to clk_enable/clk_disable. [db: remove inline #ifdefs for IXP non-support of calls] Signed-off-by: Dmitry Baryshkov [EMAIL PROTECTED] Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- drivers/usb/gadget/pxa2xx_udc.c

Re: Question regarding usb-serial based driver.

2008-02-22 Thread Chetan Karia
On 22/02/2008, Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Feb 20, 2008 at 10:35:48AM -0800, Chetan Karia wrote: > > Hello, > > > > I am kernel newbie and I have a question about usb serial driver. I > > have a usb to serial driver which exposes 3 virtual serial ports > > ttyUSB0, ttyUSB1 and

Re: Question regarding usb-serial based driver.

2008-02-22 Thread Greg KH
On Fri, Feb 22, 2008 at 05:30:22PM -0800, Chetan Karia wrote: > On 22/02/2008, Greg KH <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 20, 2008 at 10:35:48AM -0800, Chetan Karia wrote: > > > Hello, > > > > > > I am kernel newbie and I have a question about usb serial driver. I > > > have a usb to se