Re: [linux-usb-devel] isp1362 hack for isp1161x?

2008-01-31 Thread Cristian Chiarello
Felipe Balbi ha scritto: Hi, On Jan 30, 2008 3:36 AM, Cristian Chiarello <[EMAIL PROTECTED]> wrote: Hi, I have readed "isp116x embedded programming guide" and if I haven't misunderstood, it's need to add ITL buffer management and to change irq handler routine. Is this the just way? Hack the i

isp1161x isochronous transfers support

2008-01-31 Thread Cristian Chiarello
Hi guys, I need to add isoc mode to the driver drivers/usb/host/isp116x-hcd.c for an isp1161A. I have readed "isp116x embedded programming guide" and if I haven't misunderstood, it's need to add ITL buffer management (some routine refer only to the ATL buffer) and to change irq handler routine

Re: [linux-usb-devel] 2.6.24: NULL scatter-gather pointer in usb_storage:usb_stor_access_xfer_buf?

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 1:08 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > Boaz: > > This looks like it might have something to do with your changes. > > Alan Stern > > > On Wed, 30 Jan 2008, Mark Glines wrote: > >> : >> Mime-Version: 1.0 >> Content-Type: text/plain; charset=US-ASCII >> Conte

Re: [linux-usb-devel] isp1362 hack for isp1161x?

2008-01-31 Thread Felipe Balbi
On Jan 31, 2008 3:04 AM, Cristian Chiarello <[EMAIL PROTECTED]> wrote: > Felipe Balbi ha scritto: > > Hi, > > > > On Jan 30, 2008 3:36 AM, Cristian Chiarello <[EMAIL PROTECTED]> wrote: > >> Hi, > >> > >> I have readed "isp116x embedded programming guide" and if I haven't > >> misunderstood, it's ne

Re: [linux-usb-devel] 2.6.24: NULL scatter-gather pointer in usb_storage:usb_stor_access_xfer_buf?

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 17:08 +0200, Mark Glines <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008 11:27:39 +0200 > Boaz Harrosh <[EMAIL PROTECTED]> wrote: > >> Please check the below patch. >> >> one thing that I can see is that the isd200 does an INQUARY transfer >> of sizeof(struct inquiry_data)

Re: [linux-usb-devel] 2.6.24: NULL scatter-gather pointer in usb_storage:usb_stor_access_xfer_buf?

2008-01-31 Thread Mark Glines
On Thu, 31 Jan 2008 11:27:39 +0200 Boaz Harrosh <[EMAIL PROTECTED]> wrote: > Please check the below patch. > > one thing that I can see is that the isd200 does an INQUARY transfer > of sizeof(struct inquiry_data) which is 96 bytes, when scsi_scan.c > sends an INQUARY with 36 bytes buffer. So we h

Re: Problem: hiddev stops sending events after some error recoveries

2008-01-31 Thread Salvador Eduardo Tropea
On 30/01/08 14:05, Alan Stern wrote: > It's a bug for Set-Interface to fail. Yes and not. > Following a reset, the device has no reason to fail such a request. > The device doesn't, but you can lose a packet (i.e. CRC error). In this case the kernel should properly recover. In this case the

Re: [linux-usb-devel] 2.6.24: NULL scatter-gather pointer in usb_storage:usb_stor_access_xfer_buf?

2008-01-31 Thread Alan Stern
On Thu, 31 Jan 2008, Boaz Harrosh wrote: > >> Please check the below patch. > >> > >> one thing that I can see is that the isd200 does an INQUARY transfer > >> of sizeof(struct inquiry_data) which is 96 bytes, when scsi_scan.c > >> sends an INQUARY with 36 bytes buffer. So we have an underflow in

[Fwd: Re: Problem: hiddev stops sending events after some error recoveries]

2008-01-31 Thread Salvador Eduardo Tropea
Original Message Subject:Re: Problem: hiddev stops sending events after some error recoveries Date: Thu, 31 Jan 2008 14:55:16 -0200 From: Salvador Eduardo Tropea <[EMAIL PROTECTED]> To: Alan Stern <[EMAIL PROTECTED]> References: <[EMAIL PROTECTED]> On 31/01/08

Re: Problem: hiddev stops sending events after some error recoveries

2008-01-31 Thread Alan Stern
On Thu, 31 Jan 2008, Salvador Eduardo Tropea wrote: > On 30/01/08 14:05, Alan Stern wrote: > > It's a bug for Set-Interface to fail. > > Yes and not. > > > Following a reset, the device has no reason to fail such a request. > > > > The device doesn't, but you can lose a packet (i.e. CRC err

[PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Boaz Harrosh
scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would volunteer 96 bytes of INQUIRY. This caused an underflow condition in protocol.c usb_stor_access_xfer_buf(). So first fix is to usb_stor_access_xfer_buf() to properly handle underflow conditions. Then usb_stor_set_xfer_b

Re: [linux-usb-devel] 2.6.24: NULL scatter-gather pointer in usb_storage:usb_stor_access_xfer_buf?

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 18:45 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008, Boaz Harrosh wrote: > Please check the below patch. one thing that I can see is that the isd200 does an INQUARY transfer of sizeof(struct inquiry_data) which is 96 bytes, when scsi_

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Alan Stern
On Thu, 31 Jan 2008, Boaz Harrosh wrote: > @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer, > { > unsigned int offset = 0; > struct scatterlist *sg = NULL; > + unsigned int count; > > - usb_stor_access_xfer_buf(buffer, buflen, srb, &sg, &offset, > +

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Greg KH
On Thu, Jan 31, 2008 at 07:19:57PM +0200, Boaz Harrosh wrote: > > scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would > volunteer 96 bytes of INQUIRY. This caused an underflow condition in > protocol.c usb_stor_access_xfer_buf(). So first fix is to > usb_stor_access_xfer_b

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 20:00 +0200, Greg KH <[EMAIL PROTECTED]> wrote: > On Thu, Jan 31, 2008 at 07:19:57PM +0200, Boaz Harrosh wrote: >> scsi_scan is issuing a 36-byte INQUIRY request to llds. isd200 would >> volunteer 96 bytes of INQUIRY. This caused an underflow condition in >> protocol.c

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008, Boaz Harrosh wrote: > >> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer, >> { >> unsigned int offset = 0; >> struct scatterlist *sg = NULL; >> +unsigned int count;

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Alan Stern
On Thu, 31 Jan 2008, Boaz Harrosh wrote: > On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > > On Thu, 31 Jan 2008, Boaz Harrosh wrote: > > > >> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(unsigned char *buffer, > >> { > >>unsigned int offset = 0; > >>struct

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 21:34 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008, Boaz Harrosh wrote: > >> On Thu, Jan 31 2008 at 19:49 +0200, Alan Stern <[EMAIL PROTECTED]> wrote: >>> On Thu, 31 Jan 2008, Boaz Harrosh wrote: >>> @@ -228,9 +228,14 @@ void usb_stor_set_xfer_buf(

Re: [PATCH 2.6.24] bugfix for an overflow condition in usb storage & isd200.c

2008-01-31 Thread Matthew Dharm
No. No no no. The ISD200 code was written by the ISD200 developers. I really don't want to go mucking about changing what commands actually get send to the ISD200 parts. We have no idea if the will reliably accept a 36-byte INQUIRY. Just because it happens to work for a couple of people doesn'

[PATCH 2.6.24] bugfix for an overflow condition in usb storage & isd200.c

2008-01-31 Thread Boaz Harrosh
Greg KH <[EMAIL PROTECTED]> rote: > As this is a regression and hits 2.6.24, can you send the final version > of this patch to the [EMAIL PROTECTED] address so we can get it into the > 2.6.24.y tree? > > thanks, > > greg k-h Mark - This is for you on top of vanila v2.6.24 kernel from Linus. ---

Re: [PATCH 2.6.24] bugfix for an overflow condition in usb storage & isd200.c

2008-01-31 Thread Boaz Harrosh
On Thu, Jan 31 2008 at 21:49 +0200, Matthew Dharm <[EMAIL PROTECTED]> wrote: > No. No no no. > > The ISD200 code was written by the ISD200 developers. I really don't want > to go mucking about changing what commands actually get send to the ISD200 > parts. We have no idea if the will reliably a

Re: [PATCH 2.6.24] bugfix for an overflow condition in usb storage & isd200.c

2008-01-31 Thread Matthew Dharm
On Thu, Jan 31, 2008 at 10:05:19PM +0200, Boaz Harrosh wrote: > On Thu, Jan 31 2008 at 21:49 +0200, Matthew Dharm <[EMAIL PROTECTED]> wrote: > > No. No no no. > > Please re-inspect the code again. > There is no device involved here. The code completely emulates this commands > with a driver made

Re: [PATCH] bugfix for an underflow condition in usb storage & isd200.c

2008-01-31 Thread Alan Stern
On Thu, 31 Jan 2008, Boaz Harrosh wrote: > >> The code in usb_stor_access_xfer_buf() will > >> now correctly attempt to transfer according to buflen and what ever is > >> available > >> at the passed sg's. Now this can be less or it can be more. SCSI standard > >> defines > >> this as underflow

Re: request: patch for oracom mp3 stick --> usb-storage: unusual_devs.h

2008-01-31 Thread Alan Stern
On Thu, 31 Jan 2008, Robert Spitzenpfeil wrote: > this mp3 stick has always worked with windows xp. it used to work with > older kernels (e.g. 2.4.21-144, suse 9.0) > but I could never make it work with any 2.6.xx before I found that patch. > > find attached: snoopypro log (binary + xml) : plugi

Re: request: patch for oracom mp3 stick --> usb-storage: unusual_devs.h

2008-01-31 Thread David Brownell
On Thursday 31 January 2008, Alan Stern wrote: > The interesting difference lay in what Windows did when the Get-Max-LUN > stalled.  It sent a Clear-Halt request to endpoint 0! Yes that *is* strange! Considering that ep0 wasn't stalling ... - To unsubscribe from this list: send the line "unsub

Re: request: patch for oracom mp3 stick --> usb-storage: unusual_devs.h

2008-01-31 Thread Robert Spitzenpfeil
Alan Stern wrote: On Thu, 31 Jan 2008, Robert Spitzenpfeil wrote: this mp3 stick has always worked with windows xp. it used to work with older kernels (e.g. 2.4.21-144, suse 9.0) but I could never make it work with any 2.6.xx before I found that patch. find attached: snoopypro log (binary