Re: [PATCH] Moving spinlock to struct usb_hcd

2008-01-26 Thread David Brownell
On Friday 25 January 2008, Romit Dasgupta wrote: > This should help > reduce contention to usb during high load where i/o is happening  to > multiple hcds. Looking at how this lock is used, contention doesn't look likely to be an issue. It's never held for long ... > @@ -1106,9 +1103,9 @@ EXPORT

Re: using a "real" vendor id for root hubs

2008-01-26 Thread Oliver Neukum
Am Freitag, 25. Januar 2008 23:28:09 schrieb Greg KH: > On Fri, Jan 25, 2008 at 09:44:32PM +0100, Oliver Neukum wrote: > > Am Freitag, 25. Januar 2008 17:58:56 schrieben Sie: > > > Right now we use a "fake" vendor and product id for root hubs in the > > > kernel. However, I'm happy to announce tha

Re: [PATCH] Moving spinlock to struct usb_hcd

2008-01-26 Thread Romit Dasgupta
> > > Looking at how this lock is used, contention doesn't look likely > to be an issue. It's never held for long ... yes in the general case but in usb_hcd_flush_endpoint routine it seems to be held for longer than other routines. I agree that usb_hcd_flush_endpoint is an infrequently called rout

Re: using a "real" vendor id for root hubs

2008-01-26 Thread Alan Stern
On Sat, 26 Jan 2008, Oliver Neukum wrote: > Am Freitag, 25. Januar 2008 23:28:09 schrieb Greg KH: > > On Fri, Jan 25, 2008 at 09:44:32PM +0100, Oliver Neukum wrote: > > > Am Freitag, 25. Januar 2008 17:58:56 schrieben Sie: > > > > Right now we use a "fake" vendor and product id for root hubs in th

Re: using a "real" vendor id for root hubs

2008-01-26 Thread Oliver Neukum
Am Samstag, 26. Januar 2008 16:56:39 schrieb Alan Stern: > > "should" doesn't mean do. You want to make a change visible to user space. > > That needs a reason beyond coolness. > > There was a reason.  Some device was using ID 0, and Greg wanted to > avoid a clash. Sorry. Yes, that's a good reas

Re: [Bugme-new] [Bug 9815] New: Unable to mount ipod

2008-01-26 Thread Alan Stern
On Fri, 25 Jan 2008, Andrew Morton wrote: > > On Fri, 25 Jan 2008 08:34:00 -0800 (PST) [EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=9815 > > Problem Description: Cannot mount ipod or an external hard disk > > Incidentally, I can mount my pen drive of 1 GB capacity. But

Blackberry through a TT hub

2008-01-26 Thread Pete Zaitcev
Hi, Greg: I think the berry_charge is your baby. Please direct me to the right person if it's not so. I have a bug in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=379341 It's pretty long, but the summary is this. When Blackberry is hooked to a hub, it seems to try to re-initialize again

Re: [EMAIL PROTECTED]: USB VendorID=0x0000]

2008-01-26 Thread Felipe Balbi
On Fri, 25 Jan 2008 08:56:35 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > Hi all, > > I have a report here of a device in the wild that is using a USB vendor > id of 0x. From everything I can tell, this _could_ be a valid > vendor id, but I'm pretty sure that it isn't :) Why would usb-if gi

Re: [EMAIL PROTECTED]: USB VendorID=0x0000]

2008-01-26 Thread Greg KH
On Sat, Jan 26, 2008 at 08:40:48PM -0600, Felipe Balbi wrote: > > > On Fri, 25 Jan 2008 08:56:35 -0800, Greg KH <[EMAIL PROTECTED]> wrote: > > Hi all, > > > > I have a report here of a device in the wild that is using a USB vendor > > id of 0x. From everything I can tell, this _could_ be a