Re: XHCI: Ring expansion failure

2013-12-18 Thread hemantk
> On Wed, Nov 06, 2013 at 11:09:50PM -, hema...@codeaurora.org wrote: >> >> On Wed, Nov 6, 2013 at 12:33 PM, wrote: >> On Wed, Nov 6, 2013 at 12:53 AM, wrote: >> > Hi > > Hi Hemant, > >> > By performing iterative port suspend and resume (which results >> > in function suspe

Re: XHCI: Ring expansion failure

2013-12-18 Thread Alan Stern
On Wed, 18 Dec 2013, Sarah Sharp wrote: > I think there's a couple of ways we could fix this. > > One would be to set the IOC flag on the last no-op TRBs in a TD we're > trying to cancel. I think that will make the event handling code > increment the dequeue pointer and update the number of free

Re: XHCI: Ring expansion failure

2013-12-18 Thread Sarah Sharp
On Wed, Nov 06, 2013 at 11:09:50PM -, hema...@codeaurora.org wrote: > >> On Wed, Nov 6, 2013 at 12:33 PM, wrote: > On Wed, Nov 6, 2013 at 12:53 AM, wrote: > > Hi Hi Hemant, > > By performing iterative port suspend and resume (which results > > in function suspend and resu

RE: xhci ring expansion

2013-11-13 Thread David Laight
> From: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] > > On Thu, Oct 31, 2013 at 04:16:14PM -, David Laight wrote: > > Code was recently added to the xhci driver to dynamically add extra ring > > segments if there is insufficient space for all the fragments of the > > URB being sent. > >

Re: xhci ring expansion

2013-11-12 Thread Sarah Sharp
On Thu, Oct 31, 2013 at 04:16:14PM -, David Laight wrote: > Code was recently added to the xhci driver to dynamically add extra ring > segments if there is insufficient space for all the fragments of the > URB being sent. > > ISTM that it would be better to just queue the URB (on the ring) > a

RE: XHCI: Ring expansion failure

2013-11-07 Thread David Laight
> Sounds like a bug. Why num_trbs_in_deq_seg becomes high? How many urbs > are submitted during resume? Normally only isoc transfer triggers ring > expansion with multiple trbs per urb. I've seen the number of free ring entries go down after a sequence where all the active urb got cancelled. Not l

Re: XHCI: Ring expansion failure

2013-11-06 Thread hemantk
>> On Wed, Nov 6, 2013 at 12:33 PM, wrote: On Wed, Nov 6, 2013 at 12:53 AM, wrote: > Hi > > By performing iterative port suspend and resume (which results in > function > suspend and resume), ring expansion failure is observed. Attached > device > has multiple i

Re: XHCI: Ring expansion failure

2013-11-06 Thread hemantk
> On Wed, Nov 6, 2013 at 12:33 PM, wrote: >>> On Wed, Nov 6, 2013 at 12:53 AM, wrote: Hi By performing iterative port suspend and resume (which results in function suspend and resume), ring expansion failure is observed. Attached device has multiple interfaces

Re: XHCI: Ring expansion failure

2013-11-06 Thread Andiry Xu
On Wed, Nov 6, 2013 at 12:33 PM, wrote: >> On Wed, Nov 6, 2013 at 12:53 AM, wrote: >>> Hi >>> >>> By performing iterative port suspend and resume (which results in >>> function >>> suspend and resume), ring expansion failure is observed. Attached device >>> has multiple interfaces for which int

Re: XHCI: Ring expansion failure

2013-11-06 Thread hemantk
> On Wed, Nov 6, 2013 at 12:53 AM, wrote: >> Hi >> >> By performing iterative port suspend and resume (which results in >> function >> suspend and resume), ring expansion failure is observed. Attached device >> has multiple interfaces for which interface host drivers are unlinking >> the >> urbs

Re: XHCI: Ring expansion failure

2013-11-06 Thread Andiry Xu
On Wed, Nov 6, 2013 at 12:53 AM, wrote: > Hi > > By performing iterative port suspend and resume (which results in function > suspend and resume), ring expansion failure is observed. Attached device > has multiple interfaces for which interface host drivers are unlinking the > urbs during functio

RE: XHCI: Ring expansion failure

2013-11-06 Thread David Laight
> By performing iterative port suspend and resume (which results in function > suspend and resume), ring expansion failure is observed. Attached device > has multiple interfaces for which interface host drivers are unlinking the > urbs during function suspend and submitting urbs during resume. > >

XHCI: Ring expansion failure

2013-11-06 Thread hemantk
Hi By performing iterative port suspend and resume (which results in function suspend and resume), ring expansion failure is observed. Attached device has multiple interfaces for which interface host drivers are unlinking the urbs during function suspend and submitting urbs during resume. For the

xhci ring expansion

2013-10-31 Thread David Laight
Code was recently added to the xhci driver to dynamically add extra ring segments if there is insufficient space for all the fragments of the URB being sent. ISTM that it would be better to just queue the URB (on the ring) and process it when space becomes available. This wouldn't solve the probl