Re: xhci inc_deq question

2012-08-18 Thread loody
hi Sebastian 2012/8/18 Sebastian Andrzej Siewior : > On Wed, Aug 08, 2012 at 08:55:37PM +0800, loody wrote: >> when I study inc_deq in xhci-ring.c, why we need to announce and >> assigned value to "addr" >> it seems useless. > > Unless Sarah plans to use addr for debug output you can remove this a

Re: xhci inc_deq question

2012-08-18 Thread Sebastian Andrzej Siewior
On Wed, Aug 08, 2012 at 08:55:37PM +0800, loody wrote: > when I study inc_deq in xhci-ring.c, why we need to announce and > assigned value to "addr" > it seems useless. Unless Sarah plans to use addr for debug output you can remove this addr and the one in the function below. Sebastian -- To unsu

xhci inc_deq question

2012-08-08 Thread loody
hi all: when I study inc_deq in xhci-ring.c, why we need to announce and assigned value to "addr" it seems useless. static void inc_deq(struct xhci_hcd *xhci, struct xhci_ring *ring) { unsigned long long addr; .. .. addr = (unsigned long lo