Re: xhci-hcd wakeup settings

2013-11-08 Thread Alan Stern
On Thu, 7 Nov 2013, Sarah Sharp wrote: > > Probably the current code is wrong. The wakeup bits don't need to be > > set during port suspend or root-hub suspend, but only during controller > > suspend -- they get used only when the controller is not in D0. I > > guess we should change both driver

Re: xhci-hcd wakeup settings

2013-11-07 Thread Sarah Sharp
On Mon, Oct 21, 2013 at 10:24:47AM -0400, Alan Stern wrote: > On Sun, 20 Oct 2013, Sarah Sharp wrote: > > > > > So it means xHCI driver should clear wakeup flags for suspended ports > > > > in this case, just like ehci driver does. Correct? > > > > > > Yes, I agree. > > > > > > Sarah, is this wo

Re: xhci-hcd wakeup settings

2013-10-21 Thread Andiry Xu
On Mon, Oct 21, 2013 at 11:40 AM, Alan Stern wrote: > On Sat, 19 Oct 2013, Andiry Xu wrote: > >> Hi Sarah, nice to see you again:) I'm still working on my PhD degree >> at UC San Diego. I'm working with storage devices on Linux, but not on >> driver. With fast non-volatile storage - perhaps as fas

Re: xhci-hcd wakeup settings

2013-10-21 Thread Alan Stern
On Sat, 19 Oct 2013, Andiry Xu wrote: > Hi Sarah, nice to see you again:) I'm still working on my PhD degree > at UC San Diego. I'm working with storage devices on Linux, but not on > driver. With fast non-volatile storage - perhaps as fast as DRAM, all the > software overhead is significant, incl

Re: xhci-hcd wakeup settings

2013-10-21 Thread Alan Stern
On Sun, 20 Oct 2013, Sarah Sharp wrote: > > > So it means xHCI driver should clear wakeup flags for suspended ports > > > in this case, just like ehci driver does. Correct? > > > > Yes, I agree. > > > > Sarah, is this worth reporting to the Intel chipset engineers as a bug? > > I'm not sure. I

Re: xhci-hcd wakeup settings

2013-10-19 Thread Andiry Xu
On Sat, Oct 19, 2013 at 9:45 PM, Sarah Sharp wrote: > On Sat, Oct 19, 2013 at 03:36:58PM -0400, Alan Stern wrote: >> On Fri, 18 Oct 2013, Andiry Xu wrote: >> >> > Interesting. I used the following commands: >> > >> > #echo disabled > /sys/bus/pci/devices/:00:14.0/power/wakeup >> > #echo enable

Re: xhci-hcd wakeup settings

2013-10-19 Thread Sarah Sharp
On Sat, Oct 19, 2013 at 03:36:58PM -0400, Alan Stern wrote: > On Fri, 18 Oct 2013, Andiry Xu wrote: > > > Interesting. I used the following commands: > > > > #echo disabled > /sys/bus/pci/devices/:00:14.0/power/wakeup > > #echo enabled > /sys/bus/pci/devices/:00:14.0/usb3/power/wakeup > >

Re: xhci-hcd wakeup settings

2013-10-19 Thread Alan Stern
On Fri, 18 Oct 2013, Andiry Xu wrote: > Interesting. I used the following commands: > > #echo disabled > /sys/bus/pci/devices/:00:14.0/power/wakeup > #echo enabled > /sys/bus/pci/devices/:00:14.0/usb3/power/wakeup > #echo enabled > /sys/bus/pci/devices/:00:14.0/usb4/power/wakeup > >

Re: xhci-hcd wakeup settings

2013-10-18 Thread Andiry Xu
On Fri, Oct 18, 2013 at 3:06 PM, Alan Stern wrote: > On Fri, 18 Oct 2013, Andiry Xu wrote: > >> On Wed, Oct 16, 2013 at 9:14 AM, Alan Stern >> wrote: >> > Sarah: >> > >> > While working on some general fixes for wakeup races during PCI >> > suspend, I noticed that xhci_pci_suspend() ignores its

Re: xhci-hcd wakeup settings

2013-10-18 Thread Alan Stern
On Fri, 18 Oct 2013, Andiry Xu wrote: > On Wed, Oct 16, 2013 at 9:14 AM, Alan Stern wrote: > > Sarah: > > > > While working on some general fixes for wakeup races during PCI > > suspend, I noticed that xhci_pci_suspend() ignores its do_wakeup > > argument. What's the story? > > > > I believe it

Re: xhci-hcd wakeup settings

2013-10-18 Thread Andiry Xu
On Wed, Oct 16, 2013 at 9:14 AM, Alan Stern wrote: > Sarah: > > While working on some general fixes for wakeup races during PCI > suspend, I noticed that xhci_pci_suspend() ignores its do_wakeup > argument. What's the story? > I believe it's simply because I don't know how to handle the argument

xhci-hcd wakeup settings

2013-10-16 Thread Alan Stern
Sarah: While working on some general fixes for wakeup races during PCI suspend, I noticed that xhci_pci_suspend() ignores its do_wakeup argument. What's the story? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.ker