On Thu, Jul 26, 2012 at 11:17:38AM -0400, Alan Stern wrote:
> On Thu, 26 Jul 2012, Felipe Balbi wrote:
>
> > Hi,
> >
> > On Wed, Jul 25, 2012 at 02:53:00PM +0200, Rajaram REGUPATHY wrote:
> > > The short_not_ok field is used by class drivers to indicate udc whether
> > > short packet is expected
On Thu, 26 Jul 2012, Paul Zimmerman wrote:
> > Hmmm. I suppose an impartial approach would be to set short_not_ok
> > only when the blocksize >= the maxpacket size. That should always work
> > as a general rule, regardless of speed.
>
> Yes. And that might save us from having to rehash all this
> From: Alan Stern [mailto:st...@rowland.harvard.edu]
> Sent: Thursday, July 26, 2012 12:32 PM
>
> On Thu, 26 Jul 2012, Paul Zimmerman wrote:
>
> > > That's very clear. So Rajaram, when you redo the patch you can simply
> > > leave out the checks for SuperSpeed. Set or clear the short_not_ok
>
On Thu, 26 Jul 2012, Paul Zimmerman wrote:
> > That's very clear. So Rajaram, when you redo the patch you can simply
> > leave out the checks for SuperSpeed. Set or clear the short_not_ok
> > flag depending only on the size of the bulk transfer, regardless of the
> > speed.
>
> I have a bit of
> From: Alan Stern [mailto:st...@rowland.harvard.edu]
> Sent: Thursday, July 26, 2012 8:16 AM
>
> On Thu, 26 Jul 2012, Felipe Balbi wrote:
>
> > > > > > > > Maybe while bringing it back you can remove the checks for
> > > > > > > > SuperSpeed.
> > > > > > > > Is there any reason to keep them?
>
On Thu, 26 Jul 2012, Felipe Balbi wrote:
> Hi,
>
> On Wed, Jul 25, 2012 at 02:53:00PM +0200, Rajaram REGUPATHY wrote:
> > The short_not_ok field is used by class drivers to indicate udc whether
> > short packet is expected during a particular transfer.
> > In case of mass storage, during command
On Thu, 26 Jul 2012, Felipe Balbi wrote:
> > > > > > > Maybe while bringing it back you can remove the checks for
> > > > > > > SuperSpeed.
> > > > > > > Is there any reason to keep them?
> > > Okay, that's fine. But it doesn't answer my earlier question: Is there
> > > really any need for the
Hi,
On Wed, Jul 25, 2012 at 02:53:00PM +0200, Rajaram REGUPATHY wrote:
> The short_not_ok field is used by class drivers to indicate udc whether short
> packet is expected during a particular transfer.
> In case of mass storage, during command and status phase this field is set as
> false and se
to:st...@rowland.harvard.edu]
> > > > Sent: Wednesday, July 25, 2012 12:48 PM
> > > > To: Paul Zimmerman
> > > > Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org
> > > > Subject: RE: usb : mass storage : short_not_ok for non usb3 udc
chal Nazarewicz; linux-usb@vger.kernel.org
>> > Subject: RE: usb : mass storage : short_not_ok for non usb3 udc
>> >
>> > On Wed, 25 Jul 2012, Paul Zimmerman wrote:
>> >
>> > > > > > I don't understand this either. What's wrong with s
gt; To: Paul Zimmerman
> > > Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org
> > > Subject: RE: usb : mass storage : short_not_ok for non usb3 udc
> > >
> > > On Wed, 25 Jul 2012, Paul Zimmerman wrote:
> > >
> > > > > > > I
On Wed, 25 Jul 2012, Paul Zimmerman wrote:
> > From: Alan Stern [mailto:st...@rowland.harvard.edu]
> > Sent: Wednesday, July 25, 2012 12:48 PM
> > To: Paul Zimmerman
> > Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org
> > Subject: RE: usb : mass storage :
> From: Alan Stern [mailto:st...@rowland.harvard.edu]
> Sent: Wednesday, July 25, 2012 12:48 PM
> To: Paul Zimmerman
> Cc: Rajaram R; Michal Nazarewicz; linux-usb@vger.kernel.org
> Subject: RE: usb : mass storage : short_not_ok for non usb3 udc
>
> On Wed, 25 Jul 2012,
On Wed, 25 Jul 2012, Paul Zimmerman wrote:
> > > > I don't understand this either. What's wrong with setting
> > > > short_not_ok while at SuperSpeed? It shouldn't force the use of a
> > bounce buffer.
> > > >
> > >
> > > I have just brought back some code removed by patch "usb: fix mass
> > > s
On Wed, 25 Jul 2012, Rajaram R wrote:
> On Wed, Jul 25, 2012 at 10:51 PM, Alan Stern
> wrote:
> > On Wed, 25 Jul 2012, Rajaram R wrote:
> >
> >> >> > There's one thing I don't get. The message talks about musb but the
> >> >> > code
> >> >> > checks for non Super Speed devices. So maybe the c
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Alan Stern
>
> On Wed, 25 Jul 2012, Rajaram R wrote:
>
> > >> > There's one thing I don't get. The message talks about musb but
> > >> > the code checks for non Super Speed devices. So maybe the cod
On Wed, Jul 25, 2012 at 10:51 PM, Alan Stern wrote:
> On Wed, 25 Jul 2012, Rajaram R wrote:
>
>> >> > There's one thing I don't get. The message talks about musb but the
>> >> > code
>> >> > checks for non Super Speed devices. So maybe the code is correct, maybe
>> >> > it's not, but the messag
On Wed, 25 Jul 2012, Rajaram R wrote:
> >> > There's one thing I don't get. The message talks about musb but the code
> >> > checks for non Super Speed devices. So maybe the code is correct, maybe
> >> > it's not, but the message does not really explain it (at least to me).
> >> >
> >> Please le
Hi Alan
On Wed, Jul 25, 2012 at 9:07 PM, Alan Stern wrote:
> On Wed, 25 Jul 2012, Rajaram R wrote:
>
>> Hi
>>
>> On Wed, Jul 25, 2012 at 6:33 PM, Michal Nazarewicz wrote:
>> > On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY
>> > wrote:
>> >>
>> >> The short_not_ok field is used by class d
On Wed, 25 Jul 2012, Rajaram R wrote:
> Hi
>
> On Wed, Jul 25, 2012 at 6:33 PM, Michal Nazarewicz wrote:
> > On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY
> > wrote:
> >>
> >> The short_not_ok field is used by class drivers to indicate udc whether
> >> short packet is expected during a
On Wed, 25 Jul 2012, Rajaram REGUPATHY wrote:
> The short_not_ok field is used by class drivers to indicate udc whether short
> packet is expected during a particular transfer.
> In case of mass storage, during command and status phase this field is set as
> false and set to true during data pha
Hi
On Wed, Jul 25, 2012 at 6:33 PM, Michal Nazarewicz wrote:
> On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY
> wrote:
>>
>> The short_not_ok field is used by class drivers to indicate udc whether
>> short packet is expected during a particular transfer.
>> In case of mass storage, during
On Wed, 25 Jul 2012 14:53:00 +0200, Rajaram REGUPATHY
wrote:
The short_not_ok field is used by class drivers to indicate udc whether short
packet is expected during a particular transfer.
In case of mass storage, during command and status phase this field is set as
false and set to true durin
The short_not_ok field is used by class drivers to indicate udc whether short
packet is expected during a particular transfer.
In case of mass storage, during command and status phase this field is set as
false and set to true during data phase.
musb driver uses this field to decide whether to pr
24 matches
Mail list logo
