On Wed, May 14, 2014 at 10:01:17AM +0300, Ivan T. Ivanov wrote:
> On Tue, 2014-05-13 at 23:20 +0300, Dan Carpenter wrote:
> > Hello Ivan T. Ivanov,
> >
> > The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device
> > Resource allocation" from Apr 28
On Tue, 2014-05-13 at 23:20 +0300, Dan Carpenter wrote:
> Hello Ivan T. Ivanov,
>
> The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device
> Resource allocation" from Apr 28, 2014, leads to the following static
> checker warning:
>
> dri
Hello Ivan T. Ivanov,
The patch 6b99c68ec1f9: "usb: phy: msm: Migrate to Managed Device
Resource allocation" from Apr 28, 2014, leads to the following static
checker warning:
drivers/usb/phy/phy-msm-usb.c:1590 msm_otg_probe()
warn: 'motg->regs' isn't
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 187 +++---
1 file changed, 68 insertions(+), 119 deletions(
On Fri, 2014-04-25 at 15:53 -0500, Felipe Balbi wrote:
> On Thu, Apr 24, 2014 at 01:49:38PM -0300, Fabio Estevam wrote:
> > On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov wrote:
> >
> > > + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX");
> > > + if (IS_ERR(motg->vddc
On Thu, Apr 24, 2014 at 01:49:38PM -0300, Fabio Estevam wrote:
> On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov wrote:
>
> > + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX");
> > + if (IS_ERR(motg->vddcx)) {
> > + dev_err(motg->phy.dev, "unable to get h
On Thu, Apr 24, 2014 at 12:48 PM, Ivan T. Ivanov wrote:
> + motg->vddcx = devm_regulator_get(motg->phy.dev, "HSUSB_VDDCX");
> + if (IS_ERR(motg->vddcx)) {
> + dev_err(motg->phy.dev, "unable to get hsusb vddcx\n");
> + return PTR_ERR(motg->vddcx);
> +
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 192 --
1 file changed, 73 insertions(+), 119 deletions(
On Tue, 2014-04-22 at 16:07 +0100, Srinivas Kandagatla wrote:
>
> On 22/04/14 10:20, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov"
> >
> > Move memory, regulators, clocks and irq allocation to
> > devm_* variants. Properly check for valid clk handles.
> >
> >
> > -module_platform_driver_probe(
On 22/04/14 10:20, Ivan T. Ivanov wrote:
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
-module_platform_driver_probe(msm_otg_driver, msm_otg_probe);
+module_platform_driver(msm_otg_driver);
This change d
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 195 --
1 file changed, 75 insertions(+), 120 deletions(
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 192 -
1 file changed, 74 insertions(+), 118 deletions(
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 192 -
1 file changed, 74 insertions(+), 118 deletions(
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 192 -
1 file changed, 74 insertions(+), 118 deletions(
Hi,
On Mon, 2013-07-29 at 15:25 +0300, Felipe Balbi wrote:
> Hi,
>
> On Mon, Jul 29, 2013 at 10:04:21AM +0300, Ivan T. Ivanov wrote:
> > motg->irq = platform_get_irq(pdev, 0);
> > - if (!motg->irq) {
> > + if (motg->irq < 0) {
>
> looks like this particular hunk isn't part of $subject.
Hi,
On Mon, Jul 29, 2013 at 10:04:21AM +0300, Ivan T. Ivanov wrote:
> motg->irq = platform_get_irq(pdev, 0);
> - if (!motg->irq) {
> + if (motg->irq < 0) {
looks like this particular hunk isn't part of $subject.
--
balbi
signature.asc
Description: Digital signature
From: "Ivan T. Ivanov"
Move memory, regulators, clocks and irq allocation to
devm_* variants. Properly check for valid clk handles.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 188 -
1 file changed, 71 insertions(+), 117 deletions(
Hi,
On Wed, 2013-07-24 at 15:38 +0300, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote:
> > From: "Ivan T. Ivanov"
> >
> > Use managed device resources to clean up the probe/remove
> > and get DT support for free.
> >
> > Signed-off-by: Ivan T. Iv
Hi,
On Tue, Jul 09, 2013 at 06:47:08PM +0300, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov"
>
> Use managed device resources to clean up the probe/remove
> and get DT support for free.
>
> Signed-off-by: Ivan T. Ivanov
> ---
> drivers/usb/phy/phy-msm-usb.c | 78
> +++--
From: "Ivan T. Ivanov"
Use managed device resources to clean up the probe/remove
and get DT support for free.
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 78 +++--
1 file changed, 20 insertions(+), 58 deletions(-)
diff --git a/driver
From: "Ivan T. Ivanov"
Cc: Felipe Balbi
Cc: Greg Kroah-Hartman
Cc: linux-usb@vger.kernel.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Ivan T. Ivanov
---
drivers/usb/phy/phy-msm-usb.c | 78 +++--
1 file changed, 20 insertions(+), 58 deletions(-)
d
21 matches
Mail list logo