Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-18 Thread Oliver Neukum
Am Sonntag, den 16.04.2017, 20:34 +0200 schrieb Rolf Evers-Fischer: > Both functions are described in Documentation/usb/anchors.txt and I agree: It > is not stated clearly that we must always call the > "usb_wait_anchor_empty_timeout()" function before we can call the > "usb_kill_anchored_urbs()

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-18 Thread Rolf Evers-Fischer
Dear Alan and Oliver, > Oliver Neukum hat am 18. April 2017 um 09:37 geschrieben: > > You can call usb_kill_anchored_urbs() always. > Alan Stern hat am 17. April 2017 um 16:14 > geschrieben: > > It is not necessary to call usb_wait_anchor_empty_timeout() before > calling usb_kill_anchored_u

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-18 Thread Oliver Neukum
Am Sonntag, den 16.04.2017, 20:34 +0200 schrieb Rolf Evers-Fischer: > Both functions are described in Documentation/usb/anchors.txt and I agree: It > is not stated clearly that we must always call the > "usb_wait_anchor_empty_timeout()" function before we can call the > "usb_kill_anchored_urbs()

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-17 Thread Alan Stern
On Sun, 16 Apr 2017, Rolf Evers-Fischer wrote: > Hi Chris, > > On 04/11/2017 04:33 PM, Christian Gromm wrote: > > Well, this sounds like a workaround to me as you are changing the timing > > by waiting for the URBs to finish. This might prevent the > > race from happening. > > > I personally woul

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-16 Thread Rolf Evers-Fischer
Hi Chris, > On 04/11/2017 04:33 PM, Christian Gromm wrote: > Well, this sounds like a workaround to me as you are changing the timing > by waiting for the URBs to finish. This might prevent the > race from happening. > I personally would rate it rather as a fix than as a workaround, because the "

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-11 Thread Christian Gromm
On 04/11/2017 04:13 PM, Rolf Evers-Fischer wrote: Hi, Christian Gromm writes: we observe an issue with a td_list running empty and an endpoint being stalled at the same time on Linux ihu-low 4.1.27-abl #1 SMP PREEMPT Mon Mar 20 13:51:51 CET 2017 x86_64 x86_64 x86_64 GNU/Linux. we've recen

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-04-11 Thread Rolf Evers-Fischer
Hi, Christian Gromm writes: > we observe an issue with a td_list running empty and an > endpoint being stalled at the same time on > > Linux ihu-low 4.1.27-abl #1 SMP PREEMPT Mon Mar 20 13:51:51 CET 2017 > x86_64 x86_64 x86_64 GNU/Linux. we've recently observed the same problem with "Linux ihu-

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-30 Thread Janusz Dziedzic
On 30 March 2017 at 11:23, Greg KH wrote: > On Thu, Mar 30, 2017 at 11:11:34AM +0200, Janusz Dziedzic wrote: >> On 30 March 2017 at 10:53, Greg KH wrote: >> > On Thu, Mar 30, 2017 at 10:29:41AM +0200, Christian Gromm wrote: >> >> >> >> >> >> On 03/27/2017 11:31 AM, Felipe Balbi wrote: >> >> > >>

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-30 Thread Greg KH
On Thu, Mar 30, 2017 at 11:11:34AM +0200, Janusz Dziedzic wrote: > On 30 March 2017 at 10:53, Greg KH wrote: > > On Thu, Mar 30, 2017 at 10:29:41AM +0200, Christian Gromm wrote: > >> > >> > >> On 03/27/2017 11:31 AM, Felipe Balbi wrote: > >> > > >> > Hi, > >> > > >> > Christian Gromm writes: > >>

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-30 Thread Janusz Dziedzic
On 30 March 2017 at 10:53, Greg KH wrote: > On Thu, Mar 30, 2017 at 10:29:41AM +0200, Christian Gromm wrote: >> >> >> On 03/27/2017 11:31 AM, Felipe Balbi wrote: >> > >> > Hi, >> > >> > Christian Gromm writes: >> > > we observe an issue with a td_list running empty and an >> > > endpoint being st

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-30 Thread Greg KH
On Thu, Mar 30, 2017 at 10:29:41AM +0200, Christian Gromm wrote: > > > On 03/27/2017 11:31 AM, Felipe Balbi wrote: > > > > Hi, > > > > Christian Gromm writes: > > > we observe an issue with a td_list running empty and an > > > endpoint being stalled at the same time on > > > > > > Linux ihu-l

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-30 Thread Christian Gromm
On 03/27/2017 11:31 AM, Felipe Balbi wrote: Hi, Christian Gromm writes: we observe an issue with a td_list running empty and an endpoint being stalled at the same time on Linux ihu-low 4.1.27-abl #1 SMP PREEMPT Mon Mar 20 13:51:51 CET 2017 x86_64 x86_64 x86_64 GNU/Linux. this is one old

Re: usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-27 Thread Felipe Balbi
Hi, Christian Gromm writes: > we observe an issue with a td_list running empty and an > endpoint being stalled at the same time on > > Linux ihu-low 4.1.27-abl #1 SMP PREEMPT Mon Mar 20 13:51:51 CET 2017 > x86_64 x86_64 x86_64 GNU/Linux. this is one old kernel. Please upgrade to v4.11-rc4 or v

usb: host: xhci: stalled endpoint ring not cleared on empty td_list

2017-03-27 Thread Christian Gromm
Hi, we observe an issue with a td_list running empty and an endpoint being stalled at the same time on Linux ihu-low 4.1.27-abl #1 SMP PREEMPT Mon Mar 20 13:51:51 CET 2017 x86_64 x86_64 x86_64 GNU/Linux. According to the logs, the halt condition of the endpoint is detected on host side, but n