+CC: Felipe Balbi
On 11/24/2014 04:48 AM, Dan Carpenter wrote:
> On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote:
>> Hello Dinh Nguyen,
>>
>> The patch 8d736d8a9c44: "usb: dwc2: gadget: Do not fail probe if
>> there isn't a clock node"
On Mon, Nov 24, 2014 at 10:49:57AM -0600, Dinh Nguyen wrote:
> +CC: Felipe Balbi
>
> On 11/24/2014 04:48 AM, Dan Carpenter wrote:
> > On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote:
> >> Hello Dinh Nguyen,
> >>
> >> The patch 8d736d8a9c44
On Mon, Nov 24, 2014 at 01:46:56PM +0300, Dan Carpenter wrote:
> Hello Dinh Nguyen,
>
> The patch 8d736d8a9c44: "usb: dwc2: gadget: Do not fail probe if
> there isn't a clock node" from Nov 11, 2014, leads to the following
> static checker warning:
>
>
Hello Dinh Nguyen,
The patch 8d736d8a9c44: "usb: dwc2: gadget: Do not fail probe if
there isn't a clock node" from Nov 11, 2014, leads to the following
static checker warning:
drivers/usb/dwc2/gadget.c:3436 dwc2_gadget_init()
warn: passing zero to 'PTR_ER
On Fri, Nov 14, 2014 at 09:01:49PM +, Paul Zimmerman wrote:
> > From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com]
> > Sent: Tuesday, November 11, 2014 9:14 AM
> >
> > From: Dinh Nguyen
> >
> > Since the dwc2 hcd driver is currently not looking for a clock node duri
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com]
> Sent: Tuesday, November 11, 2014 9:14 AM
>
> From: Dinh Nguyen
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
>
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
By assigning clk = NULL, this allows the driver, when configured for dual-role
mode, to be able to continue loading the host portion of
Hi,
On Fri, Oct 31, 2014 at 02:31:31PM -0500, Dinh Nguyen wrote:
> On 10/31/2014 12:42 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Fri, Oct 31, 2014 at 10:20:06AM -0500, Dinh Nguyen wrote:
> @@ -339,7 +339,8 @@ static void dwc2_handle_wakeup_detected_intr(struct
> dwc2_hsotg *hsotg)
> >
On 10/31/2014 02:31 PM, Dinh Nguyen wrote:
> On 10/31/2014 12:42 PM, Felipe Balbi wrote:
>> Hi,
>>
>> On Fri, Oct 31, 2014 at 10:20:06AM -0500, Dinh Nguyen wrote:
> @@ -339,7 +339,8 @@ static void dwc2_handle_wakeup_detected_intr(struct
> dwc2_hsotg *hsotg)
> }
>
On 10/31/2014 12:42 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Oct 31, 2014 at 10:20:06AM -0500, Dinh Nguyen wrote:
@@ -339,7 +339,8 @@ static void dwc2_handle_wakeup_detected_intr(struct
dwc2_hsotg *hsotg)
}
/* Change to L0 state */
hsotg-
Hi,
On Fri, Oct 31, 2014 at 10:20:06AM -0500, Dinh Nguyen wrote:
> >> @@ -339,7 +339,8 @@ static void dwc2_handle_wakeup_detected_intr(struct
> >> dwc2_hsotg *hsotg)
> >>}
> >>/* Change to L0 state */
> >>hsotg->lx_state = DWC2_L0;
> >> - call_gadget(h
On 10/30/2014 09:04 AM, Felipe Balbi wrote:
> Hi,
>
> On Tue, Oct 28, 2014 at 06:25:47PM -0500, dingu...@opensource.altera.com
> wrote:
>> From: Dinh Nguyen
>>
>> Since the dwc2 hcd driver is currently not looking for a clock node during
>> init, we should not completely fail if there isn't a cl
On Fri, Oct 31, 2014 at 10:38:28AM +0800, Kever Yang wrote:
> Hi Dinh,
>
> On 10/29/2014 07:25 AM, dingu...@opensource.altera.com wrote:
> >From: Dinh Nguyen
> >
> >Since the dwc2 hcd driver is currently not looking for a clock node during
> >init, we should not completely fail if there isn't a c
Hi Dinh,
On 10/29/2014 07:25 AM, dingu...@opensource.altera.com wrote:
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
For dual-role mode, we will only fail init for a non-clock no
Hi,
On Tue, Oct 28, 2014 at 06:25:47PM -0500, dingu...@opensource.altera.com wrote:
> From: Dinh Nguyen
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
> For dual-role mode, we will only fail in
> From: dingu...@opensource.altera.com [mailto:dingu...@opensource.altera.com]
> Sent: Tuesday, October 28, 2014 4:26 PM
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
> For dual-role mode, we wi
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
For dual-role mode, we will only fail init for a non-clock node error. We
then update the HCD to only call gadget funtions if there is
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
For dual-role mode, we will only fail init for a non-clock node error. We
then update the HCD to only call gadget funtions if there is
On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote:
>
> [ added linux-kernel ML to cc: ]
>
> Hi,
>
> On Tuesday, August 26, 2014 11:19:59 AM dingu...@opensource.altera.com wrote:
>> From: Dinh Nguyen
>>
>> Since the dwc2 hcd driver is currently not looking for a clock node during
>> init,
[ added linux-kernel ML to cc: ]
Hi,
On Tuesday, August 26, 2014 11:19:59 AM dingu...@opensource.altera.com wrote:
> From: Dinh Nguyen
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
> Add a c
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
Acked-by: Paul Zimmerman
---
drivers/usb/d
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
---
drivers/usb/dwc2/gadget.c | 36
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
---
drivers/usb/dwc2/gadget.c | 37 ++
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
---
drivers/usb/dwc2/gadget.c | 15 ++
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
---
drivers/usb/dwc2/gadget.c | 15 ++
From: Dinh Nguyen
Since the dwc2 hcd driver is currently not looking for a clock node during
init, we should not completely fail if there isn't a clock provided.
Add a check for a valid clock before calling clock functions.
Signed-off-by: Dinh Nguyen
---
drivers/usb/dwc2/gadget.c | 15 ++
26 matches
Mail list logo
