Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Dan Carpenter
Fine. Sounds good. I just wanted to make sure. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Valentina Manea
On Tue, Aug 26, 2014 at 11:47 AM, Dan Carpenter wrote: > On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: >> On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter >> wrote: >> >707 /* >> >708 * loop over all packets from last to first (to prevent >> > overwri

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Greg Kroah-Hartman
On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: > On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter > wrote: > > This was promoted out of staging and there wasn't an email to the > > staging list. Normally I like to go through any remaining questions > > before the code is moved. T

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Dan Carpenter
On Tue, Aug 26, 2014 at 09:06:17AM -0700, Valentina Manea wrote: > On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter > wrote: > >707 /* > >708 * loop over all packets from last to first (to prevent > > overwritting > >709 * memory when padding) and move them

Re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Valentina Manea
On Tue, Aug 26, 2014 at 6:12 AM, Dan Carpenter wrote: > This was promoted out of staging and there wasn't an email to the > staging list. Normally I like to go through any remaining questions > before the code is moved. The code looks pretty good, I just had one > question. > I didn't know I sho

re: staging: usbip: bugfix for isochronous packets and optimization

2014-08-26 Thread Dan Carpenter
This was promoted out of staging and there wasn't an email to the staging list. Normally I like to go through any remaining questions before the code is moved. The code looks pretty good, I just had one question. drivers/usb/usbip/usbip_common.c:712 usbip_pad_iso() warn: why is z