Re: USB: EHCI: create per-TT bandwidth tables

2013-11-06 Thread Dan Carpenter
On Wed, Nov 06, 2013 at 11:24:37AM -0500, Alan Stern wrote: > Short of adding redundant tests, how would you suggest this be handled? Yeah. I discourage people from making changes to please the checker. It often hurts readability. Also the checker is changing all the time and later we might want

re: USB: EHCI: create per-TT bandwidth tables

2013-11-06 Thread Alan Stern
On Tue, 5 Nov 2013, Dan Carpenter wrote: > Hello Alan Stern, > > The patch b35c5009bbf6: "USB: EHCI: create per-TT bandwidth tables" > from Oct 11, 2013, leads to the following > static checker warning: "drivers/usb/host/ehci-sched.c:1377 > reserve_release_iso_bandwidth() >error: 'tt' d

re: USB: EHCI: create per-TT bandwidth tables

2013-11-05 Thread Dan Carpenter
Hello Alan Stern, The patch b35c5009bbf6: "USB: EHCI: create per-TT bandwidth tables" from Oct 11, 2013, leads to the following static checker warning: "drivers/usb/host/ehci-sched.c:1377 reserve_release_iso_bandwidth() error: 'tt' dereferencing possible ERR_PTR()" drivers/usb/host/ehc