Re: question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Julia Lawall
On Fri, 28 Oct 2016, Bin Liu wrote: > On Fri, Oct 28, 2016 at 04:53:03PM -0400, Greg Kroah-Hartman wrote: > > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > > > > The file drivers/usb/musb/musb_core.c contains the

Re: question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Bin Liu
On Fri, Oct 28, 2016 at 04:53:03PM -0400, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > > The file drivers/usb/musb/musb_core.c contains the code: > > > > > > static DEVICE_ATTR(srp, 0644, NU

Re: question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Julia Lawall
On Fri, 28 Oct 2016, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > > The file drivers/usb/musb/musb_core.c contains the code: > > > > > > static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store);

Re: question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Julia Lawall
[Corrected email for Felipe] On Fri, 28 Oct 2016, Greg Kroah-Hartman wrote: > On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > > > The file drivers/usb/musb/musb_core.c contains the code: > > > > > > static DEVICE_ATTR(srp, 0

Re: question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Greg Kroah-Hartman
On Fri, Oct 28, 2016 at 10:33:19PM +0200, Julia Lawall wrote: > > > On Fri, 28 Oct 2016, Julia Lawall wrote: > > > The file drivers/usb/musb/musb_core.c contains the code: > > > > static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store); > > > > Is it correct to have NULL in the third argument for an

Re: question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Julia Lawall
On Fri, 28 Oct 2016, Julia Lawall wrote: > The file drivers/usb/musb/musb_core.c contains the code: > > static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store); > > Is it correct to have NULL in the third argument for an attribute that can > be read? Should the permission be 0444 instead? Sorry, I

question about drivers/usb/musb/musb_core.c

2016-10-28 Thread Julia Lawall
The file drivers/usb/musb/musb_core.c contains the code: static DEVICE_ATTR(srp, 0644, NULL, musb_srp_store); Is it correct to have NULL in the third argument for an attribute that can be read? Should the permission be 0444 instead? thanks, julia -- To unsubscribe from this list: send the line