RE: net2280 Driver Bug

2017-02-08 Thread Felipe Balbi
Hi, Raz Manor writes: > Raz Manor writes: >> Got it. Then I'm resending the patch, and looking forward to your replay. > > please read Documentation/SubmittingPatches :-) > > you need a commit log, a Signed-off-by line, etc etc. Please send a proper > patch otherwise we can't apply it, sorry.

RE: net2280 Driver Bug

2017-02-08 Thread Raz Manor
-Original Message- From: Felipe Balbi [mailto:ba...@kernel.org] Sent: Monday, February 6, 2017 10:26 AM To: Raz Manor ; Greg Kroah-Hartman Cc: Alan Stern ; Linus Torvalds ; USB list ; Tim Harvey ; Heikki Krogerus ; Jussi Kivilinna ; Colin Ian King Subject: RE: net2280 Driver Bug

RE: net2280 Driver Bug

2017-02-06 Thread Felipe Balbi
Hi, Raz Manor writes: > Got it. Then I'm resending the patch, and looking forward to your replay. please read Documentation/SubmittingPatches :-) you need a commit log, a Signed-off-by line, etc etc. Please send a proper patch otherwise we can't apply it, sorry. -- balbi signature.asc Desc

RE: net2280 Driver Bug

2017-02-05 Thread Raz Manor
elipe Balbi ; Tim Harvey ; Heikki Krogerus ; Jussi Kivilinna ; Colin Ian King Subject: Re: net2280 Driver Bug On Thu, Feb 02, 2017 at 12:50:02PM +, Raz Manor wrote: > I opened a pull request for this patch > https://github.com/torvalds/linux/pull/388 Linux development does not work with

Re: net2280 Driver Bug

2017-02-02 Thread Greg Kroah-Hartman
On Thu, Feb 02, 2017 at 12:50:02PM +, Raz Manor wrote: > I opened a pull request for this patch > https://github.com/torvalds/linux/pull/388 Linux development does not work with github pull requests, sorry. Please see Documentation/development_process/ for how we all work together. Please se

RE: net2280 Driver Bug

2017-02-02 Thread Raz Manor
Manor ; Linus Torvalds ; USB list ; Felipe Balbi ; Tim Harvey ; Heikki Krogerus ; Jussi Kivilinna ; Colin Ian King Subject: Re: net2280 Driver Bug On Thu, 5 Jan 2017, Greg Kroah-Hartman wrote: > On Tue, Dec 27, 2016 at 03:56:11PM +, Raz Manor wrote: > > I'm not entirely sure e

Re: net2280 Driver Bug

2017-01-05 Thread Alan Stern
On Thu, 5 Jan 2017, Greg Kroah-Hartman wrote: > On Tue, Dec 27, 2016 at 03:56:11PM +, Raz Manor wrote: > > I'm not entirely sure either, that is why I wanted the specs. > > Alan sent me the PLX NET2280 specs, but I'm using the USB3380/USB3381 - the > > USB3 version of the device. > > As it se

Re: net2280 Driver Bug

2017-01-05 Thread Greg Kroah-Hartman
On Tue, Dec 27, 2016 at 03:56:11PM +, Raz Manor wrote: > I'm not entirely sure either, that is why I wanted the specs. > Alan sent me the PLX NET2280 specs, but I'm using the USB3380/USB3381 - the > USB3 version of the device. > As it seems from the code, the HW interface is mostly the same, w

RE: net2280 Driver Bug

2016-12-27 Thread Raz Manor
m Harvey ; Heikki Krogerus ; Jussi Kivilinna ; Colin Ian King Subject: RE: net2280 Driver Bug On Mon, 26 Dec 2016, Linus Torvalds wrote: > On Dec 26, 2016 4:04 PM, "Alan Stern" wrote: > > > Note that the usage of tmp in the "if (unlikely(req->td->dmadesc == 0))

RE: net2280 Driver Bug

2016-12-27 Thread Alan Stern
On Mon, 26 Dec 2016, Linus Torvalds wrote: > On Dec 26, 2016 4:04 PM, "Alan Stern" wrote: > > > Note that the usage of tmp in the "if (unlikely(req->td->dmadesc == 0)) {" > branch really is not conflicting, because that branch breaks out of the > enclosing "while" loop. > > > No. > > Look clo

RE: net2280 Driver Bug

2016-12-26 Thread Alan Stern
On Mon, 26 Dec 2016, Raz Manor wrote: > Hello all, > Linus is right, I should remove all debug prints and keep > whit-spacing conventions. > > As for the real part of the patch, it is correct that it is only the > tmp reuse problem, and I couldn't agree more that it is a bad idea to > reuse a var

RE: net2280 Driver Bug

2016-12-26 Thread Raz Manor
Kivilinna ; Colin Ian King ; Tim Harvey ; Heikki Krogerus Cc: Greg Kroah-Hartman ; USB list Subject: Re: net2280 Driver Bug On Sun, Dec 25, 2016 at 8:09 AM, Raz Manor wrote: > > I had a problem with the net2280 driver- reading from an endpoint > resulted with a wrong read size i

Re: net2280 Driver Bug

2016-12-25 Thread Linus Torvalds
On Sun, Dec 25, 2016 at 8:09 AM, Raz Manor wrote: > > I had a problem with the net2280 driver- reading from an endpoint resulted > with a wrong read size in some cases. > > I found the problem and fixed it, and I wanted to publish the fix. However, > I have no push access, and I couldn't find who