Re: handling ioctl for storage autopm

2008-01-18 Thread Alan Stern
On Fri, 18 Jan 2008, Oliver Neukum wrote: > Am Dienstag, 15. Januar 2008 16:30:34 schrieb Alan Stern: > > On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > > > Hi Alan, > > > > > > here's a simple implementation to handle ioctl() by blocking > > > autosuspend until the device is closed again. > >

Re: handling ioctl for storage autopm

2008-01-18 Thread Oliver Neukum
Am Dienstag, 15. Januar 2008 16:30:34 schrieb Alan Stern: > On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > Hi Alan, > > > > here's a simple implementation to handle ioctl() by blocking > > autosuspend until the device is closed again. > > > > It is relative to your patch set. > > A few comment

Re: handling ioctl for storage autopm

2008-01-16 Thread Alan Stern
On Wed, 16 Jan 2008, Oliver Neukum wrote: > > The only scenario where this would matter is when there are two > > overlapping open calls, of which one uses ioctls and the other does > > doesn't. I can't think of any examples, except perhaps where somebody > > does an ioctl on a mounted device

Re: handling ioctl for storage autopm

2008-01-16 Thread Oliver Neukum
Am Mittwoch, 16. Januar 2008 16:58:51 schrieb Alan Stern: > On Wed, 16 Jan 2008, Oliver Neukum wrote: > > > > This entire issue needs more thought. There must be plenty of ioctl > > > calls which shouldn't force a device to remain resumed. > > > > Sure. The question is whether it is worth a lot

Re: handling ioctl for storage autopm

2008-01-16 Thread Alan Stern
On Wed, 16 Jan 2008, Oliver Neukum wrote: > > This entire issue needs more thought. There must be plenty of ioctl > > calls which shouldn't force a device to remain resumed. > > Sure. The question is whether it is worth a lot of effort to filter them. > Are ioctl()s on block devices common? I

Re: handling ioctl for storage autopm

2008-01-16 Thread Oliver Neukum
Am Mittwoch, 16. Januar 2008 16:26:03 schrieb Alan Stern: > On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > > > > Do all ioctls filter through this routine? It looks like requests > > > > > coming through block/scsi_ioctl.c will bypass this code. Have you > > > > > decided to ignore those requ

Re: handling ioctl for storage autopm

2008-01-16 Thread Alan Stern
On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > > Do all ioctls filter through this routine? It looks like requests > > > > coming through block/scsi_ioctl.c will bypass this code. Have you > > > > decided to ignore those requests for now? > > > > > > I found no way to deal with them without

Re: handling ioctl for storage autopm

2008-01-15 Thread Oliver Neukum
Am Dienstag, 15. Januar 2008 17:19:02 schrieb Alan Stern: > On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > > > --- linux-as/drivers/scsi/sd.c 2008-01-15 14:17:05.0 +0100 > > > > +++ linux-2.6.24-scsi-pm/drivers/scsi/sd.c 2008-01-15 > > > > 14:20:13.0 +0100 > > > > @@ -711,6

Re: handling ioctl for storage autopm

2008-01-15 Thread Alan Stern
On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > --- linux-as/drivers/scsi/sd.c2008-01-15 14:17:05.0 +0100 > > > +++ linux-2.6.24-scsi-pm/drivers/scsi/sd.c2008-01-15 > > > 14:20:13.0 +0100 > > > @@ -711,6 +718,19 @@ static int sd_ioctl(struct inode * inode > > >

Re: handling ioctl for storage autopm

2008-01-15 Thread Oliver Neukum
Am Dienstag, 15. Januar 2008 16:30:34 schrieb Alan Stern: > On Tue, 15 Jan 2008, Oliver Neukum wrote: > > > Hi Alan, > > > > here's a simple implementation to handle ioctl() by blocking > > autosuspend until the device is closed again. > > > > It is relative to your patch set. > > A few comment

Re: handling ioctl for storage autopm

2008-01-15 Thread Alan Stern
On Tue, 15 Jan 2008, Oliver Neukum wrote: > Hi Alan, > > here's a simple implementation to handle ioctl() by blocking > autosuspend until the device is closed again. > > It is relative to your patch set. A few comments are below. > --- linux-as/drivers/scsi/sd.c2008-01-15 14:17:05.

handling ioctl for storage autopm

2008-01-15 Thread Oliver Neukum
Hi Alan, here's a simple implementation to handle ioctl() by blocking autosuspend until the device is closed again. It is relative to your patch set. Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> --- linux-as/drivers/scsi/sd.c 2008-01-15 14:17:05.0 +0100 +++ linux-2.6.24-scsi-