Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Fri, Aug 17, 2012 at 03:41:33PM +0200, Gerd Hoffmann wrote: > I'm testing uas in a virtual machine, qemu 1.2 (to be released soon) > features uas emulation support. Only usb 2.0 for now, qemu usb > emulation can't handle streams and other 3.0 stuff. Yet. Ah good to know. So there is an altern

Re: disconnect and uas_work_list

2012-08-17 Thread Gerd Hoffmann
On 08/17/12 15:01, Sebastian Andrzej Siewior wrote: > On Fri, Aug 17, 2012 at 02:13:40PM +0200, Oliver Neukum wrote: >>> I just noticed some of my patches here got reverted. Do you have any >>> hardware >>> or did you just stumble over it? I have just my target UAS gadget… >> >> No hardware. Do

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Fri, Aug 17, 2012 at 03:05:15PM +0200, Oliver Neukum wrote: > On Friday 17 August 2012 15:01:16 Sebastian Andrzej Siewior wrote: > > > It is possible that you get -ENOMEM while a command is already being > > > executed. The worst case is probably that you got a command to the device > > > and y

Re: disconnect and uas_work_list

2012-08-17 Thread Oliver Neukum
On Friday 17 August 2012 15:01:16 Sebastian Andrzej Siewior wrote: > > It is possible that you get -ENOMEM while a command is already being > > executed. The worst case is probably that you got a command to the device > > and you need to do autosense, but you get -ENOMEM. > > Looking at the code,

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Fri, Aug 17, 2012 at 02:13:40PM +0200, Oliver Neukum wrote: > > I just noticed some of my patches here got reverted. Do you have any > > hardware > > or did you just stumble over it? I have just my target UAS gadget… > > No hardware. Do you have suggestions where to get hardware? No. I've b

Re: disconnect and uas_work_list

2012-08-17 Thread Oliver Neukum
On Friday 17 August 2012 13:11:30 Sebastian Andrzej Siewior wrote: > On Thu, Aug 16, 2012 at 04:23:15PM +0200, Oliver Neukum wrote: > > > > > No, you are right. If the command EP was closed and the URB submission > > > then it > > > will retry over and over again. > > > > Well, what remedy woul

Re: disconnect and uas_work_list

2012-08-17 Thread Sebastian Andrzej Siewior
On Thu, Aug 16, 2012 at 04:23:15PM +0200, Oliver Neukum wrote: > > > No, you are right. If the command EP was closed and the URB submission then > > it > > will retry over and over again. > > Well, what remedy would you suggest? I just noticed some of my patches here got reverted. Do you have

Re: disconnect and uas_work_list

2012-08-17 Thread Oliver Neukum
On Thursday 16 August 2012 16:03:36 Sebastian Andrzej Siewior wrote: > On Tue, Aug 14, 2012 at 05:48:56PM +0200, Oliver Neukum wrote: > > going through uas it looks to me like there is a race by which > > uas_do_work() can walk uas_work_list and do IO to a device > > after it has been removed. This

Re: disconnect and uas_work_list

2012-08-16 Thread Sebastian Andrzej Siewior
On Tue, Aug 14, 2012 at 05:48:56PM +0200, Oliver Neukum wrote: > going through uas it looks to me like there is a race by which > uas_do_work() can walk uas_work_list and do IO to a device > after it has been removed. This makes me wonder why you used > a single global list. Could you comment on th

disconnect and uas_work_list

2012-08-14 Thread Oliver Neukum
Hi, going through uas it looks to me like there is a race by which uas_do_work() can walk uas_work_list and do IO to a device after it has been removed. This makes me wonder why you used a single global list. Could you comment on that and tell me whether I missed something subtle? Regards