Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+d232cca6ec42c2edb...@syzkaller.appspotmail.com Tested on: commit: e06ce4da usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Oliver Neukum
Am Montag, den 19.08.2019, 17:50 -0700 schrieb syzbot: > syzbot has found a reproducer for the following crash on: Hi Bjørn, taking you into CC as you are affected. V4: > HEAD commit:e06ce4da usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Oliver Neukum
Am Dienstag, den 20.08.2019, 15:13 +0200 schrieb Bjørn Mork : > Oliver Neukum writes: > > > + wait_event(desc->wait, > > + /* > > +* needs both flags. We cannot do with one > > +* because resetting it would cause a race > > +

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Bjørn Mork
Oliver Neukum writes: > + wait_event(desc->wait, > + /* > + * needs both flags. We cannot do with one > + * because resetting it would cause a race > + * with write() yet we need to signal > +

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+d232cca6ec42c2edb...@syzkaller.appspotmail.com Tested on: commit: e06ce4da usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Oliver Neukum
Am Montag, den 19.08.2019, 17:50 -0700 schrieb syzbot: > syzbot has found a reproducer for the following crash on: Hi Bjørn, taking you into CC as you are affected. V3: changes you suggested > HEAD commit:e06ce4da usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Oliver Neukum
Am Dienstag, den 20.08.2019, 12:44 +0200 schrieb Bjørn Mork : > Oliver Neukum writes: > > > diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c > > index 1656f5155ab8..a341081a5f47 100644 > > --- a/drivers/usb/class/cdc-wdm.c > > +++ b/drivers/usb/class/cdc-wdm.c > > @@ -588,14

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+d232cca6ec42c2edb...@syzkaller.appspotmail.com Tested on: commit: e06ce4da usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Oliver Neukum
Am Montag, den 19.08.2019, 17:50 -0700 schrieb syzbot: > syzbot has found a reproducer for the following crash on: Hi Bjørn, taking you into CC as you are affected. V2: fix logic bug Regards Oliver > HEAD commit:e06ce4da usb-fuzzer: main usb gadget fuzzer driver > g

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Bjørn Mork
Oliver Neukum writes: > diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c > index 1656f5155ab8..a341081a5f47 100644 > --- a/drivers/usb/class/cdc-wdm.c > +++ b/drivers/usb/class/cdc-wdm.c > @@ -588,14 +588,24 @@ static int wdm_flush(struct file *file, fl_owner_t id) > { >

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: INFO: task hung in wdm_flush INFO: task syz-executor.1:2841 blocked for more than 143 seconds. Not tainted 5.3.0-rc5+ #1 "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. syz-ex

Re: WARNING in wdm_write/usb_submit_urb

2019-08-20 Thread Oliver Neukum
Am Montag, den 19.08.2019, 17:50 -0700 schrieb syzbot: > syzbot has found a reproducer for the following crash on: Hi Bjørn, taking you into CC as you are affected. > HEAD commit:e06ce4da usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzz

Re: WARNING in wdm_write/usb_submit_urb

2019-08-19 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:e06ce4da usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=14a8c0b660 kernel config: https://syzkaller.ap

WARNING in wdm_write/usb_submit_urb

2019-08-19 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d0847550 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasan.git usb-fuzzer console output: https://syzkaller.appspot.com/x/log.txt?x=16462bba60 kernel config: https://syzkaller.appspot.com/x/.