Re: USB: serial: ftdi_sio: fix extreme low-latency setting

2017-05-02 Thread Johan Hovold
On Tue, May 02, 2017 at 12:05:48PM +0200, Anthony Mallet wrote: > On Tuesday 2 May 2017, at 10:34, Johan Hovold wrote: > > On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: > > > This is due to commit 557aaa7 > > > https://github.com/torvalds/linux/commit/557aaa7ffab639d0190b935a041b

Re: USB: serial: ftdi_sio: fix extreme low-latency setting

2017-05-02 Thread Anthony Mallet
On Tuesday 2 May 2017, at 10:34, Johan Hovold wrote: > On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: > > This is due to commit 557aaa7 > > https://github.com/torvalds/linux/commit/557aaa7ffab639d0190b935a041b16ae44606342 > > that silently/partially ignores the ASYNC_LOW_LATENCY f

Re: USB: serial: ftdi_sio: fix extreme low-latency setting

2017-05-02 Thread Johan Hovold
On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: > Hello, > > Regarding this commit: > https://github.com/torvalds/linux/commit/c6dce262 > > The change breaks things badly as regular users cannot > programmatically get the previous 1ms latency setting anymore. This is > even more h

Re: USB: serial: ftdi_sio: fix extreme low-latency setting

2017-04-28 Thread Greg KH
On Fri, Apr 28, 2017 at 02:34:17PM +0200, Anthony Mallet wrote: > On Friday 28 Apr 2017, at 14:11, Greg KH wrote: > | On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: > | > Regarding this commit: > | > https://github.com/torvalds/linux/commit/c6dce262 > | > | Any reason you didn't c

Re: USB: serial: ftdi_sio: fix extreme low-latency setting

2017-04-28 Thread Anthony Mallet
On Friday 28 Apr 2017, at 14:11, Greg KH wrote: | On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: | > Regarding this commit: | > https://github.com/torvalds/linux/commit/c6dce262 | | Any reason you didn't cc: the author of that patch, and the person | that reported the original iss

Re: USB: serial: ftdi_sio: fix extreme low-latency setting

2017-04-28 Thread Greg KH
On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: > Hello, > > Regarding this commit: > https://github.com/torvalds/linux/commit/c6dce262 Any reason you didn't cc: the author of that patch, and the person that reported the original issue that patch was trying to fix? > The change b

USB: serial: ftdi_sio: fix extreme low-latency setting

2017-04-28 Thread Anthony Mallet
Hello, Regarding this commit: https://github.com/torvalds/linux/commit/c6dce262 The change breaks things badly as regular users cannot programmatically get the previous 1ms latency setting anymore. This is even more harmful that distributions started to include this patch, e.g. in ubuntu 14.04.5

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

2017-01-25 Thread Johan Hovold
On Wed, Jan 25, 2017 at 04:42:01PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2017 at 04:14:36PM +0100, Johan Hovold wrote: > > On Wed, Jan 25, 2017 at 04:06:47PM +0100, Greg Kroah-Hartman wrote: > > > On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > > > > Since commit 557aaa

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

2017-01-25 Thread Greg Kroah-Hartman
On Wed, Jan 25, 2017 at 04:14:36PM +0100, Johan Hovold wrote: > On Wed, Jan 25, 2017 at 04:06:47PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > > > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY > > > flag") the FTDI driver h

RE: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

2017-01-25 Thread David Laight
From: Johan Hovold > Sent: 25 January 2017 14:35 > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY > flag") the FTDI driver has been using a receive latency-timer value of > 1 ms instead of the device default of 16 ms. > > The latency timer is used to periodically empty a non-full

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

2017-01-25 Thread Johan Hovold
On Wed, Jan 25, 2017 at 04:06:47PM +0100, Greg Kroah-Hartman wrote: > On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY > > flag") the FTDI driver has been using a receive latency-timer value of > > 1 ms instead of the

Re: [PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

2017-01-25 Thread Greg Kroah-Hartman
On Wed, Jan 25, 2017 at 03:35:20PM +0100, Johan Hovold wrote: > Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY > flag") the FTDI driver has been using a receive latency-timer value of > 1 ms instead of the device default of 16 ms. > > The latency timer is used to periodically emp

[PATCH] USB: serial: ftdi_sio: fix extreme low-latency setting

2017-01-25 Thread Johan Hovold
Since commit 557aaa7ffab6 ("ft232: support the ASYNC_LOW_LATENCY flag") the FTDI driver has been using a receive latency-timer value of 1 ms instead of the device default of 16 ms. The latency timer is used to periodically empty a non-full receive buffer, but a status header is always sent when th