Re: ehci-hcd compile error

2013-01-22 Thread Alan Stern
On Tue, 22 Jan 2013, Roger Quadros wrote: > Alan, > > It seems that EHCI_STATS is locally defined in ehci_hcd.c thus causing > different versions of struct ehci_hcd to be visible to other users > like ehci-omap.c > > The attached patch solves the problem for me and must go in with your > other p

Re: ehci-hcd compile error

2013-01-22 Thread Roger Quadros
On 01/18/2013 08:35 PM, Alan Stern wrote: > On Fri, 18 Jan 2013, Roger Quadros wrote: > >> Thanks. I used the below code (also attached) and could reproduce >> corruption on the first byte at ehci->priv. This is from the the kernel log. >> >>> [ 30.381774] ehci-omap ehci-omap.0: ehci_hcd_omap_pr

Re: ehci-hcd compile error

2013-01-18 Thread Alan Stern
On Fri, 18 Jan 2013, Roger Quadros wrote: > Thanks. I used the below code (also attached) and could reproduce > corruption on the first byte at ehci->priv. This is from the the kernel log. > > > [ 30.381774] ehci-omap ehci-omap.0: ehci_hcd_omap_probe a 0x1234abcd, b > > 0x5679efba > > > [ 12

Re: ehci-hcd compile error

2013-01-18 Thread Roger Quadros
On 01/17/2013 06:10 PM, Alan Stern wrote: > On Thu, 17 Jan 2013, Roger Quadros wrote: > >> Alan, >> >> What tree is your patch based off? > > Roughly speaking, 3.7 plus Greg KH's usb-next branch as of the 3.7 > release. This should be pretty much the same as 3.8-rc1 as far as the > USB stack is

Re: ehci-hcd compile error

2013-01-17 Thread Alan Stern
On Thu, 17 Jan 2013, Roger Quadros wrote: > Alan, > > What tree is your patch based off? Roughly speaking, 3.7 plus Greg KH's usb-next branch as of the 3.7 release. This should be pretty much the same as 3.8-rc1 as far as the USB stack is concerned. I haven't tried applying the patch to 3.8-rc

Re: ehci-hcd compile error

2013-01-17 Thread Roger Quadros
On 01/17/2013 05:39 PM, Alan Stern wrote: >>> On Thu, 10 Jan 2013, Felipe Balbi wrote: >>> Hi Alan, with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" r

Re: ehci-hcd compile error

2013-01-17 Thread Alan Stern
> > > > > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > > > > > > > > > Hi Alan, > > > > > > > > > > > > > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use > > > > > > > allmodconfig: > > > > > > > > > > > > > > drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" >

Re: ehci-hcd compile error

2013-01-11 Thread Roger Quadros
On 01/11/2013 05:09 PM, Alan Stern wrote: > On Fri, 11 Jan 2013, Roger Quadros wrote: > >>> --- usb-3.7.orig/drivers/usb/host/ehci.h >>> +++ usb-3.7/drivers/usb/host/ehci.h >>> @@ -221,6 +221,8 @@ struct ehci_hcd { /* one per >>> controlle >>> #ifdef DEBUG >>> struct de

Re: ehci-hcd compile error

2013-01-11 Thread Alan Stern
On Fri, 11 Jan 2013, Roger Quadros wrote: > > --- usb-3.7.orig/drivers/usb/host/ehci.h > > +++ usb-3.7/drivers/usb/host/ehci.h > > @@ -221,6 +221,8 @@ struct ehci_hcd { /* one per > > controlle > > #ifdef DEBUG > > struct dentry *debug_dir; > > #endif > > + >

Re: ehci-hcd compile error

2013-01-11 Thread Roger Quadros
On 01/10/2013 10:28 PM, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > >> -ENOROGER :-p >> >> On Thu, Jan 10, 2013 at 08:23:56PM +0200, Felipe Balbi wrote: >>> Hi >>> >>> On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: On Thu, 10 Jan 2013, Felipe Balbi wrote:

Re: ehci-hcd compile error

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > -ENOROGER :-p > > On Thu, Jan 10, 2013 at 08:23:56PM +0200, Felipe Balbi wrote: > > Hi > > > > On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > > > Hi, > > > > > > > > On Thu, Jan 10,

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
-ENOROGER :-p On Thu, Jan 10, 2013 at 08:23:56PM +0200, Felipe Balbi wrote: > Hi > > On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > Hi, > > > > > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > > > On Thu, 10

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi On Thu, Jan 10, 2013 at 12:01:09PM -0500, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > Hi, > > > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > > > Hi Alan, > > > > > > > > with v3.8-rc3, ehci-hcd

Re: ehci-hcd compile error

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > Hi, > > On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > > > Hi Alan, > > > > > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > > > > > drivers/usb/host/ehci-h

Re: ehci-hcd compile error

2013-01-10 Thread Felipe Balbi
Hi, On Thu, Jan 10, 2013 at 10:36:27AM -0500, Alan Stern wrote: > On Thu, 10 Jan 2013, Felipe Balbi wrote: > > > Hi Alan, > > > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > > > drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined > > [enable

Re: ehci-hcd compile error

2013-01-10 Thread Alan Stern
On Thu, 10 Jan 2013, Felipe Balbi wrote: > Hi Alan, > > with v3.8-rc3, ehci-hcd fails to compile for ARM if I use allmodconfig: > > drivers/usb/host/ehci-hcd.c:1285:0: warning: "PLATFORM_DRIVER" redefined > [enabled by default] > drivers/usb/host/ehci-hcd.c:1255:0: note: this is the location of