Re: dwc2: Host channel not always released on dequeue

2013-03-23 Thread Matthijs Kooijman
Hi Paul, > I would prefer to keep that part of the code as-is for now. I haven't > quite convinced myself that the function can never be called with > halt_status = DWC2_HC_XFER_URB_DEQUEUE. Ok. For arguments sake, it should be easy to convince yourself: dwc2_hc_chhltd_intr is a static function o

RE: dwc2: Host channel not always released on dequeue

2013-03-22 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Friday, March 22, 2013 5:02 PM > > I think you misread the code. The two nested ifs can indeed be true at > > the same time. > You are right, I had placed the parenthesis wrong. I see what happens > there now, yes. > > > So I will leave

RE: dwc2: Host channel not always released on dequeue

2013-03-22 Thread Paul Zimmerman
> From: Matthijs Kooijman [mailto:matth...@stdin.nl] > Sent: Friday, March 22, 2013 9:32 AM ... > However, when the last urb is dequeued, the qtd list for the qh > associated with the channel becomes empty, which triggers the following > shortcut in dwc2_hc_n_intr: > > if (list_empty(&ch