Re: divide error in usbtmc_generic_read

2019-08-20 Thread Oliver Neukum
Am Montag, den 19.08.2019, 17:40 +0200 schrieb Andrey Konovalov: > > This implies that we can differentiate between different crashes. We > can differentiate between different manifestations of crashes, but > those can be caused by the same bug. I think we can remove the word > "still" though, so

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Andrey Konovalov
On Mon, Aug 19, 2019 at 3:49 PM Oliver Neukum wrote: > > Am Montag, den 19.08.2019, 15:18 +0200 schrieb Andrey Konovalov: > > On Mon, Aug 19, 2019 at 3:09 PM Oliver Neukum wrote: > > > > > > Am Montag, den 19.08.2019, 14:43 +0200 schrieb Andrey Konovalov: > > > > On Mon, Aug 19, 2019 at 2:37 PM O

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Oliver Neukum
Am Montag, den 19.08.2019, 15:18 +0200 schrieb Andrey Konovalov: > On Mon, Aug 19, 2019 at 3:09 PM Oliver Neukum wrote: > > > > Am Montag, den 19.08.2019, 14:43 +0200 schrieb Andrey Konovalov: > > > On Mon, Aug 19, 2019 at 2:37 PM Oliver Neukum wrote: > > > > The original error was a divide by z

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Andrey Konovalov
On Mon, Aug 19, 2019 at 3:09 PM Oliver Neukum wrote: > > Am Montag, den 19.08.2019, 14:43 +0200 schrieb Andrey Konovalov: > > On Mon, Aug 19, 2019 at 2:37 PM Oliver Neukum wrote: > > > > The original error was a divide by zero. The first fix fixed that > > > but still another error showed up. If

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Oliver Neukum
Am Montag, den 19.08.2019, 14:43 +0200 schrieb Andrey Konovalov: > On Mon, Aug 19, 2019 at 2:37 PM Oliver Neukum wrote: > > The original error was a divide by zero. The first fix fixed that > > but still another error showed up. If I propose a fix there are > > other possibilities besides it work

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Andrey Konovalov
On Mon, Aug 19, 2019 at 2:37 PM Oliver Neukum wrote: > > Am Montag, den 19.08.2019, 14:17 +0200 schrieb Andrey Konovalov: > > On Thu, Aug 15, 2019 at 3:31 PM Oliver Neukum wrote: > > > > > > Am Mittwoch, den 14.08.2019, 06:38 -0700 schrieb syzbot: > > > > syzbot has tested the proposed patch but

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Oliver Neukum
Am Montag, den 19.08.2019, 14:17 +0200 schrieb Andrey Konovalov: > On Thu, Aug 15, 2019 at 3:31 PM Oliver Neukum wrote: > > > > Am Mittwoch, den 14.08.2019, 06:38 -0700 schrieb syzbot: > > > syzbot has tested the proposed patch but the reproducer still triggered > > > crash: > > > KASAN: use-afte

Re: divide error in usbtmc_generic_read

2019-08-19 Thread Andrey Konovalov
On Thu, Aug 15, 2019 at 3:31 PM Oliver Neukum wrote: > > Am Mittwoch, den 14.08.2019, 06:38 -0700 schrieb syzbot: > > syzbot has tested the proposed patch but the reproducer still triggered > > crash: > > KASAN: use-after-free Read in usbtmc_disconnect > > I am afraid that is a difficiency in KASA

Re: divide error in usbtmc_generic_read

2019-08-15 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+55b0304b360654a75...@syzkaller.appspotmail.com Tested on: commit: d0847550 usb-fuzzer: main usb gadget fuzzer driver git tree: https://github.com/google/kasa

Re: divide error in usbtmc_generic_read

2019-08-15 Thread Oliver Neukum
Am Mittwoch, den 14.08.2019, 04:38 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit:d0847550 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.

Re: divide error in usbtmc_generic_read

2019-08-15 Thread Oliver Neukum
Am Mittwoch, den 14.08.2019, 06:38 -0700 schrieb syzbot: > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: use-after-free Read in usbtmc_disconnect I am afraid that is a difficiency in KASAN that should be fixed. Is the class of the error compared if I l

RE: Re: divide error in usbtmc_generic_read

2019-08-14 Thread Guido Kiener
...@keysight.com; syzkaller-bugs Subject: *EXT* Re: divide error in usbtmc_generic_read On Wed, Aug 14, 2019 at 3:38 PM syzbot wrote: > > Hello, > > syzbot has tested the proposed patch but the reproducer still > triggered > crash: > KASAN: use-after-free Read in usbtmc_disconnect Looks

Re: divide error in usbtmc_generic_read

2019-08-14 Thread Andrey Konovalov
On Wed, Aug 14, 2019 at 3:38 PM syzbot wrote: > > Hello, > > syzbot has tested the proposed patch but the reproducer still triggered > crash: > KASAN: use-after-free Read in usbtmc_disconnect Looks like a different bug in the same driver that gets triggered by the same reproducer =) You fix look

Re: divide error in usbtmc_generic_read

2019-08-14 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer still triggered crash: KASAN: use-after-free Read in usbtmc_disconnect usb 5-1: USB disconnect, device number 2 == BUG: KASAN: use-after-free in __mutex_lock_common

Re: divide error in usbtmc_generic_read

2019-08-14 Thread Oliver Neukum
Am Mittwoch, den 14.08.2019, 04:38 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit:d0847550 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.