Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2017-01-11 Thread Mathias Nyman
On 11.01.2017 13:27, Richard van der Hoff wrote: On 14/09/16 15:07, Mathias Nyman wrote: I've been staring at the code for a while and I think xhci might need a bigger rework in this area. For example the XHCI_STATE_DYING flag was originally a flag meaning that a watchdog function for a timed ou

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2017-01-11 Thread Richard van der Hoff
On 14/09/16 15:07, Mathias Nyman wrote: I've been staring at the code for a while and I think xhci might need a bigger rework in this area. For example the XHCI_STATE_DYING flag was originally a flag meaning that a watchdog function for a timed out stop endpoint command is running and all URBs wi

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-14 Thread Mathias Nyman
On 08.09.2016 17:38, Alan Stern wrote: On Thu, 8 Sep 2016, Mathias Nyman wrote: ehci-hcd includes checks in several places for ehci->rh_state == RH_STATE_RUNNING. The removal pathway sets ehci->rh_state to RH_STATE_HALTED. As a result, the driver avoids waiting for things that will never happ

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-08 Thread Alan Stern
On Thu, 8 Sep 2016, Mathias Nyman wrote: > > ehci-hcd includes checks in several places for ehci->rh_state == > > RH_STATE_RUNNING. The removal pathway sets ehci->rh_state to > > RH_STATE_HALTED. As a result, the driver avoids waiting for things > > that will never happen. > > > > Yes, seems th

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-08 Thread Mathias Nyman
On 07.09.2016 17:53, Alan Stern wrote: On Wed, 7 Sep 2016, Mathias Nyman wrote: I'm still seeing occasional problems. For example, when I unplugged the dock last night, it seems to have wedged some things, and then plugging it back in didn't work. See some logs below. I ran a show-blocked-t

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-07 Thread Alan Stern
On Wed, 7 Sep 2016, Mathias Nyman wrote: > > I'm still seeing occasional problems. For example, when I unplugged the > > dock last night, it seems to have wedged some things, and then plugging it > > back in didn't work. See some logs below. > > > > > > I ran a show-blocked-tasks after plugging

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-07 Thread Mathias Nyman
On 07.09.2016 11:46, Richard van der Hoff wrote: On 01/09/16 08:53, Richard van der Hoff wrote: On 30/08/16 21:52, Richard van der Hoff wrote: On 30/08/16 19:48, Alan Stern wrote: On Tue, 30 Aug 2016, Richard van der Hoff wrote: I have a USB-3.1 dock; sometimes I see a kernel panic when I un

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-07 Thread Richard van der Hoff
On 01/09/16 08:53, Richard van der Hoff wrote: On 30/08/16 21:52, Richard van der Hoff wrote: On 30/08/16 19:48, Alan Stern wrote: On Tue, 30 Aug 2016, Richard van der Hoff wrote: I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, which hangs the entire system. It appears

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-09-01 Thread Richard van der Hoff
On 30/08/16 21:52, Richard van der Hoff wrote: On 30/08/16 19:48, Alan Stern wrote: On Tue, 30 Aug 2016, Richard van der Hoff wrote: I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, which hangs the entire system. It appears that the first unplug is successful; the second

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-08-30 Thread Richard van der Hoff
On 30/08/16 19:48, Alan Stern wrote: On Tue, 30 Aug 2016, Richard van der Hoff wrote: I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, which hangs the entire system. It appears that the first unplug is successful; the second one normally triggers a crash. Please try app

Re: crash in usb_hc_died+0x16 when unplugging usb-c dock

2016-08-30 Thread Alan Stern
On Tue, 30 Aug 2016, Richard van der Hoff wrote: > I have a USB-3.1 dock; sometimes I see a kernel panic when I unplug it, > which hangs the entire system. It appears that the first unplug is > successful; the second one normally triggers a crash. > > The situation is complicated by the fact th