Re: Two remain problems at chipidea driver

2013-06-28 Thread Alexander Shishkin
Peter Chen writes: > On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen wrote: >> On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: >>> Peter Chen writes: >>> >>> > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >>> >> >>> >> > Eg, for tablet or phone, the dr_mo

Re: Two remain problems at chipidea driver

2013-06-27 Thread Peter Chen
On Mon, Jun 17, 2013 at 9:59 AM, Peter Chen wrote: > On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen wrote: >> On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: >>> Peter Chen writes: >>> >>> > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >>> >> >>> >> > Eg,

Re: Two remain problems at chipidea driver

2013-06-16 Thread Peter Chen
On Thu, Mar 21, 2013 at 11:06 AM, Peter Chen wrote: > On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: >> Peter Chen writes: >> >> > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >> >> >> >> > Eg, for tablet or phone, the dr_mode may be "gadget", but the >

Re: Two remain problems at chipidea driver

2013-03-27 Thread Marc Kleine-Budde
On 03/27/2013 02:35 AM, Peter Chen wrote: > On Tue, Mar 26, 2013 at 12:35:44PM +0200, Alexander Shishkin wrote: >> >> I'm thinking now that what Felipe suggests is probably the best at least >> for the time being. That is, if we don't want host, for example, in the >> product build, we just compile

Re: Two remain problems at chipidea driver

2013-03-26 Thread Peter Chen
On Tue, Mar 26, 2013 at 12:35:44PM +0200, Alexander Shishkin wrote: > > I'm thinking now that what Felipe suggests is probably the best at least > for the time being. That is, if we don't want host, for example, in the > product build, we just compile it out. And then we expect the dr_mode to > be

Re: Two remain problems at chipidea driver

2013-03-26 Thread Alexander Shishkin
Peter Chen writes: > On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: >> Peter Chen writes: >> >> > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >> >> >> >> > Eg, for tablet or phone, the dr_mode may be "gadget", but the >> >> > otg_capable = 1. >> >>

Re: Two remain problems at chipidea driver

2013-03-26 Thread Alexander Shishkin
Marc Kleine-Budde writes: > On 03/20/2013 02:37 PM, Alexander Shishkin wrote: >> Marc Kleine-Budde writes: >> >>> On 03/20/2013 12:23 PM, Alexander Shishkin wrote: Marc Kleine-Budde writes: > On 03/20/2013 12:04 PM, Alexander Shishkin wrote: >> Peter Chen writes: >>

Re: Two remain problems at chipidea driver

2013-03-20 Thread Peter Chen
On Wed, Mar 20, 2013 at 01:04:33PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: > >> > >> > Eg, for tablet or phone, the dr_mode may be "gadget", but the > >> > otg_capable = 1. > >> > >> No, because dr_mode indi

Re: Two remain problems at chipidea driver

2013-03-20 Thread Felipe Balbi
On Wed, Mar 20, 2013 at 05:32:05PM +0100, Marc Kleine-Budde wrote: > On 03/20/2013 05:02 PM, Felipe Balbi wrote: > > On Wed, Mar 20, 2013 at 04:58:05PM +0100, Marc Kleine-Budde wrote: > >> On 03/20/2013 03:44 PM, Felipe Balbi wrote: > >>> Hi, > >>> > >>> On Wed, Mar 20, 2013 at 04:26:02PM +0200, Al

Re: Two remain problems at chipidea driver

2013-03-20 Thread Marc Kleine-Budde
On 03/20/2013 05:02 PM, Felipe Balbi wrote: > On Wed, Mar 20, 2013 at 04:58:05PM +0100, Marc Kleine-Budde wrote: >> On 03/20/2013 03:44 PM, Felipe Balbi wrote: >>> Hi, >>> >>> On Wed, Mar 20, 2013 at 04:26:02PM +0200, Alexander Shishkin wrote: dr_cap is what the device can actually do (hos

Re: Two remain problems at chipidea driver

2013-03-20 Thread Felipe Balbi
On Wed, Mar 20, 2013 at 04:58:05PM +0100, Marc Kleine-Budde wrote: > On 03/20/2013 03:44 PM, Felipe Balbi wrote: > > Hi, > > > > On Wed, Mar 20, 2013 at 04:26:02PM +0200, Alexander Shishkin wrote: > >> dr_cap is what the device can actually do (host, peripheral, etc). > >> Tells > >>

Re: Two remain problems at chipidea driver

2013-03-20 Thread Marc Kleine-Budde
On 03/20/2013 03:44 PM, Felipe Balbi wrote: > Hi, > > On Wed, Mar 20, 2013 at 04:26:02PM +0200, Alexander Shishkin wrote: >> dr_cap is what the device can actually do (host, peripheral, etc). Tells >> us which roles to initialize and wether we can access OTGSC on this >> device. >>

Re: Two remain problems at chipidea driver

2013-03-20 Thread Marc Kleine-Budde
On 03/20/2013 02:37 PM, Alexander Shishkin wrote: > Marc Kleine-Budde writes: > >> On 03/20/2013 12:23 PM, Alexander Shishkin wrote: >>> Marc Kleine-Budde writes: >>> On 03/20/2013 12:04 PM, Alexander Shishkin wrote: > Peter Chen writes: > >> On Fri, Mar 15, 2013 at 05:17:08PM

Re: Two remain problems at chipidea driver

2013-03-20 Thread Felipe Balbi
Hi, On Wed, Mar 20, 2013 at 04:26:02PM +0200, Alexander Shishkin wrote: > >> >> dr_cap is what the device can actually do (host, peripheral, etc). Tells > >> >> us which roles to initialize and wether we can access OTGSC on this > >> >> device. > >> >> dr_mode is what function of the device we'll

Re: Two remain problems at chipidea driver

2013-03-20 Thread Alexander Shishkin
Felipe Balbi writes: > Hi, > > On Wed, Mar 20, 2013 at 03:37:01PM +0200, Alexander Shishkin wrote: >> >> dr_cap is what the device can actually do (host, peripheral, etc). Tells >> >> us which roles to initialize and wether we can access OTGSC on this >> >> device. >> >> dr_mode is what function

Re: Two remain problems at chipidea driver

2013-03-20 Thread Felipe Balbi
Hi, On Wed, Mar 20, 2013 at 03:37:01PM +0200, Alexander Shishkin wrote: > >> dr_cap is what the device can actually do (host, peripheral, etc). Tells > >> us which roles to initialize and wether we can access OTGSC on this > >> device. > >> dr_mode is what function of the device we'll be using on

Re: Two remain problems at chipidea driver

2013-03-20 Thread Alexander Shishkin
Marc Kleine-Budde writes: > On 03/20/2013 12:23 PM, Alexander Shishkin wrote: >> Marc Kleine-Budde writes: >> >>> On 03/20/2013 12:04 PM, Alexander Shishkin wrote: Peter Chen writes: > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >> >>> Eg, for tabl

Re: Two remain problems at chipidea driver

2013-03-20 Thread Marc Kleine-Budde
On 03/20/2013 12:23 PM, Alexander Shishkin wrote: > Marc Kleine-Budde writes: > >> On 03/20/2013 12:04 PM, Alexander Shishkin wrote: >>> Peter Chen writes: >>> On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: > >> Eg, for tablet or phone, the dr_mode may be "gadge

Re: Two remain problems at chipidea driver

2013-03-20 Thread Alexander Shishkin
Marc Kleine-Budde writes: > On 03/20/2013 12:04 PM, Alexander Shishkin wrote: >> Peter Chen writes: >> >>> On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: > Eg, for tablet or phone, the dr_mode may be "gadget", but the > otg_capable = 1. No, because dr

Re: Two remain problems at chipidea driver

2013-03-20 Thread Marc Kleine-Budde
On 03/20/2013 12:04 PM, Alexander Shishkin wrote: > Peter Chen writes: > >> On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >>> Eg, for tablet or phone, the dr_mode may be "gadget", but the otg_capable = 1. >>> >>> No, because dr_mode indicates controller's capabilit

Re: Two remain problems at chipidea driver

2013-03-20 Thread Alexander Shishkin
Peter Chen writes: > On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: >> >> > Eg, for tablet or phone, the dr_mode may be "gadget", but the >> > otg_capable = 1. >> >> No, because dr_mode indicates controller's capability, and not the >> "current" mode of operation. Why would

Re: Two remain problems at chipidea driver

2013-03-20 Thread Peter Chen
On Wed, Mar 20, 2013 at 11:11:09AM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > On Thu, Mar 14, 2013 at 09:53:55AM +0100, Marc Kleine-Budde wrote: > >> On 03/14/2013 09:34 AM, Peter Chen wrote: > >> > Hi Alex and all, > >> > > >> > Currently, we have two problems to block chipidea

Re: Two remain problems at chipidea driver

2013-03-20 Thread Alexander Shishkin
Peter Chen writes: > On Thu, Mar 14, 2013 at 09:53:55AM +0100, Marc Kleine-Budde wrote: >> On 03/14/2013 09:34 AM, Peter Chen wrote: >> > Hi Alex and all, >> > >> > Currently, we have two problems to block chipidea driver coming >> > development. >> > >> > As there are so many chipidea versions

Re: Two remain problems at chipidea driver

2013-03-17 Thread Peter Chen
On Fri, Mar 15, 2013 at 01:42:36PM +0100, Matthieu CASTET wrote: > Peter Chen a écrit : > > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: > Do you see any problems with this? > >>> How to know vbus status if dr_mode == gadget, we need to indicate > >>> connection > >>> a

Re: Two remain problems at chipidea driver

2013-03-17 Thread Peter Chen
On Fri, Mar 15, 2013 at 05:17:08PM +0200, Alexander Shishkin wrote: > > > Eg, for tablet or phone, the dr_mode may be "gadget", but the > > otg_capable = 1. > > No, because dr_mode indicates controller's capability, and not the > "current" mode of operation. Why would anyone want to put *that* in

Re: Two remain problems at chipidea driver

2013-03-17 Thread Peter Chen
On Fri, Mar 15, 2013 at 11:04:47PM +0200, Svetoslav Neykov wrote: > Hi Peter, > > >> There is a core on mips which doesn't support otg. From my point of > >> view, support for dual_role should be a separate patch, ideally by > >> Svetoslav (Cc'ed) who has this hardware, after we've cleaned up all

RE: Two remain problems at chipidea driver

2013-03-15 Thread Svetoslav Neykov
Hi Peter, >> There is a core on mips which doesn't support otg. From my point of >> view, support for dual_role should be a separate patch, ideally by >> Svetoslav (Cc'ed) who has this hardware, after we've cleaned up all >> dr-mode related stuff. > >What means support OTG? The spec said it or the

Re: Two remain problems at chipidea driver

2013-03-15 Thread Alexander Shishkin
Peter Chen writes: > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: >> >> >> >> I'd say, in the core driver: >> >> 1) get dr_mode from platform data >> >> 2) only if that's DR_MODE_UNKNOWN (iirc), read DCCPARAMS, since it's >> >> not guaranteed to work across all chipi

Re: Two remain problems at chipidea driver

2013-03-15 Thread Matthieu CASTET
Peter Chen a écrit : > On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: Do you see any problems with this? >>> How to know vbus status if dr_mode == gadget, we need to indicate connection >>> and disconnection? >> We don't. Do we need to indicate vbus session valid for gadge

Re: Two remain problems at chipidea driver

2013-03-15 Thread Peter Chen
On Fri, Mar 15, 2013 at 12:38:07PM +0200, Alexander Shishkin wrote: > >> > >> I'd say, in the core driver: > >> 1) get dr_mode from platform data > >> 2) only if that's DR_MODE_UNKNOWN (iirc), read DCCPARAMS, since it's > >> not guaranteed to work across all chipideas; > >> 3) if dr_mode =

Re: Two remain problems at chipidea driver

2013-03-15 Thread Alexander Shishkin
Peter Chen writes: > On Thu, Mar 14, 2013 at 12:31:38PM +0200, Alexander Shishkin wrote: >> Peter Chen writes: >> >> > Hi Alex and all, >> > >> > Currently, we have two problems to block chipidea driver coming >> > development. >> > >> > As there are so many chipidea versions, we impossible to

Re: Two remain problems at chipidea driver

2013-03-14 Thread Peter Chen
On Thu, Mar 14, 2013 at 12:31:38PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > Hi Alex and all, > > > > Currently, we have two problems to block chipidea driver coming > > development. > > > > As there are so many chipidea versions, we impossible to collect > > all to make a decis

Re: Two remain problems at chipidea driver

2013-03-14 Thread Marc Kleine-Budde
On 03/14/2013 11:31 AM, Alexander Shishkin wrote: > Peter Chen writes: > >> Hi Alex and all, >> >> Currently, we have two problems to block chipidea driver coming >> development. >> >> As there are so many chipidea versions, we impossible to collect >> all to make a decision, it is better to cove

Re: Two remain problems at chipidea driver

2013-03-14 Thread Alexander Shishkin
Peter Chen writes: > Hi Alex and all, > > Currently, we have two problems to block chipidea driver coming > development. > > As there are so many chipidea versions, we impossible to collect > all to make a decision, it is better to cover most of the cases, > and using device tree (or platform dat

Re: Two remain problems at chipidea driver

2013-03-14 Thread Peter Chen
On Thu, Mar 14, 2013 at 09:53:55AM +0100, Marc Kleine-Budde wrote: > On 03/14/2013 09:34 AM, Peter Chen wrote: > > Hi Alex and all, > > > > Currently, we have two problems to block chipidea driver coming > > development. > > > > As there are so many chipidea versions, we impossible to collect > >

Re: Two remain problems at chipidea driver

2013-03-14 Thread Marc Kleine-Budde
On 03/14/2013 09:34 AM, Peter Chen wrote: > Hi Alex and all, > > Currently, we have two problems to block chipidea driver coming > development. > > As there are so many chipidea versions, we impossible to collect > all to make a decision, it is better to cover most of the cases, > and using devic