Re: Threaded interrupts for USB HCD instead of tasklets

2018-06-01 Thread Alan Stern
On Fri, 1 Jun 2018, Sebastian Andrzej Siewior wrote: > On 2018-05-22 15:14:17 [-0400], Alan Stern wrote: > > Sorry, I don't understand that sentence at all. And I don't see how it > > could be relevant to the point I was trying to make. > > > > Consider, for example, drivers/hid/usbhid/hid-core

Re: Threaded interrupts for USB HCD instead of tasklets

2018-06-01 Thread Sebastian Andrzej Siewior
On 2018-05-22 15:14:17 [-0400], Alan Stern wrote: > Sorry, I don't understand that sentence at all. And I don't see how it > could be relevant to the point I was trying to make. > > Consider, for example, drivers/hid/usbhid/hid-core.c. In that file, > hid_io_error() is called by hid_irq_in(), w

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-23 Thread Sebastian Andrzej Siewior
On 2018-05-22 15:14:17 [-0400], Alan Stern wrote: > On Tue, 22 May 2018, Sebastian Andrzej Siewior wrote: > > > On 2018-05-07 11:37:29 [-0400], Alan Stern wrote: > > > > As far as I understand it there should be no deadlock. Without the > > > > local_irq_save() things should not deadlock because t

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-22 Thread Alan Stern
On Tue, 22 May 2018, Sebastian Andrzej Siewior wrote: > On 2018-05-07 11:37:29 [-0400], Alan Stern wrote: > > > As far as I understand it there should be no deadlock. Without the > > > local_irq_save() things should not deadlock because the HCD invokes USB > > > driver's (usb-storage for instance)

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-22 Thread Sebastian Andrzej Siewior
On 2018-05-07 11:37:29 [-0400], Alan Stern wrote: > > As far as I understand it there should be no deadlock. Without the > > local_irq_save() things should not deadlock because the HCD invokes USB > > driver's (usb-storage for instance) ->complete callback always in the > > same way. If you mix the

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-07 Thread Alan Stern
On Mon, 7 May 2018, Sebastian Andrzej Siewior wrote: > On 2018-05-04 16:07:22 [-0400], Alan Stern wrote: > > On Fri, 4 May 2018, Sebastian Andrzej Siewior wrote: > > > > > Hi Alan, > > > > > > I posted a RFC [0] to let the HCD complete the URB in threaded-IRQ > > > context to avoid the softirq/t

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-07 Thread Sebastian Andrzej Siewior
On 2018-05-04 16:07:22 [-0400], Alan Stern wrote: > On Fri, 4 May 2018, Sebastian Andrzej Siewior wrote: > > > Hi Alan, > > > > I posted a RFC [0] to let the HCD complete the URB in threaded-IRQ > > context to avoid the softirq/tasklet. Mauro reported that this does not > > help him and never cam

Re: Threaded interrupts for USB HCD instead of tasklets

2018-05-04 Thread Alan Stern
On Fri, 4 May 2018, Sebastian Andrzej Siewior wrote: > Hi Alan, > > I posted a RFC [0] to let the HCD complete the URB in threaded-IRQ > context to avoid the softirq/tasklet. Mauro reported that this does not > help him and never came back after that. > You did not oppose the approach as long as