Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Alexander Shishkin
Dan Carpenter writes: > On Fri, Feb 15, 2013 at 02:54:56PM +0200, Alexander Shishkin wrote: >> Dan Carpenter writes: >> >> > On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: >> >> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: >> >> > On Fri, Sep 14, 2012 at 09:50:5

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Dan Carpenter
On Fri, Feb 15, 2013 at 02:54:56PM +0200, Alexander Shishkin wrote: > Dan Carpenter writes: > > > On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: > >> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: > >> > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote:

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Alexander Shishkin
Dan Carpenter writes: > On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: >> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: >> > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: >> > > There is a '&' vs '|' typo in the original code so the condition is >>

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Dan Carpenter
On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote: > On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: > > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: > > > There is a '&' vs '|' typo in the original code so the condition is > > > never true and we don't q

Re: [patch] USB: chipidea: fix & vs | bug

2013-02-15 Thread Dan Carpenter
On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote: > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: > > There is a '&' vs '|' typo in the original code so the condition is > > never true and we don't queue the work. > > > > Signed-off-by: Dan Carpenter > > --- > > > >

Re: [patch] USB: chipidea: fix & vs | bug

2012-09-13 Thread Richard Zhao
On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote: > There is a '&' vs '|' typo in the original code so the condition is > never true and we don't queue the work. > > Signed-off-by: Dan Carpenter > --- > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c > index 2