Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-17 Thread Chao Xie
On Thu, Feb 7, 2013 at 1:57 PM, kishon wrote: > Hi, > > > On Thursday 07 February 2013 07:56 AM, Chao Xie wrote: >> >> On Wed, Feb 6, 2013 at 6:35 PM, kishon wrote: >>> >>> Hi, >>> >>> >>> On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote: On Wed, Feb 6, 2013 at 4:10 PM, kisho

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread kishon
Hi, On Thursday 07 February 2013 07:56 AM, Chao Xie wrote: On Wed, Feb 6, 2013 at 6:35 PM, kishon wrote: Hi, On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote: On Wed, Feb 6, 2013 at 4:10 PM, kishon wrote: Hi, On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote: The PHY is

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread Chao Xie
On Wed, Feb 6, 2013 at 6:35 PM, kishon wrote: > Hi, > > > On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote: >> >> On Wed, Feb 6, 2013 at 4:10 PM, kishon wrote: >>> >>> Hi, >>> >>> >>> On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote: The PHY is seperated from usb contro

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread Chao Xie
On Wed, Feb 6, 2013 at 10:42 PM, Mark Rutland wrote: > Hi, > > I have a few comments on the devicetree binding and the way it's parsed. > > I note many are similar to those I commented on for the mv_udc and ehci-mv > devicetree code. > > On Wed, Feb 06, 2013 at 07:23:36AM +, Chao Xie wrote: >>

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread Mark Rutland
Hi, I have a few comments on the devicetree binding and the way it's parsed. I note many are similar to those I commented on for the mv_udc and ehci-mv devicetree code. On Wed, Feb 06, 2013 at 07:23:36AM +, Chao Xie wrote: > The PHY is seperated from usb controller. > The usb controller used

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread kishon
Hi, On Wednesday 06 February 2013 01:48 PM, Chao Xie wrote: On Wed, Feb 6, 2013 at 4:10 PM, kishon wrote: Hi, On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote: The PHY is seperated from usb controller. The usb controller used in marvell pxa168/pxa910/mmp2 are same, but PHY initializa

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread Chao Xie
On Wed, Feb 6, 2013 at 4:10 PM, kishon wrote: > Hi, > > > On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote: >> >> The PHY is seperated from usb controller. >> The usb controller used in marvell pxa168/pxa910/mmp2 are same, >> but PHY initialization may be different. >> the usb controller can

Re: [V6 PATCH 01/16] usb: phy: mv_usb2: add PHY driver for marvell usb2 controller

2013-02-06 Thread kishon
Hi, On Wednesday 06 February 2013 12:53 PM, Chao Xie wrote: The PHY is seperated from usb controller. The usb controller used in marvell pxa168/pxa910/mmp2 are same, but PHY initialization may be different. the usb controller can support udc/otg/ehci, and for each of the mode, it need PHY to ini