Re: [RFC v3] Add support for Sony PS2 OHCI

2018-06-24 Thread Fredrik Noring
Hi Alan Stern, On Wed, Mar 14, 2018 at 04:52:13PM -0400, Alan Stern wrote: > This should not be needed; it indicates that something is wrong with > the way interrupt requests are handled on this platform. > > Are you using threaded interrupts at all? If you are, you have to > change the spin_l

Re: [RFC v3] Add support for Sony PS2 OHCI

2018-03-14 Thread Alan Stern
On Wed, 14 Mar 2018, Fredrik Noring wrote: > Hi Alan Stern, > > > > > What happened to the changes to ohci_run() and ohci_irq() that were in > > > > v2 of this RFC? Did you decide they weren't needed? > > > > > > In v3 Jürgen Urban folded those changes into the driver functions > > > > > >

Re: [RFC v3] Add support for Sony PS2 OHCI

2018-03-14 Thread Fredrik Noring
Hi Alan Stern, > > > What happened to the changes to ohci_run() and ohci_irq() that were in > > > v2 of this RFC? Did you decide they weren't needed? > > > > In v3 Jürgen Urban folded those changes into the driver functions > > > > ohci_ps2_enable(), > > ohci_ps2_disable(), > > ohc

Re: [RFC v3] Add support for Sony PS2 OHCI

2018-02-01 Thread Fredrik Noring
Hi Alan Stern, On Mon, Nov 27, 2017 at 10:46:55AM -0500, Alan Stern wrote: > I did not read the whole thing in detail, but it generally looks okay. > Except, of course, that the dma-mapping.h change can't be part of this > patch. That will have to be done separately. We are observing seemingly

Re: [RFC v3] Add support for Sony PS2 OHCI

2017-11-29 Thread Alan Stern
On Wed, 29 Nov 2017, Fredrik Noring wrote: > Hi Alan Stern, > > > I did not read the whole thing in detail, but it generally looks okay. > > Except, of course, that the dma-mapping.h change can't be part of this > > patch. That will have to be done separately. > > Agreed. > > > What happened

Re: [RFC v3] Add support for Sony PS2 OHCI

2017-11-29 Thread Fredrik Noring
Hi Alan Stern, > I did not read the whole thing in detail, but it generally looks okay. > Except, of course, that the dma-mapping.h change can't be part of this > patch. That will have to be done separately. Agreed. > What happened to the changes to ohci_run() and ohci_irq() that were in > v2

Re: [RFC v3] Add support for Sony PS2 OHCI

2017-11-27 Thread Alan Stern
On Sun, 26 Nov 2017, Fredrik Noring wrote: > Hi Alan Stern, > > > > Be aware that your driver should utilize ohci_init_driver(), like > > > several of the other platform-specific OHCI drivers do. Unless there's > > > some very good reason, new drivers should never use the old interface. > > > >

Re: [RFC v3] Add support for Sony PS2 OHCI

2017-11-26 Thread Fredrik Noring
Hi Alan Stern, > > Be aware that your driver should utilize ohci_init_driver(), like > > several of the other platform-specific OHCI drivers do. Unless there's > > some very good reason, new drivers should never use the old interface. > > Agreed, please find updated patch with the new interface.