Re: [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers

2018-09-07 Thread Tomasz Figa
On Fri, Aug 31, 2018 at 2:59 AM Christoph Hellwig wrote: > > > + dma_sync_single_for_cpu(&urb->dev->dev, urb->transfer_dma, > > + urb->transfer_buffer_length, DMA_FROM_DEVICE); > > You can't ue dma_sync_single_for_cpu on non-coherent dma buffers, > which is one of the major issues

Re: [RFC 3/3] stk1160: Use non-coherent buffers for USB transfers

2018-08-30 Thread Christoph Hellwig
> + dma_sync_single_for_cpu(&urb->dev->dev, urb->transfer_dma, > + urb->transfer_buffer_length, DMA_FROM_DEVICE); You can't ue dma_sync_single_for_cpu on non-coherent dma buffers, which is one of the major issues with them.