> Yes, it can, if you look at the comment in usb_match_id(), we have to
> check for this there.
Geez, /me blind... Will send a patch.
Thanks!
signature.asc
Description: Digital signature
On Sun, Jan 12, 2014 at 10:11:54AM +0100, Wolfram Sang wrote:
>
> > > I also wonder if we should return an error to the user in case we don't
> > > find a matching reference entry? It will otherwise be very difficult
> > > for the user to catch typos.
> >
> > Ah, yeah, that would be a good idea,
> > To be fair, Bjørn had this idea two years ago, but hesitated to
> > implement it. I found his mail while implementing my idea, though.
>
> I did? Wow. I know I was looking at solutions to this problem, but I
> didn't remember thinking about taking the device reference from
> userspace.
:)
> > I also wonder if we should return an error to the user in case we don't
> > find a matching reference entry? It will otherwise be very difficult
> > for the user to catch typos.
>
> Ah, yeah, that would be a good idea, Wofram, care to do an add-on patch
> for that?
Just sent. Another questi
Greg KH writes:
> On Fri, Jan 10, 2014 at 11:25:13PM +0100, Bjørn Mork wrote:
>>
>> I still see one use case which isn't yet covered: Overriding a static
>> entry. This would be particularily useful for class drivers with per
>> device exceptions. Is there any real reason why we cannot parse the
On Fri, Jan 10, 2014 at 11:25:13PM +0100, Bjørn Mork wrote:
>
> I still see one use case which isn't yet covered: Overriding a static
> entry. This would be particularily useful for class drivers with per
> device exceptions. Is there any real reason why we cannot parse the
> dynamic list before
Wolfram Sang writes:
>> We've always had the problem of how to do this before, I don't think
>> anyone's thought of using a "reference" device in tha past, this should
>> solve the driver_data issue just fine.
>
> To be fair, Bjørn had this idea two years ago, but hesitated to
> implement it. I f
Greg KH writes:
> Very nice, I like this a lot!
Agreed! Nice idea. Please go ahead and add it for 3.14. My following
comments are just some additional ideas that popped into my head. They
can be dealt with later, if they make sense to anyone else.
I still see one use case which isn't yet co
> Very nice, I like this a lot!
Yay!
> We've always had the problem of how to do this before, I don't think
> anyone's thought of using a "reference" device in tha past, this should
> solve the driver_data issue just fine.
To be fair, Bjørn had this idea two years ago, but hesitated to
implemen
On Fri, Jan 10, 2014 at 07:36:42PM +0100, Wolfram Sang wrote:
> Often, usb drivers need some driver_info to get a device to work. To
> have access to driver_info when using new_id, allow to pass a reference
> vendor:product tuple from which new_id will inherit driver_info.
>
> Signed-off-by: Wolfr
10 matches
Mail list logo
