Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

2015-03-23 Thread Heikki Krogerus
> >+ > >+/** > >+ * ulpi_register_driver - unregister a driver with the ULPI bus > Hi Heikki, > > "ulpi_register_driver" should be changed to "ulpi_unregister_driver". OK, Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majo

Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

2015-03-23 Thread Lu, Baolu
On 03/18/2015 08:40 PM, Heikki Krogerus wrote: + +/** + * ulpi_register_driver - unregister a driver with the ULPI bus Hi Heikki, "ulpi_register_driver" should be changed to "ulpi_unregister_driver". Thanks, Baolu + * @drv: driver to unregister + * + * Unregisters a driver with the ULPI bus

Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

2015-03-19 Thread Heikki Krogerus
> > +#include > > So is this include needed? I can change it to linux/kmod.h. We'll still do the request_module call even after these changes. > > +static int __init ulpi_init(void) > > +{ > > + return bus_register(&ulpi_bus); > > +} > > +module_init(ulpi_init); > > This will be equivalent t

Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

2015-03-18 Thread Paul Bolle
On Wed, 2015-03-18 at 14:40 +0200, Heikki Krogerus wrote: > --- a/drivers/usb/common/Makefile > +++ b/drivers/usb/common/Makefile > @@ -7,3 +7,4 @@ usb-common-y+= common.o > usb-common-$(CONFIG_USB_LED_TRIG) += led.o > > obj-$(CONFIG_USB_OTG_FSM) += usb-otg-fsm.o > +obj-$(CO