Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-20 Thread Doug Anderson
On Wed, Dec 19, 2012 at 10:37 PM, Vivek Gautam wrote: > > On Thu, Dec 20, 2012 at 5:00 AM, Doug Anderson wrote: >> >> On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam >> wrote: >>> +static void s5p_ehci_phy_enable(struct s5p_ehci_hcd *s5p_ehci) >>> +{ >>> + struct platform_device *pdev = to_

Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-19 Thread Vivek Gautam
Hi Doug, On Thu, Dec 20, 2012 at 5:00 AM, Doug Anderson wrote: > Vivek, > > Again, not a high-level review, but... > Thanks for reviewing. :-) > > On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam > wrote: >> Adding the phy driver to ehci-s5p. Keeping the platform data >> for continuing the smoot

Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-19 Thread Doug Anderson
Vivek, Again, not a high-level review, but... On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- >

Re: [PATCH v5 3/4] USB: ehci-s5p: Add phy driver support

2012-12-18 Thread Vivek Gautam
CC: Doug Anderson. On Tue, Dec 18, 2012 at 8:13 PM, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > --- > drivers/usb/host/ehci-s5p.