Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-25 Thread Dan Williams
On Tue, Feb 25, 2014 at 12:20 PM, Alan Stern wrote: > On Mon, 24 Feb 2014, Dan Williams wrote: > >> @@ -163,12 +227,18 @@ int usb_hub_create_port_device(struct usb_hub *hub, >> int port1) >> port_dev->dev.parent = hub->intfdev; >> port_dev->dev.groups = port_dev_group; >> port_d

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-25 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > @@ -163,12 +227,18 @@ int usb_hub_create_port_device(struct usb_hub *hub, int > port1) > port_dev->dev.parent = hub->intfdev; > port_dev->dev.groups = port_dev_group; > port_dev->dev.type = &usb_port_device_type; > - dev_set_name(&p

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-25 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > Subject: usb: assign default peer ports for root hubs > > From: Dan Williams > > Assume that the peer of a superspeed port is the port with the same id > on the shared_hcd root hub. This identification scheme is required of > external hubs by the USB3

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-25 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > >> What's worse, in-kernel gymnastics to print out useful names, or > >> adding sysfs links from the old short name to the new name? > > > > Normally I'd agree, but this is a marginal case. What do other people > > think? > > How about this, make the de

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Dan Williams
On Mon, 2014-02-24 at 16:46 -0500, Alan Stern wrote: > On Fri, 21 Feb 2014, Dan Williams wrote: > > > Assume that the peer of a superspeed port is the port with the same id > > on the shared_hcd root hub. This identification scheme is required of > > external hubs by the USB3 spec [1]. However,

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 2:12 PM, Alan Stern wrote: > On Mon, 24 Feb 2014, Dan Williams wrote: > >> > Also, the gyrations you have to go through here and elsewhere to print >> > useful names indicate that we should set up better names for the port >> > devices. How about: >> > >> > dev_set

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Alan Stern
On Mon, 24 Feb 2014, Dan Williams wrote: > > Also, the gyrations you have to go through here and elsewhere to print > > useful names indicate that we should set up better names for the port > > devices. How about: > > > > dev_set_name(&port_dev->dev, "%s-port%d", dev_name(&hub->hdev->dev)

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Dan Williams
On Mon, Feb 24, 2014 at 1:46 PM, Alan Stern wrote: > On Fri, 21 Feb 2014, Dan Williams wrote: > >> Assume that the peer of a superspeed port is the port with the same id >> on the shared_hcd root hub. This identification scheme is required of >> external hubs by the USB3 spec [1]. However, for r

Re: [PATCH v5 02/16] usb: assign default peer ports for root hubs

2014-02-24 Thread Alan Stern
On Fri, 21 Feb 2014, Dan Williams wrote: > Assume that the peer of a superspeed port is the port with the same id > on the shared_hcd root hub. This identification scheme is required of > external hubs by the USB3 spec [1]. However, for root hubs, tier mismatch > may be in effect [2]. Tier mism