Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-06 Thread Rob Herring
On Mon, Dec 04, 2017 at 09:27:51AM -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-05 Thread Adam Wallis
Rob, On 12/5/2017 3:48 AM, Mathias Nyman wrote: > On 05.12.2017 04:54, Adam Wallis wrote: >> On 12/4/2017 9:15 PM, Chunfeng Yun wrote: >>> On Mon, 2017-12-04 at 09:27 -0500, Adam Wallis wrote: The xHCI driver currently has the IMOD set to 160, which [..] > > If Rob Acks this version I'll app

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-05 Thread Mathias Nyman
On 05.12.2017 04:54, Adam Wallis wrote: On 12/4/2017 9:15 PM, Chunfeng Yun wrote: On Mon, 2017-12-04 at 09:27 -0500, Adam Wallis wrote: The xHCI driver currently has the IMOD set to 160, which translates to an IMOD interval of 40,000ns (160 * 250)ns Commit 0cbd4b34cda9 ("xhci: mediatek: suppor

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
On 12/4/2017 9:15 PM, Chunfeng Yun wrote: > On Mon, 2017-12-04 at 09:27 -0500, Adam Wallis wrote: >> The xHCI driver currently has the IMOD set to 160, which >> translates to an IMOD interval of 40,000ns (160 * 250)ns >> >> Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") >>

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Chunfeng Yun
On Mon, 2017-12-04 at 09:27 -0500, Adam Wallis wrote: > The xHCI driver currently has the IMOD set to 160, which > translates to an IMOD interval of 40,000ns (160 * 250)ns > > Commit 0cbd4b34cda9 ("xhci: mediatek: support MTK xHCI host controller") > introduced a QUIRK for the MTK platform to adju

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Timur Tabi
On 12/04/2017 09:48 AM, Adam Wallis wrote: As noted in the patch description, xhci-plat devices will use a default of 40,000, while MTK devices will use a default of 5,000. This is also documented in the probe for each relevant driver. This is further confirmed in the description for each driver'

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Adam Wallis
Timur On 12/4/2017 9:58 AM, Timur Tabi wrote: > On 12/4/17 8:27 AM, Adam Wallis wrote: >> If no interval is specified, the default of 40,000ns (IMOD=160) will be >> used. > > ... > >> + - imod-interval-ns: default interrupt moderation interval is 5000ns > > ... > >> +  - imod-interval-ns: defa

Re: [PATCH v4] usb: xhci: allow imod-interval to be configurable

2017-12-04 Thread Timur Tabi
On 12/4/17 8:27 AM, Adam Wallis wrote: If no interval is specified, the default of 40,000ns (IMOD=160) will be used. ... + - imod-interval-ns: default interrupt moderation interval is 5000ns ... + - imod-interval-ns: default interrupt moderation interval is 5000ns ... + xhci->i