Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, > How about add a new function as follows to convert dr_mode from string to > enum, then both Keikki's and my function will be shorter by calling it? > > static enum usb_dr_mode of_usb_get_dr_mode_from_string(char *string) > { > for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++) >

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 10/05/2015 02:54 PM, Felipe Balbi wrote: Bin Liu writes: Hi Felipe, On 09/24/2015 03:37 AM, Hans de Goede wrote: Hi, On 23-09-15 22:59, Bin Liu wrote: Hi, On 09/23/2015 02:53 PM, Hans de Goede wrote: Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balb

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Bin Liu writes: > Hi Felipe, > > On 09/24/2015 03:37 AM, Hans de Goede wrote: >> Hi, >> >> On 23-09-15 22:59, Bin Liu wrote: >>> Hi, >>> >>> On 09/23/2015 02:53 PM, Hans de Goede wrote: Hi, On 23-09-15 19:10, Bin Liu wrote: > Hi, > > On 09/22/2015 04:18 PM, Felipe Balbi

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi Felipe, On 09/24/2015 03:37 AM, Hans de Goede wrote: Hi, On 23-09-15 22:59, Bin Liu wrote: Hi, On 09/23/2015 02:53 PM, Hans de Goede wrote: Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: H

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 23-09-15 22:59, Bin Liu wrote: Hi, On 09/23/2015 02:53 PM, Hans de Goede wrote: Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon, S

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 09/23/2015 02:53 PM, Hans de Goede wrote: Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 23-09-15 19:10, Bin Liu wrote: Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu wrote: Some USB phy drivers have different handli

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 09/22/2015 04:18 PM, Felipe Balbi wrote: On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu wrote: Some USB phy drivers have different handling for the controller in each dr_mode. B

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

On Tue, Sep 22, 2015 at 02:31:18PM -0500, Bin Liu wrote: > Hi, > > On 09/22/2015 09:40 AM, Felipe Balbi wrote: > >On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu wrote: > >>Some USB phy drivers have different handling for the controller in each > >>dr_mode. But the phy driver does not have visib

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

Hi, On 09/22/2015 09:40 AM, Felipe Balbi wrote: On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu wrote: Some USB phy drivers have different handling for the controller in each dr_mode. But the phy driver does not have visibility to the dr_mode of the controller. This adds an api to return the

Re: [PATCH v4] usb: of: add an api to get dr_mode by the phy node

On Mon, Sep 21, 2015 at 10:50:56AM -0500, Bin Liu wrote: > Some USB phy drivers have different handling for the controller in each > dr_mode. But the phy driver does not have visibility to the dr_mode of > the controller. > > This adds an api to return the dr_mode of the controller which > associa